Commit Graph

27867 Commits

Author SHA1 Message Date
Azat Khuzhin
e70cff2cea Fix parts removal after incorrect server shutdown
Before this patch, and after transaction support had been added #24258,
if the server had not removed old parts on shutdown, then they will left
forever.

Fixes: #24258 (cc @tavplubix)
v2: use Tx::PrehistoricTID over removePartsFromWorkingSet() from ctor
v3: apply black to new test
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-06-27 23:56:25 +03:00
Azat Khuzhin
f0271dc486 Refactor deactive_part() a little
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-06-27 23:42:39 +03:00
Dmitry Novik
b629d557ce
Merge pull request #38246 from ClickHouse/overcommit-deadlock-fix
Fix deadlock in OvercommitTracker logging
2022-06-27 21:57:31 +02:00
Yakov Olkhovskiy
d5f65ece9b
Merge pull request #38105 from arenadata/ADQM-419
Add kerberosInit function as a replacement for kinit executable calls in Kafka and HDFS
2022-06-27 14:19:24 -04:00
Robert Schulze
53cd8820d3
Merge pull request #38434 from ClickHouse/multi-match-with-nonconst-patterns
Refactoring to enable multi-match functions with non-const needles
2022-06-27 19:35:48 +02:00
alesapin
bed8ee556c
Merge pull request #38465 from ClickHouse/kssenii-patch-4
Fix comment
2022-06-27 18:44:17 +02:00
Alexander Tokmakov
2283436d24
Merge pull request #38344 from Algunenano/implicit_transactions
Add implicit_transaction setting
2022-06-27 18:50:37 +03:00
Kseniia Sumarokova
e515579cbe
Update IObjectStorage.h 2022-06-27 16:26:36 +02:00
Alexander Tokmakov
bec921c9d9
Merge pull request #38265 from ClickHouse/cleanup_garbage_in_store_dir
Add background cleanup of store/ subdirs
2022-06-27 16:53:13 +03:00
Anton Kozlov
5f81bcd84f
CLICKHOUSE-1331 Rewrite tuple functions as literals in backwards-compatibility mode (#38096)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-06-27 14:13:21 +02:00
Nikita Taranov
2487ba7f00
Move updateInputStream to ITransformingStep (#37393) 2022-06-27 13:16:52 +02:00
mergify[bot]
da52780cb5
Merge branch 'master' into implicit_transactions 2022-06-27 09:46:34 +00:00
alesapin
50eb364a56
Merge pull request #38436 from kssenii/remote-path-separation-in-object-storage
more consistent work with paths in object storages
2022-06-27 10:58:01 +02:00
kssenii
5727671cac Fix tests 2022-06-27 00:34:57 +02:00
Robert Schulze
959cbaab02
Move loop over patterns into implementations
- This is preparation for non-const regexp arguments, where this loop
  will run for each row.
2022-06-26 16:26:13 +00:00
Robert Schulze
cb5d1a4a85
Fix style check 2022-06-26 16:25:49 +00:00
Robert Schulze
b8f67185bf
Cosmetics: Whitespaces 2022-06-26 16:25:49 +00:00
Robert Schulze
e2b11899a1
Move check if cfg allows hyperscan into implementations
- This is not needed for non-const regexp array arguments but cleans up
  the code and runs the check only in functions which actually use
  hyperscan.
2022-06-26 16:25:49 +00:00
Robert Schulze
c2cea38b97
Move local variable into if statement 2022-06-26 16:25:49 +00:00
Robert Schulze
c9ce0efa66
Instantiate MultiMatchAnyImpl template using enums
- With this, invalid combinations of the FindAny/FindAnyIndex bools are
  no longer possible and we can remove the corresponding check

- Also makes the instantiations more readable.
2022-06-26 16:25:49 +00:00
Robert Schulze
2f15d45f27
Move check for regexp array size into implementations
- This is not needed for non-const regexp array arguments (the
  cardinality of arrays is fixed per column) but it cleans up the code
  and runs the check only in functions which have restrictions on the
  number of patterns.

- For functions using hyperscans, it was checked that the number of
  regexes is < 2^32. Removed the check because I don't think anyone will
  every specify 4 billion patterns.
2022-06-26 16:25:43 +00:00
Robert Schulze
3478db9fb6
Move check for regexp array size into implementations
- This is not needed for non-const regexp array arguments (the
  cardinality of arrays is fixed per column) but it cleans up the code
  and runs the check only in functions which have restrictions on the
  number of patterns.

- For functions using hyperscans, it was checked that the number of
  regexes is < 2^32. Removed the check because I don't think anyone will
  every specify 4 billion patterns.
2022-06-26 15:38:12 +00:00
Robert Schulze
7913edc172
Move check for hyperscan regexp constraints into implementations
- This is preparation for non-const regexp arguments, where this check
  will run for each row.
2022-06-26 15:38:05 +00:00
Robert Schulze
89bfdd50bf
Remove unnecessary check
- getReturnTypeImpl() ensures that the haystack column has type "String"
  and we can simply assert that.
2022-06-26 15:34:24 +00:00
Robert Schulze
580d89477f
Minimally faster performance 2022-06-26 15:34:22 +00:00
Robert Schulze
4bc59c18e3
Cosmetics: Move some code around + docs + whitespaces + minor stuff 2022-06-26 15:34:15 +00:00
Robert Schulze
1273756911
Cosmetics: fmt-based exceptions 2022-06-26 15:33:18 +00:00
Robert Schulze
e5c74a14f7
Cosmetics: More consistent naming
- rename utility function and file to "checkHyperscanRegexp"
2022-06-26 15:33:18 +00:00
Robert Schulze
072e0855a8
Cosmetics: Make member variables const 2022-06-26 15:32:26 +00:00
Robert Schulze
2ebfd01c2e
Cosmetics: Pull out settings variable 2022-06-26 15:32:23 +00:00
Robert Schulze
bb7c627964
Cosmetics: Pass patterns around as std::string_view instead of StringRef
- The patterns are not used in hashing, there should not be a performance
  impact when we use stuff from the standard library instead.

- added forgotten .reserve() in FunctionsMultiStringPosition.h
2022-06-26 15:32:19 +00:00
kssenii
a15238d147 Review fixes, fix hdfs tests 2022-06-26 16:51:08 +02:00
mergify[bot]
f63c959679
Merge branch 'master' into cleanup_garbage_in_store_dir 2022-06-26 13:35:10 +00:00
kssenii
8da6136f88 Fix 2022-06-26 13:21:05 +02:00
Alexey Milovidov
e29582daad
Merge pull request #38417 from ClickHouse/lower-mutex-scope
Lower mutex scope in ThreadStatus
2022-06-26 10:05:25 +03:00
Alexey Milovidov
b3098822e0
Merge pull request #38171 from ClickHouse/hyper-to-vectorscan
Replace hyperscan by vectorscan
2022-06-26 10:01:45 +03:00
kssenii
725d80d470 get rid of path separation 2022-06-26 01:17:19 +02:00
Alexey Milovidov
25cc406201
Update src/Common/ThreadStatus.cpp
Co-authored-by: Dmitry Novik <n0vik@clickhouse.com>
2022-06-26 01:29:06 +03:00
Alexey Milovidov
90307177b4
Merge pull request #38428 from ClickHouse/remove-codec-asynchronous-metric-log
Remove useless codec from `system.asynchronous_metric_log`
2022-06-25 18:59:02 +03:00
Kseniia Sumarokova
0d626982ee
Merge pull request #38369 from kssenii/fix-pg-compatibility
Fix postgres database engine possible incompatibility on upgrade
2022-06-25 11:18:46 +02:00
Kseniia Sumarokova
3c70e07fe9
Merge pull request #38366 from kssenii/fix-pg-ndim-with-schema
Fix postgres engine not using pg schema when retrieving array dimension size
2022-06-25 11:14:01 +02:00
Alexey Milovidov
a45e3d47ad Remove useless codec from system.asynchronous_metric_log 2022-06-25 07:16:25 +02:00
Alexey Milovidov
0654684bd4 Fix wrong implementation of filesystem* functions 2022-06-25 06:10:50 +02:00
Alexey Milovidov
e33f236d50 Slight improvement 2022-06-25 03:59:01 +02:00
Alexey Milovidov
b89f01438e Lower mutex scope 2022-06-25 03:05:55 +02:00
Alexey Milovidov
370a0eb458
Merge pull request #38159 from zvonand/zvonand-base58
Add Base58 encoding/decoding
2022-06-25 02:35:28 +03:00
alesapin
80d27f6381
Merge pull request #38380 from ClickHouse/simplify_parts_commit_merge_tree
Simplify parts commit methods
2022-06-25 00:12:52 +02:00
Alexander Gololobov
189d0fffb8
Merge pull request #37165 from ClickHouse/merge_tree_reader
Merge tree reader support for multiple read/filter steps: row level filter, prewhere, ...
2022-06-24 21:32:31 +02:00
Andrey Zvonov
ea73d9c492
Merge branch 'master' into zvonand-base58 2022-06-24 21:37:20 +03:00
kssenii
a88ae9ca99 Review fix 2022-06-24 19:48:38 +02:00