Commit Graph

4852 Commits

Author SHA1 Message Date
Anton Popov
fa9a19cbdd fix pushdown of having 2021-04-07 17:02:59 +03:00
Alexander Kuzmenkov
06bb58cb69
Merge pull request #22704 from ClickHouse/aku/window-multiple
fix window functions with multiple input streams and no sorting
2021-04-07 15:15:47 +03:00
Ilya Yatsishin
ed2d82603e
Merge pull request #22588 from foolchi/fix_dist_map_select
fix dist map type select
2021-04-07 11:53:23 +03:00
Vladimir
864ab4a7ab
Merge pull request #21370 from vdimir/fix-merge-engine-join-group-by 2021-04-07 11:52:27 +03:00
alesapin
451ba892fa
Merge pull request #22708 from CurtizJ/fix-flaky-tests-2
Fix test 01702_system_query_log
2021-04-07 11:51:57 +03:00
Vladimir
db0550013c
Merge pull request #22325 from azat/dist-async-insert-header-check
Check only column name and type for async distributed blocks
2021-04-07 11:51:12 +03:00
alesapin
9fd251eaaf
Merge pull request #22514 from ClickHouse/merge_tree_deduplication
Non replicated merge tree deduplication
2021-04-07 10:19:43 +03:00
Azat Khuzhin
60b000ed51 Fix approx total rows accounting for reverse reading from MergeTree 2021-04-06 21:13:51 +03:00
Alexander Kuzmenkov
d9ad06bd6d fix ubsan 2021-04-06 19:24:56 +03:00
Amos Bird
a89e3df40a
Disable table function view in expression (#21465) 2021-04-06 16:08:29 +03:00
Anton Popov
f9b1661372 fix test 01702_system_query_log 2021-04-06 15:44:06 +03:00
Alexander Kuzmenkov
585da2c8d0 Merge remote-tracking branch 'origin/master' into HEAD 2021-04-06 14:58:21 +03:00
Alexander Kuzmenkov
4497b00ff5 the test 2021-04-06 14:57:32 +03:00
alexey-milovidov
636fe8b631
Merge pull request #22662 from vitlibar/fix-test-01294_create_settings_profile
Fix test 01294_create_settings_profile
2021-04-06 14:40:28 +03:00
Anton Popov
a9a01df74a add test 2021-04-06 14:38:35 +03:00
Anton Popov
c05c1f7a34
Merge pull request #22666 from CurtizJ/fix-flaky-tests-1
Fix random failures of tests that are using query_log
2021-04-06 14:22:26 +03:00
Nikolai Kochetov
6102652c99 Merge branch 'master' into better-filter-push-down 2021-04-06 13:38:03 +03:00
alesapin
3148c224ad
Merge pull request #22663 from CurtizJ/fix-flakey-tests
Fix test 01039_row_policy_dcl
2021-04-06 13:19:08 +03:00
alesapin
6456a1507c Support alter setting 2021-04-06 13:14:44 +03:00
vdimir
735154c81a
Handle not plain where tree in StorageMerge modifySelect 2021-04-06 12:29:29 +03:00
alesapin
fbfa53684a
Merge pull request #22670 from ClickHouse/fix_killer_test
Fix mutation killers tests
2021-04-06 10:24:36 +03:00
Azat Khuzhin
27d4fbd13b Compare Block itself for distributed async INSERT batches
INSERT into Distributed with insert_distributed_sync=1 stores the
distributed batches on the disk for sending in background.

But types may be a little bit different for the Distributed and it's
underlying table, so the initiator need to know whether conversion is
required or not.

Before this patch those on disk distributed batches contains header,
which includes dumpStructure() for the block in that batch, however it
checks not only names and types and plus dumpStructure() is a debug
method.

So instead of storing string representation for the block header we
should store empty block in the file header (note, that we cannot store
the empty block not in header, since this will require reading all
blocks from file, due to some trickery of the readers interface).

Note, that this patch also contains tiny refactoring:
- s/header/distributed_header/

v1: dumpNamesAndTypes()
v2: dump empty block into the batch itself
v3: move empty block into the header
2021-04-06 10:05:21 +03:00
Anton Popov
472662de80
skip test in arcadia 2021-04-06 00:45:28 +03:00
Anton Popov
dfb6890f27 fix flaky test 2021-04-06 00:04:13 +03:00
Anton Popov
1e7f3fd576
Update tests/queries/0_stateless/01670_log_comment.sql
Co-authored-by: Alexander Kuzmenkov <36882414+akuzm@users.noreply.github.com>
2021-04-05 20:17:26 +03:00
alesapin
be22ffa5a8 Fix mutation killers tests 2021-04-05 19:31:49 +03:00
Anton Popov
700f4dabbd
Update 01670_log_comment.sql 2021-04-05 18:25:31 +03:00
Anton Popov
1f1a01171f try fix one more test 2021-04-05 17:52:41 +03:00
feng lv
f6e4e13f89 fix conflict 2021-04-05 14:08:30 +00:00
feng lv
56073db22d max distributed depth
Add settings max_distributed_depth

fix style

fix

fix

fix

fix test

fix

fix
2021-04-05 14:00:54 +00:00
Vitaly Baranov
278ad443e4 Test 01294_create_settings_profile no longer changes settings of the default user. 2021-04-05 13:28:39 +03:00
alesapin
8d5a787f6b Merge branch 'master' into merge_tree_deduplication 2021-04-05 10:40:03 +03:00
Azat Khuzhin
42d858b7e5 Fix LOGICAL_ERROR for Log with nested types w/o columns in the SELECT clause
Found with fuzzer [1]:

<details>

    2021.04.04 10:25:46.762596 [ 135 ] {4b6b5de3-d242-4267-910a-76b235467356} <Fatal> : Logical error: 'Logical error: no information about file column%2Ename.size0 in StorageLog'.
    ...
    2021.04.04 10:25:46.763563 [ 44 ] {} <Trace> BaseDaemon: Received signal 6
    2021.04.04 10:25:46.765884 [ 165 ] {} <Fatal> BaseDaemon: 5. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.04.04 10:25:46.901540 [ 165 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:51: DB::handle_error_code() @ 0x11cc4f16 in /workspace/clickhouse
    2021.04.04 10:25:47.030755 [ 165 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:58: DB::Exception::Exception() @ 0x11cc5025 in /workspace/clickhouse
    2021.04.04 10:25:47.617201 [ 165 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../src/Storages/StorageLog.cpp:183: DB::LogSource::readData()

</details>

  [1]: https://clickhouse-test-reports.s3.yandex.net/22583/69296876005c0fa171c755f8b224e4d58192c402/fuzzer_debug/report.html#fail1

The problem here is that there is no column%2Ename.size0 there is
column.size0 instead, and it seems that reading sizeX file is not enough
in other places, so just filter them out in
ExpressionActions::getSmallestColumn() (fallback method for storages w/o
getColumnSizes() implemented)
2021-04-05 08:48:04 +03:00
alexey-milovidov
a16a09eb2f
Merge pull request #22596 from ClickHouse/fix-some-tests-aarch64
Fix some tests on AArch64
2021-04-05 07:40:33 +03:00
alexey-milovidov
6cefb8e620
Merge pull request #22583 from azat/log-rwlock-ub-fix
Avoid UB in *Log engines for rwlock unlock due to unlock from another thread
2021-04-05 05:20:16 +03:00
alexey-milovidov
a9eb7a7c7e
Merge pull request #22595 from ClickHouse/change-accurate-comparison
Change accurate comparison of integer and float to be more consistent across different CPU
2021-04-05 04:22:50 +03:00
Alexey Milovidov
d645c4d4e2 Whitespace 2021-04-05 03:52:44 +03:00
Alexey Milovidov
08f129c0d3 Mark test as long 2021-04-05 03:52:06 +03:00
Alexey Milovidov
e50d82ab45 Merge branch 'master' into change-accurate-comparison 2021-04-05 01:38:55 +03:00
Alexey Milovidov
b07d53640c Fix flaky test 00816_long_concurrent_alter_column 2021-04-05 00:34:51 +03:00
alesapin
0ceb95aa55 Merge branch 'master' into merge_tree_deduplication 2021-04-04 18:32:27 +03:00
Anton Popov
0d03b8c0c4
Merge pull request #21889 from CurtizJ/fix-aggregation-in-order-1
Fix bugs in aggregation by primary key
2021-04-04 18:17:04 +03:00
Maksim Kita
ff86c21e65 Dictionary update field fix 2021-04-04 16:30:48 +03:00
Alexey Milovidov
cae21b8560 Fix test 2021-04-04 15:50:19 +03:00
alexey-milovidov
44e160596e
Merge pull request #22587 from ClickHouse/fix-flaky-test-15
Fix flaky test after #22427
2021-04-04 15:44:44 +03:00
alexey-milovidov
f6e6842383
Merge pull request #22590 from ClickHouse/fix-tests-aarch64
Fix CPU-dependent behaviour in tests
2021-04-04 15:43:12 +03:00
alexey-milovidov
0e1035735c
Merge pull request #22565 from ClickHouse/fix-assert-arena
Fix assert in Arena when doing GROUP BY Array of Nothing of non-zero size.
2021-04-04 15:38:17 +03:00
Alexey Milovidov
d18daa5919 Fix test 2021-04-04 15:18:17 +03:00
Alexey Milovidov
3ad3109ec5 Fix tests 2021-04-04 15:14:01 +03:00
Alexey Milovidov
9d47adbae6 Fix tests 2021-04-04 15:10:13 +03:00
Alexey Milovidov
9383fec50b Fix test 2021-04-04 15:07:52 +03:00
Alexey Milovidov
4a58055b2d Update test 2021-04-04 14:52:46 +03:00
Alexey Milovidov
eae9b978f8 Generate test files for accurate comparison int vs. float 2021-04-04 14:49:24 +03:00
Maksim Kita
0bfb429c42
Merge pull request #22479 from kitaisreal/clickhouse-dictionary-source-loop-fix
ClickHouseDictionarySource loop fix
2021-04-04 13:29:17 +03:00
Azat Khuzhin
44abb7588a StorageStripeLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
89a96cf14d StorageLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
5d795661ed StorageTinyLog: add regression test for UB due to unlock from different thread
Refs: #22560
2021-04-04 13:25:44 +03:00
Alexey Milovidov
729214c845 Fix some tests on AArch64 2021-04-04 13:11:36 +03:00
Alexey Milovidov
3ae0c7e17a Fix CPU-dependent behaviour in tests 2021-04-04 12:55:04 +03:00
Alexey Milovidov
41dfcb7bec Fix flaky test after #22427 2021-04-04 12:24:00 +03:00
Alexey Milovidov
e684b463ae Add test 2021-04-03 22:51:37 +03:00
alexey-milovidov
d0effbb0fc
Merge pull request #22534 from ClickHouse/minor-fixes-in-tests
Minor fixes in tests for AArch64
2021-04-03 22:10:43 +03:00
alesapin
0204f5dd35 Merge branch 'master' into merge_tree_deduplication 2021-04-03 15:24:26 +03:00
Maksim Kita
2f1f9692e6 Fixed test 2021-04-03 13:58:11 +03:00
alexey-milovidov
30ece2c28f
Merge pull request #22510 from vdimir/merge-join-lc-bug-fix
Convert right block to full in MergeJoin
2021-04-03 12:54:34 +03:00
Alexey Milovidov
0733144b4a Lower test scale 2021-04-03 12:53:57 +03:00
alexey-milovidov
143f4b59a0
Merge pull request #22527 from ClickHouse/fix-missing-nl-parse-tsv
Fix deserialization of empty string without newline at end of TSV format
2021-04-03 12:51:10 +03:00
alexey-milovidov
9f5cd35a69
Merge pull request #22323 from abyss7/poco-http2
Follow up to #19516
2021-04-03 02:09:10 +03:00
alexey-milovidov
3d860fc6ac
Merge pull request #22322 from abyss7/issue-21907
Do not limit HTTP chunk size
2021-04-03 01:58:22 +03:00
Alexey Milovidov
9c93ce7ff6 Minor fixes in tests 2021-04-03 01:57:04 +03:00
Maksim Kita
d84fd76f3f Fixed test 2021-04-03 00:40:31 +03:00
Maksim Kita
07d5a1ec21 ClickHouseDictionarySource loop fix 2021-04-03 00:40:07 +03:00
Alexey Milovidov
47a12a7b0b Add a test 2021-04-03 00:14:13 +03:00
alexey-milovidov
c3a9cbe01c
Merge pull request #22421 from ClickHouse/fix-buffer-overflow-in-token-extractor
Fix buffer overflow in token extractor
2021-04-02 22:08:28 +03:00
Alexander Kuzmenkov
d0037329cf
Merge pull request #22459 from ClickHouse/aku/window-frame-offset
fix window frame offset check and add more tests
2021-04-02 19:49:59 +03:00
alesapin
759dd79c76 Add tests 2021-04-02 19:45:18 +03:00
vdimir
8dcfe119bf
Add test pmj_lc_bug 2021-04-02 18:18:36 +03:00
Alexander Kuzmenkov
e7df8893df
Merge pull request #22300 from ClickHouse/trying_parallel_func_tests
Trying parallel func tests
2021-04-02 18:09:58 +03:00
Ivan Lezhankin
059175217f Fix test a little bit 2021-04-02 13:57:56 +03:00
Alexander Kuzmenkov
3492e3c40c fixes 2021-04-02 13:50:09 +03:00
Vladimir
9b40f384e9
Merge pull request #20622 from vdimir/issue-20497 2021-04-02 11:48:29 +03:00
Maksim Kita
3b799c5d7d
Merge pull request #22413 from kitaisreal/added-function-dict-get-or-null
Added function dictGetOrNull
2021-04-02 11:39:01 +03:00
Maksim Kita
d06fb1197a
Merge pull request #22096 from kitaisreal/hierarchy-dictionaries-updated
Refactored hierarchy dictionaries interface
2021-04-02 11:38:01 +03:00
Kseniia Sumarokova
b80951b06a
Merge pull request #21519 from fastio/aliases_to_visitParam
add aliases to visitParam/visitParamExtract* functions
2021-04-02 10:31:32 +03:00
alexey-milovidov
952429b73e
Update 01781_token_extractor_buffer_overflow.sql 2021-04-02 05:26:56 +03:00
Anton Popov
6aecaea664 add test for aggregation by primary key and many parts 2021-04-02 00:32:09 +03:00
kssenii
b66e0401f6 Lowercase 2021-04-01 23:07:01 +03:00
Alexander Kuzmenkov
ac97f7df29
Update 01591_window_functions.reference 2021-04-01 20:16:59 +03:00
Alexander Kuzmenkov
3f57ed41ed
Update 01591_window_functions.sql 2021-04-01 20:16:27 +03:00
Alexander Kuzmenkov
d006c5532e fix window frame offset check and add more tests 2021-04-01 18:56:58 +03:00
Ivan Lezhankin
4006be502b Add test 2021-04-01 18:09:10 +03:00
Alexey Milovidov
fbb4b05df0 Merge remote-tracking branch 'origin' into fix-buffer-overflow-in-token-extractor 2021-04-01 16:30:10 +03:00
alexey-milovidov
28c7980fba
Merge pull request #22427 from ClickHouse/protocol-break-oom
Better exception message in client in case of exception while writing blocks
2021-04-01 16:28:50 +03:00
alexey-milovidov
e3aa47c525
Merge pull request #22425 from ClickHouse/parallel-formatting-memory
Add memory accounting in parallel formatting
2021-04-01 16:23:48 +03:00
alesapin
85fbb7eccf
Merge pull request #21976 from ClickHouse/try-fix-excessive-rows-for-collapsing-merge
CollapsingSortedAlgorithm should not return more than index_granularity rows
2021-04-01 16:20:28 +03:00
Ivan Lezhankin
cc1c439ad8 Merge remote-tracking branch 'upstream/master' into poco-http2 2021-04-01 16:20:15 +03:00
Alexander Kuzmenkov
4e2d841e35 Merge remote-tracking branch 'origin/master' into HEAD 2021-04-01 15:13:41 +03:00
vdimir
1c5c1946df
Add test merge_engine_join_key_condition 2021-04-01 14:46:05 +03:00
vdimir
3f464595eb
Accurate removing 'join' part for queries to 'Merge' engine 2021-04-01 14:31:57 +03:00
vdimir
fff8043e55
Revert "Fix joined table access with Merge engine and aggregation"
This reverts commit 5476e68d6c.
2021-04-01 14:31:46 +03:00