Azat Khuzhin
18d2a99761
Use comments for variables that clang can parse
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 16:53:45 +01:00
Han Fei
0f7defb87f
Merge branch 'master' into hanfei/gwp-asan
2023-02-07 14:55:55 +01:00
Robert Schulze
08c1f8346e
Merge remote-tracking branch 'origin/master' into rs/fix-fragile-linking
2023-02-07 11:22:00 +00:00
Robert Schulze
84b9ff450f
Fix terribly broken, fragile and potentially cyclic linking
...
Sorry for the clickbaity title. This is about static method
ConnectionTimeouts::getHTTPTimeouts(). It was be declared in header
IO/ConnectionTimeouts.h, and defined in header
IO/ConnectionTimeoutsContext.h (!). This is weird and caused issues with
linking on s390x (##45520). There was an attempt to fix some
inconsistencies (#45848 ) but neither did @Algunenano nor me at first
really understand why the definition is in the header.
Turns out that ConnectionTimeoutsContext.h is only #include'd from
source files which are part of the normal server build BUT NOT part of
the keeper standalone build (which must be enabled via CMake
-DBUILD_STANDALONE_KEEPER=1). This dependency was not documented and as
a result, some misguided workarounds were introduced earlier, e.g.
0341c6c54b
The deeper cause was that getHTTPTimeouts() is passed a "Context". This
class is part of the "dbms" libary which is deliberately not linked by
the standalone build of clickhouse-keeper. The context is only used to
read the settings and the "Settings" class is part of the
clickhouse_common library which is linked by clickhouse-keeper already.
To resolve this mess, this PR
- creates source file IO/ConnectionTimeouts.cpp and moves all
ConnectionTimeouts definitions into it, including getHTTPTimeouts().
- breaks the wrong dependency by passing "Settings" instead of "Context"
into getHTTPTimeouts().
- resolves the previous hacks
2023-02-05 20:49:34 +00:00
Robert Schulze
9b841d67e8
Merge remote-tracking branch 'origin/master' into qc-max_cache_size
2023-02-05 16:47:02 +00:00
Antonio Andelic
12569da984
Merge branch 'master' into add-support-for-settings-alias
2023-02-05 16:08:57 +00:00
Boris Kuschel
1d4cf4fe69
Add encryption support with openssl
2023-02-04 14:59:34 -05:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
...
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00
Mikhail f. Shiryaev
cd2e1cfada
Merge pull request #45568 from ClickHouse/keeper-systemd
...
Add systemd.service for clickhouse-keeper
2023-02-03 23:08:02 +01:00
Antonio Andelic
8929838fcc
Merge branch 'master' into add-support-for-settings-alias
2023-02-03 17:47:00 +00:00
Nikita Mikhaylov
33877b5e00
Parallel replicas. Part [2] ( #43772 )
2023-02-03 14:34:18 +01:00
Anton Popov
cdbe145bc1
Merge pull request #45796 from CurtizJ/fix-leak-in-azure-sdk
...
Fix test `test_azure_blob_storage_zero_copy_replication ` (memory leak in azure sdk)
2023-02-03 14:16:19 +01:00
Mikhail f. Shiryaev
a42d20e19d
Create "coordination" directory in keeper if does not exist
2023-02-03 12:16:19 +01:00
Robert Schulze
f72286c8f3
Merge branch 'master' into qc-max_cache_size
2023-02-03 10:54:35 +01:00
Robert Schulze
b1889b0284
Make the naming a little less confusing
2023-02-02 19:18:39 +00:00
Kevin Zhang
45e8020768
remove host used for dev
2023-02-02 09:16:39 -05:00
Antonio Andelic
f613bfd8d2
Merge branch 'master' into add-support-for-settings-alias
2023-02-02 11:15:39 +00:00
Robert Schulze
53e1c9cd08
Merge branch 'master' into qc-max_cache_size
2023-02-02 11:45:29 +01:00
Kevin Zhang
28a20f8de9
fix charts not clearing previous plot when editing after deleting charts
2023-02-01 16:49:58 -05:00
Kevin Zhang
698c819ea9
show authentication error message in dashboard when credentials invalid
2023-02-01 16:45:40 -05:00
Vladimir C
0d48eed68f
Merge pull request #45848 from Algunenano/fix_connection_timeouts_context_include
2023-02-01 12:53:50 +01:00
Robert Schulze
216636f984
Make query cache global settings re-configurable
2023-02-01 10:35:19 +00:00
Robert Schulze
b512316586
Merge pull request #45682 from ClickHouse/rename-qrc-to-qc
...
Rename "Query Result Cache" to "Query Cache"
2023-02-01 11:23:29 +01:00
Antonio Andelic
ec04cf6876
Merge branch 'master' into add-support-for-settings-alias
2023-02-01 09:01:01 +00:00
Raúl Marín
7c31cb7adc
Proper includes for ConnectionTimeoutsContext.h
2023-01-31 16:11:32 +01:00
Han Fei
716518f143
Merge branch 'master' into hanfei/gwp-asan
2023-01-31 15:01:25 +01:00
Kseniia Sumarokova
7d53f8bbf6
Merge pull request #45591 from bharatnc/ncb/odbc-connection-pool-fixes
...
fixes to use the odbc_bridge_use_connection_pooling setting correctly
2023-01-31 11:31:59 +01:00
Robert Schulze
325c6bdf3d
Renaming: "Query Result Cache" --> "Query Cache"
...
Reasons:
- The cache will at some point store intermediate results as opposed to
only query results. We should change the terminology now without
having to worry about backward compat.
- Equivalent caches in MySQL (1) and Starrocks (2) are called "query
cache".
- The new name is ca. 13.8% more catchy.
(1) https://dev.mysql.com/doc/refman/5.6/en/query-cache.html
(2) https://docs.starrocks.io/en-us/2.5/using_starrocks/query_cache
2023-01-31 09:54:34 +00:00
Alexey Milovidov
7aa10a430a
Merge branch 'master' into hanfei/gwp-asan
2023-01-31 04:13:59 +03:00
Anton Popov
839cd614fb
fix memory leak in azure sdk
2023-01-31 01:01:10 +00:00
Bharat Nallan
f1d6e3b908
Merge branch 'master' into ncb/odbc-connection-pool-fixes
2023-01-30 15:49:04 -08:00
Han Fei
4971358de5
fix init
2023-01-30 17:07:01 +01:00
Azat Khuzhin
4564a1ef29
Add ability to override connection settings based on connection names
...
This is somehow analog of .netrc [1].
[1]: https://www.gnu.org/software/inetutils/manual/html_node/The-_002enetrc-file.html
The follow options can be overwritten on a per-hostname/connection
basis:
- hostname
- port
- secure
- user
- password
- database
- history_file
Also note, that you can have multiple settings for one hostname, can be
useful to distinguish readonly from non-readonly for example.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-28 17:01:12 +01:00
Anton Popov
d8fe2bcbaa
Merge branch 'master' into randomize-mt-settings
2023-01-27 16:03:00 +01:00
Antonio Andelic
defc9108f0
Extend support for aliases to constraints and profiles
2023-01-27 09:39:10 +00:00
Alexander Tokmakov
067b1f5f13
Merge branch 'master' into exception_message_patterns4
2023-01-26 15:20:58 +01:00
Antonio Andelic
714fad1529
Add support for settings alias
2023-01-26 14:06:46 +00:00
Anton Popov
92fa39798b
Merge remote-tracking branch 'upstream/master' into HEAD
2023-01-26 13:29:23 +00:00
Azat Khuzhin
5729ff6043
Add example of background_*_pool_size into config.xml
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-25 19:53:45 +01:00
Bharat Nallan
2ef8fcb318
Merge branch 'master' into ncb/odbc-connection-pool-fixes
2023-01-24 21:27:20 -08:00
Alexander Tokmakov
31e16c4b4d
fix
2023-01-24 15:29:19 +01:00
Alexander Tokmakov
6ecae8388e
Merge branch 'master' into exception_message_patterns4
2023-01-24 14:42:36 +01:00
Alexey Milovidov
cb1e8afda6
Merge pull request #45524 from kssenii/fix-cache-policies-getter
...
Add proper default to cache policy getter
2023-01-24 12:46:33 +03:00
Alexander Tokmakov
3f6594f4c6
forbid old ctor of Exception
2023-01-23 22:18:05 +01:00
Alexander Tokmakov
70d1adfe4b
Better formatting for exception messages ( #45449 )
...
* save format string for NetException
* format exceptions
* format exceptions 2
* format exceptions 3
* format exceptions 4
* format exceptions 5
* format exceptions 6
* fix
* format exceptions 7
* format exceptions 8
* Update MergeTreeIndexGin.cpp
* Update AggregateFunctionMap.cpp
* Update AggregateFunctionMap.cpp
* fix
2023-01-24 00:13:58 +03:00
kssenii
3a4d5ba07d
Fix cache policy getter
2023-01-23 22:07:06 +01:00
Anton Popov
08b2e524c7
Merge remote-tracking branch 'upstream/master' into HEAD
2023-01-23 15:34:53 +00:00
Robert Schulze
340f406553
Merge branch 'master' into query-result-cache
2023-01-22 13:21:36 +01:00
Han Fei
8b29f8406b
Merge branch 'master' into hanfei/gwp-asan
2023-01-20 11:03:12 +01:00
Stig Bakken
420c179b55
Add <storage_policy> config parameter for system logs
2023-01-19 10:25:28 +01:00
Bharat Nallan Chakravarthy
16a2585d55
fixes to odbc connection pooling
2023-01-18 16:38:56 -08:00
Robert Schulze
4f90824347
Merge remote-tracking branch 'origin/master' into query-result-cache
2023-01-17 22:49:53 +00:00
Smita Kulkarni
09241150a0
Updated recording of startup time till after starting last listener and added stopping the StopWatch - Record server startup time in ProfileEvents
2023-01-16 08:32:25 +01:00
Smita Kulkarni
a0fe26f506
Addressed review comments and updated name to ServerStartupMilliseconds - Record server startup time in ProfileEvents
2023-01-13 14:38:54 +01:00
Smita Kulkarni
cf5cb0da97
Record server startup time in ProfileEvents
...
Implementation:
* Added ProfileEvents::ServerStartupTime.
* Recorded time from start of main till listening to sockets.
Testing:
* Added a test 02532_profileevents_server_startup_time.sql
2023-01-13 13:47:54 +01:00
Robert Schulze
843264ae3e
Add QRC settings to default config.xml
2023-01-13 10:32:22 +00:00
Robert Schulze
475bb31f33
Make server configuratio hierarchical
2023-01-12 21:24:40 +00:00
Han Fei
f5e736e240
introduce llvm/gwp-asan
2023-01-12 15:00:26 +01:00
Anton Popov
ca80240d84
Merge remote-tracking branch 'upstream/master' into HEAD
2023-01-12 12:13:45 +00:00
Robert Schulze
923fa2c15a
Fix review comments, pt. II
2023-01-10 10:21:08 +00:00
Robert Schulze
45dbcf88e5
Merge remote-tracking branch 'origin/master' into query-result-cache
2023-01-06 20:42:48 +00:00
Kseniia Sumarokova
573d3283b0
Merge pull request #44327 from kssenii/use-new-named-collections-code-2
...
Replace old named collections code with new (from #43147 ) part 2
2023-01-06 13:06:26 +01:00
Alexey Milovidov
3a027d285f
Merge pull request #44828 from ClickHouse/remove-two-lines-of-code
...
What if I will remove two lines of code?
2023-01-04 04:50:52 +03:00
Robert Schulze
27f5aad49e
What happens if I remove 156 lines of code?
2023-01-03 18:51:16 +00:00
Robert Schulze
cfb6feffde
What happens if I remove these 139 lines of code?
2023-01-03 18:35:31 +00:00
kssenii
67509aa2d5
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2
2023-01-03 16:41:30 +01:00
Robert Schulze
e9e04166d9
Merge remote-tracking branch 'origin/master' into query-result-cache
2023-01-02 08:20:27 +00:00
Alexey Milovidov
b859cc2ddc
Fix build
2023-01-02 03:27:21 +01:00
Alexey Milovidov
47ae8c5c79
Remove more lines
2023-01-02 02:06:11 +01:00
Alexey Milovidov
6e946cc757
Less OOM in stress test
2023-01-01 23:22:26 +01:00
Nikolay Degterinsky
dfe93b5d82
Merge pull request #42284 from Algunenano/perf_experiment
...
Performance experiment
2022-12-30 03:14:22 +01:00
Raúl Marín
e915ce1e95
Merge remote-tracking branch 'blessed/master' into perf_experiment
2022-12-28 20:15:43 +01:00
Azat Khuzhin
b7f92454bf
Move LineReader/ReplxxLineReader out from base
...
This will simplify linking dependencies, and anyway this classes are not
base in any sense.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Alexey Milovidov
514ff2ba20
Merge pull request #44570 from ClickHouse/clickhouse-benchmark-better-arguments
...
Better command line argument name in `clickhouse-benchmark`
2022-12-27 16:10:21 +03:00
Alexey Milovidov
e1115828d0
Merge pull request #44593 from ClickHouse/better-diagnostic-in-stress-test
...
Better diagnostics on server stop for the stress test
2022-12-27 16:07:43 +03:00
Alexey Milovidov
1c8fa6eb26
Merge pull request #44595 from ClickHouse/wrong-place-of-log-message
...
The position of the log message about the server environment was wrong
2022-12-27 16:00:37 +03:00
Alexey Milovidov
1b21cc018e
Merge pull request #44342 from ClickHouse/add-test-29883
...
Add a test for #29883
2022-12-27 14:55:14 +03:00
Raúl Marín
fc1fa82a39
Merge branch 'master' into perf_experiment
2022-12-27 10:51:58 +01:00
Alexey Milovidov
b218d549bf
Fix bad log message
2022-12-26 13:56:09 +01:00
Alexey Milovidov
d08e7e5f2d
The position of the log message about the server environment was wrong
2022-12-26 13:30:13 +01:00
Alexey Milovidov
e98f217b87
Better diagnostics on stop
2022-12-26 12:15:58 +01:00
Alexey Milovidov
d4864c7d38
Better command line argument name in clickhouse-benchmark
2022-12-24 20:40:23 +01:00
kssenii
8308177361
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2
2022-12-23 12:14:46 +01:00
vdimir
511e8d698d
Rename config param tmp_cache -> temporary_data_in_cache
2022-12-22 10:22:56 +00:00
vdimir
d30d25dbbe
Temporary files evict fs cache
2022-12-22 10:22:49 +00:00
Alexey Milovidov
a6f50edde3
Merge branch 'master' into add-test-29883
2022-12-21 01:45:18 +03:00
kssenii
6bd4f8c029
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2
2022-12-20 21:17:28 +01:00
Anton Popov
56187c5f0e
Merge remote-tracking branch 'upstream/master' into HEAD
2022-12-20 13:37:23 +00:00
Raúl Marín
45d27f461b
Merge branch 'master' into perf_experiment
2022-12-20 09:07:48 +00:00
Sergei Trifonov
6f7bba159f
Merge pull request #41840 from ClickHouse/io-scheduler
...
IO scheduling subsystem
2022-12-19 15:15:19 +01:00
Robert Schulze
b93c56323c
Merge remote-tracking branch 'origin/master' into query-result-cache
2022-12-19 09:18:36 +00:00
Alexey Milovidov
1795c583a1
Add a test for #29883
2022-12-18 08:00:32 +01:00
Alexey Milovidov
30fd9b8317
Merge pull request #43597 from ClickHouse/sd_notify_followup_fixes
...
Followup fixes for systemd notification (#43400 )
2022-12-17 04:35:05 +03:00
kssenii
30547d2dcd
Replace old named collections code for url
2022-12-17 00:24:05 +01:00
Boris Kuschel
b1e401eb93
Merge branch 'ClickHouse:master' into openssl_support
2022-12-16 16:40:08 -05:00
Boris Kuschel
1b7c5758d2
Fix openssl Bug
2022-12-16 12:31:17 -08:00
Sergei Trifonov
f61a98b5dc
Merge branch 'master' into io-scheduler
2022-12-16 15:55:08 +01:00
Anton Popov
b6f2754afb
Merge remote-tracking branch 'upstream/master' into HEAD
2022-12-16 14:37:34 +00:00
Robert Schulze
4db33f16e3
Make DoS attack on cache less likely
2022-12-15 21:42:51 +00:00
Robert Schulze
537c64aad2
Merge remote-tracking branch 'origin/master' into query-result-cache
...
Conflicts:
- tests/queries/0_stateless/02117_show_create_table_system.reference
2022-12-15 12:17:58 +00:00