alesapin
323e1a5087
Add woboq workflow
2021-12-21 14:23:17 +03:00
alesapin
5929d65e9e
Add regular job
2021-12-21 14:22:47 +03:00
alesapin
a89a05c0da
Finally woboq is ready
2021-12-21 14:16:21 +03:00
mergify[bot]
1daf469799
Merge branch 'master' into clickhouse-test-unknown
2021-12-21 10:55:11 +00:00
Haavard Kvaalen
9a2b0680a1
Fix weird permission on log directories
...
Several log directories for integration tests were created with full
permissions for "others" but no permission for the owner of the
directory. This caused issues when trying to run integration tests
again without manually wiping files from previous runs. The test would
fail with "PermissionError: [Errno 13] Permission denied: 'logs'".
The intention may have been to do the equivalent of 'chmod o+rwx logs',
but it instead did the equivalent of 'chmod 007 logs'.
2021-12-21 11:50:54 +01:00
Kseniia Sumarokova
c5dfbfc6f5
Merge pull request #32992 from ClickHouse/kssenii-patch-2
...
Fix typo
2021-12-21 12:43:32 +03:00
Kseniia Sumarokova
de7a5dd1e6
Update ExpressionListParsers.cpp
2021-12-21 12:39:31 +03:00
Maksim Kita
c343623fa4
Merge pull request #32990 from dalei2019/patch-1
...
Update role.md
2021-12-21 12:01:29 +03:00
Raúl Marín
eddccb0065
Merge remote-tracking branch 'blessed/master' into kill_scalar_github
2021-12-21 10:00:17 +01:00
alesapin
754785fee5
Better container
2021-12-21 11:07:24 +03:00
dalei2019
11c85fe66b
Update role.md
2021-12-21 16:03:37 +08:00
kssenii
ebcb66a361
Fix
2021-12-21 10:58:02 +03:00
mergify[bot]
7cf7c5d247
Merge branch 'master' into keeper_handler_remove_operation_when_response_sent
2021-12-21 07:55:19 +00:00
alesapin
0e7f63c4d1
Merge pull request #32987 from kssenii/fix-clang-tidy
...
Fix clang-tidy
2021-12-21 10:52:17 +03:00
alesapin
532b01c371
Followup
2021-12-21 10:49:22 +03:00
Kseniia Sumarokova
e0f2fe457d
Update test.py
2021-12-21 10:29:27 +03:00
mergify[bot]
649226853d
Merge branch 'master' into fix-clang-tidy
2021-12-21 06:05:57 +00:00
Azat Khuzhin
4230f04f72
Fix UB in LimitReadBuffer in case of unexpected EOF
...
Fixes the following possible assertions:
- ./src/IO/ReadBuffer.h:58: bool DB::ReadBuffer::next(): Assertion `!hasPendingData()' failed.
- ./src/IO/LimitReadBuffer.cpp:17: virtual bool DB::LimitReadBuffer::nextImpl(): Assertion `position() >= in->position()' failed.
Fixes: 02151_http_s_structure_set_eof
2021-12-21 08:38:41 +03:00
Azat Khuzhin
08ced87880
Rework MultipartReadBuffer::skipToNextBoundary()
...
As suggested by @vitlibar
2021-12-21 08:38:41 +03:00
Azat Khuzhin
d7c7a91f66
Check that at least one boundary exist in HTMLForm::readMultipart()
2021-12-21 08:38:41 +03:00
Azat Khuzhin
4dfa9324d1
Check for EOF in MultipartReadBuffer::skipToNextBoundary()
...
Otherwise you may hit internal assertion when client goes away:
clickhouse-server: ./src/Server/HTTP/HTMLForm.cpp:245: bool DB::HTMLForm::MultipartReadBuffer::skipToNextBoundary(): Assertion `boundary_hit' failed.
Fixes: 02151_http_s_structure_set_eof
2021-12-21 08:38:41 +03:00
Azat Khuzhin
7193bb9579
Add a test with EOF during creating set over HTTP
...
v2: update some comments
2021-12-21 08:38:41 +03:00
JackyWoo
7a19570853
keeper handler should remove operation when response sent
2021-12-21 11:43:14 +08:00
kssenii
30996b2448
Fix
2021-12-21 01:19:51 +03:00
N. Kolotov
66eb6bf560
Added test to check client option --echo.
2021-12-21 00:59:35 +03:00
alexey-milovidov
04fb8aeaa5
Merge pull request #32946 from antonio2368/feature/hints-for-settings
...
Hints for invalid settings in query and HTTP requests
2021-12-21 00:52:42 +03:00
kssenii
175ad8a989
Fix
2021-12-21 00:20:08 +03:00
Kseniia Sumarokova
d51b101244
Update test.py
2021-12-21 00:06:24 +03:00
Maksim Kita
26ea47982e
Merge pull request #32965 from save-my-heart/fix-data-part-modification-time
...
fix wrong modification_time after move part
2021-12-21 00:05:27 +03:00
kssenii
a064410a39
Fix
2021-12-21 00:03:55 +03:00
Kseniia Sumarokova
2ac7897470
Merge pull request #32841 from lingtaolf/feature/add-clickhouse-client-hints
...
Add clickhouse client hints
2021-12-20 23:48:50 +03:00
Azat Khuzhin
a367326abb
Mark 02152_http_external_tables_memory_tracking as no-tsan
2021-12-20 23:30:44 +03:00
Vitaly Baranov
be44743ebe
Don't throw in unexceptional cases: update().
2021-12-20 23:10:46 +03:00
Vitaly Baranov
ed94c640fa
Don't throw in unexceptional cases: remove().
2021-12-20 23:10:43 +03:00
Vitaly Baranov
551fcc55e8
Don't throw in unexceptional cases: insert().
2021-12-20 23:09:55 +03:00
Alexey
5a63f311fc
en edits
2021-12-20 20:05:55 +00:00
alesapin
e194b38096
Followup
2021-12-20 22:54:04 +03:00
alesapin
a962cc67da
Fix deps
2021-12-20 22:45:30 +03:00
alesapin
62eb504029
Trying to add woboq
2021-12-20 22:43:37 +03:00
Antonio Andelic
4eae5ce00e
Fix http request check
2021-12-20 20:39:31 +01:00
mergify[bot]
e21c04ff9c
Merge branch 'master' into fix-data-part-modification-time
2021-12-20 18:58:47 +00:00
Azat Khuzhin
6afcb1d1c8
Replace uuidgen(1) with generateUUID() function in 02152_http_external_tables_memory_tracking
...
uuidgen (from e2fsprogs) does not exists on CI images, so use internal
clickhouse function.
2021-12-20 21:43:26 +03:00
Vitaly Baranov
8c4e689da3
Don't throw in unexceptional cases: read() & readName()
2021-12-20 21:26:35 +03:00
Vitaly Baranov
a87f0b483e
Replace function IAccessStorage::canInsert() with isReadOnly().
2021-12-20 21:26:35 +03:00
Vitaly Baranov
6721060649
Rename function IAccessStorage::login() -> IAccessStorage::authenticate().
...
Remove functions IAccessStorage::hasSubscriptionImpl() and IAccessStorage::existsImpl().
2021-12-20 21:26:27 +03:00
Vitaly Baranov
c01d0f95c3
Remove the function IAccessStorage::getIDOfLoggedUser() and move its functionality to login(AlwaysAllowCredentials).
2021-12-20 21:24:38 +03:00
Azat Khuzhin
a9f80dd705
Fix Context leak in case of cancel_http_readonly_queries_on_client_close
...
To handle cancel_http_readonly_queries_on_client_close=true context
attaches progress callback with holding a copy of the current context,
and this creates recursive context reference and so shared_ptr will be
never released, [1] contains simplest example.
One example of a memory leak, external tables passed with HTTP query
(s_structure + file upload), since they are stored in the context, and
can occupate enough memory to make it visible to user.
Note, that the lifetime of the Context should be fine, since callback
can be called only when query is executed.
[1]: Example of recursive reference
```c
#include <memory>
#include <functional>
#include <cassert>
bool released = true;
class Context : public std::enable_shared_from_this<Context>
{
using Func = std::function<void()>;
Func func;
public:
Context() { released = false; }
~Context() { released = true; }
Context(const Context & context) = delete;
void addCallback(Func func_)
{
func = func_;
}
};
int main()
{
{
auto context = std::make_shared<Context>();
context->addCallback([context]() {});
}
assert(released == true);
}
```
2021-12-20 21:05:38 +03:00
Azat Khuzhin
dd8c64e380
Set QueryScope earlier for HTTP queries
2021-12-20 21:05:38 +03:00
Azat Khuzhin
095f558ba1
Cover memory tracking of external tables via HTTP queries
...
Thanks to @den-crane
2021-12-20 21:05:37 +03:00
Nikolai Kochetov
35883e0dae
Merge pull request #32979 from ClickHouse/decrease-some-s3-log-level
...
Decrease log level for some s3 messages.
2021-12-20 20:56:22 +03:00
