Commit Graph

42 Commits

Author SHA1 Message Date
Nikolai Kochetov
d939cef9d1 Fix result for SimpleAggregateFunction with LowCardinality for AggregatingSortedBlockInputStream. 2020-01-10 17:51:30 +03:00
Nikolai Kochetov
87377431f4 Fix result for SimpleAggregateFunction with LowCardinality for AggregatingSortedBlockInputStream. 2020-01-10 17:01:24 +03:00
Alexey Milovidov
9f3afed5ff Optimization of priority queue 2019-12-22 03:19:07 +03:00
Boris Granveaud
a9160e908c fix "Sizes of columns doesn't match" error with SimpleAggregateFunction 2019-11-15 14:24:54 +01:00
Nikolai Kochetov
77ca4acf67 Remove LowCardinality in AggregatingSortedBlockInputStream. 2019-08-02 13:54:40 +03:00
Nikolai Kochetov
5a9a4b23c3 Remove LowCardinality in AggregatingSortedBlockInputStream. 2019-08-02 13:50:42 +03:00
Nikolai Kochetov
f71ce27a70 Remove LowCardinality in AggregatingSortedBlockInputStream. 2019-08-02 13:49:52 +03:00
Azat Khuzhin
db274bf516
Allocates arena for SimpleAggregateFunction only if IAggregateFunction requires 2019-05-19 03:33:04 +03:00
Azat Khuzhin
4e8370b0b0
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
SimpleAggregateFunction do not pass arena to the
add_function -> getAddressOfAddFunction(), hence next crash happens:
  (gdb) bt
  #0  DB::Arena::alloc (size=64, this=0x0) at ../dbms/src/Common/Arena.h:124
  #1  DB::SingleValueDataString::changeImpl (this=0x7f97424a27d8, value=..., arena=0x0) at ../dbms/src/AggregateFunctions/AggregateFunctionMinMaxAny.h:274
  #2  0x0000000005ea5319 in DB::AggregateFunctionNullUnary<true>::add (arena=<optimized out>, row_num=<optimized out>, columns=<optimized out>, place=<optimized out>, this=<optimized out>) at ../dbms/src/AggregateFunctions/AggregateFunctionNull.h:43
  #3  DB::IAggregateFunctionHelper<DB::AggregateFunctionNullUnary<true> >::addFree (that=<optimized out>, place=<optimized out>, columns=<optimized out>, row_num=<optimized out>, arena=<optimized out>) at ../dbms/src/AggregateFunctions/IAggregateFunction.h:131
  #4  0x000000000679772f in DB::AggregatingSortedBlockInputStream::addRow (this=this@entry=0x7f982de19c00, cursor=...) at ../dbms/src/Common/AlignedBuffer.h:31
  #5  0x0000000006797faa in DB::AggregatingSortedBlockInputStream::merge (this=this@entry=0x7f982de19c00, merged_columns=..., queue=...) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:140
  #6  0x0000000006798979 in DB::AggregatingSortedBlockInputStream::readImpl (this=0x7f982de19c00) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:78
  #7  0x000000000622db55 in DB::IBlockInputStream::read (this=0x7f982de19c00) at ../dbms/src/DataStreams/IBlockInputStream.cpp:56
  #8  0x0000000006613bee in DB::MergeTreeDataMergerMutator::mergePartsToTemporaryPart (this=this@entry=0x7f97ec65e1a0, future_part=..., merge_entry=..., time_of_merge=<optimized out>, disk_reservation=<optimized out>, deduplicate=<optimized out>) at /usr/include/c++/8/bits/shared_ptr_base.h:1018
  #9  0x000000000658f7a4 in DB::StorageReplicatedMergeTree::tryExecuteMerge (this=0x7f97ec65b810, entry=...) at /usr/include/c++/8/bits/unique_ptr.h:342
  #10 0x00000000065940ab in DB::StorageReplicatedMergeTree::executeLogEntry (this=0x7f97ec65b810, entry=...) at ../dbms/src/Storages/StorageReplicatedMergeTree.cpp:910
  <snip>

  (gdb) f 1
  (gdb) p MAX_SMALL_STRING_SIZE
  $1 = 48
  (gdb) p capacity
  $2 = 64
  (gdb) p value
  $3 = {data = 0x7f97242fcbd0 "HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH", size = 61}

v2: avoid leaking of allocated by Arena memory on the intermediate step

Fixes: 8f8d2c048e ("Merge pull request #4629 from bgranvea/simple_aggregate_function")
2019-05-19 03:32:55 +03:00
bgranvea
42b07c5ee9 refactor to avoid dynamic_cast in data type serialization 2019-04-08 15:39:42 +02:00
bgranvea
faa7d38cb5 fix for style 2019-04-08 15:39:42 +02:00
bgranvea
9d9d16e1ea support for SimpleAggregateFunction data type 2019-04-08 15:39:41 +02:00
Vitaly Baranov
ad377d421f MergingSortedBlockInputStream class constructor, "max_block_size" parameter: change type UInt64 -> size_t. 2019-02-19 14:56:08 +03:00
Alexey Milovidov
58a6accee5 Updated test #4246 2019-02-10 19:55:12 +03:00
Alexey Milovidov
36db216abf Preparation for extra warnings [#CLICKHOUSE-2] 2018-08-10 07:02:56 +03:00
Alexey Milovidov
3fd2773151 Improved code after introduction of method "getHeader" in every stream [#CLICKHOUSE-2] 2018-04-07 04:46:50 +03:00
Alexey Milovidov
f66d2fb780 Allow to use FINAL even in case of single part #2086 2018-04-06 00:36:55 +03:00
Nikolai Kochetov
66b94d481a added MultiversionMergeTree [#CLICKHOUSE-3479] 2018-02-13 00:13:50 +03:00
proller
d97b2edc7c Make separate libs Common/ZooKeeper and Common/ConfigProcessor (#1749)
* Make separate libs Common/ZooKeeper and Common/ConfigProcessor
renamed:    dbms/src/Common/StringUtils.h -> dbms/src/Common/StringUtils/StringUtils.h

* Fix space

* Fix data in system.build_options

* merge

* merge
2018-01-15 22:07:47 +03:00
Alexey Milovidov
4148c6ce81 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 03:06:56 +03:00
Alexey Milovidov
8926af2ced Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 03:01:59 +03:00
Alexey Milovidov
819287b697 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-13 04:27:53 +03:00
Alexey Milovidov
86c46ad1bd Unification [#CLICKHOUSE-2]. 2017-09-15 15:16:12 +03:00
Nikolai Kochetov
75be0b81d8 removed typeid_cast from IColumn.h 2017-07-13 23:58:19 +03:00
Alexey Milovidov
310736cd7e Moved headers and sources to same place [#CLICKHOUSE-3]. 2017-04-01 12:22:42 +03:00
Alexey Milovidov
137ad95929 Changed tabs to spaces in code [#CLICKHOUSE-3]. 2017-04-01 11:35:09 +03:00
Alexey Milovidov
14c8003081 Normalized formatting [#CLICKHOUSE-3].
Apply in a loop:
find dbms -name '*.h' -or -name '*.cpp' | xargs grep -l -P '^(\t*)    ' | xargs sed -i -r -e 's/^(\t*)    /\1\t/'
2017-03-26 04:28:07 +03:00
Alexey Milovidov
93890423f1 Fixed zero-width spaces [#CLICKHOUSE-3].
find dbms -name '*.h' -or -name '*.cpp' | xargs grep -l $'\xe2\x80\x8b' | xargs sed -i 's/'$'\xe2\x80\x8b''//g'
2017-03-26 04:20:25 +03:00
f1yegor
bc0d9a2cae translate comments 2017-03-25 21:12:56 +01:00
Alexey Milovidov
2b4f3b5d34 Renamed method (less confusion) [#METR-2944]. 2017-01-02 23:12:12 +03:00
Alexey Milovidov
55ed2904f4 Allowed for certain aggregate functions to have case insensitive names for compatibility [#METR-22087]. 2016-07-14 08:22:09 +03:00
Alexey Milovidov
1d2c603ecf Fixed errors [#METR-12588]. 2016-04-14 08:03:33 +03:00
Alexey Milovidov
0ea54e943b Fixed error in prev. revision [#METR-12588]. 2016-04-14 06:49:12 +03:00
Alexey Milovidov
b664f367d8 Improved Summing/Aggregating streams [#METR-12588]. 2016-04-14 00:15:36 +03:00
Alexey Milovidov
c0e029bb1b dbms: renamed ColumnWithNameAndType to ColumnWithTypeAndName for clarification [#METR-2944]. 2015-07-17 04:27:35 +03:00
Alexey Milovidov
e3b0c97b0f dbms: fixed error with merging [#METR-16247]. 2015-05-12 07:55:14 +03:00
Alexey Milovidov
1685b293f7 dbms: tiny improvements [#METR-2944]. 2015-01-18 11:25:56 +03:00
Alexey Milovidov
108a7850a5 dbms: improved performance on short queries [#METR-11571]. 2014-06-26 04:58:14 +04:00
Alexey Milovidov
895ae78c9e dbms: incremental aggregation: fixed error [#METR-10894]. 2014-06-16 22:28:04 +04:00
Alexey Milovidov
649114821c dbms: development [#METR-10894]. 2014-06-06 23:35:41 +04:00
Sergey Fedorov
edd482acf3 dbms: more fixes on aggregate function columns [METR-10894] 2014-05-30 20:22:14 +04:00
Sergey Fedorov
8f306f4238 Merge 2014-05-26 20:13:46 +04:00