Commit Graph

12 Commits

Author SHA1 Message Date
bharatnc
b7678c1bc1 fix s2 functions having const columns 2022-02-18 22:42:27 -08:00
bharatnc
3df4929b63 minor fixes 2022-02-05 16:45:12 -08:00
bharatnc
557cf6ecc1 check and get column remaining s2 funcs 2022-02-05 16:32:15 -08:00
bharatnc
b9787f730e use prefix increment for rows 2021-12-19 20:32:52 -08:00
bharatnc
15c555c161 simplify looping in S2 functions
Previously replaced range based for loops in H3 functions with simple
for loops based on review. Similarly doing the same for the S2 functions
also.
2021-12-19 20:00:28 -08:00
Alexey Milovidov
8b4a6a2416 Remove cruft 2021-10-28 02:10:39 +03:00
Alexey Milovidov
fe6b7c77c7 Rename "common" to "base" 2021-10-02 10:13:14 +03:00
bharatnc
503b7a59f0 fix getNumberOfArguments() for s2Rect functions
This fixes the value returned by the getNumberOfArguments() by the
s2RectAdd and the s2RectContains functions. Only 3 arguments are
used by these functions and not 4:

- low s2Point of rectangle
- high s2Point of rectangle
- given s2Point

The given s2Point is used to groow the size of the bounding rectangle to
include the given S2Point in case of the s2RectAdd function. In case
of s2RectContains, the function determines if the bounded rectangle
contains the given point.

PS: I wonder if it's more apt to call rectAdd as rectGrow since
it's used to grow the size of a given rectangle.
2021-09-06 14:19:18 -07:00
Pavel Kruglov
b841a96c39 Refactor code 2021-08-10 14:31:15 +03:00
Nikita Mikhaylov
1b4f60a0f6 fix fuzzer 2021-07-13 10:51:35 +00:00
Nikita Mikhaylov
fbf529411b fix tests 2021-07-13 10:51:35 +00:00
Nikita Mikhaylov
67fecc55a9 add tests 2021-07-13 10:50:39 +00:00