Commit Graph

131626 Commits

Author SHA1 Message Date
Azat Khuzhin
51d4f583e6 Properly set shutdown_called in StorageKafka::shutdown()
Fixes: https://github.com/ClickHouse/ClickHouse/pull/42777
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-27 09:49:07 +01:00
Azat Khuzhin
123d63e824 Remove StorageKafka::num_created_consumers (in favor of all_consumers.size())
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-27 09:49:07 +01:00
Pengyuan Bian
3dcc1f5448 update. 2023-12-27 07:54:18 +00:00
Raúl Marín
76abd32196 Speedup MIN and MAX for native types 2023-12-26 20:23:55 +01:00
Alexey Milovidov
a0fccb0498
Merge pull request #58224 from amosbird/part_offset_pk
Primary key analysis for _part_offset
2023-12-26 14:51:57 +01:00
Alexey Milovidov
4fbe41b47e
Update 02950_part_offset_as_primary_key.sql 2023-12-26 16:51:39 +03:00
Alexey Milovidov
31a081bd83
Merge pull request #58226 from Algunenano/cleanup_known_short
Cleanup some known short messages
2023-12-26 14:40:58 +01:00
Alexey Milovidov
ee1d7f25de
Merge pull request #58221 from ClickHouse/fix_syntax_and_doc
Fix syntax and doc
2023-12-26 14:38:54 +01:00
Yarik Briukhovetskyi
41c275274b
Merge pull request #58148 from yariks5s/fix_s3_regions
S3-links region independency
2023-12-26 12:59:00 +01:00
Raúl Marín
e87b9751bd Cleanup some known short messages 2023-12-26 12:58:50 +01:00
Maksim Kita
71921086ae Fixed tests 2023-12-26 12:41:21 +03:00
Maksim Kita
cbf9304d1f MergeTree automatically derive do_not_merge_across_partitions_select_final setting 2023-12-26 12:41:21 +03:00
Amos Bird
66660ee4e2
Add comment 2023-12-26 17:04:00 +08:00
Amos Bird
bfcccf9fa3
Primary key analysis for _part_offset 2023-12-26 17:03:59 +08:00
Pengyuan Bian
2765acfe45 wip test. 2023-12-26 07:50:46 +00:00
santrancisco
91835256aa
fix doc 2023-12-26 16:57:18 +11:00
santrancisco
a59d874bf9
fix syntax 2023-12-26 16:56:58 +11:00
wangtao.2077
7ad278eefb fix AddDefaultDatabaseVisitor bad performance 2023-12-26 13:31:45 +08:00
Nikolay Degterinsky
85b149395a
Merge pull request #57796 from evillique/replicated-database-forbid-create-as-select
Forbid CREATE AS SELECT for database Replicated
2023-12-25 19:43:28 +01:00
Alexey Milovidov
005023a16d
Merge pull request #58210 from chhetripradeep/pchhetri/param-query-clickhouse-local
Add support for specifying query parameters in the command line in clickhouse-local
2023-12-25 13:34:04 +01:00
Maksim Kita
c5959068cb Fixed tests 2023-12-25 12:51:17 +03:00
Maksim Kita
46446ed0c4 Fixed tests 2023-12-25 12:51:17 +03:00
Maksim Kita
51d6c444f5 Fixed tests 2023-12-25 12:51:17 +03:00
Maksim Kita
269e9706fb MergeTree FINAL extract non intersecting parts ranges 2023-12-25 12:51:17 +03:00
Alexey Milovidov
35e27ab1a3
Merge pull request #58213 from azat/tests/processes-cleanup-v2
Fix leftover processes/hangs in tests (resubmit)
2023-12-25 05:07:43 +01:00
Alexey Milovidov
9196c2b994 Follow-up 2023-12-25 04:54:54 +01:00
Alexey Milovidov
c2f93ecf4d
Merge pull request #58211 from ClickHouse/binary-viewer
Binary (symbols) viewer
2023-12-25 04:52:57 +01:00
Nikolay Degterinsky
98a6d67ae3 Disable tests with CREATE AS SELECT for database Replicated 2023-12-24 23:49:26 +00:00
Nikolay Degterinsky
d524951416
Merge pull request #58198 from azat/exception-fmt
Fix all Exception with missing arguments
2023-12-25 00:40:18 +01:00
Azat Khuzhin
3be3b0a280 Fix incorrect Exceptions
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-24 21:26:32 +01:00
Azat Khuzhin
435e1de7b0 Remove Exception's ctor to create it from a simple string-like object
This may cause troubles, like forgetting to pass arguments, and there
are few places in the code (see the upcomming patch).

I doubt that this will make any performance changes, since the check
should be compile time.

And anyway Exception is an exceptional situation which should be rare
(there is no such code with single argument for logging, while logging
is more common).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-24 21:26:31 +01:00
Nikolay Degterinsky
033fb14a2a Merge remote-tracking branch 'upstream/master' into replicated-database-forbid-create-as-select 2023-12-24 20:07:12 +00:00
Kevin Mingtarja
807d815df1 Merge branch 'master' into optimize-long-and-notequals-chain 2023-12-24 18:49:30 +00:00
Kevin Mingtarja
5416bd6e93 Add optimization for AND notEquals chain to NOT IN 2023-12-24 13:26:41 +00:00
Azat Khuzhin
c5dbde8407 Replace timeout --foreground with one workaround
The problem with --foreground option is that it send the signal only to
the process that had been spawned by timeout(1), while it can create
lots of children, and when you killing parent you are closing pipes and
childrens will get EPIPE, like in [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/0/069f8bbb2f48541cc736903e1da5459fa2c27da0/stateless_tests__debug__%5B2_5%5D.html

Another problem is that now child process will finish correctly, which
may also print some errors like QUERY_WAS_CANCELLED (see [2]).

  [2]: https://s3.amazonaws.com/clickhouse-test-reports/0/ef66714bf20042ba9cb5d59b7839befe26110b93/stateless_tests__release__analyzer_.html

In general this is not required actually, since all timeout invocations
uses timeout value less then the default test limit (10min). But it may
leave some processes in case of overriding this limit, i.e.
`clickhouse-test --timeout 1`

So to workaround this at least somehow, let's send SIGTERM and only
after some timeout (here I use 0.1), SIGKILL. This will give at least
some ability to terminate all childrens that had been spawned by
timeout(1).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-24 13:23:09 +01:00
Pradeep Chhetri
1ed19fc8b1 Add test 2023-12-24 19:59:14 +08:00
Alexey Milovidov
325ccacc45
Merge pull request #58208 from ClickHouse/dbase
Fix DWARFBlockInputFormat using wrong base address sometimes
2023-12-24 12:33:21 +01:00
Alexey Milovidov
6eaa17d5a4
Merge pull request #58206 from ClickHouse/fix-error-in-archive-reader
Fix error in archive reader
2023-12-24 12:32:49 +01:00
Alexey Milovidov
658336f674 Add documentation 2023-12-24 12:22:31 +01:00
Alexey Milovidov
7c18530a8c Add a test 2023-12-24 12:19:31 +01:00
Alexey Milovidov
0e89d01b94 Binary (symbols) viewer 2023-12-24 12:14:45 +01:00
Pradeep Chhetri
5899ee99bd Add support for specifying query parameters in the command line in clickhouse-local 2023-12-24 18:07:26 +08:00
Azat Khuzhin
1fdee81ad5 Fix leftover processes/hangs in tests
One of such cases is 02479_race_condition_between_insert_and_droppin_mv
[1], yes it can be fixed (by using fixed number of iterations, or with
some bash trickery), but it is better to fix them completelly,
eventually such tests will be submitted and pass review anyway.

By allocating process group for each test we can kill all the processes
in this process group, and this what this patch does.

This will also fix some test hangs (like in [1]) as well as some
possible issues in stress tests.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/0/e2c1230b00386c4d0096a245396ab3be7ce60950/stateless_tests__release__analyzer_/run.log

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
(cherry picked from commit 72fa58e192)
2023-12-24 09:43:58 +01:00
Michael Kolupaev
a3f204cb7e Fix base address for ranges 2023-12-24 05:14:34 +00:00
Alexey Milovidov
f459a2b0c9
Merge pull request #58207 from ClickHouse/revert-58200-tests/processes-cleanup
Revert "Fix leftover processes/hangs in tests"
2023-12-24 05:57:53 +01:00
Alexey Milovidov
71c5ae548f
Revert "Fix leftover processes/hangs in tests" 2023-12-24 07:57:43 +03:00
Alexey Milovidov
f582a9b39c Add a test 2023-12-24 05:55:53 +01:00
Alexey Milovidov
ae51334ba5 Merge branch 'master' into fix-error-in-archive-reader 2023-12-24 05:53:22 +01:00
Alexey Milovidov
e98c49a58f Fix a benign error in archive reader 2023-12-24 05:44:24 +01:00
Alexey Milovidov
1054118607
Merge pull request #58133 from ClickHouse/parallel-replicas-in-subquery
Disable parallel replicas with IN (subquery)
2023-12-24 05:03:35 +01:00