Amos Bird
ea84430864
Get rid of useless std::move to get NRVO
...
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision
Some quote:
> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."
There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
if (block && remove_filter)
block.erase(static_cast<size_t>(filter_column));
return std::move(block);
}
```
because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
alexey-milovidov
5c1925af58
Merge pull request #2920 from VadimPE/CLICKHOUSE-3819
...
CLICKHOUSE-3819 add CASE without ELSE
2018-08-22 22:52:24 +03:00
VadimPE
9e485dae1e
CLICKHOUSE-3819 add CASE without ELSE
2018-08-22 18:17:40 +03:00
Alexey Milovidov
465ff07398
Merge branch 'master' of github.com:yandex/ClickHouse
2018-08-20 18:50:09 +03:00
Alexey Milovidov
2717185991
Modified names #2015
2018-08-20 18:49:39 +03:00
Alexey Milovidov
acb99b49df
Merge branch 'master' into CLICKHOUSE-2910
2018-08-14 23:29:42 +03:00
Vadim
b9b6818325
Merge branch 'master' into CLICKHOUSE-3211
2018-08-13 13:48:44 +03:00
VadimPE
bb9d99b00c
CLICKHOUSE-3211 add Exception
2018-08-13 13:45:27 +03:00
VadimPE
e8ebcc4d48
CLICKHOUSE-3211 add TOP m, and OFFSET k
2018-08-10 14:12:43 +03:00
Alexey Milovidov
36db216abf
Preparation for extra warnings [#CLICKHOUSE-2]
2018-08-10 07:02:56 +03:00
Alexey Milovidov
8bc95412b6
Fixed bad code #2708
2018-07-28 00:33:30 +03:00
alexey-milovidov
9242588449
Merge pull request #2708 from VadimPE/CLICKHOUSE-3837
...
CLICKHOUSE-3837 Add support for table function in remote() and cluster()
2018-07-26 21:36:04 +03:00
VadimPE
867a3ebfae
CLICKHOUSE-3837 fix mistakes
2018-07-25 15:31:47 +03:00
alexey-milovidov
2f3c02cbe4
Update ASTOptimizeQuery.cpp
2018-07-24 22:07:13 +03:00
zhang2014
7e87fa8e18
ISSUES-2688 support on cluster for kill & optimize query
2018-07-24 22:07:13 +03:00
Vadim
437f3f20a9
Merge branch 'master' into CLICKHOUSE-3837
2018-07-24 16:21:51 +03:00
VadimPE
8dfb6806d8
add support for table function in remote() and cluster()
2018-07-24 16:10:34 +03:00
Alexey Milovidov
65f6696750
Quote all identifiers when querying external database #2635
2018-07-20 03:04:48 +03:00
Alexey Milovidov
0b827058ff
Added missing file #2635
2018-07-20 03:04:48 +03:00
Alexey Milovidov
245b114363
Quote all identifiers when querying external database #2635
2018-07-20 03:04:48 +03:00
Alexey Milovidov
fe8c4d64e4
Better fix #2660
2018-07-19 23:51:03 +03:00
Alexey Milovidov
06fdc5d0ab
Fixed error with DROP TEMPORARY queries #2624
2018-07-16 06:34:05 +03:00
alexey-milovidov
3904ba561f
Merge branch 'master' into CLICKHOUSE-2910
2018-06-28 20:47:25 +03:00
alexey-milovidov
b7ac6ac8c1
Update IAST.cpp
2018-06-28 20:25:09 +03:00
Nikolai Kochetov
782caef119
Added IAST::appendColumnName(WriteBuffer &); reimplemented IAST::getColumnName() using it.
2018-06-28 20:25:09 +03:00
Vitaliy Lyudvichenko
4cd230f85c
Merge remote-tracking branch 'origin/master' into CLICKHOUSE-2910
2018-06-14 16:04:00 +03:00
Vitaliy Lyudvichenko
95b42afcb9
Add test for profile events logging. [#CLICKHOUSE-2910]
2018-06-14 14:56:12 +03:00
alexey-milovidov
08ec751a8c
Merge pull request #2504 from yandex/system-mutations-table
...
[WIP] system.mutations table skeleton
2018-06-13 23:00:30 +03:00
alexey-milovidov
c1910fef37
Update ASTAlterQuery.h
2018-06-13 23:00:10 +03:00
Alexey Zatelepin
14947b494f
make ASTAlterQuery::Parameters a real AST element ASTAlterCommand [#CLICKHOUSE-3747]
2018-06-13 17:13:28 +03:00
Alexey Milovidov
d864f39ec7
Merge branch 'master' into zhang2014-feature/support_truncate
2018-06-09 19:10:06 +03:00
Alexey Milovidov
f3d8b4e3cf
Merging: Fixed most of problems #2260
2018-06-09 19:03:07 +03:00
Alexey Milovidov
0bc678474e
Merge branch 'feature/support_truncate' of https://github.com/zhang2014/ClickHouse into zhang2014-feature/support_truncate
2018-06-09 17:24:50 +03:00
Alexey Milovidov
7125db4679
Fixed code with extremely high level of ugliness [#CLICKHOUSE-3764]
2018-06-07 23:25:38 +03:00
proller
347579ce46
Cmake: mark system includes as SYSTEM ( #1449 )
...
* contrib: cctz as submodule. update cctz.
* pbuilder: add ubuntu bionic, devel
* Cmake: mark system includes as SYSTEM
* Build fixes
* fix
* Fix package without compiler
* Better
* fix
* fix
* fix
* Build fix
* fix
* fix
* fix
* Cmake: Add SYSTEM to includes for external libs
2018-06-06 23:21:58 +03:00
Alexey Milovidov
f5adbceed2
Non significant changes according to clang's -Weverything, part 3 [#CLICKHOUSE-2]
2018-06-03 23:39:06 +03:00
Alexey Milovidov
1c2b024c39
Non significant changes according to clang's -Weverything, part 2 [#CLICKHOUSE-2]
2018-06-03 20:43:56 +03:00
alexey-milovidov
55cfebc36b
Merge pull request #2395 from yandex/string_range-pointers-comparsion
...
Renamed StringRangeHash to StringRangePointersHash and added StringRa…
2018-05-21 22:42:42 +03:00
Vitaliy Lyudvichenko
c888903488
Add query ALTER TABLE t1 [REPLACE|ATTACH] PARTITION FROM t2
...
* Add ATTACH PARTITION FROM table for MergeTree. [#CLICKHOUSE-3546]
* Implemented replicated case on non-leader replica. [#CLICKHOUSE-3546]
* Disable merges in the dropping range. [#CLICKHOUSE-3546]
* DROP PARTITION is atomic and simpler now. [#CLICKHOUSE-3546]
* Implemented more SYSTEM queries. [#CLICKHOUSE-2931] [#CLICKHOUSE-3546]
SYSTEM queries:
RESTART REPLICAS
SYNC REPLICA db.name
STOP MERGES [db.name]
START MERGES [db.name]
STOP FETCHES [db.name]
START FETCHES [db.name]
STOP REPLICATED SENDS [db.name]
START REPLICATED SENDS [db.name]
STOP REPLICATION QUEUES [db.name]
START REPLICATION QUEUES [db.name]
* Fixed a bunch of bugs in REPLACE PARTITION. [#CLICKHOUSE-3546]
* Add tests for REPLACE PARTITION and SYSTEM. [#CLICKHOUSE-3546]
* Add system.part_log logging. [#CLICKHOUSE-3546]
* Fixed long wait in SYNC REPLICA. [#CLICKHOUSE-3546]
* Add requested changes. [#CLICKHOUSE-3546]
Fixed clickhouse-client bad return code.
* Add requested chenges. [#CLICKHOUSE-3546]
* Add requested chenges. [#CLICKHOUSE-3546]
2018-05-21 16:49:54 +03:00
Nikolai Kochetov
aeaec2e6d7
Renamed StringRangeHash to StringRangePointersHash and added StringRangePointersEqualTo.
2018-05-21 14:18:11 +03:00
zhang2014
c8f655c1aa
ISSUES-2259 fix the test after the merge master
2018-05-21 11:38:46 +08:00
zhang2014
6613e56784
ISSUES-2259 support truncate syntax
2018-05-21 11:38:46 +08:00
alexey-milovidov
0fe2984d00
Merge pull request #2388 from yandex/fix-prepared-sets-creation
...
Fix prepared sets creation
2018-05-19 19:03:04 +03:00
Alexey Milovidov
74a6b0010f
utils/check-style/fix-style #2387
2018-05-18 21:30:02 +03:00
Nikolai Kochetov
a4b04739c8
Renamed need_parents back to need_parens. [#CLICKHOUSE-3735]
2018-05-18 21:28:11 +03:00
Nikolai Kochetov
f739078ea5
Fixed IAST::clone() implementations which were without children deep copy. [#CLICKHOUSE-3735]
2018-05-18 21:28:11 +03:00
Nikolai Kochetov
5e22f19258
Added fake range for ASTIdentifier in order to fix multiple global in. [#CLICKHOUSE-3734]
2018-05-18 20:27:58 +03:00
Nikolai Kochetov
9a1c286ade
Changed prepared set indexation from AST* to StringRange. [#CLICKHOUSE-3734]
2018-05-17 17:54:43 +03:00
Alexey Zatelepin
3b97d3938f
alter delete skeleton [#CLICKHOUSE-3688]
2018-05-16 05:46:15 +03:00
Vitaliy Lyudvichenko
8fd72a6777
Add automatic DROP DNS CACHE, update of SYSTEM queries. [#CLICKHOUSE-3645]
2018-05-09 07:55:08 +03:00