Commit Graph

106269 Commits

Author SHA1 Message Date
avogar
73538117eb Fix and add a test 2023-01-23 16:24:00 +00:00
Kruglov Pavel
af2c1bac6a
Fix typo 2023-01-23 17:13:16 +01:00
Alexander Tokmakov
0e0e2f0f67
Update test.py 2023-01-23 19:01:06 +03:00
Sergei Trifonov
e1b20e4314
Merge pull request #45503 from ClickHouse/serxa-patch-3
Provide more clear syntax for `fromUnixTimestamp64*` and `toUnixTimestamp64*` functions
2023-01-23 16:28:32 +01:00
Kseniia Sumarokova
8ec39ab6f3
Merge pull request #45442 from kssenii/minor-changes
Minor improvements around reading from remote
2023-01-23 15:46:30 +01:00
Nikolay Degterinsky
f9960361db Fix MSan build 2023-01-23 14:38:07 +00:00
Alexander Tokmakov
a182a6b851
Merge pull request #45493 from azat/fix-detach
Fix possible in-use table after DETACH
2023-01-23 17:36:45 +03:00
Kruglov Pavel
84200be7d2
Better comment 2023-01-23 15:31:07 +01:00
Kruglov Pavel
3b53b195be
Fix special build 2023-01-23 15:27:36 +01:00
Nikolay Degterinsky
c47a29a089
Merge pull request #45506 from den-crane/patch-58
Update column.md
2023-01-23 15:24:08 +01:00
Denny Crane
531ad1661e
Update column.md 2023-01-23 09:57:42 -04:00
Denny Crane
4d9be1ef4f
Update column.md 2023-01-23 09:57:04 -04:00
Denny Crane
2bf59fd48c
Update column.md 2023-01-23 09:55:30 -04:00
Kruglov Pavel
fd7e04a96d
Merge pull request #45446 from kssenii/fix-assertion-in-cache-over-local
Fix Buffer's offsets mismatch logical error in stress test
2023-01-23 14:38:25 +01:00
Kseniia Sumarokova
16ffed2c0e
Merge pull request #45502 from azat/dist/fix-race-on-create
Fix a race between Distributed table creation and INSERT into it
2023-01-23 14:38:11 +01:00
Anton Popov
61b0c4da38
Merge pull request #45498 from CurtizJ/fix-race-parallel-parsing
Fix abort in destructor of `ParallelParsingInputFormat`
2023-01-23 14:12:53 +01:00
vdimir
dac86d48d2
fixing join data was released 2023-01-23 12:34:36 +00:00
Anton Popov
606a5b1fca fix test 2023-01-23 12:00:36 +00:00
Mikhail f. Shiryaev
f092b46025
Improve logging for TeePopen.timeout exceeded 2023-01-23 12:50:49 +01:00
Sergei Trifonov
0fbfa17863
Merge branch 'master' into cancellable-mutex-integration 2023-01-23 12:44:09 +01:00
Sergei Trifonov
e0fa5b9bac
Update type-conversion-functions.md 2023-01-23 12:26:24 +01:00
Azat Khuzhin
51019bc9f3 Fix a race between Distributed table creation and INSERT into it
Initializing queues for pending on-disk files for async INSERT cannot be
done after table had been attached and visible to user, since it
initializes the per-table counter, that is used during INSERT.

Now there is a window, when this counter is not initialized and it will
start from the beginning, and this could lead to CANNOT_LINK error:

    Destination file /data/clickhouse/data/urls_v1/urls_in/shard6_replica1/13129817.bin is already exist and have different inode

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-23 09:55:43 +01:00
Robert Schulze
4e0dd08f8c
Merge pull request #45152 from ClickHouse/partial-to-backward-incompatible
Performance report: "Partial queries" --> "Backward-incompatible queries
2023-01-23 09:16:55 +01:00
Smita Kulkarni
383af7f3a6 Moved settings inside backups section - Updated backup/restore status when concurrent backups & restores are not allowed 2023-01-23 08:59:44 +01:00
Anton Popov
8a39337c7c add fields to table system.formats 2023-01-23 02:04:31 +00:00
Anton Popov
f181254fb0 fix race in destructor of ParallelParsingInputFormat 2023-01-23 01:18:58 +00:00
kssenii
dfac0bb42d Fix stress test 2023-01-22 20:31:49 +01:00
Kseniia Sumarokova
c3d545b64a
Merge pull request #45489 from azat/build/queue-fwd-decl
Forward declaration of ConcurrentBoundedQueue in ThreadStatus
2023-01-22 20:23:05 +01:00
Robert Schulze
40ced78a7e
Update report.py 2023-01-22 20:01:55 +01:00
Smita Kulkarni
310ae62d90 Updated backup/restore status when concurrent backups & restores are not allowed
Implementation:
* Moved concurrent backup/restore check inside try-catch block which sets the status so that other nodes in cluster are aware of failures.
* Renamed backup_uuid to restore_uuid in RestoreSettings.
Testing:
* Updated test test_backup_and_restore_on_cluster/test_disallow_concurrency to check for specific backup/restore id.
2023-01-22 19:01:09 +01:00
Robert Schulze
de8fc04b03
Performance report: "Partial queries" --> "Backward-incompatible queries 2023-01-22 17:43:27 +00:00
Robert Schulze
96c2f43a4c
Merge pull request #45495 from ClickHouse/fix-weird-formatting
Docs: Fix weird formatting
2023-01-22 17:07:22 +01:00
Robert Schulze
5eabb061a6
Merge pull request #45496 from ClickHouse/fix-link-to-writing-guide
Docs: Fix link to writing guide
2023-01-22 17:06:36 +01:00
Robert Schulze
a3153174db
Docs: Fix link to writing guide 2023-01-22 16:57:58 +01:00
Robert Schulze
ed84021aa5
Formatting fixup 2023-01-22 16:45:26 +01:00
Robert Schulze
0ffffdd442
Docs: Fix weird formatting 2023-01-22 15:38:11 +00:00
Nikolay Degterinsky
97900e9613
Merge pull request #45479 from evillique/astfuzzer-retries
Add more retries to AST Fuzzer
2023-01-22 13:45:38 +01:00
Robert Schulze
340f406553
Merge branch 'master' into query-result-cache 2023-01-22 13:21:36 +01:00
Robert Schulze
531e64dc39
Merge branch 'master' into inv-index-cleanup 2023-01-22 13:20:38 +01:00
Azat Khuzhin
ca8af3d18c Fix possible in-use table after DETACH
Right now in case of DETACH/ATTACH there can be a window when after the
table had been DETACH'ed someone will still use it, the common example
here is MVs handling.

It happens because TableExclusiveLockHolder does not guards the
shard_ptr of the IStorage, and so if someone holds it, then it can use
it. So if ATTACH will be done for this table then, you can have multiple
instances of it.

It is not possible for DROP, because before using a table, you should
lock it and after table had been DROP'ed you cannot lock it anymore.

So let's do the same for DETACH.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-22 13:18:56 +01:00
Alexander Gololobov
91fb1eab8c
Merge pull request #45373 from ClickHouse/throttler-metrics
Add detailed profile events for throttling
2023-01-22 11:20:45 +01:00
Alexander Tokmakov
1174eaa132
Merge pull request #45492 from azat/revert/dist/async-INSERT-metrics
Revert "Merge pull request #44922 from azat/dist/async-INSERT-metrics"
2023-01-22 00:45:10 +03:00
Azat Khuzhin
a55798626a Revert "Merge pull request #44922 from azat/dist/async-INSERT-metrics"
There are the following problems with this patch:
- Looses files on exception
- Existing current_batch.txt on startup leads to ENOENT error and hung
  of distributed sends without ATTACH/DETACH
- Race between creating the queue for sending at table startup and
  INSERT, if it had been created from INSERT, then it will not be
  initialized from disk

They were addressed in #45491, but it makes code more cmoplex and plus
since, likely, the release is comming, it is better to revert the
change.

This reverts commit 94604f71b7, reversing
changes made to 80f6a45376.
2023-01-21 22:42:00 +01:00
Maksim Kita
19f1bae5ed
Merge pull request #45254 from kitaisreal/planner-small-fixes
Planner small fixes
2023-01-21 19:54:17 +03:00
Maksim Kita
6594aa8f1e
Merge pull request #44234 from kitaisreal/analyzer-expired-context-crash-fix
Analyzer expired Context crash fix
2023-01-21 18:49:50 +03:00
Azat Khuzhin
2a8f116c18 Forward declaration of ConcurrentBoundedQueue in ThreadStatus
ThreadStatus is the header that recomplies almost all ClickHouse
modules.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-21 16:02:09 +01:00
Vitaly Baranov
5ceb64accc Use new copy s3 functions in S3ObjectStorage. 2023-01-21 15:47:58 +01:00
Vitaly Baranov
f0fda580d0
Merge pull request #45188 from vitlibar/backup-to-s3-memory-optimization
Optimize memory consumption during backup to S3
2023-01-21 12:37:35 +01:00
Maksim Kita
5146087db1 Fix style 2023-01-21 12:19:09 +01:00
Nikolai Kochetov
b877c484d2
Merge pull request #45481 from ClickHouse/fix-deadlock-with-allow_asynchronous_read_from_io_pool_for_merge_tree
Fix possible deadlock with allow_asynchronous_read_from_io_pool_for_merge_tree in case of exception from ThreadPool::schedule
2023-01-21 12:05:34 +01:00