Azat Khuzhin
68789895a4
ThreadPool: incapsulate Poco::Event and std: 🧵 :id into State struct
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-13 15:51:49 +03:00
HeenaBansal2009
e9dcc7d05a
try to fix flaky test as suggested in review comments
2022-07-13 05:49:03 -07:00
Azat Khuzhin
7ffa15b94b
ThreadPool: fix thread_id assignment
...
As found by @KochetovNicolai before this patch, lambda in
ThreadFromGlobalPool() ctor assigns value only to a copy of the
thread_id value, and so check in joinable() had been working
incorrectly, fix this by changing the value not the shared_ptr itself.
Also it is not safe to assign thread_id w/o atomics, since this can be
racy, so wrap id with std::atomic<>
Fixes : #28431
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-13 15:42:46 +03:00
Azat Khuzhin
25eb82f120
ThreadPool: do not use joinable() internally
...
joinable() should be used only outside, since internally it is enough to
know `state` to know that something is wrong.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-13 15:42:46 +03:00
Azat Khuzhin
3473b80077
ThreadPool: add some clarification comments
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-13 15:42:46 +03:00
Alexander Tokmakov
635e527234
Merge pull request #39176 from ClickHouse/tavplubix-patch-1
...
Suppression for BC check (`Cannot parse string 'Hello' as UInt64`)
2022-07-13 15:25:34 +03:00
Nikolai Kochetov
83c3670f2a
Fix style
2022-07-13 12:23:01 +00:00
Alexander Tokmakov
991493e6fc
Update run.sh
2022-07-13 15:22:36 +03:00
Azat Khuzhin
8122c1b07f
Optimize accesses to system.stack_trace
...
- filter by thread_id
- filter by thread_name
- filter by requested columns (query_id/trace, thread_name)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-13 15:17:09 +03:00
vdimir
4124dc9ac4
Rewrite tryPushDownFilter for join with lambda
2022-07-13 12:06:29 +00:00
Nikolai Kochetov
37f0d96e36
Add test for #39132
2022-07-13 12:04:42 +00:00
vdimir
549a85fee9
Throw logical error on child idx mismatch in tryAddNewFilterStep
2022-07-13 11:53:46 +00:00
vdimir
fa59133463
Do not spam log in MergeJoinAlgorithm
2022-07-13 11:51:11 +00:00
Nikolay Degterinsky
e3a79520c1
Merge remote-tracking branch 'upstream/master' into translate
2022-07-13 11:42:40 +00:00
Nikolay Degterinsky
c344e2de84
Fix style
2022-07-13 11:41:08 +00:00
Nikolai Kochetov
4f8cc871eb
Merge pull request #39132 from ClickHouse/fix-data-race-in-completed-pipeline-executor
...
Fix data race in CompletedPipelineExecutor.
2022-07-13 13:39:44 +02:00
vdimir
bddf6c1b32
Pushdown filter to the right side of sorting join
2022-07-13 11:36:25 +00:00
Yatsishin Ilya
d886aea351
Add setting opentelemetry_trace_processors
2022-07-13 11:31:24 +00:00
Vladimir C
d376a4b593
Merge pull request #39155 from amosbird/trivial-count-empty-set
...
Fix trivial count with empty set
2022-07-13 12:53:14 +02:00
Vladimir C
d1d1e4d8a1
Merge pull request #38943 from amosbird/better-join-plan1
...
Avoid redundant join block transformation during planning.
2022-07-13 12:39:45 +02:00
FArthur-cmd
411a08630c
add docs
2022-07-13 10:29:13 +00:00
Amos Bird
90fa4863f9
Text log source regexp
2022-07-13 17:52:14 +08:00
Kseniia Sumarokova
48cb1ed909
Update test.py
2022-07-13 11:48:39 +02:00
Kseniia Sumarokova
d6c145e5e1
Update CachedReadBufferFromRemoteFS.cpp
2022-07-13 11:48:17 +02:00
Alexander Tokmakov
a0bff953f6
Merge pull request #39154 from amosbird/slightly-change
...
Slightly better interface of waitForMutation
2022-07-13 12:34:18 +03:00
kssenii
83a09fd961
Merge remote-tracking branch 'petrenko/master' into petrenko-master
2022-07-13 11:28:52 +02:00
kssenii
ae324622d3
Add one more test
2022-07-13 11:27:43 +02:00
Nikita Mikhaylov
1f0280bcde
Fix path retrieval for Keeper's state ( #39148 )
2022-07-13 11:25:34 +02:00
kssenii
9973fb2f1d
Fix merge
2022-07-13 11:19:14 +02:00
Yakov Olkhovskiy
334b3f3c73
Merge pull request #38864 from azat/fix-rwlock
...
Fix waiting of shared lock after exclusive lock failure
2022-07-13 02:10:35 -04:00
Yakov Olkhovskiy
2079699f75
Merge pull request #39065 from ClickHouse/utils-self-extracting-decompressor
...
Parameter --decompressor added to utils/self-extracting-executable/compressor
2022-07-13 01:50:12 -04:00
Amos Bird
0595c50c92
Fix trivial count with empty set
2022-07-13 12:54:52 +08:00
Amos Bird
0795cdd36a
Slightly better interface of waitForMutation
2022-07-13 12:34:12 +08:00
Nikolay Degterinsky
185978bfbe
Add docs
2022-07-13 01:52:25 +00:00
Nikolay Degterinsky
daae55b4ac
Better
2022-07-13 01:41:27 +00:00
Anton Popov
df190b14b2
Merge pull request #39113 from CurtizJ/tuple-lowcardinality
...
Keep `LowCardinality` type in `tuple()` function
2022-07-13 02:28:56 +02:00
Alexey Milovidov
fa572dc40c
Merge pull request #39141 from ClickHouse/clickbench-3
...
Add ClickHouse with zstd to benchmark
2022-07-13 01:03:07 +03:00
Alexey Milovidov
dcfe299966
Add ClickHouse with zstd to benchmark
2022-07-12 23:51:12 +02:00
Kruglov Pavel
da24f93445
Merge pull request #39101 from Avogar/fix-try-get-least-supertype
...
Fix code in getLeastSupertype function
2022-07-12 22:59:29 +02:00
Dmitry Novik
66ade34508
Merge branch 'master' into window-expressions-fix
2022-07-12 22:36:19 +02:00
Alexey Milovidov
c25a08222c
Merge pull request #39136 from ClickHouse/move-clickbench-2
...
Move benchmark (2)
2022-07-12 21:51:51 +03:00
Alexey Milovidov
1760417bfc
Update index.html
2022-07-12 20:28:43 +02:00
Alexey Milovidov
e93e3212a7
Remove old file
2022-07-12 20:28:02 +02:00
Alexey Milovidov
f71d3666d3
Merge pull request #39134 from ClickHouse/move-clickbench
...
Move benchmark into separate repository
2022-07-12 21:27:06 +03:00
Alexey Milovidov
6d3b0032c3
Change the link to Hardware benchmark script
2022-07-12 20:25:40 +02:00
vdimir
d636674a9e
Add order by to some join tests
2022-07-12 20:22:35 +02:00
vdimir
af55f1c1e3
Update toPowerOfTwo in ConcurrentHashJoin
2022-07-12 20:22:35 +02:00
vdimir
b4cb2a847e
Default join algorithm set to hash
2022-07-12 20:22:35 +02:00
vdimir
b4176828c6
Apply intHash64 on top of WeakHash32 for parallel join
2022-07-12 20:22:35 +02:00
vdimir
dfc0d49834
remove tag ignore-order from tests
2022-07-12 20:22:35 +02:00
