Commit Graph

2682 Commits

Author SHA1 Message Date
Sema Checherinda
ae3a199939 support max requests for keep alive 2024-04-05 00:37:29 +02:00
Sema Checherinda
dd852da339 add more debug logs 2024-04-05 00:30:03 +02:00
Alexander Tokmakov
5db9fbed52 cancel tasks on exception 2024-04-04 22:32:57 +02:00
Anton Popov
d7fb851d17 better handling of errors from azure storage 2024-04-04 19:53:58 +00:00
kssenii
1e982a2368 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-04-04 13:26:06 +02:00
kssenii
be30806dbe Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-04-04 13:20:12 +02:00
Robert Schulze
de2a0be025
Don't access static members through instance
- clang-tidy rightfully complains (-readability-static-accessed-through-instance)
- not going to enable the warning for now to avoid breaking the build
2024-04-03 18:50:33 +00:00
SmitaRKulkarni
9bb185593e
Merge pull request #61988 from ClickHouse/Azure_fix_exception_in_finalize
Fix WriteBufferAzureBlobStorage destructor uncaught exception
2024-04-03 18:22:27 +02:00
vdimir
e5f218c4cc
Merge branch 'master' into vdimir/storage_join_load_order 2024-04-01 14:15:01 +02:00
kssenii
5c63d09c5b More tests fixes 2024-03-28 14:15:14 +01:00
Smita Kulkarni
afbb3f8a50 Added wait before commit blocks 2024-03-28 09:26:00 +01:00
kssenii
ca1c119115 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-27 22:32:44 +01:00
kssenii
a2e210462d Fix style check 2024-03-27 22:31:22 +01:00
kssenii
7a991de488 Fix tests 2024-03-27 19:06:19 +01:00
Smita Kulkarni
42a27c5c87 Fix WriteBufferAzureBlobStorage destructor uncaught exception 2024-03-27 16:27:47 +01:00
vdimir
128c51c6fc
Fix storage join loading order 2024-03-27 11:27:30 +00:00
Michael Kolupaev
d5da446d21 Tidy 2024-03-27 02:32:15 +00:00
Nikita Mikhaylov
1b828ab6f6 Fix for ASync 2024-03-26 16:05:43 +00:00
Michael Kolupaev
ab0c601d63 Make userspace page cache work with 'web' disks 2024-03-26 09:14:55 +00:00
kssenii
f5982fdb1f Fix some tests 2024-03-25 19:19:54 +01:00
kssenii
e019b3a391 Fix build after merge 2024-03-25 16:12:39 +01:00
kssenii
46941e7243 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-25 15:10:11 +01:00
SmitaRKulkarni
a642f4d3ec
Merge pull request #59929 from ClickHouse/Azure_write_buffer
Asynchronous WriteBuffer for AzureBlobStorage
2024-03-25 10:32:56 +01:00
SmitaRKulkarni
f16dffaefc
Merge pull request #61503 from ClickHouse/Azure_read_buffer
Add support of ParallelReadBuffer to ReadBufferFromAzureBlobStorage
2024-03-25 09:51:59 +01:00
alesapin
a41c005a6e
Merge branch 'master' into Azure_write_buffer 2024-03-24 15:04:18 +01:00
Alexey Milovidov
056c8ce021
Merge pull request #59965 from nickitat/express_support
S3Express support
2024-03-23 20:52:44 +03:00
Smita Kulkarni
19e7022a87 Merge branch 'master' into Azure_write_buffer 2024-03-23 11:48:10 +01:00
Smita Kulkarni
7a154ad373 Updated log levels 2024-03-22 11:51:35 +01:00
Smita Kulkarni
a08c16e8eb Fixed clang tidy build 2024-03-22 10:45:48 +01:00
Smita Kulkarni
d969c0cd08 Removed unused includes 2024-03-22 10:30:55 +01:00
Smita Kulkarni
257c263596 Avoid extra copy of data 2024-03-21 22:33:34 +01:00
SmitaRKulkarni
3822e41f7d
Merge a2836b0887 into 30df0fcd60 2024-03-21 21:17:57 +00:00
Smita Kulkarni
3f653bbc32 Added test with log check 2024-03-21 20:28:52 +01:00
Smita Kulkarni
929173cce2 Fix S3 buffer allocation 2024-03-21 19:18:16 +01:00
Kseniia Sumarokova
0c824dab17
Merge pull request #60585 from aalexfvk/traverse_shadow_remote_data_paths
Traverse shadow directory for system.remote_data_paths
2024-03-21 19:02:36 +01:00
Smita Kulkarni
6c5e881da7 Merge branch 'master' into Azure_write_buffer 2024-03-21 11:12:19 +01:00
Smita Kulkarni
e0d14a1eaf Updated lambda and name of BufferAllocationPolicy 2024-03-21 11:10:54 +01:00
Smita Kulkarni
7a3ab461bf Fix style check 2024-03-21 09:24:35 +01:00
Smita Kulkarni
040b191899 Fix readBigAt 2024-03-20 20:25:38 +01:00
Smita Kulkarni
9f2d44fc65 Merge branch 'master' into Azure_write_buffer 2024-03-20 11:02:48 +01:00
Smita Kulkarni
2c0e266cfe Addressed review comments 2024-03-20 10:58:46 +01:00
kssenii
0122c3e883 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-19 19:31:02 +01:00
Smita Kulkarni
824092b619 Updated to use single part upload for single block of small size and fixed test fail 2024-03-19 18:38:02 +01:00
Raúl Marín
de855ca917 Reduce header dependencies 2024-03-19 17:04:29 +01:00
Smita Kulkarni
c16922493a Removed detachPart & reallocateBuffer functions 2024-03-19 14:54:06 +01:00
János Benjamin Antal
922df7d60e
Merge pull request #61003 from amosbird/less-header-1
Replace some header includes with forward declarations
2024-03-19 12:14:06 +01:00
Smita Kulkarni
45e15d16e5 Merge branch 'master' into Azure_write_buffer 2024-03-19 09:31:11 +01:00
Smita Kulkarni
0530055842 Updated names in BufferAllocationPolicy 2024-03-18 15:59:05 +01:00
János Benjamin Antal
4b4a03c0f1
Merge branch 'master' into less-header-1 2024-03-18 10:25:42 +01:00
Smita Kulkarni
248a8a60f1 Fix style check 2024-03-18 10:02:52 +01:00
Robert Schulze
c17536c3b3
Enable clang-tidy in headers 2024-03-18 08:00:09 +00:00
Smita Kulkarni
12289a9ebe Add support of ParallelReadBuffer to ReadBufferFromAzureBlobStorage 2024-03-17 22:34:41 +01:00
Alexey Milovidov
8094dd88d9 Merge branch 'master' into split-cast-overload-resolver 2024-03-14 13:08:37 +01:00
Alexey Milovidov
1a41aa4ac7 Merge branch 'master' of github.com:ClickHouse/ClickHouse into split-cast-overload-resolver 2024-03-14 13:06:23 +01:00
Kseniia Sumarokova
bc9dd7bb0b
Merge branch 'master' into revive-cache-contention-fix 2024-03-13 16:52:00 +01:00
Kseniia Sumarokova
893ea7e4fe
Merge pull request #60396 from ClickHouse/fix-usage-of-plain-metadata
Fix usage of plain metadata type with new disks configuration option
2024-03-13 14:18:36 +01:00
kssenii
3931351ec4 Pass timeout through setting 2024-03-13 12:36:47 +01:00
kssenii
296f7a1da2 Fix 2024-03-12 19:02:58 +01:00
Kseniia Sumarokova
3257bfa918
Merge branch 'master' into traverse_shadow_remote_data_paths 2024-03-12 15:18:52 +01:00
Kseniia Sumarokova
61543edc8b
Merge branch 'master' into fix-usage-of-plain-metadata 2024-03-12 11:53:00 +01:00
Alexey Milovidov
5222ebc4b4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into split-cast-overload-resolver 2024-03-12 06:37:38 +01:00
Kseniia Sumarokova
38ba6990bb
Merge branch 'master' into use-iobject-storage-for-table-engines-1 2024-03-11 18:47:56 +01:00
kssenii
bfc4f5e1d3 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-11 14:57:15 +01:00
Kseniia Sumarokova
e59564a9d9
Merge branch 'master' into traverse_shadow_remote_data_paths 2024-03-11 13:19:05 +01:00
Kseniia Sumarokova
3832b0e126
Merge branch 'master' into add-a-way-to-force-read-through-filesystem-cache-for-merges 2024-03-11 11:30:03 +01:00
kssenii
70272d4174 Minor 2024-03-11 10:55:01 +01:00
Kseniia Sumarokova
aacfefe0fe
Merge branch 'master' into fix-usage-of-plain-metadata 2024-03-11 10:37:53 +01:00
Smita Kulkarni
c724d36220 Merge branch 'master' into Azure_write_buffer 2024-03-11 09:27:24 +01:00
Alexey Milovidov
4373d5ba16 Merge branch 'master' into split-cast-overload-resolver 2024-03-11 03:01:50 +01:00
Kseniia Sumarokova
ae98d4290c
Merge branch 'master' into traverse_shadow_remote_data_paths 2024-03-10 12:16:54 +01:00
kssenii
e5e6625b0c Merge remote-tracking branch 'origin/master' into fix-usage-of-plain-metadata 2024-03-10 12:05:02 +01:00
Sema Checherinda
77c5de700f fix how web disk read empty directories 2024-03-10 10:00:18 +01:00
Sema Checherinda
f7f1d86e66 fix tests test_attach_without_fetching test_replicated_merge_tree_wait_on_shutdown 2024-03-10 10:00:18 +01:00
Sema Checherinda
5c41727725 http connections pools 2024-03-10 10:00:18 +01:00
Alexey Milovidov
009c2ea9f6 Move a class into an anonymous namespace 2024-03-09 05:27:29 +01:00
Nikita Taranov
e66ac5770c
Merge pull request #60462 from ClickHouse/davenger-patch-1
Do not check to and from files existence in metadata_storage because it does not see uncommitted changes
2024-03-08 00:26:58 +01:00
Amos Bird
f2a3ffe9eb
Replace some headers with forward decl 2024-03-07 18:10:09 +08:00
Smita Kulkarni
10b5ce8ab3 Updated BufferAllocationPolicy 2024-03-07 10:26:50 +01:00
kssenii
31ed1966e3 Fix build 2024-03-07 16:44:10 +08:00
Kseniia Sumarokova
a24e32168a
Merge branch 'master' into fix-usage-of-plain-metadata 2024-03-07 14:44:06 +08:00
Kseniia Sumarokova
0d67d9c79d
Merge pull request #60165 from ClickHouse/fix-for-local-object-storage
Allow local/azure as object storage type instead of local_blob_storage/azure_blob_storage
2024-03-07 14:42:44 +08:00
Kseniia Sumarokova
8fc3581446
Merge branch 'master' into fix-usage-of-plain-metadata 2024-03-07 14:29:57 +08:00
Sema Checherinda
bae34f4cd2
Merge pull request #59495 from ClickHouse/chesema-remove-objects-capability
generate key for clickhouse_remove_objects_capability
2024-03-06 17:45:32 +01:00
kssenii
0c293bce11 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-06 12:06:19 +08:00
Nikita Taranov
c8e41dc07c
Merge branch 'master' into davenger-patch-1 2024-03-05 19:12:22 +01:00
Sema Checherinda
6e085c713f generate key for clickhouse_remove_objects_capability 2024-03-05 14:02:43 +01:00
Nikolai Kochetov
86ad80839a Merge pull request #60515 from ClickHouse/cleanup-lazy-format-always
PullingAsyncPipelineExecutor cleanup
2024-03-05 13:12:07 +01:00
Aleksei Filatov
f7d8dd0b71
Merge branch 'master' into traverse_shadow_remote_data_paths 2024-03-05 10:11:07 +03:00
Aleksei Filatov
758a75c1b4 Fix flaky test. Fix clang-tidy warning 2024-03-05 09:53:30 +03:00
Kseniia Sumarokova
6f5d79db24
Merge branch 'master' into fix-for-local-object-storage 2024-03-05 14:14:34 +08:00
Kseniia Sumarokova
2ee846b393
Fix build 2024-03-05 14:07:56 +08:00
Kseniia Sumarokova
b0050566e2
Fix style check 2024-03-05 12:14:56 +08:00
Kseniia Sumarokova
3f90c933f3
Merge branch 'master' into fix-usage-of-plain-metadata 2024-03-05 11:22:56 +08:00
Kseniia Sumarokova
dbbe6b9f69
Merge branch 'master' into add-a-way-to-force-read-through-filesystem-cache-for-merges 2024-03-05 11:13:32 +08:00
Alexey Milovidov
de6c5d3a40
Merge pull request #60552 from ClickHouse/pc2
Userspace page cache again
2024-03-04 17:47:35 +03:00
Kseniia Sumarokova
a7db6688ed
Update ObjectStorageFactory.cpp 2024-03-04 18:24:24 +08:00
Kseniia Sumarokova
925fd00fd1
Merge branch 'master' into fix-usage-of-plain-metadata 2024-03-04 16:04:46 +08:00
Alexey Milovidov
3938d7156a Merge branch 'master' into fix-for-local-object-storage 2024-03-02 19:44:12 +01:00
Alexander Gololobov
2dd83a09e3 No need to capture this 2024-03-01 13:40:09 +01:00
Nikita Mikhaylov
590c30a23a Update DiskObjectStorageTransaction.cpp 2024-03-01 13:40:09 +01:00
Alexander Gololobov
b45ff56e4d Do not check to and from files existence in metadata_storage because it does not see uncommitted changes 2024-03-01 13:40:09 +01:00
Robert Schulze
3a5c9b627b
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-src 2024-03-01 10:31:55 +00:00
Smita Kulkarni
0f2d47e5a4 Renamed WriteBufferFromS3TaskTracker to ThreadPoolTaskTracker 2024-03-01 10:52:44 +01:00
Kseniia Sumarokova
5ac53c9578
Merge branch 'master' into add-a-way-to-force-read-through-filesystem-cache-for-merges 2024-03-01 11:05:47 +08:00
Robert Schulze
4ee1aa8c7c
Fixing more headers 2024-02-29 15:40:30 +00:00
Nikita Taranov
f9d1c5769e
Merge branch 'master' into express_support 2024-02-29 16:26:43 +01:00
Aleksei Filatov
8b1a1d42da Traverse shadow directory for system.remote_data_paths 2024-02-29 18:07:00 +03:00
Smita Kulkarni
3c00d19261 Merge branch 'master' into Azure_write_buffer 2024-02-29 13:39:31 +01:00
Michael Kolupaev
42437a2ae1 Userspace page cache (#53770)
* Userspace page cache

* Maybe it'll build this time, who knows.

* 'auto' went out of fashion, I guess

* Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary

* Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments.

* Fix

* Another fix

* Fix restricted seek, fix ppc64le build

* Don't allow page cache with file cache

* Adjust tests a little

* Fix clang-tidy

* Conflicts

* Comments

* Maybe unbroke AsynchronousBoundedReadBuffer

* SettingsChangesHistory.h

* Fix warning in test
2024-02-29 12:28:32 +00:00
Alexander Tokmakov
15e1191f74
Revert "Userspace page cache (#53770)"
This reverts commit 7b55c61551.
2024-02-29 13:20:17 +01:00
Michael Kolupaev
7b55c61551
Userspace page cache (#53770)
* Userspace page cache

* Maybe it'll build this time, who knows.

* 'auto' went out of fashion, I guess

* Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary

* Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments.

* Fix

* Another fix

* Fix restricted seek, fix ppc64le build

* Don't allow page cache with file cache

* Adjust tests a little

* Fix clang-tidy

* Conflicts

* Comments

* Maybe unbroke AsynchronousBoundedReadBuffer

* SettingsChangesHistory.h

* Fix warning in test
2024-02-29 11:27:32 +00:00
Smita Kulkarni
a168a84624 Merge branch 'master' into Fix_endpoint_for_azureblobstorage 2024-02-29 10:55:31 +01:00
Smita Kulkarni
5d68c9f046 Updated default value of endpoint_contains_account_name to true 2024-02-29 09:38:13 +01:00
Kseniia Sumarokova
0d4648b535
Fix clang-tidy 2024-02-29 10:30:17 +08:00
Nikita Taranov
974ba7364f better 2024-02-29 00:55:17 +01:00
Robert Schulze
a1c164a758
Fix a bunch of clang-tidy warnings in headers 2024-02-28 23:43:12 +00:00
Smita Kulkarni
a46d7c9191 Updated docs and addressed comments 2024-02-28 11:25:35 +01:00
kssenii
cb8390e9c8 Fix build 2024-02-28 13:32:43 +08:00
Smita Kulkarni
ca05557659 Fix typo 2024-02-27 19:16:36 +01:00
Smita Kulkarni
414c8da128 Fix build 2024-02-27 18:09:21 +01:00
kssenii
4243ac160f Merge remote-tracking branch 'origin/master' into fix-usage-of-plain-metadata 2024-02-27 23:28:48 +08:00
kssenii
98b27fd45f Fix style check 2024-02-27 23:00:27 +08:00
Smita Kulkarni
ae309e6ea9 Updated to set proper prefix for azure blob storage disk 2024-02-27 11:12:19 +01:00
kssenii
978fe9fa1a Add comments 2024-02-27 17:43:34 +08:00
kssenii
fb38bd139c Remove debug logging 2024-02-27 17:38:02 +08:00
kssenii
f53f43b78d Fixes for LocalObjectStorage and plain metadata 2024-02-27 17:33:47 +08:00
kssenii
277e8d9655 Fix usage plain metadata type with new configuration option 2024-02-26 17:27:45 +08:00
Nikita Taranov
835b47519a impl 2024-02-25 00:33:50 +01:00
kssenii
f1e95fb78b Add a way to force read-through cache for merges 2024-02-22 15:40:00 +01:00
Smita Kulkarni
3eb1f24770 Merge branch 'master' into Azure_write_buffer 2024-02-22 11:31:47 +01:00
Smita Kulkarni
0eefab131d Updated pos check 2024-02-22 11:05:33 +01:00
Smita Kulkarni
f1d5892d50 Fix style check 2024-02-22 10:06:33 +01:00
kssenii
80eb0c3782 Fix for hdfs 2024-02-21 20:47:25 +01:00
Smita Kulkarni
29b7bf64d4 Fix issues with endpoint and prefix 2024-02-21 20:04:12 +01:00
kssenii
d88f8646b1 Fix after merge with master 2024-02-21 11:03:12 +01:00
Kseniia Sumarokova
2a30d6b9d4
Update ObjectStorageFactory.cpp 2024-02-20 10:57:32 +01:00
kssenii
a2fa67c280 Allow local type for local_blob_storage 2024-02-20 10:54:33 +01:00
zvonand
e06d1fea26 use insert return value to check uniqueness 2024-02-20 10:19:52 +01:00
zvonand
622f3ebbe1 update behavior to be more intuitive 2024-02-20 10:19:52 +01:00
zvonand
e0d8a77792 fix typos and docs 2024-02-20 10:19:51 +01:00
zvonand
811027aa00 sort -> stable_sort 2024-02-20 10:19:51 +01:00
zvonand
1701183ced add volume_priority description in docs 2024-02-20 10:19:51 +01:00
zvonand
fbe5d61b3b added 'volume_priority' tag to volumes in storage policies 2024-02-20 10:19:51 +01:00
kssenii
c146446ab3 Fix style check 2024-02-19 20:29:22 +01:00
kssenii
e23b929e18 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-02-19 19:55:47 +01:00
kssenii
2e9b6545b6 Fix 2024-02-19 19:53:38 +01:00
kssenii
0552f44f70 Fixes after merge with master, move some part of code to object storage 2024-02-19 16:43:49 +01:00
Vitaly Baranov
3323d5ce81 Move threadPoolCallbackRunner to the "Common" folder. 2024-02-17 21:59:51 +01:00
kssenii
1cccb3ccdf Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-02-16 15:21:10 +01:00
Smita Kulkarni
62dfa4c65d Merge branch 'master' into Azure_write_buffer 2024-02-16 11:19:44 +01:00
Smita Kulkarni
7bf42fd86e Fix upgrade check 2024-02-16 11:16:14 +01:00
Kseniia Sumarokova
0f9cf00740
Merge pull request #59630 from vitlibar/fix-read-beyond-last-offset
Fix error "Read beyond last offset" for AsynchronousBoundedReadBuffer
2024-02-16 11:11:17 +01:00
Alexey Milovidov
46fb01c4f6 Fix trash 2024-02-15 02:31:46 +01:00
Vitaly Baranov
d842c497e6 Change code to pass test 02963_remote_read_small_buffer_size_bug. 2024-02-14 20:47:34 +01:00
Smita Kulkarni
26fd3d0d85 Removed offset check 2024-02-14 16:13:53 +01:00
kssenii
84b0fe670a Refactor data lakes 2024-02-14 15:50:43 +01:00
Vitaly Baranov
8919e3b011 Add test. 2024-02-14 13:41:23 +01:00
Vitaly Baranov
eb3836ac5a Fix error "Read beyond last offset" for AsynchronousBoundedReadBuffer. 2024-02-14 13:41:18 +01:00
Alexey Milovidov
98f7602ea1 Less conflicts 2024-02-14 03:01:03 +01:00
Smita Kulkarni
d12ecdc5f0 Asynchronous WriteBuffer for AzureBlobStorage 2024-02-13 12:35:17 +01:00
Nikita Mikhaylov
4b85f6b39a
Revert "Less error prone interface of read buffers" (#59911) 2024-02-13 12:02:46 +01:00
kssenii
6d91d92601 Better 2024-02-12 20:22:24 +01:00
kssenii
3cca841038 Unite s3/hdfs/azure storage implementations into a single class on top of IObjectStorage 2024-02-09 21:32:04 +01:00
Maksim Kita
dc52def9eb Revert "Revert "Poco Logger small refactoring"" 2024-02-09 21:39:35 +03:00
Smita Kulkarni
e594608c42 Merge branch 'master' into Azure_backup 2024-02-07 13:48:46 +01:00
Smita Kulkarni
b0994c5fa7 Addressed comments, added test for named collection 2024-02-04 11:28:20 +01:00
Raúl Marín
87d493533c
Revert "Poco Logger small refactoring" 2024-02-02 12:10:05 +01:00
Maksim Kita
88f1381739 Poco Logger small refactoring 2024-02-01 12:51:50 +03:00
Alexey Milovidov
2a1cbc2db4
Merge pull request #59354 from CurtizJ/better-memory-usage-async-read
Slightly better memory usage in `AsynchronousBoundedReadBuffer`
2024-01-30 03:55:42 +01:00
Anton Popov
182d1c08b8 slightly better memory usage in AsynchronousBoundedReadBuffer 2024-01-29 21:21:52 +00:00
Smita Kulkarni
6bfa910d9e Fix merge 2024-01-29 16:47:02 +01:00
Maksim Kita
5affd6af2e IVolume constructor improve exception message 2024-01-29 15:32:22 +03:00
Smita Kulkarni
3183026521 Merge branch 'master' into Azure_backup 2024-01-29 11:08:13 +01:00
Smita Kulkarni
99a1b269d7 Removed unwanted setting 2024-01-29 11:00:59 +01:00
Smita Kulkarni
a22b68f46f Added setting azure_max_single_part_copy_size 2024-01-29 10:49:36 +01:00
Kseniia Sumarokova
6903957414
Merge pull request #59001 from ClickHouse/Add_configurable_write_retry_azure
Add settings max_unexpected_write_error_retries for Azure Blob Storage
2024-01-29 10:48:17 +01:00
Smita Kulkarni
d264a5a148 Update client & settings to std::shared_ptr<const> 2024-01-28 12:06:52 +01:00
Azat Khuzhin
d79c1f7e1c Fix MetadataStorageFromPlainObjectStorage::iterateDirectory() (add prefix)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
9ce18bbf43 Implement MetadataStorageFromPlainObjectStorageTransaction::removeDirectory (for DROP TABLE)
This is required to remove format_version.txt for MergeTree after DROP

    (lldb) bt
    * thread 192, name = 'BgSchPool', stop reason = breakpoint 1.1
        frame 0: 0x0000000016c7f452 clickhouse`__cxa_throw(thrown_object=0x00007ffd7a53c480, tinfo=0x00000000011602a0, dest=(clickhouse`DB::Exception::~Exception() at Exception.h:40)) + 18 at cxa_exception.cpp:258
        frame 1: 0x00000000109bf709 clickhouse`DB::IMetadataTransaction::throwNotImplemented() + 137 at IMetadataStorage.h:151
        frame 2: 0x00000000109bf126 clickhouse`DB::IMetadataTransaction::removeDirectory(this=<unavailable>, (null)=<unavailable>) + 6 at IMetadataStorage.h:96
        frame 3: 0x0000000010968978 clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::removeMetadataRecursive(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1, path_to_remove="tmp_insert_all_2_2_0") + 376 at DiskObjectStorageTransaction.cpp:364
        frame 4: 0x000000001096893d clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::removeMetadataRecursive(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1, path_to_remove="store/27f/27f6f9d2-ab2e-4817-b771-0e706e485b15/") + 317 at DiskObjectStorageTransaction.cpp:362
        frame 5: 0x0000000010965a7f clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::execute(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1) + 95 at DiskObjectStorageTransaction.cpp:372
        frame 6: 0x0000000010963a2f clickhouse`DB::DiskObjectStorageTransaction::commit(this=0x00007ffea22b6168) + 79 at DiskObjectStorageTransaction.cpp:903
        frame 7: 0x00000000109577e5 clickhouse`DB::DiskObjectStorage::removeSharedRecursive(this=<unavailable>, path="store/27f/27f6f9d2-ab2e-4817-b771-0e706e485b15/", keep_all_batch_data=false, file_names_remove_metadata_only=size=0) + 133 at DiskObjectStorage.cpp:426
        frame 8: 0x000000001095af79 clickhouse`DB::DiskObjectStorage::removeRecursive(this=<unavailable>, path=<unavailable>) + 57 at DiskObjectStorage.h:79
      * frame 9: 0x0000000010b5c3d5 clickhouse`DB::DatabaseCatalog::dropTableFinally(this=0x00007ffff7096800, table=0x00007ffe853e1bd0) + 1365 at DatabaseCatalog.cpp:1317
        frame 10: 0x0000000010b5b7e7 clickhouse`DB::DatabaseCatalog::dropTableDataTask(this=0x00007ffff7096800) + 2375 at DatabaseCatalog.cpp:1270

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
41ebaefeda Add a note for MetadataStorageFromPlainObjectStorage to support transactions
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Kseniia Sumarokova
70514e3d14
Merge pull request #57615 from ClickHouse/filecache-small-optimization
fs cache: small optimization
2024-01-25 15:50:09 +01:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
Kseniia Sumarokova
b13be4fd55
Merge pull request #59175 from ClickHouse/filecache-minor
Move some headers
2024-01-25 11:33:57 +01:00
Smita Kulkarni
09f1e2840c Simplified calculatePartSize and upload task 2024-01-25 10:06:05 +01:00
kssenii
9038f0710a Minor 2024-01-24 18:44:13 +01:00
kssenii
ed607fbd2c Merge remote-tracking branch 'origin/master' into filecache-small-optimization 2024-01-24 11:58:44 +01:00
Antonio Andelic
62a3847888
Update src/Disks/ObjectStorages/ObjectStorageFactory.cpp 2024-01-24 11:15:52 +01:00
Smita Kulkarni
4d92eba316 Merge branch 'master' into Azure_backup 2024-01-24 11:13:57 +01:00
Antonio Andelic
e112288c0b Capability check for s3_plain 2024-01-24 09:27:27 +00:00
Anton Popov
4292ee7d51
Merge pull request #58886 from CurtizJ/better-read-buffers
Less error prone interface of read buffers
2024-01-23 14:59:27 +01:00
Smita Kulkarni
992d859e72 Fix style check 2024-01-23 14:16:14 +01:00
Alexander Gololobov
9a0e5d0aac
Merge pull request #58914 from ClickHouse/ot_spans_in_insert
Opentelemetry spans to analyze CPU and S3 bottlenecks on inserts
2024-01-23 13:53:13 +01:00
Smita Kulkarni
2e7ce5b0e2 Updated settings ptr and fetching of client from Disk & ObjectStorage 2024-01-22 16:24:43 +01:00
Anton Popov
e1e7a9cd45
Merge branch 'master' into better-read-buffers 2024-01-22 15:50:48 +01:00
Sema Checherinda
9adab57771
Correct initialization of ConnectionTimeouts (#59000) 2024-01-22 12:03:36 +01:00
robot-clickhouse
273a06856a
Merge pull request #59025 from ClickHouse/cpu-scheduler
Split resource scheduler off `IO/` into `Common/Scheduler/`
2024-01-20 15:43:50 +01:00
Kseniia Sumarokova
5d67e26fc4
Merge pull request #58869 from ClickHouse/force-check-for-cached-custom-disk
Fix for custom cached disk creation
2024-01-20 14:47:36 +01:00
Kseniia Sumarokova
689e617c12
Merge pull request #58963 from ClickHouse/follow-up-disk-configuration
Follow up to #58357
2024-01-20 14:41:34 +01:00
serxa
172d68ceca Merge branch 'master' into cpu-scheduler 2024-01-20 12:21:21 +00:00
serxa
824deab761 split resource scheduler off IO/ into Common/Scheduler/ 2024-01-20 12:06:26 +00:00