Commit Graph

25581 Commits

Author SHA1 Message Date
Vitaly Baranov
88b0cf3ca0 Fix TemporaryFileOnDisk 2022-04-25 16:33:38 +02:00
Vitaly Baranov
6743eb6bef Correct error messages shown by File & Disk backup engines. 2022-04-25 16:33:38 +02:00
Sergei Trifonov
ad9d57807f
fix typo 2022-04-25 16:06:14 +02:00
Meena Renganathan
ab329721d7 Merge branch 'master' of https://github.com/DevTeamBK/ClickHouse into FIPS_compliance 2022-04-25 06:21:44 -07:00
Yakov Olkhovskiy
579e8105a3
Merge pull request #36468 from ClickHouse/decouple_ParserAttachAccessEntity
Refactoring dependency for ParserAttachAccessEntity
2022-04-25 08:28:17 -04:00
Antonio Andelic
4e3b79ec0c remove arena 2022-04-25 12:23:24 +00:00
Antonio Andelic
3dd38f4917 Use vector for segments 2022-04-25 12:10:41 +00:00
Azat Khuzhin
01329d7d08 Explicit disconnect in case of error during Ping <-> Pong
v2: fix lifetime of the socket for TimeoutSetter
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-25 14:42:29 +03:00
Azat Khuzhin
a939a20443 client: gracefully handle client exceptions for INSERT queries
In other words avoid reconnect in this case, like in [1]:

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/36587/3dc8aa8caa8918f8e4a42dea72da2b94ed5e17ca/fast_test__actions_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-25 14:42:29 +03:00
Azat Khuzhin
53be9c5d0c client: add a message on reconnect (under warning log level)
This will make debugging tests easier, since sometimes it is possible
for server to hung for a few seconds, and this leads to client
reconnect, which can leave the query in backround, like in [1] ([2]).

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/35865/0cb3770d104b5f673d1d0d1076ac3fd3619fee9e/stateless_tests__debug__actions__%5B2/3%5D.html
  [2]: https://github.com/ClickHouse/ClickHouse/pull/35865#issuecomment-1099516534

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-25 14:42:29 +03:00
Antonio Andelic
ef00ac12fa Use Memory 2022-04-25 11:39:07 +00:00
Kseniia Sumarokova
2106a7b895
Merge pull request #36489 from awakeljw/fork_chmaster
fix ConvertDecimalType unexpected behavior
2022-04-25 13:23:54 +02:00
Nikolai Kochetov
0fa63a8d65
Merge pull request #36549 from ClickHouse/interpolate-alias-fix
Avoid projections if INTERPOLATE with expressions is present
2022-04-25 13:18:00 +02:00
Kruglov Pavel
34c342fdd3
Merge pull request #36205 from Avogar/improve-globs
Some refactoring around schema inference with globs
2022-04-25 13:14:46 +02:00
Nikolai Kochetov
d5b2d28f7b
Merge pull request #36579 from amosbird/refactor-executor1
Small refactoring of Processors and QueryPipeline
2022-04-25 12:47:59 +02:00
Alexander Gololobov
c484a1c269 Preserve order of virtual columns in the header and in data chunks when adding _part_offset together with other virtual columns 2022-04-25 12:10:56 +02:00
Antonio Andelic
d60384d336
Merge pull request #36469 from bigo-sg/fix_ranger_generator
Fix bug of range generator
2022-04-25 10:52:34 +02:00
Azat Khuzhin
278101fc0c Add a comment for taskstruct netlink interface rounding to KiB
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-25 08:49:17 +03:00
Azat Khuzhin
d161b798a8 Strict taskstats parser
This will unhide possible issues (since sometimes statistics is
inaccurate).

Also before this patch TASKSTATS_TYPE_AGGR_TGID had been handled, while
it not correct to take into account, but it was not requested anyway.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
(cherry picked from commit bfa65b651a)
2022-04-25 07:56:54 +03:00
Azat Khuzhin
6df54611a9 Log which taskstats provider is in use
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add missing __builtin_unreachable() for gcc built [1]
    [1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
(cherry picked from commit 2be022cb56)
2022-04-25 07:56:54 +03:00
mergify[bot]
705d5af3a0
Merge branch 'master' into to_start_of_five_minutes 2022-04-24 22:24:24 +00:00
Alexey Milovidov
74bb6349c2
Revert "Strict taskstats parser" 2022-04-25 01:15:08 +03:00
awakeljw
d58a21678a fix ConvertDecimalType unexpected behavior 2022-04-24 23:35:58 +08:00
Amos Bird
bff54af46e
Better exception for ConnectionCollector 2022-04-24 19:44:05 +08:00
Amos Bird
a25bb50096
Refactor many exception messages
1. Always use fmt variant
2. Remove redundant period at the end of message
3. Remove useless parenthesis
2022-04-24 19:44:00 +08:00
alesapin
edc78247f0
Merge pull request #36299 from ClickHouse/fix_trash
Trying to fix some trash in zero copy replication
2022-04-24 13:19:43 +02:00
Amos Bird
e73d7fea31
Rename narrowBlockInputStream to narrowPipe 2022-04-24 18:33:48 +08:00
Amos Bird
ff77e5e379
Small refactoring of ExecutorTasks 2022-04-24 15:54:06 +08:00
Alexey Milovidov
90297e225c
Merge pull request #36430 from amosbird/fixcolumnmatcher
Fix column matcher and column transformer
2022-04-24 09:11:21 +03:00
taiyang-li
6716aa9d95 Merge remote-tracking branch 'ck/master' into fix_ranger_generator 2022-04-24 11:31:19 +08:00
Alexey Milovidov
fe004c3486
Merge pull request #36486 from kitaisreal/executable-user-defined-functions-fix-group-by
ExecutableUserDefinedFunction fix usage in GROUP BY
2022-04-24 06:11:57 +03:00
Alexey Milovidov
8af3159916
Merge pull request #36351 from azat/netlink-strict
Strict taskstats parser
2022-04-24 05:14:06 +03:00
Alexey Milovidov
909646247d
Update TranslateQualifiedNamesVisitor.cpp 2022-04-24 05:04:13 +03:00
Alexey Milovidov
da1b0b491f
Merge pull request #36487 from FArthur-cmd/fix_certificates
Add passphrase for certificates
2022-04-24 04:58:21 +03:00
Alexey Milovidov
3b9c72ba94
Update CertificateReloader.cpp 2022-04-24 04:57:46 +03:00
Kruglov Pavel
3936b3e800
Merge pull request #36207 from Avogar/improve-json-schema-inference
Improve schema inference for json objects
2022-04-23 16:42:27 +02:00
alesapin
f0f92341e0
Merge pull request #36492 from ClickHouse/fix-keeper-hostname-check
Fix hostname checks in clickhouse-keeper
2022-04-23 13:54:57 +02:00
tavplubix
9fa1edd6ef
Merge pull request #36535 from xiedeyantu/fix-log
fix log should print 'from' path
2022-04-23 14:10:09 +03:00
zombee0
c02de61086 fixed the cow_compositions.cpp clone inner column when there is no need
Signed-off-by: zombee0 <flylucas_10@163.com>
2022-04-23 18:42:04 +08:00
alesapin
46792379e7 Merge branch 'master' into fix_trash 2022-04-23 12:05:35 +02:00
alesapin
2b04c19435 Satisfy clang-tidy 2022-04-23 11:58:56 +02:00
wuxiaobai24
751185a366 allow file descriptor in table function file() 2022-04-23 11:01:27 +08:00
alesapin
7380a71333
Merge pull request #31833 from ClickHouse/musl-check
Build clickhouse-keeper with Musl
2022-04-22 22:41:16 +02:00
alesapin
f183eabaa2 Return normal settings 2022-04-22 22:36:55 +02:00
avogar
80eacc8533 Merge branch 'master' of github.com:ClickHouse/ClickHouse into improve-json-schema-inference 2022-04-22 17:18:44 +00:00
alesapin
ebdd53ef8f Fix shared fetch 2022-04-22 19:18:18 +02:00
mergify[bot]
eefc302779
Merge branch 'master' into fix-keeper-hostname-check 2022-04-22 14:07:53 +00:00
Nikita Mikhaylov
9baf7b14dc Fix build 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
aaa7112405 Even better 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
e475849761 Style and Docs update 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
bf6d3af536 Better 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
36bdee0499 Deleted settings 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
4818b63979 Better 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
8c325c2cdd Better 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
31ccb9c1c3 Done 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
224f4dc620
Made parallel_reading_from_replicas work with localhost replica (#36281) 2022-04-22 15:52:38 +02:00
Yakov Olkhovskiy
e4af79c2a0 avoid projections if INTERPOLATE with expressions is present 2022-04-22 09:47:59 -04:00
alesapin
2559d62d74 Better logging and bugfixes 2022-04-22 15:35:25 +02:00
alesapin
64383bcb0a Better 2022-04-22 15:35:25 +02:00
tavplubix
7f50bebba1
Merge pull request #36463 from ClickHouse/fix_36451
Ignore DNS errors when checking if dictionary source is local
2022-04-22 15:28:48 +03:00
Anton Popov
5b5dd4fa46
Merge pull request #36423 from CurtizJ/return-back-36126
Return back #36126
2022-04-22 14:27:57 +02:00
Anton Popov
39fa397e9f allow names of tuple elements starting from digits 2022-04-22 12:07:23 +00:00
Antonio Andelic
2e187e4b97
Merge pull request #36439 from xiedeyantu/temp-table-improve
temporary table can show total rows and total bytes
2022-04-22 13:41:25 +02:00
Kseniia Sumarokova
33bb48106f
Merge pull request #36314 from CurtizJ/print-bad-filenames
Show names of erroneous files in case of parsing errors while executing table functions
2022-04-22 13:24:55 +02:00
xiedeyantu
550460c541 fix log should print from path 2022-04-22 18:30:40 +08:00
Kseniia Sumarokova
e7af16b7b7
Merge pull request #36481 from kssenii/fix-client-exception
Fix possible exception with unknown packet from server in client
2022-04-22 11:52:40 +02:00
Antonio Andelic
4e389d8df1 Rename to hostname, add tests 2022-04-22 08:16:14 +00:00
taiyang-li
3751c69aaa fix code style 2022-04-22 15:38:19 +08:00
Sergei Trifonov
b371251e80 Merge branch 'master' into surahman-CH-31221-AWS-S3-object-version-id 2022-04-22 08:39:02 +02:00
taiyang-li
6bcf24ae36 add test for range generator 2022-04-22 12:33:16 +08:00
Yakov Olkhovskiy
e6c5ac3b02 print error string 2022-04-22 00:31:23 -04:00
Alexey Milovidov
e8575f5f35
Merge pull request #36327 from ucasfl/alias
Add aliases JSONLines and NDJSON for JSONEachRow
2022-04-22 07:08:02 +03:00
Memo
856412ea6e fix wrong alias 2022-04-22 11:27:24 +08:00
Memo
25f4d76da3 change name 2022-04-22 11:24:44 +08:00
Memo
956d525840 fix conflict 2022-04-22 11:22:50 +08:00
Memo
32721b001f add alias 2022-04-22 11:18:07 +08:00
Memo
39aadf0975 replaced toStartOfFiveMinute to toStartOfFiveMinutes 2022-04-22 10:49:59 +08:00
mergify[bot]
cd8fa75546
Merge branch 'master' into fix_trash 2022-04-21 21:45:31 +00:00
Maksim Kita
bac1f12a2b
Merge pull request #36167 from kitaisreal/special-operators-broken-aliases-fix
Fix broken aliases during parsing of special operators
2022-04-21 22:31:45 +02:00
Maksim Kita
a077751100 Fixed style check 2022-04-21 21:31:50 +02:00
Maksim Kita
583cbcb834
Merge branch 'master' into fix_session_log_error_on_local_and_tcp_interserver_session 2022-04-21 21:15:11 +02:00
Maksim Kita
9713441650
Merge pull request #36480 from Joeywzr/session_log
add missing enum values in session_log
2022-04-21 21:14:12 +02:00
Alexey Milovidov
b1e3130a5e
Revert "Minor refactor to prefer C++ Standard Algorithms" 2022-04-21 20:22:37 +03:00
Maksim Kita
485c1d4072 Fixed tests 2022-04-21 19:10:11 +02:00
Yakov Olkhovskiy
f966d69791 error processing for RAND_bytes, style issue 2022-04-21 13:07:44 -04:00
Anton Popov
6724e1344e fix build 2022-04-21 16:54:25 +00:00
Anton Popov
5a3edeac18 fix build 2022-04-21 16:23:01 +00:00
Mikhail f. Shiryaev
e3d8da26b7
Merge pull request #36502 from ClickHouse/22.5-prepare
Update version after release
2022-04-21 17:44:09 +02:00
Mikhail f. Shiryaev
5997d7af60
Update version to 22.5.1.1 2022-04-21 17:39:40 +02:00
alesapin
cbced6567d Fix build 2022-04-21 17:32:23 +02:00
mergify[bot]
e38a3c3595
Merge branch 'master' into alias 2022-04-21 15:02:30 +00:00
Anton Popov
a87f19b493 fix more cases with nested arrays 2022-04-21 14:57:12 +00:00
Maksim Kita
57444fc7d3
Merge pull request #36444 from rschu1ze/clang-tidy-fixes
Clang tidy fixes
2022-04-21 16:11:27 +02:00
Antonio Andelic
6ac3784af7 Add config example 2022-04-21 13:49:36 +00:00
Dmitry Novik
77a82cc090
Merge pull request #35631 from amosbird/projection-fix1
Fix broken SET reuse during projection analysis.
2022-04-21 15:32:52 +02:00
Antonio Andelic
1778ddda97 Simplify code 2022-04-21 13:32:12 +00:00
Antonio Andelic
792b06cc66 Add config for host check 2022-04-21 13:32:12 +00:00
Antonio Andelic
b2770fbe1c Add setting for disabling checks 2022-04-21 13:32:12 +00:00
tavplubix
5b74281a02
Merge pull request #35463 from ClickHouse/tavplubix-patch-1
Set `distributed_ddl_entry_format_version` to 2 by default
2022-04-21 15:45:15 +03:00
mergify[bot]
04e3356d50
Merge branch 'master' into temp-table-improve 2022-04-21 12:43:55 +00:00
alesapin
5465415751 Fix replace/move partition with zero copy replication 2022-04-21 14:39:12 +02:00
Antonio Andelic
03779fd463 Merge branch 'master' into keeper-recovery-mode 2022-04-21 12:34:18 +00:00
FArthur-cmd
f0a4009f60 Add passphrase for certificates 2022-04-21 12:26:30 +00:00
Maksim Kita
be53daf405 Fixed tests 2022-04-21 14:20:10 +02:00
mergify[bot]
be6914f6f9
Merge branch 'master' into session_log 2022-04-21 11:52:20 +00:00
mergify[bot]
1ba1cad5cf
Merge branch 'master' into improve-globs 2022-04-21 11:52:13 +00:00
avogar
a093181b4f Fix comments 2022-04-21 11:48:17 +00:00
Maksim Kita
01e09ba44e Fixed tests 2022-04-21 13:47:43 +02:00
Maksim Kita
c9a1605b1e Fixed tests 2022-04-21 13:47:43 +02:00
Maksim Kita
fb28791d83 Fixed tests 2022-04-21 13:47:43 +02:00
Maksim Kita
90e3a75874 Fixed tests 2022-04-21 13:47:43 +02:00
Maksim Kita
00ac3231b2 Fix broken aliases during parsing of special operators 2022-04-21 13:47:43 +02:00
Maksim Kita
397603e9be ExecutableUserDefinedFunction fix usage in GROUP BY 2022-04-21 13:44:56 +02:00
Kruglov Pavel
a6186f7ba4
Merge pull request #36333 from ClickHouse/bool-sync-after-error
Fix tech debt for Bool and Map data types
2022-04-21 13:32:14 +02:00
Kruglov Pavel
016da97d4f
Merge pull request #36454 from azat/fix-limit-by
Fix "Cannot find column" error for distributed queries with LIMIT BY
2022-04-21 12:50:27 +02:00
mergify[bot]
27479e94ce
Merge branch 'master' into fix_dictionary_reload_bug 2022-04-21 09:59:45 +00:00
Vasily Nemkov
e2866b0541 Fixed missing enum values for ClientInfo::Interface 2022-04-21 12:16:12 +03:00
kssenii
c1b5ac52ab Fix 2022-04-21 11:14:11 +02:00
Memo
ce91a261e8 add missing enum values in session_log 2022-04-21 17:01:44 +08:00
taiyang-li
adb1288e10 fix bug of range generator 2022-04-21 11:33:15 +08:00
Yakov Olkhovskiy
b2d7cb769c dedicated files for ParserAttachAccessEntity 2022-04-20 22:59:12 -04:00
Yakov Olkhovskiy
85df222f15 refactoring ParserAttachAccessEntity 2022-04-20 22:57:44 -04:00
Alexey Milovidov
ec9b86fd03
Merge branch 'master' into fixcolumnmatcher 2022-04-21 02:15:25 +03:00
alesapin
cbfe00bb47 Fix tidy 2022-04-21 00:30:13 +02:00
Yakov Olkhovskiy
a7318b3a96
Merge pull request #36172 from DevTeamBK/feature-password
password hash salt feature
2022-04-20 17:52:25 -04:00
alesapin
c14e2e0b96 Fix more 2022-04-20 21:08:26 +02:00
Azat Khuzhin
2be022cb56 Log which taskstats provider is in use
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add missing __builtin_unreachable() for gcc built [1]
    [1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
2022-04-20 21:39:26 +03:00
Azat Khuzhin
bfa65b651a Strict taskstats parser
This will unhide possible issues (since sometimes statistics is
inaccurate).

Also before this patch TASKSTATS_TYPE_AGGR_TGID had been handled, while
it not correct to take into account, but it was not requested anyway.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-20 21:39:25 +03:00
Kseniia Sumarokova
f9faadcfee
Merge pull request #36452 from KinderRiven/master
Bad assert cause system crash in local cache
2022-04-20 19:48:02 +02:00
Alexander Tokmakov
5d129e13ee ignore DNS errors when checking if dictionary source is local 2022-04-20 18:40:10 +02:00
Sergei Trifonov
34842f209c merge master and fix conflicts 2022-04-20 18:35:56 +02:00
Kseniia Sumarokova
842879beea
Merge pull request #36272 from kssenii/mongo-fix
Allow missing columns for mongo storage
2022-04-20 17:54:35 +02:00
xiedeyantu
8d4a104d22 fix code 2022-04-20 23:43:46 +08:00
Yakov Olkhovskiy
95fc6243b1
Merge pull request #36386 from Joeywzr/hex_support_uint128
hex support Int128/Int256/UInt128/UInt256
2022-04-20 11:11:51 -04:00
Larry Luo
33cdeab4cc Removed space. 2022-04-20 11:07:06 -04:00
Larry Luo
cd59a2db08 Fixed unit tests. 2022-04-20 11:00:18 -04:00
Kruglov Pavel
56cfa55bd5
Fix style 2022-04-20 16:35:57 +02:00
Kruglov Pavel
813e228fcc
Merge branch 'master' into improve-globs 2022-04-20 16:31:47 +02:00
Anton Popov
d4df38a0e6 fix tests 2022-04-20 14:13:04 +00:00
Kseniia Sumarokova
df8312b357
Merge pull request #36388 from kssenii/fix-s3-tests-3
Fix test 01161_all_system_tables under s3 storage
2022-04-20 15:46:12 +02:00
alesapin
6ee0df251f Add ditry settings 2022-04-20 15:11:03 +02:00
alesapin
829854113b Add a little thread safety 2022-04-20 15:10:36 +02:00
mergify[bot]
ded06ff100
Merge branch 'master' into return-back-36126 2022-04-20 13:01:32 +00:00
Azat Khuzhin
c6ffec1fec Fix "Cannot find column" error for distributed queries with LIMIT BY
Consider the following example:

    SELECT k FROM (SELECT materialize('foo') AS k, -1 AS v) ORDER BY abs(v) AS _v ASC LIMIT 1 BY k

The problem here is that in case of query has LIMIT BY for
WithMergeableState* (which is the final state on the remote shard for
distributd queries) it returns the following columns:
- k
- v

While it should return:
- k
- abs(v)

So as query w/o LIMIT BY, so that initiator will be able to do the sorting

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-20 15:23:24 +03:00
KinderRiven
137a1a3392 fix bug for local cache 2022-04-20 20:22:33 +08:00
alesapin
e8fba1644c Fix bug 2022-04-20 14:13:29 +02:00
KinderRiven
59d56b6391 resubmit 2022-04-20 20:10:31 +08:00
alesapin
41b57f78cf Revert extreme settings 2022-04-20 13:59:12 +02:00
alesapin
612a81ba24
Update src/Disks/IDisk.h
Co-authored-by: tavplubix <tavplubix@clickhouse.com>
2022-04-20 13:58:31 +02:00
larryluogit
46a9226bf6
Merge branch 'ClickHouse:master' into feature-password 2022-04-20 07:57:21 -04:00
Kruglov Pavel
5801de7f72
Merge pull request #36254 from Avogar/improve-client
Send both stdin data and data from query/data from infile in client
2022-04-20 13:55:04 +02:00
KinderRiven
910c4a6660 fix bug for local cache 2022-04-20 19:49:04 +08:00
KinderRiven
b91f18033c fix bug for local cache 2022-04-20 19:43:07 +08:00
Robert Schulze
7550d9b281
Fix build 2022-04-20 13:34:17 +02:00
alesapin
5334522d5c Extreme settings 2022-04-20 13:33:42 +02:00
alesapin
a9131de657 Merge branch 'fix_trash' of github.com:ClickHouse/ClickHouse into fix_trash 2022-04-20 13:27:03 +02:00
alesapin
2eee79dc2a Review fixes 2022-04-20 13:26:20 +02:00
Kseniia Sumarokova
70100dbd8d
Update MongoDBSource.cpp 2022-04-20 13:18:11 +02:00
李扬
a1e54c3918
Fix wrong result of datetime64 when negative (#35440) 2022-04-20 13:11:31 +02:00
Rajkumar
419970cc1c moved class definition to header 2022-04-20 04:05:23 -07:00
alesapin
40c15222f8 Merge branch 'master' into fix_trash 2022-04-20 12:45:49 +02:00
Rajkumar
16a3e9cb2d updated unit test case 2022-04-20 03:29:58 -07:00
Antonio Andelic
d77678d1d1
Merge pull request #36410 from xinhuitian/move_down_data_range_construction
Move down data_range construction in filterMarksUsingIndex and filterMarksUsingMergedIndex
2022-04-20 12:18:05 +02:00
mergify[bot]
0df5fda6ed
Merge branch 'master' into musl-check 2022-04-20 09:28:40 +00:00
mergify[bot]
9e0cc9606b
Merge branch 'master' into tavplubix-patch-1 2022-04-20 09:05:21 +00:00
tavplubix
2c54381520
Merge pull request #36200 from ClickHouse/fix_create_as_replicated_default_args
Fix CREATE AS for ReplicatedMergeTree with default arguments
2022-04-20 12:01:13 +03:00
kssenii
5fc4aaaa2d Better 2022-04-20 10:42:07 +02:00
Robert Schulze
b24ca8de52
Fix various clang-tidy warnings
When I tried to add cool new clang-tidy 14 warnings, I noticed that the
current clang-tidy settings already produce a ton of warnings. This
commit addresses many of these. Almost all of them were non-critical,
i.e. C vs. C++ style casts.
2022-04-20 10:29:05 +02:00
Kseniia Sumarokova
f37812f89a
Merge pull request #36079 from kssenii/change-hashed-path
Change hashed path for cache
2022-04-20 10:27:44 +02:00
Kseniia Sumarokova
766a84e64f
Merge pull request #35915 from kssenii/better-s3-settings
Better settings configuration for s3
2022-04-20 10:22:06 +02:00
Antonio Andelic
bb0d941add Run tests on a single cluster 2022-04-20 08:06:17 +00:00
Robert Schulze
b6d7367538
Merge remote-tracking branch 'origin/master' into erase_if3
Conflicts:
- Interpreters/ActionsDAG.cpp
2022-04-20 10:02:59 +02:00
Antonio Andelic
f0774ca9ee
Merge pull request #36393 from tcoyvwac/fix/prefer-standard-algorithms-std-transform-storages
Minor refactor to prefer C++ Standard Algorithms
2022-04-20 08:42:54 +02:00
Antonio Andelic
bbb0be6a44
Merge pull request #36402 from rschu1ze/clang-tidy-contains
Activate clang-tidy warning "readability-container-contains"
2022-04-20 08:15:46 +02:00
Yakov Olkhovskiy
f6a7b6c2a1
Merge pull request #36352 from awakeljw/fork_chmaster
Possible range issues in automatic assigned enums, also fix error message.
2022-04-19 23:34:35 -04:00
xiedeyantu
47c826935d temporary table can show total rows and total bytes 2022-04-20 10:03:16 +08:00
Larry Luo
cfbdb32901 Merge branch 'feature-password' of github.com:DevTeamBK/ClickHouse into feature-password 2022-04-19 21:46:06 -04:00
Larry Luo
ed7eb988d8 Addressed build warnings. 2022-04-19 21:45:30 -04:00
avogar
f31f019252 Fix 2022-04-19 19:25:41 +00:00
avogar
1f252cedfe Make better 2022-04-19 19:16:47 +00:00
Kruglov Pavel
894b1b163e
Merge pull request #36055 from helifu/master2
Don't materialize external tables if it's explain statement
2022-04-19 20:26:27 +02:00
Kruglov Pavel
7fb7fc9daa
Merge pull request #36275 from Avogar/fix-insert-select
Place new logic of schema inference in insert select from table function under setting
2022-04-19 20:19:28 +02:00
Amos Bird
158a25d5fa
Fix column matcher and column transformer 2022-04-20 01:22:04 +08:00
alesapin
033a3475a5
Update src/Disks/IDiskRemote.cpp 2022-04-19 17:57:12 +02:00
Anton Popov
bee4ca9b62 add more tests for error diagnostics in files 2022-04-19 15:56:34 +00:00
alesapin
ffca5c3cdc
Merge branch 'master' into musl-check 2022-04-19 17:51:54 +02:00
Alexey Milovidov
152acb19a9 Fix strange trash in Keeper 2022-04-19 17:44:27 +02:00
fenglv
07b6274825 Implement type inference for INSERT INTO function null() 2022-04-19 17:44:27 +02:00
Alexey Milovidov
034eb9246f Do not randomize "priority" setting 2022-04-19 17:44:27 +02:00
fenglv
ee3e366356 fix
fix typo
2022-04-19 17:44:27 +02:00
fenglv
72b0aa18e7 Add setting throw_if_no_data_to_insert 2022-04-19 17:44:27 +02:00
Alexey Milovidov
93229133e2 Return two changes 2022-04-19 17:44:27 +02:00
Alexey Milovidov
79be0aa75b Remove Arcadia 2022-04-19 17:44:27 +02:00
Alexey Milovidov
436bece3f6 Remove Arcadia 2022-04-19 17:44:27 +02:00
Alexey Milovidov
3c1e05eb53 Remove Arcadia 2022-04-19 17:44:27 +02:00
Alexey Milovidov
0118d98e93 Remove Arcadia 2022-04-19 17:44:27 +02:00
Alexey Milovidov
8a8b9c1e34 Remove "Arcadia" build system 2022-04-19 17:44:27 +02:00
Alexey Milovidov
8fb78f89cf Fix clang-tidy 2022-04-19 17:44:27 +02:00
Alexey Milovidov
7629016f66 Fix clang-tidy-14 (part 1) 2022-04-19 17:44:27 +02:00
Alexey Milovidov
b6c06268eb Simplification #36313 2022-04-19 17:44:27 +02:00
Alexey Milovidov
767b2eecff Remove trash 2022-04-19 17:44:27 +02:00
Alexey Milovidov
fb9545e0b4 Remove trash 2022-04-19 17:44:27 +02:00
Alexey Milovidov
611ea86d60 Remove abbreviation 2022-04-19 17:44:26 +02:00
Alexey Milovidov
c46715db82 Remove abbreviation 2022-04-19 17:44:26 +02:00
kssenii
2fb331bcec Better 2022-04-19 17:32:46 +02:00
alesapin
aea7c7755a Fix style 2022-04-19 17:25:08 +02:00
Anton Popov
3e361c9759 Merge remote-tracking branch 'upstream/master' into HEAD 2022-04-19 14:18:04 +00:00
alesapin
7919485db2 Fix 2022-04-19 15:57:25 +02:00
alesapin
7cb7c120cc Less ugly 2022-04-19 15:53:10 +02:00
Anton Popov
056500f2ad
Merge pull request #33391 from zhongyuankai/fix_storage_distributed_ttl
Fix Alter ttl modification unsupported table engine
2022-04-19 15:47:01 +02:00
Anton Popov
7b7939c52c fix parsing of ints 2022-04-19 13:31:45 +00:00
Kseniia Sumarokova
53f1cff96f
Merge pull request #36287 from bigo-sg/fixhdfsreadbuffer
Fix ReadBufferFromHDFS crash in debug mode
2022-04-19 15:27:51 +02:00
Robert Schulze
72a331189e
Fix glitch 2022-04-19 14:59:47 +02:00
Antonio Andelic
e129f8ce00 Small fix 2022-04-19 12:39:34 +00:00
larryluogit
d8865f338c
Merge branch 'ClickHouse:master' into feature-password 2022-04-19 08:36:00 -04:00
Antonio Andelic
70f3d3a863 Merge branch 'master' into keeper-recovery-mode 2022-04-19 12:32:48 +00:00
Kruglov Pavel
ec4e1cb6d8
Merge pull request #36211 from Avogar/insert-select-all-formats
Allow insert select for files with formats without schema inference
2022-04-19 14:25:59 +02:00
Kruglov Pavel
2b2e4030be
Fix special build 2022-04-19 14:21:14 +02:00
mergify[bot]
3c1dd44b80
Merge branch 'master' into fix-insert-select 2022-04-19 12:17:31 +00:00
alesapin
7c2fcee351 Simplify interface 2022-04-19 14:13:11 +02:00
Antonio Andelic
3e77340a81
Allow clickhouse-keeper to serve 4-letter commands before quorum (#35992)
* Use async start for clichkouse-keeper

* Return non active server for 4lw commands if quorum not achieved
2022-04-19 14:03:00 +02:00
alesapin
cc06bc3d99 Add some clarifications 2022-04-19 14:01:30 +02:00
xiedeyantu
89d0c30f38
Fix the repeated call of func to get the table when drop table (#36248) 2022-04-19 13:51:51 +02:00
tcoyvwac
2441d33940
storages: prefer standard algorithms
StorageSystemZooKeeper.cpp:
Prefer std::any_of over ranged-for.
2022-04-19 13:40:50 +02:00
tcoyvwac
f7789c9b6d
storages: prefer standard algorithms
StorageSystemZooKeeper.cpp:
Prefer std::transform over ranged-for.
2022-04-19 13:40:49 +02:00
tcoyvwac
10dfeedd23
storages: prefer standard algorithms
StorageSystemZooKeeper.cpp:
Prefer std::transform over ranged-for.
2022-04-19 13:40:49 +02:00
alesapin
ee8d26ff0e Better test and fix for move 2022-04-19 13:27:55 +02:00
Sergei Trifonov
75c1053ad7 Merge remote-tracking branch 'origin/master' into surahman-CH-31221-AWS-S3-object-version-id 2022-04-19 13:17:25 +02:00
Antonio Andelic
73db184ad6 Ignore requests on leader while in recovery mode 2022-04-19 10:23:54 +00:00
alesapin
8ade9fba52 Fix 2022-04-19 11:56:14 +02:00
mergify[bot]
64d5e0c8a2
Merge branch 'master' into change-hashed-path 2022-04-19 09:33:48 +00:00
mergify[bot]
d22f538b41
Merge branch 'master' into fix-s3-tests-3 2022-04-19 09:32:54 +00:00
mergify[bot]
d894aed7ae
Merge branch 'master' into mongo-fix 2022-04-19 09:32:51 +00:00
kssenii
0e05e1fa2f Fix 2022-04-19 11:31:27 +02:00
kssenii
1f9a597b77 Merge master 2022-04-19 11:31:13 +02:00
kssenii
f8f66dd23d Better 2022-04-19 10:59:47 +02:00
Antonio Andelic
608c0996d0 Fix tests 2022-04-19 08:59:44 +00:00
Kseniia Sumarokova
f7a2fa487d
Fix style check 2022-04-19 10:45:48 +02:00
Antonio Andelic
cd548aeb30 Refactor test for multiple cluster size 2022-04-19 08:08:36 +00:00
Antonio Andelic
6c3bf0a5d3 Format files 2022-04-19 08:08:36 +00:00
Antonio Andelic
272965fc44 Refactoring 2022-04-19 08:08:35 +00:00
Antonio Andelic
4ecb66c1ad Support recovery with four letter commands 2022-04-19 08:08:35 +00:00
Antonio Andelic
ff2ebe113c WIP 2022-04-19 08:08:35 +00:00
Antonio Andelic
dbd88a5acb Use 1 leader quorum for recovery 2022-04-19 08:08:35 +00:00
Antonio Andelic
0e1ba927bd Add argument for force recovery 2022-04-19 08:08:35 +00:00
Antonio Andelic
bb4bc17af1 Force recover from configuration 2022-04-19 08:08:35 +00:00
Memo
8d4e433c7d add int8 int16 int32 int64 and tests 2022-04-19 14:38:16 +08:00
xinhuitian
5d0957e669 move down data range construction in filterMarksUsingIndex and filterMarksUsingMergedIndex 2022-04-19 13:26:33 +08:00
Yakov Olkhovskiy
8a2e006cc4
Merge pull request #36374 from ucasfl/typo
fix typo
2022-04-18 21:47:45 -04:00
alesapin
c81cb9e563 Better 2022-04-19 01:12:07 +02:00
alesapin
bd7b3847c1 Some code 2022-04-19 01:09:09 +02:00
Robert Schulze
118e94523c
Activate clang-tidy warning "readability-container-contains"
This check suggests replacing <Container>.count() by
<Container>.contains() which is more speaking and in case of
multimaps/multisets also faster.
2022-04-18 23:53:11 +02:00
Larry Luo
a7ed0ef568 Fixed style check error 2022-04-18 17:20:58 -04:00
Larry Luo
5a5cc3dd13 Added keyword SALT to indicate random salt value in CREATE/ALTER USER results. 2022-04-18 17:02:22 -04:00
Alexey Milovidov
1e1ffbbfe2
Update SessionLog.cpp 2022-04-18 23:07:34 +03:00
Alexey Milovidov
8f8f798438
Merge pull request #36368 from ClickHouse/column-nodiscard
Add nodiscard attribute to immutable methods of `IColumn` to avoid errors
2022-04-18 23:03:02 +03:00
Anton Popov
56bdc654d4 Revert "Merge pull request #36337 from ClickHouse/revert-36126-fork_chmaster2"
This reverts commit e04f80d4a7, reversing
changes made to 06e0afb67f.
2022-04-18 17:59:46 +00:00
Larry Luo
e4d83f5627 Remove test code. 2022-04-18 13:48:50 -04:00
mergify[bot]
daca157111
Merge branch 'master' into fix_storage_distributed_ttl 2022-04-18 17:31:59 +00:00
Larry Luo
3b605b3fd7 Fixed check style error 2022-04-18 12:03:14 -04:00
larryluogit
393fd88d95
Merge branch 'ClickHouse:master' into feature-password 2022-04-18 11:39:40 -04:00
Larry Luo
6189b28489 Added unit tests for parsing sha256_password and sha256_hash with salt 2022-04-18 11:34:25 -04:00
lthaooo
1b533aa583 fix dictionary reload bug 2022-04-18 21:13:08 +08:00
kssenii
40f7ddb6cc Fix 2022-04-18 15:07:07 +02:00
Memo
a17f102fe6 fix style 2022-04-18 20:31:40 +08:00
Memo
335be4c807 hex support Int128/Int256/UInt128/UInt256 2022-04-18 20:13:43 +08:00
alesapin
a97754f462 Fix 2022-04-18 13:39:09 +02:00
alesapin
c4b70f3ed3 Merge branch 'master' into fix_trash 2022-04-18 12:20:09 +02:00
zhanglistar
5670dcf750 Fix crash in debug mode of ReadBufferFromHDFS. 2022-04-18 17:52:59 +08:00
alesapin
8e01b3a5d7
Merge pull request #36369 from ClickHouse/fix-strange-trash-in-keeper
Fix strange trash in Keeper
2022-04-18 11:44:02 +02:00
zhanglistar
355333b361
Merge branch 'ClickHouse:master' into fixhdfsreadbuffer 2022-04-18 16:42:03 +08:00
fenglv
735c38cdcc fix typo 2022-04-18 04:59:41 +00:00
Memo
b3adf150b5 add_query_level_settings 2022-04-18 12:15:41 +08:00
Alexey Milovidov
f5e270b2f8
Merge pull request #36353 from ucasfl/type-infer-null
Implement type inference for INSERT INTO function null()
2022-04-18 07:06:54 +03:00
Alexey Milovidov
0af183826d
Merge pull request #36358 from ClickHouse/don-t-randomize-priority
Do not randomize "priority" setting
2022-04-18 07:04:36 +03:00
Alexey Milovidov
1333b4cd89
Merge pull request #36345 from ucasfl/throw-no-data
Add setting throw_if_no_data_to_insert
2022-04-18 07:04:16 +03:00
Alexey Milovidov
f6ab2bd523
Merge pull request #36312 from ClickHouse/remove-arcadia
Remove remaining parts of Arcadia
2022-04-18 07:02:54 +03:00
Alexey Milovidov
36595e4206
Merge pull request #36320 from ClickHouse/fix-clang-tidy-14
Fix clang-tidy-14 (part 1)
2022-04-18 07:02:10 +03:00
Alexey Milovidov
48fd09c7db
Merge pull request #36310 from ClickHouse/cpuid-remove-trash
Remove trash from CPUID
2022-04-18 07:01:23 +03:00
Alexey Milovidov
f86808914c Fix strange trash in Keeper 2022-04-18 04:44:30 +02:00
Alexey Milovidov
c23e451b04 Add nodiscard attribute to immutable methods of IColumn to avoid errors 2022-04-18 04:22:40 +02:00
Alexey Milovidov
bd16102e53 Fix absolutely wrong code in Map data type 2022-04-18 04:05:49 +02:00
Alexey Milovidov
3817c6d710 Fix absolutely wrong code in Map data type 2022-04-18 03:58:32 +02:00
Alexey Milovidov
2855d987ce Merge branch 'master' into bool-sync-after-error 2022-04-18 02:44:40 +02:00
Alexey Milovidov
543e5d7242 Merge branch 'master' into musl-check 2022-04-18 02:40:13 +02:00
Alexey Milovidov
70d7ba5d61 Fix clang-tidy 2022-04-18 02:13:28 +02:00
Alexey Milovidov
6de5d8a554 Merge branch 'master' into fix-clang-tidy-14 2022-04-18 02:12:45 +02:00
Alexey Milovidov
0051e651c6
Update AsynchronousMetricLog.h 2022-04-18 03:01:57 +03:00
Alexey Milovidov
c7bca13a03 Remove abbreviation 2022-04-18 01:03:58 +02:00
Alexey Milovidov
242919eddd Remove abbreviation 2022-04-18 01:02:49 +02:00
Alexey Milovidov
8ea14d2664 Custom ORDER BY for system.asynchronous_metric_log 2022-04-17 23:59:05 +02:00
Alexey Milovidov
e36e22812a Custom column list for system.asynchronous_metric_log 2022-04-17 23:53:28 +02:00
Alexey Milovidov
300ef741cc Custom column list for system.asynchronous_metric_log 2022-04-17 23:51:56 +02:00
Alexey Milovidov
4c09e2d30a Custom column list for system.asynchronous_metric_log 2022-04-17 23:49:39 +02:00
Alexey Milovidov
37c61d9f0a Round values for the log 2022-04-17 22:07:50 +02:00
Alexey Milovidov
1f5df287c0 Remove useless code 2022-04-17 22:02:55 +02:00
Alexey Milovidov
6807f8428d Remove microseconds from system.asynchronous_metric_log 2022-04-17 22:01:58 +02:00
Alexey Milovidov
250ca83058 Allow custom default ORDER BY for system logs 2022-04-17 21:57:44 +02:00
Alexey Milovidov
a64765bc6f Allow custom default ORDER BY for system logs 2022-04-17 21:56:36 +02:00
Alexey Milovidov
aa93f4a074 Do not randomize "priority" setting 2022-04-17 20:48:02 +02:00
fenglv
0024a08ace fix
fix typo
2022-04-17 15:12:07 +00:00
fenglv
293d0a5d46 Implement type inference for INSERT INTO function null() 2022-04-17 15:07:56 +00:00
Alexey Milovidov
89deaf0af1
Merge pull request #36056 from azat/client-trailing-space
Remove trailing whitespace in default client_name
2022-04-17 17:37:43 +03:00
mergify[bot]
4fed033dca
Merge branch 'master' into alias 2022-04-17 14:37:04 +00:00
Alexey Milovidov
27afc08d8f Merge branch 'master' into cpuid-remove-trash 2022-04-17 16:30:30 +02:00
Alexey Milovidov
7de4f2b6c1 Merge branch 'master' into remove-arcadia 2022-04-17 16:30:09 +02:00
Alexey Milovidov
fb0a23881d Merge branch 'master' into fix-clang-tidy-14 2022-04-17 16:28:54 +02:00
Alexey Milovidov
576e897a78 Merge branch 'master' into bool-sync-after-error 2022-04-17 16:27:24 +02:00
awakeljw
017777793a Possible range issues in automatic assigned enums, also fix error message. 2022-04-17 21:40:48 +08:00
Robert Schulze
1e1df8e101
Replace remove-erase idiom by C++20 erase()/erase_if()
- makes the code less verbose while being as efficient
2022-04-17 12:04:47 +02:00
fenglv
b25850a665 Add setting throw_if_no_data_to_insert 2022-04-17 05:42:07 +00:00
Alexey Milovidov
42618239a4
Update ParserDataType.cpp 2022-04-17 01:53:11 +03:00
Alexey Milovidov
cb9675d0f2
Revert "support UNSIGNED modifier with unused parameters of INT" 2022-04-16 21:23:57 +03:00
fenglv
2392d4e2b5 fix 2022-04-16 16:08:28 +00:00
Alexey Milovidov
7206838c75 Fix tech debt for Bool and Map data types 2022-04-16 16:09:04 +02:00
fenglv
58111115c5 fix style 2022-04-16 06:21:09 +00:00
fenglv
74ef1b0198 Add aliases JSONLines and NDJSON for JSONEachRow 2022-04-16 06:01:07 +00:00
larryluogit
c98e25d36c
Merge branch 'ClickHouse:master' into feature-password 2022-04-15 22:56:34 -04:00
Alexey Milovidov
294efeccfe Fix clang-tidy-14 (part 1) 2022-04-16 04:54:04 +02:00
Alexey Milovidov
33ffdcaa4f Return two changes 2022-04-16 02:18:22 +02:00
Anton Popov
2de6668b3f show names of erroneous files 2022-04-16 00:10:47 +00:00
Alexey Milovidov
69b91c5410 Simplification #36313 2022-04-16 02:08:06 +02:00
Kseniia Sumarokova
0abc6290b1
Merge pull request #36253 from kssenii/fix-s3-tests
Fix exception "File segment can be completed only by downloader" in tests
2022-04-16 01:24:39 +02:00
Alexey Milovidov
40357637ec Remove Arcadia 2022-04-16 00:33:32 +02:00
Alexey Milovidov
e128d89957 Remove Arcadia 2022-04-16 00:24:58 +02:00
Alexey Milovidov
cbeeb7ec4f Remove Arcadia 2022-04-16 00:20:47 +02:00
Alexey Milovidov
a0fe29e243 Remove Arcadia 2022-04-15 23:59:49 +02:00
Alexey Milovidov
416fa95b87 Remove "Arcadia" build system 2022-04-15 23:57:09 +02:00
Alexey Milovidov
364f10aff5 Remove trash 2022-04-15 22:56:51 +02:00
Alexey Milovidov
58fc4e033a Remove trash 2022-04-15 22:54:08 +02:00
Larry Luo
01955fd221 Use upper case salt and address style check error 2022-04-15 16:46:47 -04:00
alesapin
1706ae9e15 Some trash implementation 2022-04-15 18:36:23 +02:00
alesapin
5a8419a48e Remove more trash 2022-04-15 17:05:17 +02:00
alesapin
eb7593f786 Remove more trash 2022-04-15 16:24:38 +02:00
alesapin
2fcc00380d Get rid of iheritance 2022-04-15 14:00:52 +02:00
alesapin
40e5ba21a4
Update src/Common/FileSegment.cpp 2022-04-15 11:55:05 +02:00
zhanglistar
fe93fd83f5
Merge branch 'ClickHouse:master' into fixhdfsreadbuffer 2022-04-15 16:27:20 +08:00
zhanglistar
e22a175afb Fix ReadBufferFromHDFS crash in debug mode 2022-04-15 14:04:30 +08:00
Yakov Olkhovskiy
51b4cef6f8
Merge pull request #36101 from awakeljw/fork_chmaster
Auto assign numbers for Enum elements
2022-04-14 23:53:03 -04:00
Rajkumar
883eea5318 code review comments addressing 2022-04-14 17:06:13 -07:00
avogar
ae01646136 Place new logic of schema inference in insert select from table function under setting 2022-04-14 19:05:20 +00:00
kssenii
d8e2d693e5 Allow missing columns for mongo storage 2022-04-14 19:31:07 +02:00
Kruglov Pavel
4bad2cd364
Merge pull request #36192 from Avogar/fix-parallel-read-buffer
Use atomic instead of mutex + condvar in ParallelReadBuffer
2022-04-14 18:36:16 +02:00
alesapin
c0317c818c Fix bug in keeper 2022-04-14 17:33:46 +02:00
Anton Popov
305dd57262
Merge branch 'master' into fix_storage_distributed_ttl 2022-04-14 14:51:15 +02:00
Alexander Tokmakov
819eac6297 fix 2022-04-14 14:48:24 +02:00
Nikolay Degterinsky
b36f810132
Merge pull request #36154 from bharatnc/ncb/h3Res0Indexes-fix
remove unused array in h3Res0Indexes func
2022-04-14 14:44:00 +02:00
tavplubix
3af2384066
Merge pull request #36190 from azat/revert-27002-mutation-stuck
Revert "Fix possible mutation stuck due to race with DROP_RANGE"
2022-04-14 15:03:35 +03:00
Anton Popov
c76b9cc9f5
Merge pull request #36215 from CurtizJ/fix-reading-empty-arrays
Fix reading of empty arrays in reverse order
2022-04-14 13:51:48 +02:00
kssenii
3e42a1711d Fix 2022-04-14 13:50:13 +02:00