Commit Graph

150203 Commits

Author SHA1 Message Date
Blargian
0bb8d1a8ed optimize formatting by 3% 2024-08-06 17:10:34 +02:00
Anton Popov
47953da08d fix reading of size column from missed Nested in compact parts 2024-08-06 15:08:40 +00:00
Jacob Reckhard
86e3b35f24 spelling fixes 2024-08-06 09:07:17 -06:00
Michael Stetsyuk
df2675fad0 [resubmit] add replication lag and recovery time metrics 2024-08-06 15:06:02 +00:00
Azat Khuzhin
bdfaffa9d7 tests: make test_distributed_inter_server_secret idempotent
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-06 16:59:23 +02:00
Sema Checherinda
35c297dc83 Merge branch 'master' into chesema-perf-matview 2024-08-06 16:57:25 +02:00
robot-clickhouse
e1e298f14e Automatic style fix 2024-08-06 14:57:04 +00:00
Max Kainov
f2591bd1a6 CI: CiBuddy with channel dispatcher 2024-08-06 16:55:04 +02:00
Robert Schulze
f20cfdb54e
Cosmetics III 2024-08-06 14:53:49 +00:00
Alexey Milovidov
9a297b31f5
Merge pull request #67113 from azat/tests/part_log_rmt_fetch_errors
Reintroduce 03002_part_log_rmt_fetch_*_error tests without flakiness and less time
2024-08-06 14:46:00 +00:00
Alexey Milovidov
2df8d6acde
Merge pull request #67423 from ClickHouse/bff
Fix bloom filter index breaking some queries
2024-08-06 14:45:44 +00:00
Alexey Milovidov
6c9d631727
Merge pull request #67589 from azat/tests/01811_storage_buffer_flush_parameters
Fix 01811_storage_buffer_flush_parameters flakiness
2024-08-06 14:43:17 +00:00
Azat Khuzhin
72bd43a309 tests: do not capture client stacktraces in stress tests
They are too uncontrollable, and likely will leave some clients [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/67737/9658be5eea8351655dd3ea77b8c1d4717bac7999/stress_test__ubsan_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-06 16:42:19 +02:00
Azat Khuzhin
7c366a040f ci: use bash arrays to pass opts to clickhouse-test for stateless/stateful
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-06 16:39:16 +02:00
Azat Khuzhin
8ce23ff113 tests: increase delay co capture client stacktraces for sanitizers build
5 seconds is too small and not enough to print even few frames.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/67737/9658be5eea8351655dd3ea77b8c1d4717bac7999/stress_test__ubsan_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-06 16:39:16 +02:00
Azat Khuzhin
ef7d12db66 tests: change the process group earlier to avoid killing self
Previously it was possible to have original pgid from the spawned
threads, that could lead to killing the caller script and in case of CI
it could be init process [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/67737/e68c9c8d16f37f6c25739076c9b071ed97952269/stress_test__asan_/stress_test_run_21.txt

Repro:

    $ echo "SELECT '1" > tests/queries/0_stateless/00001_select_1.sql # break the test
    $ cat /tmp/test.sh
    ./tests/clickhouse-test 0001_select --test-runs 3 --max-failures-chain 1 --no-random-settings --no-random-merge-tree-settings

Before this change:

    $ /tmp/test.sh
    Using queries from '/src/ch/worktrees/clickhouse-upstream/tests/queries' directory
    Connecting to ClickHouse server... OK
    Connected to server 24.8.1.1 @ bef896ce143ea4e0464c9829de6277ba06cc1a53 mt/rename-without-lock-v2
    Running 3 stateless tests (MainProcess).
    00001_select_1:                                                         [ FAIL ]
    Reason: return code:  62
    Code: 62. DB::Exception: Syntax error: failed at position 8 (''1;
    '): '1;
    . Single quoted string is not closed: ''1;
    '. (SYNTAX_ERROR)

    , result:

    stdout:

    Database: test_hz2zwymr
    Child processes of 13041:
    13042 python3 ./tests/clickhouse-test 0001_select --test-runs 3 --max-failures-chain 1 --no-random-settings --no-random-merge-tree-settings
    Killing process group 13040
    Processes in process group 13040:
    13040 -bash
    13042 python3 ./tests/clickhouse-test 0001_select --test-runs 3 --max-failures-chain 1 --no-random-settings --no-random-merge-tree-settings

    [2]+  Stopped                 /tmp/test.sh
    [1]$ Process group 13040 should be killed
    Max failures chain

    [2]+  Killed                  /tmp/test.sh

After:

    $ /tmp/test.sh
    Using queries from '/src/ch/worktrees/clickhouse-upstream/tests/queries' directory
    Connecting to ClickHouse server... OK
    Connected to server 24.8.1.1 @ bef896ce143ea4e0464c9829de6277ba06cc1a53 mt/rename-without-lock-v2
    Running 3 stateless tests (MainProcess).
    00001_select_1:                                                         [ FAIL ]
    Reason: return code:  62
    Code: 62. DB::Exception: Syntax error: failed at position 8 (''1;
    '): '1;
    . Single quoted string is not closed: ''1;
    '. (SYNTAX_ERROR)

    , result:

    stdout:

    Database: test_urz6rk5z
    Child processes of 9782:
    9785 python3 ./tests/clickhouse-test 0001_select --test-runs 3 --max-failures-chain 1 --no-random-settings --no-random-merge-tree-settings
    Max failures chain

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-06 16:39:16 +02:00
Azat Khuzhin
b76fb165d1 tests: fix pylint issue in clickhouse_execute_http()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-06 16:39:16 +02:00
Azat Khuzhin
a6ccf19869 tests: capture stderr/stdout/debuglog after terminating test
It was simply wrong before, but now, with capturing stacktrace that can
take sometime it is a must.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-06 16:39:16 +02:00
Azat Khuzhin
a478ad24a9 tests: try to catch stacktraces from client in case of test timeouts
This is to catch issues like [1].

  [1]: https://github.com/ClickHouse/ClickHouse/issues/67736

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-06 16:39:16 +02:00
Azat Khuzhin
f9dcce6da3 tests: omit python stacktace in case of signals/server died
It is simply useless and only create output that only distracts.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-06 16:39:16 +02:00
Azat Khuzhin
ea1575f60a tests: avoid leaving processes leftovers
Previously processes cleanup on i.e. SIGINT simply did not work, because
the launcher kills only processes in process group, while tests are
launched with start_new_session=True for Popen(), which creates own
process group.

This is needed for killing process group in case of test timeout.

So instead, look at the parent pid, and kill the child process groups.

Also add some logging to make it more explicit which processes will be
killed.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-06 16:39:16 +02:00
Sema Checherinda
0eb6a41f57 Merge branch 'master' into chesema-processor-onCancel 2024-08-06 16:36:28 +02:00
vdimir
a180bf311c
Merge pull request #67804 from ClickHouse/vdimir/fix_fliter_pushdown_no_keys
Fix filter pushdown for aggregation without keys
2024-08-06 14:35:50 +00:00
Nikolay Degterinsky
1126ae3e5a
Merge pull request #67560 from evillique/fix-timeout-stateless-tests
[CI] Check for timeout when we stop logs replication
2024-08-06 14:35:23 +00:00
vdimir
5c4f2c1985
Fix DateTime64 parsing after constant folding 2024-08-06 14:33:28 +00:00
Anton Popov
b99c6c1153 fix reading of size column from missed Nested in compact parts 2024-08-06 14:02:24 +00:00
Max Kainov
dbcc5cf133 CI: Changelog: Critical Bug Fix to Bug Fix 2024-08-06 15:39:08 +02:00
Nikita Taranov
f37fcb7768 impl 2024-08-06 14:32:20 +01:00
avogar
e0e32b5425 Fix tests 2024-08-06 13:26:12 +00:00
Anton Popov
ba3719dd09 Merge remote-tracking branch 'upstream/master' into HEAD 2024-08-06 13:25:16 +00:00
Alexey Milovidov
77fd21555f
Merge pull request #67910 from ClickHouse/auto/v24.6.3.95-stable
Update version_date.tsv and changelogs after v24.6.3.95-stable
2024-08-06 13:23:17 +00:00
Vasily Nemkov
f3ee25036f Building aarch64 builds with '-no-pie' to allow better introspection 2024-08-06 15:15:36 +02:00
avogar
dbfba5ebc4 Validate data types in ALTER ADD/MODIFY COLUMN 2024-08-06 12:57:57 +00:00
robot-clickhouse
e2eeb6f180 Update version_date.tsv and changelogs after v24.6.3.95-stable 2024-08-06 12:54:27 +00:00
Robert Schulze
d09c82ff76
Cosmetics II 2024-08-06 12:36:09 +00:00
Raúl Marín
996699c78c Make 01456_modify_column_type_via_add_drop_update parallelizable 2024-08-06 14:34:15 +02:00
Blargian
5313c9539e update documentation for Float32/64 and variants 2024-08-06 14:34:06 +02:00
Raúl Marín
47e4ea5982 Make 02984_form_format.sh parallelizable 2024-08-06 14:31:22 +02:00
Robert Schulze
2776a515ba
Cosmetics I 2024-08-06 12:29:54 +00:00
Max Kainov
913b902864 CI: Fix for setting Mergeable Check from sync 2024-08-06 14:11:37 +02:00
Alexey Milovidov
8301fa0b06
Merge pull request #67822 from ClickHouse/fix-bad-test-03032_redundant_equals
Fix bad test `03032_redundant_equals`
2024-08-06 12:01:31 +00:00
Sema Checherinda
851d4d3fdf adjust MIN_ITERATIONS 2024-08-06 13:56:37 +02:00
Igor Nikonov
feeb945461
Merge pull request #67389 from ClickHouse/pr-all-connection-failed
Try to fix: ALL_CONNECTION_TRIES_FAILED with parallel replicas
2024-08-06 11:37:23 +00:00
Anton Popov
860050eb3d
Update src/Disks/ObjectStorages/AzureBlobStorage/AzureBlobStorageCommon.cpp
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2024-08-06 13:30:23 +02:00
Sema Checherinda
874a7dbe37 adjust settings 2024-08-06 13:22:53 +02:00
Sema Checherinda
c896165e16 add min time 2024-08-06 13:22:53 +02:00
Sema Checherinda
244da49013 add max iteration 2024-08-06 13:22:53 +02:00
Sema Checherinda
523767c0c0 run 01171 test in parallel 2024-08-06 13:22:53 +02:00
Andrey Zvonov
7d45424d31 specify files in test: 2024-08-06 11:18:47 +00:00
Andrey Zvonov
97f1cfc232 add ** glob to hdfs docs 2024-08-06 11:18:47 +00:00