Commit Graph

134146 Commits

Author SHA1 Message Date
Julia Kartseva
17d2455448 Integration tests for adaptive async insert timeout
Add initial tests.
2024-02-01 22:45:09 +00:00
Julia Kartseva
4ef02a1895 Log timeout for entries processed asynchronously 2024-02-01 22:45:09 +00:00
Julia Kartseva
c04e5a4f35 Asynchronous insert queue size and bytes metrics
Add AsynchronousInsertQueueSize and AsynchronousInsertQueueBytes
metrics to improve observability of asynchronous inserts.
The metrics do not account for tasks dispatched for immediate processing
(as opposed to, e.g., PendingAsyncInsert).

```
SELECT value
FROM system.metrics
WHERE metric IN ('AsynchronousInsertQueueSize', 'PendingAsyncInsert')

Query id: a711dd83-b48d-4ad5-8031-fa59b21a7c38

┌─value─┐
│    18 │
│    23 │
└───────┘
```

```
SELECT value
FROM system.metrics
WHERE metric IN ('AsynchronousInsertQueueSize', 'AsynchronousInsertQueueBytes')

Query id: b35a7ceb-2bb5-46ad-b301-e6cf03508699

┌─value─┐
│    28 │
│  1372 │
└───────┘
```
2024-02-01 22:45:09 +00:00
Julia Kartseva
04c8bd1be5 Adaptive asynchronous insert timeouts
Implement the algorithm described in #56783 for adaptive asynchronous
insert timeouts.
- The adaptive async insert timeout can take values within
[async_insert_busy_timeout_min_ms, async_insert_busy_timeout_max_ms].
- The initial value is set to async_insert_busy_timeout_min_ms.
- If the elapsed time since the most recent queue insert was
  greater than the maximum timeout, process the queue content immediately,
  and reduce the timeout.
- If the elapsed time was long enough (longer than a would-be decreased
  timeout), decrease the timeout.
- The adaptive timeout is changes exponentially based on the
  async_insert_busy_timeout_{increase|decrease}_rate.

Fixes: https://github.com/ClickHouse/ClickHouse/issues/56783
2024-02-01 22:45:06 +00:00
Alexey Milovidov
3fcfcd469a
Merge pull request #59499 from ClickHouse/binary-better
Fixes for binary.html
2024-02-01 21:50:08 +01:00
Alexey Milovidov
15467f2efb
Merge pull request #59451 from ClickHouse/remove-unused-headers
CLion says these headers are unused
2024-02-01 21:47:17 +01:00
Nikita Taranov
d73abc17f5 better 2024-02-01 21:42:22 +01:00
Igor Nikonov
6c83508af1 Remove unused member 2024-02-01 19:51:07 +00:00
Nikita Taranov
698d00dbfe add to MutateTask 2024-02-01 20:43:43 +01:00
Alexey Milovidov
667256a67d Fixes for binary.html 2024-02-01 20:36:38 +01:00
Raúl Marín
a40be3ea11 Make MAX use the same rules as permutation for complex types 2024-02-01 20:22:33 +01:00
Alexey Milovidov
6100e4a0ca
Merge pull request #59479 from ClickHouse/revert-59386-update_libxml2
Revert "Update libxml2 version to address some bogus security issues"
2024-02-01 19:21:25 +01:00
Alexey Milovidov
847eb86298
Merge pull request #59299 from nickitat/upd_aws_sdk
Update AWS SDK to 1.11.234
2024-02-01 19:20:42 +01:00
Nikita Taranov
132c7362cf
Fix 00191_aggregating_merge_tree_and_final
It became flaky after we merged #39663. When external aggregation happens it seems like we get more than one part, and because we used `OPTIMIZE` without `FINAL` data wasn't properly merged.
`order by` on the line 12 is not needed by now, but let's add it just in case.
2024-02-01 18:51:05 +01:00
Igor Nikonov
c93a2cd2dd Remove unused header 2024-02-01 17:31:14 +00:00
Bhavna Jindal
ce31fa912b removed unnecessary method overloading and fixed documentation 2024-02-01 09:24:12 -08:00
Nikita Taranov
76f2ae08b5 collect stats build time 2024-02-01 18:16:09 +01:00
Nikita Taranov
4795149863 print stats once 2024-02-01 17:16:42 +01:00
Igor Nikonov
72ddc6af02 Remove unused includes 2024-02-01 15:47:13 +00:00
Kseniia Sumarokova
e029021696
Merge pull request #59446 from ClickHouse/s3-queue-allow-to-add-start-point
Allow to define a starting point for s3queue ordered mode at creation
2024-02-01 16:46:24 +01:00
Raúl Marín
1438dc2f2d
Merge pull request #59461 from Algunenano/parallel_replicas_cte_fix
Fix problem detected by UBSAN
2024-02-01 16:00:33 +01:00
János Benjamin Antal
a0935770bb Fix docs 2024-02-01 14:50:29 +00:00
Max Kainov
d322accd89 CI: fix workflow run_command in bugfix validation 2024-02-01 14:43:31 +00:00
János Benjamin Antal
20311791e0 Fix tests 2024-02-01 14:43:31 +00:00
János Benjamin Antal
e8c9500981 Update src/Parsers/ASTAlterQuery.cpp
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2024-02-01 14:43:31 +00:00
János Benjamin Antal
7c04a1a972 Test query formatting 2024-02-01 14:43:31 +00:00
János Benjamin Antal
1a4f56a61a Fix ASTAlterCommand::formatImpl in case of column specific settings modifications 2024-02-01 14:43:31 +00:00
Igor Nikonov
ecd85096d0 FIx typo 2024-02-01 14:12:11 +00:00
Nikolai Kochetov
7e77c52c75
Merge pull request #59375 from kitaisreal/poco-logger-small-refactoring
Poco Logger small refactoring
2024-02-01 14:52:00 +01:00
Raúl Marín
e6061fa9f9
Revert "Update libxml2 version to address some bogus security issues" 2024-02-01 14:46:16 +01:00
Alexey Milovidov
f52b08070f Merge branch 'master' into remove-unused-headers 2024-02-01 13:42:37 +01:00
Mikhail f. Shiryaev
81fe2f330c
Merge pull request #59444 from azat/fix-stripped-stacktraces
Fix stacktraces for binaries without debug symbols
2024-02-01 13:38:09 +01:00
Igor Nikonov
03976d860d Merge remote-tracking branch 'origin/master' into cleanup-connection-pool-surroundings 2024-02-01 12:25:42 +00:00
Igor Nikonov
03249f3efa Fixes & comments
staleness -> delay (double -> UInt32)
2024-02-01 12:24:24 +00:00
Robert Schulze
3243ea0b66
Remove cgroups v1 support to simplify the code going forward 2024-02-01 12:16:31 +00:00
Robert Schulze
ad0c0d8727
Factorize cgroup memory access code
This fixes the edge case that cgroup memory limit "0" is no longer
interpreted as "no limit" but as actual zero available memory, see (*).
The cgroup default setting "max" continues to be interpreted as "no
limit".

(*) https://docs.kernel.org/admin-guide/cgroup-v2.html
2024-02-01 12:15:51 +00:00
Robert Schulze
92a00d317c
Cosmetics 2024-02-01 12:14:03 +00:00
Alexander Gololobov
6e82dc81fc Use fixed seed in test 2024-02-01 13:03:20 +01:00
Robert Schulze
82a4fa0dfc
Smaller fixups 2024-02-01 11:58:43 +00:00
robot-ch-test-poll
97f715f8ee
Merge pull request #59459 from bobmoff/patch-1
Update configuration-files.md
2024-02-01 12:46:22 +01:00
robot-clickhouse
fe829cac48 Automatic style fix 2024-02-01 11:43:55 +00:00
taiyang-li
1d8de1d345 fix style 2024-02-01 19:39:22 +08:00
kssenii
3a16427e00 Fix test 2024-02-01 12:35:01 +01:00
Robert Schulze
b9ab377c7b
Merge remote-tracking branch 'ClickHouse/master' into order_by_bug_fix 2024-02-01 11:31:03 +00:00
Raúl Marín
18386f7fb9 Merge remote-tracking branch 'blessed/master' into parallel_replicas_cte_fix 2024-02-01 12:04:46 +01:00
Raúl Marín
b93f003b3e
Merge pull request #58216 from bigo-sg/fix_quantiles_gk_state
Fix quantilesGK bug
2024-02-01 11:58:02 +01:00
Alexey Milovidov
d43d151406
Merge pull request #59447 from azat/safe-rust
Safer Rust (catch panic with catch_unwind())
2024-02-01 11:52:17 +01:00
zhongyuankai
d076b13ac8 order by all doesn't work for select * 2024-02-01 18:51:54 +08:00
Raúl Marín
a0222c0479 Fix problem detected by UBSAN 2024-02-01 11:46:59 +01:00
vdimir
a043227685
Fix ARRAY JOIN with subcolumns in analyzer 2024-02-01 10:36:31 +00:00