Maksim Kita
06fe6f3c8b
Merge pull request #31796 from kitaisreal/identifier-resolver
...
Added Analyzer
2022-10-25 12:36:08 +03:00
Nikolay Degterinsky
62a33b12d5
Small refactor
2022-10-25 11:24:42 +02:00
Nikolay Degterinsky
b63ac4826b
Merge branch 'master' into fix-aliases
2022-10-25 10:34:52 +02:00
Alexey Milovidov
90c62fe46e
Merge branch 'master' into revert-41726-fix-slow-json-extract-with-low-cardinality
2022-10-25 09:31:46 +02:00
Robert Schulze
efd47c9eff
Merge pull request #42476 from ClickHouse/add-datetime-typedefs
...
Add convenience typedefs for Date/Date32/DateTime/DateTime64 columns
2022-10-25 08:45:57 +02:00
Alexey Milovidov
4ac34117ac
Merge pull request #42635 from CurtizJ/fix-build
...
Fix build
2022-10-25 08:40:57 +02:00
Alexey Milovidov
c48127534b
Merge pull request #41753 from pkit/morton_coding
...
add Morton Coding (ZCurve)
2022-10-25 06:10:37 +02:00
Alexey Milovidov
079ffa9827
Merge pull request #42353 from azat/build/musl-static
...
Make getResource() independent from the order of the sections
2022-10-25 05:57:22 +02:00
Anton Popov
e30d425869
fix build
2022-10-25 01:55:02 +00:00
Nikolay Degterinsky
8a9cfa9b17
Merge branch 'master' into fix-aliases
2022-10-25 02:28:40 +02:00
Anton Popov
cbfa887e52
fix merge of projections
2022-10-24 23:51:57 +00:00
Anton Popov
eed21ad4ca
Revert "Low cardinality cases moved to the function for its corresponding type"
2022-10-25 01:30:32 +02:00
Anton Popov
f865b28da4
fix drop of MergeTree tables
2022-10-24 22:38:53 +00:00
Guo Wangyang
4e294b9bfc
ColumnVector: re-enable AVX512_VBMI/AVX512_VBMI2 optimized filter and index ( #41765 )
...
* Revert "Merge pull request #41752 from ClickHouse/revert-revert-revert"
This reverts commit 7bb245720a
, reversing
changes made to 78002dc248
.
* Revert "Merge pull request #41797 from ClickHouse/revert-41247"
This reverts commit 69b13d9f31
, reversing
changes made to 1719e000ea
.
* AVX512VBMI::vectorIndexImpl: Fix heap buffer overflow when limit == 0
* use SIMD_ELEMENTS instead of SIMD_BYTES to avoid confusing
2022-10-24 23:11:46 +02:00
Nikolay Degterinsky
171ed8dd4e
Apply suggestions from review
2022-10-24 20:38:04 +00:00
Alexey Milovidov
9ee7131f67
Merge pull request #42423 from ClickHouse/optimize-partitions-in-background
...
Optimize partitions in background
2022-10-24 19:41:50 +02:00
Anton Popov
b58ca49f05
fix bad cast in arrayElement with Map and Nullable index
2022-10-24 17:34:46 +00:00
Robert Schulze
655233e1c5
Add convenience typedefs for Date/Date32/DateTime/DateTime64 columns
2022-10-24 16:55:41 +00:00
SmitaRKulkarni
96c8260230
Merge branch 'master' into 36316_Support_glob_for_recursive_directory_traversal
2022-10-24 18:34:19 +02:00
Anton Popov
dcb7667808
share transaction for projections
2022-10-24 16:28:19 +00:00
Sergei Trifonov
bef3c71453
Merge pull request #41726 from AlfVII/fix-slow-json-extract-with-low-cardinality
...
Low cardinality cases moved to the function for its corresponding type
2022-10-24 18:18:40 +02:00
Nikolai Kochetov
93310fe8b1
Fix typo.
2022-10-24 15:51:21 +00:00
Nikolai Kochetov
d5bd905a41
Try to fix data race on zookeeper vs DDLWorker at server shutdown.
2022-10-24 15:09:35 +00:00
Anton Popov
128fdd785e
better interface
2022-10-24 14:44:22 +00:00
Maksim Kita
d0e64eb15b
Fixed tests
2022-10-24 16:14:05 +02:00
Nikolai Kochetov
14e3bb6354
Another case.
2022-10-24 13:58:26 +00:00
Nikolai Kochetov
5dabbf89ad
Fixing build.
2022-10-24 13:43:24 +02:00
Vitaly Baranov
cd158b021f
Merge pull request #42562 from vitlibar/subqueries-in-row-policy-filters
...
Fix using subqueries in row policy filters
2022-10-24 13:38:15 +02:00
Han Fei
8f00d0d1cc
fix tidy
2022-10-24 12:56:36 +02:00
Nikolai Kochetov
aee7bb0d91
Merge pull request #42577 from ClickHouse/clean-thread-id
...
Clear thread::id when ThreadFromGlobalPool exits.
2022-10-24 12:03:28 +02:00
filimonov
0762783fbd
Fix incorrect trace log line on dict reload
2022-10-24 11:58:37 +02:00
Robert Schulze
240637f8f1
Merge branch 'master' into update-libcxx-to-15
2022-10-24 11:11:01 +02:00
Antonio Andelic
5579d139eb
Avoid crash with big int in prewhere
2022-10-24 08:37:52 +00:00
Maksim Kita
9a02d25c0b
Fixed tests
2022-10-24 10:22:38 +02:00
Maksim Kita
3862dd96fe
Fixed tests
2022-10-24 10:22:38 +02:00
Maksim Kita
8ac7f4423b
Fixed tests
2022-10-24 10:22:38 +02:00
Maksim Kita
d083200d65
Fixed code review issues
2022-10-24 10:22:38 +02:00
Maksim Kita
561d585100
Fixed tests
2022-10-24 10:22:38 +02:00
Maksim Kita
39b2d25a43
Added tests
2022-10-24 10:22:38 +02:00
Maksim Kita
90048ce75d
Fixed code review issues
2022-10-24 10:22:38 +02:00
Maksim Kita
dbc0870eb5
Fixed tests
2022-10-24 10:22:38 +02:00
Maksim Kita
82fae0125c
Added FullSortingMerge JOIN support
2022-10-24 10:22:38 +02:00
Maksim Kita
1410befbe1
Added AggregateFunctionsArithmeticOperationsPass
2022-10-24 10:22:38 +02:00
Maksim Kita
144b33c75d
Fixed tests
2022-10-24 10:22:38 +02:00
Maksim Kita
852dd8c2bb
Updated UnionNode documentation
2022-10-24 10:22:37 +02:00
Maksim Kita
8610feb06d
Added UniqInjectiveFunctionsEliminationPass
2022-10-24 10:22:37 +02:00
Maksim Kita
c82bb1128f
Fixed nested IN functions
2022-10-24 10:22:37 +02:00
Maksim Kita
fe3eda4c2b
Added SumIfToCountIfPass
2022-10-24 10:22:37 +02:00
Maksim Kita
43ec5c830c
Added FunctionToSubcolumnsPass
2022-10-24 10:22:37 +02:00
Maksim Kita
98eba24a34
Fix LIMIT when query has WITH TOTALS
2022-10-24 10:22:37 +02:00
Maksim Kita
f4e59b217f
Added RBAC support
2022-10-24 10:22:37 +02:00
Maksim Kita
b50e2ce470
Added SETTINGS support
2022-10-24 10:22:37 +02:00
Maksim Kita
5a0298ea34
Fixed tests
2022-10-24 10:22:37 +02:00
Maksim Kita
da85af7e44
Added OrderByLimitByDuplicateEliminationPass
2022-10-24 10:22:37 +02:00
Maksim Kita
7851dfc324
Fixed tests
2022-10-24 10:22:37 +02:00
Maksim Kita
eba9607696
Analyzer move passes into separate folder
2022-10-24 10:22:37 +02:00
Maksim Kita
3a22e37691
Fix normalization of UNION inside DESCRIBE query
2022-10-24 10:22:37 +02:00
Maksim Kita
77ea9a11cd
Fixed code review issues
2022-10-24 10:22:21 +02:00
Maksim Kita
6ec5474466
Updated IQueryTreeNode interface with weak pointers array
2022-10-24 10:22:21 +02:00
Maksim Kita
2f282eeec9
Updated InDepthQueryTreeVisitor implementation
2022-10-24 10:22:21 +02:00
Maksim Kita
49a129008b
Fixed code review issues
2022-10-24 10:22:21 +02:00
Maksim Kita
239f1855aa
Updated projection names implementation
2022-10-24 10:22:21 +02:00
Maksim Kita
048e776c48
Fixed tests
2022-10-24 10:22:21 +02:00
Maksim Kita
400de59a37
Fixed style check
2022-10-24 10:22:21 +02:00
Maksim Kita
86896b76c5
Fix GROUP BY validation for subqueries
2022-10-24 10:22:21 +02:00
Maksim Kita
0892f485bb
Fix lambda tests
2022-10-24 10:22:21 +02:00
Maksim Kita
f2d801be2c
Added CustomizeFunctionsPass
2022-10-24 10:22:21 +02:00
Maksim Kita
b1471bdedf
Added CountDistinctPass
2022-10-24 10:22:21 +02:00
Maksim Kita
2aff015d29
Added NormalizeCountVariantsPass
2022-10-24 10:22:21 +02:00
Maksim Kita
54e2b6d28a
Added EXISTS support
2022-10-24 10:22:21 +02:00
Maksim Kita
f5ee7e0bee
Added IfChainToMultiIfPass
2022-10-24 10:22:21 +02:00
Maksim Kita
7c96c0afbd
Added OrderByTupleEliminationPass
2022-10-24 10:22:21 +02:00
Maksim Kita
11324aa4b4
Added IfConstantConditionPass
2022-10-24 10:22:21 +02:00
Maksim Kita
3d5b209861
Added support for dictGet, joinGet functions to handle identifier as first argument
2022-10-24 10:22:21 +02:00
Maksim Kita
7f26bcc275
Added unqualified matcher support for JOIN with USING
2022-10-24 10:22:21 +02:00
Maksim Kita
b7d0fd6bae
Added validation for subqueries and table functions in JOINs
2022-10-24 10:22:21 +02:00
Maksim Kita
d62bd792ac
Added positional arguments support
2022-10-24 10:22:21 +02:00
Maksim Kita
10438aea01
Added JOIN support for different algorithm
2022-10-24 10:22:21 +02:00
Maksim Kita
a0d9251f3a
Added ASOF join support
2022-10-24 10:22:21 +02:00
Maksim Kita
3782aed7a9
Separate planner expression analysis
2022-10-24 10:22:20 +02:00
Maksim Kita
8a39c3e1d5
Separate planner JOIN TREE processing
2022-10-24 10:22:20 +02:00
Maksim Kita
c7d51ca83d
Rename InterpolateColumnNode into InterpolateNode
2022-10-24 10:22:20 +02:00
Maksim Kita
2b2a70082e
Rename SortColumnNode into SortNode
2022-10-24 10:22:20 +02:00
Maksim Kita
fe84e871f8
Fixed build
2022-10-24 10:22:20 +02:00
Maksim Kita
8cadb1b318
Added WINDOW functions support
2022-10-24 10:22:20 +02:00
Maksim Kita
85ac02c9db
Planner improve action names
2022-10-24 10:22:20 +02:00
Maksim Kita
890d9678b9
Fixed tests
2022-10-24 10:22:20 +02:00
Maksim Kita
a06832508e
Fixed tests
2022-10-24 10:22:20 +02:00
Maksim Kita
4f68305dbe
Fixed tests
2022-10-24 10:22:20 +02:00
Maksim Kita
ca93ee7479
Fixed tests
2022-10-24 10:22:20 +02:00
Maksim Kita
fc860ec050
Planner collect table expression data
2022-10-24 10:22:20 +02:00
Maksim Kita
1844673aa8
Updated tests
2022-10-24 10:22:20 +02:00
Maksim Kita
fed146e198
Added SAMPLE BY support. Added SAMPLE BY, FINAL support for JOINS.
2022-10-24 10:22:20 +02:00
Maksim Kita
5128262129
Added GROUP BY with constant keys support
2022-10-24 10:22:20 +02:00
Maksim Kita
64c60718f8
Updated SORT COLUMN with fill
2022-10-24 10:22:20 +02:00
Maksim Kita
4110460bcd
Added LIMIT BY support
2022-10-24 10:22:20 +02:00
Maksim Kita
81e4c67f17
Added INTERPOLATE support
2022-10-24 10:22:20 +02:00
Maksim Kita
504cb2b38f
Added GROUPING function support
2022-10-24 10:22:20 +02:00
Maksim Kita
a5ce4d7823
Added GROUPING SETS support
2022-10-24 10:22:20 +02:00
Maksim Kita
63e48bd869
Added GROUP BY CUBE, ROLLUP, TOTALS support
2022-10-24 10:22:20 +02:00
Maksim Kita
216250824b
Added extremes support
2022-10-24 10:22:20 +02:00
Maksim Kita
80b77f4ccc
Added HAVING support
2022-10-24 10:22:20 +02:00
Maksim Kita
c087eff470
Perform GROUP BY and aggregates validation during analysis stage
2022-10-24 10:22:20 +02:00
Maksim Kita
ea44b4be5e
Added subquery_depth support
2022-10-24 10:22:20 +02:00
Maksim Kita
2b571004f3
Added support for projection names
2022-10-24 10:22:19 +02:00
Maksim Kita
efc2433347
Added IN function Set table support
2022-10-24 10:22:19 +02:00
Maksim Kita
de1f470cfe
Planner simplified creation of sets for IN function
2022-10-24 10:22:19 +02:00
Maksim Kita
1cbf96d165
Added LIMIT, OFFSET support
2022-10-24 10:22:19 +02:00
Maksim Kita
ce9ea7ca0b
Fixed tests
2022-10-24 10:22:19 +02:00
Maksim Kita
6aa166f366
Added ORDER BY support
2022-10-24 10:22:19 +02:00
Maksim Kita
03864790ad
Added DISTINCT support
2022-10-24 10:22:19 +02:00
Maksim Kita
5c6d175028
Added GROUP BY support
2022-10-24 10:22:19 +02:00
Maksim Kita
2995fb7944
Added support for building sets for IN function
2022-10-24 10:22:19 +02:00
Maksim Kita
44ada63a97
Added Planner
2022-10-24 10:22:19 +02:00
Maksim Kita
85193ede42
Added UNION support
2022-10-24 10:22:19 +02:00
Maksim Kita
0da0019634
Added ARRAY JOIN support
2022-10-24 10:22:19 +02:00
Maksim Kita
89e5b09e7f
Updated JOIN tests
2022-10-24 10:22:19 +02:00
Maksim Kita
b32092f24a
JOIN support join_use_nulls, USING
2022-10-24 10:22:19 +02:00
Maksim Kita
40cb904a3d
Added support for JOIN, ARRAY JOIN
2022-10-24 10:22:19 +02:00
Maksim Kita
1717d16fa4
Improved lambda matcher support
2022-10-24 10:22:19 +02:00
Maksim Kita
062e17052f
Added support for IN function
2022-10-24 10:22:19 +02:00
Maksim Kita
2148d0e58d
Added support for arrayJoin function
2022-10-24 10:22:19 +02:00
Maksim Kita
a9e1f74696
Added support for grouping function
2022-10-24 10:22:19 +02:00
Maksim Kita
635bd44413
Added support for table functions
2022-10-24 10:22:18 +02:00
Maksim Kita
569fb36097
Added support for table ALIAS columns
2022-10-24 10:22:18 +02:00
Maksim Kita
603c4febc3
Update explain query tree representation
2022-10-24 10:22:18 +02:00
Maksim Kita
dd28b58864
Added support for subqueries
2022-10-24 10:22:18 +02:00
Maksim Kita
6a5276e45e
Updated tests
2022-10-24 10:22:18 +02:00
Maksim Kita
2d61c45f94
Added support for multiple expressions with same alias
2022-10-24 10:22:18 +02:00
Maksim Kita
d835f70fdc
Added support for STRICT column transformers
2022-10-24 10:22:18 +02:00
Maksim Kita
9d4c508b39
Added lambda tests
2022-10-24 10:22:18 +02:00
Maksim Kita
75885ce2e1
Added Analyzer
2022-10-24 10:22:18 +02:00
Alexey Milovidov
f84ed91d10
Merge pull request #42598 from ClickHouse/evillique-patch-1
...
Fix possible segfault in expression parser
2022-10-24 09:26:42 +02:00
Antonio Andelic
e363e27eef
Merge pull request #42532 from ClickHouse/fix-data-race
...
Fix `KeeperTCPHandler` data race
2022-10-24 09:14:34 +02:00
Robert Schulze
c119cd2f00
Merge branch 'master' into update-libcxx-to-15
2022-10-24 08:29:37 +02:00
Azat Khuzhin
27494aea63
Make getResource() independent from the order of the sections
...
It is possible for end section goes before begin section for some
resource, and this case it will not find it.
This is what happens here [1]:
[1]: https://s3.amazonaws.com/clickhouse-test-reports/41988/053fec3f451e97ac41b6c223d95013b758a9a330/fast_test.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-24 07:10:45 +02:00
Anton Popov
cf375c9732
better interface
2022-10-23 22:29:24 +00:00
Han Fei
4a8326ff0c
fix typo
2022-10-23 23:22:52 +02:00
Nikolay Degterinsky
dd98608b78
Fix segfault in expression parser
2022-10-23 19:49:00 +02:00
Anton Popov
b40d9200d2
better semantic of constsness of DataPartStorage
2022-10-23 15:24:20 +00:00
Igor Nikonov
c0d1be9cab
Merge pull request #42560 from ClickHouse/igor/replicated_merge_tree_some_polishing
...
Some polishing: replicated merge tree
2022-10-23 15:15:24 +02:00
Azat Khuzhin
bcc8d9f9d9
Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32
...
* upstream/master:
Fix strange code in date monotonicity
Add a test
Fix error
Add tests
Remove trash
2022-10-23 07:45:10 +02:00
Azat Khuzhin
f18ac40be5
Fix clang-tidy cert-dcl58-cpp in gtest_DecimalFunctions
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-23 07:44:37 +02:00
Quanfa Fu
b07f65343d
Add functions: domainRFC, topLevelDomainRFC, domainWithoutWWWRFC...
2022-10-23 12:01:26 +08:00
Anton Popov
56e5daba0c
remove DataPartStorageBuilder
2022-10-23 00:23:15 +00:00
Alexey Milovidov
ebf330ca1a
Merge pull request #42573 from ClickHouse/remove-trash-6
...
Remove trash
2022-10-23 01:31:10 +02:00
Alexey Milovidov
6c69bdd34d
Merge pull request #42574 from ClickHouse/strange-date-monotonicity
...
Fix strange code in date monotonicity
2022-10-23 01:30:52 +02:00
Azat Khuzhin
3e5a90478e
Fix clang-tidy issue in gtest_DecimalFunctions
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-22 23:32:27 +02:00
Azat Khuzhin
a63dee2763
Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32
2022-10-22 23:32:15 +02:00
Igor Nikonov
730a3ba849
Merge branch 'master' into igor/replicated_merge_tree_some_polishing
2022-10-22 19:54:09 +02:00
Han Fei
2fc91fd338
fix behaviour of max_rows_to_read for trival limit queries
2022-10-22 18:27:24 +02:00
flynn
cd7a48215c
Fix create set with wrong header when data type is lowcardinality
2022-10-22 16:17:05 +00:00
Robert Schulze
b746224217
Merge pull request #42554 from arenadata/ADQM-604
...
Add support of Date32 arguments for dateName function
2022-10-22 17:20:10 +02:00
Azat Khuzhin
56bc85746f
Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32
...
Conflicts:
- src/Interpreters/ProcessList.cpp
2022-10-22 16:49:08 +02:00
Nikolai Kochetov
06d46ca51b
Clear thread::id when ThreadFromGlobalPool exits.
2022-10-22 13:28:22 +00:00
Nikolai Kochetov
5c32cd157d
Merge pull request #42362 from ClickHouse/fix-race-condition-finish-cancel
...
Fix data race in query finish/cancel
2022-10-22 14:58:42 +02:00
Azat Khuzhin
e3e30a4457
Fix one clang-tidy issue
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-22 13:26:58 +02:00
Amos Bird
f104dd08cd
Only fix LowCardinality for now
2022-10-22 15:47:13 +08:00
Alexey Milovidov
7bf1f4cdfa
Fix strange code in date monotonicity
2022-10-22 09:02:20 +02:00
Azat Khuzhin
dbb4f8216f
Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32
...
Conflicts:
- src/Functions/GregorianDate.h
2022-10-22 08:20:05 +02:00
Alexey Milovidov
7fc3cd7fb0
Fix error
2022-10-22 07:38:22 +02:00
Alexey Milovidov
ef4b2b3f59
Remove trash
2022-10-22 07:25:37 +02:00
Alexey Milovidov
5fd7409ce1
Merge branch 'master' into morton_coding
2022-10-22 04:39:13 +02:00
Alexey Milovidov
acc96a5ace
Merge pull request #42464 from ClickHouse/julian_day_ubsan
...
Fix UBSan report in Julian Day functions
2022-10-22 04:15:12 +02:00
Nikolai Kochetov
80867cb1fe
Add more trash.
2022-10-21 22:19:06 +00:00
Azat Khuzhin
4eeb7337ed
Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32
...
Conflicts:
- src/Common/intExp.h
- src/Functions/DateTimeTransforms.h
- src/Functions/FunctionsConversion.h
2022-10-21 22:51:56 +02:00
Azat Khuzhin
bbcdedb945
Revert changes of hash functions signatures and fix callers
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 22:40:17 +02:00
Azat Khuzhin
905a95e166
Review fixes
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 22:40:13 +02:00
Alexey Milovidov
592fbb3eaf
Merge pull request #42367 from ClickHouse/revert-40217
...
Revert #40217
2022-10-21 21:56:15 +02:00
Alexey Milovidov
3beace607b
Merge pull request #42465 from ClickHouse/decimal-asan
...
Fix buffer overflow in Decimal scale
2022-10-21 21:55:20 +02:00
Arthur Passos
615b73773a
removing unwanted files
2022-10-21 14:46:10 -03:00
Arthur Passos
e2fcd51c93
what
2022-10-21 14:43:08 -03:00
Kseniia Sumarokova
c0889e5832
Merge pull request #42418 from KinderRiven/max_cache_download_limit
...
Supports limiting the size of cached data to avoid negative optimization
2022-10-21 19:36:08 +02:00
Arthur Passos
2c41c0357d
Make CaresPTRResolver completely thread-safe
2022-10-21 14:32:48 -03:00
Alexander Tokmakov
7d11054134
Merge branch 'master' into fix_ares_fd_process_race_condition
2022-10-21 18:27:22 +03:00
Vitaly Baranov
2033ea1216
Support subqueries in row policy filters.
2022-10-21 15:42:29 +02:00
Igor Nikonov
851f556d65
Remove unused parameter
2022-10-21 14:35:37 +02:00
Igor Nikonov
13d31eefbc
Replicated merge tree polishing
...
+ make read-only members const
+ reduce memory allocations
2022-10-21 14:02:52 +02:00
Azat Khuzhin
5094c0dd6d
Fix clang-tidy performance-inefficient-vector-operation
...
By some reason it appears only after static_cast<> was added [1]:
/build/src/Processors/Formats/Impl/AvroRowInputFormat.cpp
Oct 18 01:03:56 /build/src/Processors/Formats/Impl/AvroRowInputFormat.cpp:351:21: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
Oct 18 01:03:56 symbols.push_back(root_node->nameAt(i));
Oct 18 01:03:56 ^
Oct 18 01:03:56 /build/src/Processors/Formats/Impl/AvroRowInputFormat.cpp:511:17: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
Oct 18 01:03:56 union_skip_fns.push_back(createSkipFn(root_node->leafAt(i)));
Oct 18 01:03:56 ^
Oct 18 01:03:56 /build/src/Processors/Formats/Impl/AvroRowInputFormat.cpp:552:17: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
Oct 18 01:03:56 field_skip_fns.push_back(createSkipFn(root_node->leafAt(i)));
Oct 18 01:03:56 ^
Oct 18 01:03:56 197965 warnings generated.
[1]: https://s3.amazonaws.com/clickhouse-builds/42190/453d91fa3539882dcef1d5ecd5097747499572d8/clickhouse_special_build_check/report.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:43 +02:00
Azat Khuzhin
3d400068fd
tests/gtest_compressionCodec: fix UBSAN report to avoid test failure
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:43 +02:00
Azat Khuzhin
2474303aef
tests/gtest_compressionCodec: Fix UBSAN report about signed integer overflow
...
UBSAN report:
$ UBSAN_SYMBOLIZER_PATH=/usr/bin/llvm-symbolizer-14 UBSAN_OPTIONS=print_stacktrace=1 ./unit_tests_dbms --gtest_filter=*Gorilla*
../src/Compression/tests/gtest_compressionCodec.cpp:1216:47: runtime error: signed integer overflow: 23 * 100000000 cannot be represented in type 'int'
#0 0x14f67fd1 in auto (anonymous namespace)::$_6::operator()(int) const::'lambda'(auto)::operator()<int>(auto) const build_docker/../src/Compression/tests/gtest_compressionCodec.cpp:1216:47
#1 0x14f67fd1 in (anonymous namespace)::CodecTestSequence (anonymous namespace)::generateSeq<long, (anonymous namespace)::$_6::operator()(int) const::'lambda'(auto), int, int>((anonymous namespace)::$_6::operator()(int) const::'lambda'(auto), char const*, int, int) build_docker/../src/Compression/tests/gtest_compressionCodec.cpp:394:36
#2 0x14f67fd1 in auto (anonymous namespace)::GCompatibilityTestSequence<long>() build_docker/../src/Compression/tests/gtest_compressionCodec.cpp:1224:12
#3 0x14f3c7f3 in (anonymous namespace)::gtest_GorillaCodecTestCompatibility_EvalGenerator_() build_docker/../src/Compression/tests/gtest_compressionCodec.cpp:1227:1
#4 0x14f6bdb5 in testing::internal::ParameterizedTestSuiteInfo<(anonymous namespace)::CodecTestCompatibility>::RegisterTests() build_docker/../contrib/googletest/googletest/include/gtest/internal/gtest-param-util.h:553:45
#5 0x27d87988 in testing::internal::ParameterizedTestSuiteRegistry::RegisterTests() build_docker/../contrib/googletest/googletest/include/gtest/internal/gtest-param-util.h:726:24
#6 0x27d87988 in testing::internal::UnitTestImpl::RegisterParameterizedTests() build_docker/../contrib/googletest/googletest/src/gtest.cc:2805:34
#7 0x27d87988 in testing::internal::UnitTestImpl::PostFlagParsingInit() build_docker/../contrib/googletest/googletest/src/gtest.cc:5492:5
#8 0x27d9d002 in void testing::internal::InitGoogleTestImpl<char>(int*, char**) build_docker/../contrib/googletest/googletest/src/gtest.cc:6499:22
#9 0x14fd5495 in main build_docker/../src/Coordination/tests/gtest_coordination.cpp:2189:5
#10 0x7f8c29005209 (/lib/x86_64-linux-gnu/libc.so.6+0x29209) (BuildId: 71a7c7b97bc0b3e349a3d8640252655552082bf5)
#11 0x7f8c290052bb in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x292bb) (BuildId: 71a7c7b97bc0b3e349a3d8640252655552082bf5)
#12 0x14ce356d in _start (/work1/azat/tmp/42190/unit_tests_dbms+0x14ce356d) (BuildId: 482550e3f8d45f06e8c7f8147f427ee798c1f645)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../src/Compression/tests/gtest_compressionCodec.cpp:1216:47 in
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:43 +02:00
Azat Khuzhin
784f7d988c
Fix -Wshorten-64-to-32 in examples
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:43 +02:00
Azat Khuzhin
b8ab686561
tests/gtest_compressionCodec: fix for darwin
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:43 +02:00
Azat Khuzhin
4412f66709
tests/gtest_DecimalFunctions: fix due to incorrect cast in wide_integer
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:43 +02:00
Azat Khuzhin
f14645a94f
tests/gtest_DecimalFunctions: fix operator<<
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:43 +02:00
Azat Khuzhin
15bcd6250a
Fix -Wshorten-64-to-32 for darwin builds
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:42 +02:00
Azat Khuzhin
3ccd5e8a18
Fix -Wshorten-64-to-32 with USE_BLAKE3
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:42 +02:00
Azat Khuzhin
089bf39132
Fix -Wshorten-64-to-32 for musl
...
On musl uint_fast32_t is uint32_t, while for glibc it is unsigned long
long.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:42 +02:00
Azat Khuzhin
4e76629aaf
Fixes for -Wshorten-64-to-32
...
- lots of static_cast
- add safe_cast
- types adjustments
- config
- IStorage::read/watch
- ...
- some TODO's (to convert types in future)
P.S. That was quite a journey...
v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:19 +02:00
Robert Schulze
2d448c139c
Merge pull request #42308 from arenadata/ADQM-584
...
Add support of Date32 arguments for date_diff function
2022-10-21 13:18:44 +02:00
Nikita Taranov
abd585a38a
Increase threshold for using physical cores ( #42503 )
2022-10-21 12:52:46 +02:00
Antonio Andelic
f3016fb86b
Throw exception on invalid values
2022-10-21 09:15:24 +00:00
Antonio Andelic
3091d609fa
Merge branch 'master' into optimize-partitions-in-background
2022-10-21 11:01:41 +02:00
Antonio Andelic
13480f940b
Handle 4LW correctly
2022-10-21 07:29:00 +00:00
Antonio Andelic
73e16ad55a
Fix KeeperTCPHandler data race
2022-10-21 07:29:00 +00:00
Amos Bird
1a462fddea
Fix test
2022-10-21 13:28:24 +08:00
Suzy Wang
ca3b6f602f
Merge branch 'master' into formatIpv6_s390x_support
2022-10-21 00:28:50 -04:00
Alexey Milovidov
48694def2c
Merge branch 'master' into revert-40217
2022-10-21 05:49:34 +02:00
Alexey Milovidov
ee5f5a4cb4
Unfathomable amount of trash
2022-10-21 05:33:17 +02:00
Alexey Milovidov
ff26251477
Merge branch 'master' into fix-race-condition-finish-cancel
2022-10-21 04:14:21 +02:00