Commit Graph

64106 Commits

Author SHA1 Message Date
Kseniia Sumarokova
0369aaea87
Merge pull request #69092 from 1on/master
Ability to limit columns for tables in MaterializedPostgreSQL
2024-09-17 11:08:05 +00:00
Kseniia Sumarokova
3f663f8e09
Merge pull request #68821 from joelynch/joelynch/disk-encrypted-missing-method
Fix zero copy bug with encrypted disk and UNFREEZE
2024-09-17 11:05:14 +00:00
Kseniia Sumarokova
64106e7b3c
Merge pull request #68696 from ucasfl/minor
Use proper ErrorCodes, replace NETWORK_ERROR by HDFS_ERROR
2024-09-17 10:57:30 +00:00
Vitaly Baranov
983b061b58 Corrections after review. 2024-09-17 12:56:10 +02:00
kssenii
3a299f382d Refactor 2024-09-17 12:52:45 +02:00
Vitaly Baranov
1ccd461c97 Fix restoring access entities dependant on existing ones. 2024-09-17 12:10:31 +02:00
Michael Stetsyuk
5aaff37b36 sync changes to InterpreterDropQuery::executeToDatabaseImpl from the private fork 2024-09-17 09:16:52 +00:00
Antonio Andelic
9f932fb453 Merge branch 'master' into keeper-better-ssl-support 2024-09-17 10:52:35 +02:00
Antonio Andelic
f3654b8fc8 Merge branch 'master' into keeper-some-improvement2 2024-09-17 10:35:38 +02:00
Antonio Andelic
676b6238d0 Update comments 2024-09-17 10:30:39 +02:00
Antonio Andelic
e876997ebb Merge branch 'master' into keeper-some-improvement2 2024-09-17 10:28:02 +02:00
Nikolai Kochetov
e7eaa01bb3
Merge pull request #69298 from ClickHouse/array-join-step-refactoring
Refactor ArrayJoin step.
2024-09-17 08:26:09 +00:00
Antonio Andelic
52dc9a54a7
Merge pull request #69627 from ClickHouse/keeper-fix-multi-no-auth
Fix Keeper multi request preprocessing with NOAUTH
2024-09-17 06:48:07 +00:00
Konstantin Bogdanov
a329150eef
Merge pull request #69601 from ClickHouse/fix-tsan-writebufferfromhttpserverresponse
Try to fix data race in `WriteBufferFromHTTPServerResponse`
2024-09-17 00:23:17 +00:00
pufit
7b94dc1813
Merge pull request #65277 from arthurpassos/multi_auth_methods
Multi auth methods
2024-09-16 23:53:33 +00:00
Konstantin Bogdanov
6a26c5cf8e
Fix 2024-09-16 20:54:02 +02:00
Miсhael Stetsyuk
0888b9746e
Merge pull request #69588 from ClickHouse/add-sleep-for-in-enqueueQueryImpl
sleep for 50ms before retrying to acquire a lock in `DatabaseReplicatedDDLWorker::enqueueQueryImpl`
2024-09-16 18:41:59 +00:00
Yarik Briukhovetskyi
0cdec0acf1
fix logical error 2024-09-16 19:13:30 +02:00
Yakov Olkhovskiy
19e2197582
fix 2024-09-16 10:38:28 -04:00
Yarik Briukhovetskyi
04f23332c3
fix filter issue 2024-09-16 15:59:22 +02:00
Yakov Olkhovskiy
d223c4547f
fix after master merge 2024-09-16 08:35:05 -04:00
vdimir
1986fb1418
Merge pull request #68595 from ClickHouse/vdimir/fix_function_printf_style
Fix style in Functions/printf.cpp
2024-09-16 12:34:31 +00:00
Yakov Olkhovskiy
58993d3f3b
Merge branch 'master' into refactor-secret-finder 2024-09-16 08:33:16 -04:00
Alexander Gololobov
8507d209c0
Merge branch 'master' into check_time_limit_in_index_analysis 2024-09-16 13:36:51 +02:00
Alexander Gololobov
4af369fbc4 Failpoint for testing slow index analysis 2024-09-16 13:34:01 +02:00
Antonio Andelic
8cdcc431fe Fix 2024-09-16 13:30:17 +02:00
Antonio Andelic
f401eccc64 Fix Keeper multi request preprocessing with NOAUTH 2024-09-16 12:48:01 +02:00
Robert Schulze
1a4c7b7c61
Merge pull request #69493 from ucasfl/vector-index-insert
Speedup insert performance of vector similarity index by parallelization
2024-09-16 08:54:02 +00:00
vdimir
4c4a051d5e
Merge pull request #69075 from kirillgarbar/remove-stale-moving-parts
Remove stale moving parts without zookeeper
2024-09-16 08:02:05 +00:00
Vitaly Baranov
a55cc03973
Merge pull request #69611 from vitlibar/masking-sensitive-info-in-gcs-table-function
Masking sensitive info in gcs() table function
2024-09-16 07:58:17 +00:00
Antonio Andelic
187a717872 Merge branch 'master' into keeper-better-ssl-support 2024-09-16 09:17:30 +02:00
Robert Schulze
37411bf240
Fix sizing with unconstrained thread pool size 2024-09-15 15:06:14 +00:00
Robert Schulze
733c57dae7
Merge pull request #69583 from rschu1ze/better-fix-67476
A better fix for #67476
2024-09-15 09:35:37 +00:00
李扬
4412946532
Merge branch 'master' into orc_dict_encode 2024-09-15 17:25:20 +08:00
marco-vb
038f56cb5e Only make checks to stop inserts if settings are being used. 2024-09-14 21:04:12 +00:00
Nikita Taranov
63577507c9 fix build 2024-09-14 21:43:27 +01:00
Nikita Taranov
9eb78773a6 Merge branch 'master' into adaptive_parallel_replicas 2024-09-14 19:31:02 +01:00
Nikita Taranov
918ead070a
Merge pull request #69602 from ClickHouse/rm_explicit_initial_announce_from_RFMT
Remove explicit announce from local replica in ReadFromMergeTree
2024-09-14 17:58:41 +00:00
Yakov Olkhovskiy
6f63a7b213 fix tidy 2024-09-14 16:46:48 +00:00
Yakov Olkhovskiy
56cfa74a14 fix 2024-09-14 13:32:52 +00:00
Yakov Olkhovskiy
dbb1d043fe unification of FunctionSecretArgumentsFinder 2024-09-14 05:46:08 +00:00
Vitaly Baranov
a461d20af9 Masking sensitive info in gcs() table function. 2024-09-13 23:03:56 +02:00
Yarik Briukhovetskyi
4c929aa5dd
revert last commit 2024-09-13 21:42:34 +02:00
Yarik Briukhovetskyi
7d5203f8a7
add resize for partitioning_columns 2024-09-13 21:38:48 +02:00
Yarik Briukhovetskyi
0d1d750437
fix crash 2024-09-13 20:43:51 +02:00
Yarik Briukhovetskyi
ad31d86a15
move the block inserting 2024-09-13 19:58:19 +02:00
Yarik Briukhovetskyi
991279e5c6
revert 2024-09-13 19:23:00 +02:00
Alexander Gololobov
31ddfc6f5f Check time limit while analyzing indexes 2024-09-13 19:19:21 +02:00
Marco Vilas Boas
ddf2e07fd0
Merge branch 'ClickHouse:master' into marco-vb/setting-stop-insert-on-full-disk 2024-09-13 18:17:44 +01:00
marco-vb
5cc12ca9ee Added integration testing for newly implemented settings. 2024-09-13 17:16:16 +00:00
Miсhael Stetsyuk
98a2c1c638
Merge pull request #69274 from ClickHouse/fix-metadata-version-in-zookeeper
fix `metadata_version` in ZooKeeper
2024-09-13 17:11:21 +00:00
Nikita Taranov
bab574d674
Merge pull request #69404 from bigo-sg/69135
`have_compressed` is lost in `HashJoin::reuseJoinedData`
2024-09-13 16:39:43 +00:00
Miсhael Stetsyuk
4225ba79f9
use base/sleep.h 2024-09-13 17:35:11 +01:00
Nikita Taranov
42670a46d4 impl 2024-09-13 17:00:46 +01:00
Yarik Briukhovetskyi
e64cc6ecc4
more tries😃 2024-09-13 18:00:25 +02:00
Alexander Gololobov
e13247b67e Fix clang-18 build 2024-09-13 16:50:43 +02:00
Yarik Briukhovetskyi
c184aae686
review 2024-09-13 16:40:01 +02:00
Alexander Gololobov
2650a20628 Make dedup logic O(n*log(n)) instead of O(n^2) 2024-09-13 16:21:17 +02:00
Antonio Andelic
9a31fc385d Fixes 2024-09-13 15:58:17 +02:00
marco-vb
ddc506a677 Corrected implementation for check of new settings and fix lint of settings change history. 2024-09-13 13:48:42 +00:00
Michael Stetsyuk
2b6238a5e5 sleep for 10ms beforen retrying to acquire a lock in DatabaseReplicatedDDLWorker::enqueueQueryImpl 2024-09-13 13:41:01 +00:00
Alexander Tokmakov
8111a32c72
Merge pull request #69539 from ClickHouse/evillique-patch-2
Fix attach of ReplicatedMergeTree tables in Replicated databases
2024-09-13 13:06:21 +00:00
Antonio Andelic
492461271b Merge branch 'master' into keeper-better-ssl-support 2024-09-13 14:44:12 +02:00
Michael Stetsyuk
1b1db0081f do not fix metadata_version if replica is read_only 2024-09-13 12:38:25 +00:00
Кирилл Гарбар
6a7cfd13f7 Set PRESERVE_BLOBS if part is fetched from another replica 2024-09-13 15:25:17 +03:00
Antonio Andelic
3c47f3df4b Support more advanced SSL options for Keeper internal communication 2024-09-13 14:23:01 +02:00
Robert Schulze
51f3245030
A better fix for #67476
Throw an exception instead of silently ignoring two conflicting settings.
2024-09-13 11:45:15 +00:00
Yarik Briukhovetskyi
c3f2b9714b
try to fix heap-use-after-free issues 2024-09-13 13:34:36 +02:00
Robert Schulze
9ca149a487
Fix GWP-asan crash 2024-09-13 11:07:09 +00:00
Daniil Ivanik
2fce90ab76
Merge pull request #66782 from a-a-f/input_format_json_empty_as_default
Add support for the `input_format_json_empty_as_default` setting
2024-09-13 10:33:45 +00:00
李扬
11c7cdabf8
Merge branch 'ClickHouse:master' into orc_dict_encode 2024-09-13 18:26:20 +08:00
Yarik Briukhovetskyi
e0c4a88f98
Merge pull request #69514 from aiven-sal/aiven-sal/showcolumns
Correctly handle tables' names with dots in SHOW COLUMNS and SHOW INDEX
2024-09-13 10:12:53 +00:00
Marco Vilas Boas
8299b31d47
Merge branch 'master' into marco-vb/setting-stop-insert-on-full-disk 2024-09-13 10:44:04 +01:00
lgbo-ustc
08fd6c8ab6 have_compressed is lost in reuseJoinedData 2024-09-13 17:18:27 +08:00
Nikita Taranov
f330fdb1bf
Merge pull request #69406 from canhld94/parallel_join_limit_threads
Not retaining thread in concurrent hash join threadpool
2024-09-13 09:14:48 +00:00
Arthur Passos
2c165096cd Merge branch 'master' into multi_auth_methods 2024-09-13 05:18:11 -03:00
Michael Kolupaev
adb905a692 Small improvement 2024-09-13 04:12:28 +00:00
李扬
11d2963497
fix style 2024-09-13 11:56:47 +08:00
taiyang-li
8a89d7b2b9 allow empty inputs for arrayZip or arrayZipUnaligned 2024-09-13 10:46:38 +08:00
Michael Kolupaev
e6ec9eaad3 Conflict 2024-09-13 02:18:24 +00:00
Duc Canh Le
59763a937e Merge branch 'master' into parallel_join_limit_threads
Fix CI
2024-09-13 01:47:20 +00:00
Michael Kolupaev
7e99f05981 Merge remote-tracking branch 'origin/master' into tomic 2024-09-12 21:45:09 +00:00
Michael Kolupaev
9a3adc70bd Don't leave an empty znode when replicated table is dropped 2024-09-12 21:20:25 +00:00
Alexander Gololobov
09f22920d9
Merge pull request #69525 from ClickHouse/backport_mergetask
Backport MergeTask changes from private to minimize merge conflicts
2024-09-12 19:52:10 +00:00
Kruglov Pavel
8610a01745
Merge pull request #69147 from Avogar/fix-s3-cluster-structure
Fix propogating structure argument in s3Cluster
2024-09-12 17:24:26 +00:00
Antonio Andelic
f62cb32c5c
Merge pull request #69332 from ClickHouse/issues/68932/remove-recursive
Support removeRecursive natively in keeper
2024-09-12 17:14:34 +00:00
Kseniia Sumarokova
f50898ae98
Merge pull request #69513 from ClickHouse/s3queue-refactor
S3Queue: small refactoring
2024-09-12 16:56:59 +00:00
Кирилл Гарбар
120e38c72a Merge remote-tracking branch 'kirillgarbar/master' into remove-stale-moving-parts 2024-09-12 19:26:58 +03:00
Yakov Olkhovskiy
d3533742d5
Merge pull request #68236 from marco-vb/marco-vb/x509-san-support-wildcard
Added support for wildcard usage in x509 SubjectAltName identification.
2024-09-12 16:00:35 +00:00
Nikita Taranov
7b2810bea2 Merge branch 'master' into adaptive_parallel_replicas 2024-09-12 16:51:15 +01:00
1on
51d770fa7a Ability to limit columns for tables in MaterializedPostgreSQL 2024-09-12 18:10:19 +03:00
Nikita Taranov
54f0a8c0e2
Merge pull request #69554 from KevinyhZou/fix_settings_join_to_sort
Fix upgrade check failure for join_to_sort settings
2024-09-12 15:07:17 +00:00
avogar
beffb92411 Keep original order of conditions during move to prewhere 2024-09-12 14:52:09 +00:00
Nikita Taranov
16f93ea1b3 revive separate protocol versioning for PRs 2024-09-12 15:40:51 +01:00
Nikita Taranov
1e3bc6d359 log mark_segment_size on initiator 2024-09-12 15:15:57 +01:00
Robert Schulze
c9dd409baa
Merge pull request #69549 from rschu1ze/qc-with-truncated-results
Disallow query cache for queries with non-throw overflow mode
2024-09-12 13:58:38 +00:00
marco-vb
562c23eac6 Add new settings to settings change history. 2024-09-12 13:28:49 +00:00
kevinyhzou
2225389474 Fix upgrade check failed for join_to_sort settings 2024-09-12 20:10:42 +08:00
Alexander Gololobov
e15b86cd9d
Merge branch 'master' into backport_mergetask 2024-09-12 13:29:59 +02:00
Alexander Gololobov
bbcde19910
Merge pull request #69383 from ClickHouse/tmp_files_lookup
Refactor temporary file usage in MergeTask with QueryPlan
2024-09-12 10:57:15 +00:00
Ilya Yatsishin
98ef5f6e10
Merge pull request #69253 from ClickHouse/restore-replace-to-null-settings-fix
Restore external tables to Null supports no settings
2024-09-12 10:40:54 +00:00
Robert Schulze
fe5e061fff
Some fixups 2024-09-12 10:38:14 +00:00
kssenii
3e3a80e714 Merge remote-tracking branch 'origin/s3queue-refactor' into s3queue-refactor 2024-09-12 12:35:59 +02:00
kssenii
6e94c9f617 Fix 2024-09-12 12:34:56 +02:00
Marco Vilas Boas
185d9401e5
Merge branch 'ClickHouse:master' into marco-vb/x509-san-support-wildcard 2024-09-12 11:08:45 +01:00
Joe Lynch
92351a67e8
Merge branch 'master' into joelynch/disk-encrypted-missing-method 2024-09-12 11:58:41 +02:00
Marco Vilas Boas
f292767778
Merge branch 'master' into marco-vb/setting-stop-insert-on-full-disk 2024-09-12 10:56:32 +01:00
marco-vb
7d36f3b764 Implemented checks for new settings. 2024-09-12 09:53:56 +00:00
marco-vb
21bd47f09e Add settings min_free_disk_bytes_to_throw_insert and min_free_disk_ratio_to_throw_insert and update documentation. 2024-09-12 09:45:43 +00:00
Alexey Katsman
d7f271c658
Merge pull request #69269 from alexkats/external-data-checksum
Use another error code for external data in buffer
2024-09-12 09:38:09 +00:00
Robert Schulze
5fe5cc8611
Disallow query cache for queries with non-throw overflow mode 2024-09-12 09:21:27 +00:00
Mikhail Artemenko
494455e4eb Merge branch 'master' into issues/68932/remove-recursive 2024-09-12 08:51:41 +00:00
Alexander Gololobov
8ea2573a9d Merge branch 'master' of github.com:ClickHouse/ClickHouse into backport_mergetask 2024-09-12 09:31:54 +02:00
Alexander Gololobov
856a66d45f Merge branch 'master' of github.com:ClickHouse/ClickHouse into tmp_files_lookup 2024-09-12 09:26:36 +02:00
flynn
f6b965872f Merge branch 'master' of github.com:ClickHouse/ClickHouse into vector-index-insert 2024-09-12 06:40:33 +00:00
flynn
22c3b71196 Make vector similarity index creation thread pool globally 2024-09-12 03:54:25 +00:00
Igor Nikonov
56b39c37a1
Merge pull request #64448 from ClickHouse/pr-local-plan
Local plan for parallel replicas
2024-09-11 20:44:37 +00:00
Nikolay Degterinsky
b30aabf635
Fix attach of ReplicatedMergeTree tables in Replicated databases 2024-09-11 22:38:54 +02:00
Nikita Taranov
fc83c1c7a2 use final task size in segment size calculation 2024-09-11 20:20:18 +01:00
Julia Kartseva
b5289c1f08
Merge pull request #60341 from KevinyhZou/improve_join_insert_from
Improve left/inner join performance by rerange right table by keys
2024-09-11 19:04:41 +00:00
Kseniia Sumarokova
b216e1a74b
Merge branch 'master' into s3queue-refactor 2024-09-11 20:56:11 +02:00
Yatsishin Ilya
ccc6390a9e merge remote-tracking branch 'origin/master' into restore-replace-to-null-settings-fix 2024-09-11 18:23:07 +00:00
Yarik Briukhovetskyi
a41bb7e526
fix 2024-09-11 19:12:59 +02:00
Antonio Andelic
de4774be74
Merge pull request #69469 from yariks5s/squashing_mem_usage
Fix high memory consumption on Squashing
2024-09-11 16:52:19 +00:00
Alexander Gololobov
c3416859d5 Merge branch 'master' of github.com:ClickHouse/ClickHouse into tmp_files_lookup 2024-09-11 17:22:08 +02:00
Alex Katsman
22ceaa0066 Use another error code for external data in buffer
Use CANNOT_DECOMPRESS error code for the compressed external data in
CompressedReadBufferBase for checksum validation and decompression.
2024-09-11 14:59:31 +00:00
Alexander Gololobov
f69cb73df0
Merge pull request #69167 from ClickHouse/query_plan_for_merge
Use QueryPlan for merge
2024-09-11 14:41:25 +00:00
Yarik Briukhovetskyi
5971b7307e
fuzzer fix 2024-09-11 15:56:35 +02:00
Alexander Gololobov
3aef79b5a2 Backport changes from private to minimize merge conflicts 2024-09-11 15:45:55 +02:00
kssenii
a05610c38f Move creation and validation of table metadata before creating queue metadata & save to factory 2024-09-11 15:32:22 +02:00
Antonio Andelic
9b42af7263
Merge pull request #66648 from ClickHouse/read-cgroup-memory-usage-async-metrics
Simplify some memory tracking parts
2024-09-11 13:24:38 +00:00
Salvatore Mesoraca
3556cf92c3 Allow SHOW INDEXES to work with tables that contain dots in the name 2024-09-11 15:15:31 +02:00
Salvatore Mesoraca
075a85f15c Allow SHOW COLUMNS to work with tables that contain dots in the name 2024-09-11 15:15:08 +02:00
Igor Nikonov
c53e165118
Merge branch 'master' into pr-local-plan 2024-09-11 14:03:35 +02:00
flynn
7425d4aa1a remove blank line 2024-09-11 10:12:42 +00:00
Mikhail Artemenko
55d6672bc4 add early break for test keeper impl 2024-09-11 10:00:40 +00:00
flynn
cf12e3924f Speedup insert data with vector similarity index by add data to index parallel 2024-09-11 09:31:46 +00:00
Yarik Briukhovetskyi
ccfb7ad38c
Merge pull request #69455 from yariks5s/group_concat_return_string
`groupConcat` consistency with `arrayStringConcat`
2024-09-11 08:59:48 +00:00
Robert Schulze
7a3d69b626
Merge pull request #69451 from rschu1ze/sqid-crash
Fix crash in `sqidDecode`
2024-09-11 08:56:05 +00:00
Duc Canh Le
085be6bf59 remove unwanted include
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-09-11 06:42:48 +00:00
李扬
0de3b1dacb
Merge branch 'ClickHouse:master' into orc_dict_encode 2024-09-11 12:08:06 +08:00
Kseniia Sumarokova
cb1b7dc43c
Merge pull request #69454 from ClickHouse/revert-s3queue-problem
Quick fix for s3queue problem
2024-09-10 21:13:16 +00:00
Alexander Tokmakov
629d27fec8
Merge pull request #69422 from ClickHouse/add_a_setting
Add a setting to disallow DETACH PERMANENTLY in Replicated database
2024-09-10 19:56:10 +00:00
Michael Kolupaev
263cd9e1c3 Fix error message 2024-09-10 19:41:15 +00:00
Michael Kolupaev
5539faa54e Disallow creating refreshable MV on Linux < 3.15 2024-09-10 19:41:15 +00:00
Alexander Gololobov
d4aa06524b Add materialization when building indices in vertical merge 2024-09-10 20:57:55 +02:00
Mikhail Artemenko
3e3d652320 refactor tests 2024-09-10 17:52:41 +00:00
Mikhail Artemenko
00fe1d12ee add acl test for rmr 2024-09-10 17:45:39 +00:00
Mikhail Artemenko
3730582d06 add full tree acl check 2024-09-10 17:43:35 +00:00
Igor Nikonov
c3dfdd41d3 Merge remote-tracking branch 'origin/master' into pr-local-plan 2024-09-10 17:24:44 +00:00
Nikita Taranov
8534aa07fc
Merge pull request #69400 from ClickHouse/support_more_oss_endpoints
Support more oss endpoints
2024-09-10 17:01:02 +00:00
Nikita Taranov
8fa31c0750
Merge pull request #69385 from ClickHouse/fix
Fix type mismatch
2024-09-10 16:52:57 +00:00
Alexander Gololobov
bb82465a5f Merge branch 'master' of github.com:ClickHouse/ClickHouse into query_plan_for_merge 2024-09-10 18:27:59 +02:00
Yarik Briukhovetskyi
caab4dd8b9
fix 2024-09-10 18:20:48 +02:00
Nikita Taranov
8d5d7dd83a fix wording 2024-09-10 17:18:27 +01:00
Kseniia Sumarokova
6a6d26aeed
Update StorageObjectStorageQueue.cpp 2024-09-10 18:16:27 +02:00
Joe Lynch
35df5ff28e
Add test for SYSTEM UNFREEZE with zero_copy 2024-09-10 17:52:02 +02:00
Mikhail Artemenko
8b7a5616a2 update test 2024-09-10 15:51:31 +00:00
Alexander Gololobov
e4761d40ba
Merge pull request #69429 from ClickHouse/materialize_sparse
Make `materialize()` function return full column when parameter is a sparse column
2024-09-10 15:49:29 +00:00
Robert Schulze
080193cfc3
14% more aesthetic code 2024-09-10 15:46:21 +00:00
Yarik Briukhovetskyi
d8e670297b
groupConcat consistency 2024-09-10 17:42:27 +02:00
kssenii
d43264c44e Quick fix for s3queue problem 2024-09-10 17:41:52 +02:00
Robert Schulze
04dcf73e8f
Fix crash in sqidDecode 2024-09-10 15:35:59 +00:00
Kruglov Pavel
d226b13fd4
Merge pull request #69272 from Avogar/json-memory-usage
Reduce memory usage of inserts to JSON by using adaptive write buffer size
2024-09-10 15:23:18 +00:00
Mikhail Artemenko
1aacb48bcf fix collector 2024-09-10 14:34:27 +00:00
Pablo Marcos
a34a544f4a
Merge pull request #67938 from mwoenker/incomplete-utf8-sequence
Handle incomplete sequences at end of input
2024-09-10 14:04:58 +00:00
Michael Stetsyuk
be55e1d2e1 better 2024-09-10 13:52:40 +00:00
Mikhail Artemenko
0bd7ef39c4 unify processWatches 2024-09-10 12:27:34 +00:00
Mikhail Artemenko
0453d5e91a small fixes 2024-09-10 12:26:03 +00:00
Alexander Gololobov
a01229bba2 Convert sparse columns to full in materialize() 2024-09-10 14:23:31 +02:00
Antonio Andelic
bdf8c859b1 Merge branch 'master' into read-cgroup-memory-usage-async-metrics 2024-09-10 14:13:48 +02:00
Alexander Tokmakov
89dd3188bb add a setting to disallow DETACH PERMANENTLY in Replicated 2024-09-10 13:35:18 +02:00
Nikita Fomichev
24d81fe00b
Merge pull request #69394 from ClickHouse/rows-before-aggregation-compatibility
Fix 24.8 setting compatibility `rows_before_aggregation`
2024-09-10 11:33:33 +00:00
Nikita Taranov
61ebcdc2ed fix 2024-09-10 12:07:44 +01:00
Igor Nikonov
b0c4f6b9e7 Merge remote-tracking branch 'origin/master' into pr-local-plan 2024-09-10 11:06:10 +00:00
Nikita Taranov
1df897db27 Merge branch 'master' into adaptive_parallel_replicas 2024-09-10 12:03:46 +01:00
Pablo Marcos
ac3cfef8c1
Merge pull request #69390 from pamarcos/fix-invalid-connection-logical-error
Fix undefined behavior if all connection tries fail
2024-09-10 09:45:37 +00:00
kevinyhzou
597181c45e review 2024-09-10 16:32:52 +08:00
Duc Canh Le
d089a56272 only set max_free_threads_ = 0 when creating pool
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-09-10 05:51:48 +00:00
Duc Canh Le
11478b949f limit threadpool size in concurrent hash join
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-09-10 03:12:44 +00:00
Igor Nikonov
bb063babff
Merge branch 'master' into pr-local-plan 2024-09-09 21:17:51 +02:00
Nikita Taranov
47589d4898 impl 2024-09-09 19:53:58 +01:00
Alexander Tokmakov
9ab3ee1b13
Merge pull request #66104 from ClickHouse/break_compatibility
Don't allow explicit UUIDs and ReplicatedMergeTree arguments in Replicated databases
2024-09-09 18:29:16 +00:00
Robert Schulze
2b2cd8e3e0
Merge pull request #69377 from JackyWoo/rename_statistics_count_min
Rename `count_min` statistics to `countmin`
2024-09-09 18:25:11 +00:00
Alexander Tokmakov
7fe8775361
Merge pull request #69306 from ClickHouse/tavplubix-patch-14
Update StackTrace.cpp
2024-09-09 17:55:07 +00:00
Alexander Gololobov
38b8edae97 Fix the case with empty temp file 2024-09-09 19:34:59 +02:00
Nikita Taranov
8cdc10cf65 fix settings changes 2024-09-09 18:11:03 +01:00
Kseniia Sumarokova
ef94d3422c
Merge pull request #69305 from ClickHouse/fix-segfault-deltalake
Add checks against segfault in DeltaLakeMetadata
2024-09-09 16:23:29 +00:00
Kruglov Pavel
804012b2e4
Merge pull request #69311 from Avogar/dynamic-primary-key
Mark Dynamic type as not safe primary key type to avoid issues with Fields
2024-09-09 15:33:48 +00:00
avogar
72dbc8205b Fix unit tests 2024-09-09 15:12:17 +00:00
Pablo Marcos
f7dee10030 Make a more assertive exception text 2024-09-09 14:38:06 +00:00
Robert Schulze
d749869f00
Merge pull request #67707 from bigo-sg/opt_array_map
Optimize function `array()` and `map()`
2024-09-09 14:37:50 +00:00
Alexander Gololobov
4da1e10ac6 Move sorting key calculation step outside the loop 2024-09-09 16:01:00 +02:00
Pablo Marcos
67b57eb89f Fix undefined behavior if all connection tries fail
For some reason, getManyCheckedForInsert was calling getManyImpl with
skip_unavailable_endpoints=nullptr, which resulted in getManyImpl using
the `skip_unavailable_shards` settings. Since this is true by default,
min_entries was set to 0.

Having min_entries set to 0 while using PoolMode::GET_ONE was strange,
to say the least. There was an edge case where if all connection
attempts failed and min_entries was 0, it was returning an empty vector.
That was not considered to be possible by the caller and it was getting
the front entry of an empty vector, causing undefined behavior.

Conclusion: set `skip_unavailable_endpoints=false` explicitly in
getManyCheckedForInsert so that min_entries=1. In case all connections
fail, an exception will be thrown. Also, add some defensive programming
to ensure we never ever try to get the front element of an empty vector.
2024-09-09 14:00:35 +00:00
Pablo Marcos
e6e79c3c4a Fix minor typos 2024-09-09 13:35:45 +00:00
Alexander Gololobov
8c1f434b1a Do column materialization using ActionsDAG::addMaterializingOutputActions instead of a special step 2024-09-09 15:31:43 +02:00
Alexander Gololobov
1bcc4ba823 Renamed ApplyMergeStep into MergePartsStep 2024-09-09 15:30:19 +02:00
Nikita Fomichev
66572aa029 Fix 24.8 setting compatibility rows_before_aggregation
https://github.com/ClickHouse/ClickHouse/pull/66084
2024-09-09 15:25:14 +02:00
Nikita Taranov
43d057ed0f impl 2024-09-09 13:04:45 +01:00
Alexander Gololobov
5a8bd5b4f5 Encapsulte and cleanup "rows_sources" temp file usage 2024-09-09 13:22:38 +02:00
Alexander Gololobov
7d042be8eb A simple interface to find temporary files by their logical names when building pipeline from query plan 2024-09-09 13:21:00 +02:00
Miсhael Stetsyuk
2364949c95
Merge pull request #69102 from ClickHouse/make-replicated-database-creation-operations-idempotent
Make `Replicated` database creation operations idempotent
2024-09-09 11:19:15 +00:00
Kruglov Pavel
7bf6bdf639
Merge pull request #69149 from Avogar/values-respect-settings
Respect format settings in Values format during conversion from expression to the destination type
2024-09-09 11:02:39 +00:00
avogar
4ece895b41 Merge branch 'master' of github.com:ClickHouse/ClickHouse into json-dynamic-hash 2024-09-09 10:54:18 +00:00
Nikita Taranov
57e3812087
Merge pull request #68441 from jiebinn/parallelMergeWithKey
Add thread pool and cancellation to support parallel merge with key
2024-09-09 10:41:45 +00:00
Igor Nikonov
eda6dabe41 Merge remote-tracking branch 'origin/master' into pr-local-plan 2024-09-09 09:58:36 +00:00
Raúl Marín
d968de6d26
Merge pull request #66205 from alexkorep/output-format-json-compact-with-progress
JSONCompactWithProgress query output format
2024-09-09 09:30:42 +00:00
Yarik Briukhovetskyi
2c35d53bf6
Merge pull request #56738 from yariks5s/time_buckets_impl
Add time-bucket overload to function `toStartOfInterval()`
2024-09-09 09:18:35 +00:00
Mikhail Artemenko
2fe6991124 Merge branch 'master' into issues/68932/remove-recursive 2024-09-09 08:55:53 +00:00
JackyWoo
eb800d9e39 Rename statistics of type count_min to countmin 2024-09-09 11:45:39 +08:00
taiyang-li
774ec08faf fix style 2024-09-09 11:37:27 +08:00
taiyang-li
d04997bc98 Merge branch 'opt_array_map' of https://github.com/bigo-sg/ClickHouse into opt_array_map 2024-09-09 11:36:28 +08:00
taiyang-li
f1c43472d8 change as request 2024-09-09 11:35:54 +08:00
Alexey Korepanov
1eb7cdbd42 Merge branch 'master' into output-format-json-compact-with-progress 2024-09-08 17:12:51 +02:00
Robert Schulze
26f21a0d94
Merge pull request #69326 from rschu1ze/overlay-followup
Minor follow-up for #66933
2024-09-08 09:07:54 +00:00
Antonio Andelic
65019c4b9b Merge branch 'master' into keeper-some-improvement2 2024-09-07 20:59:04 +02:00
Robert Schulze
8a87cffb82
Merge pull request #69336 from rschu1ze/fix-icu-memleak
Fix memleak in `lower/upperUTF8`
2024-09-07 15:40:01 +00:00
Antonio Andelic
190339c4e6 Fix snapshot sync 2024-09-07 17:34:59 +02:00
Antonio Andelic
5a86371b02 Merge branch 'master' into keeper-some-improvement2 2024-09-07 11:32:44 +02:00
Igor Nikonov
f5d49f8e10
Merge branch 'master' into adaptive_parallel_replicas 2024-09-06 23:08:30 +02:00
Igor Nikonov
42d3cd2b91 Merge remote-tracking branch 'origin/master' into pr-local-plan 2024-09-06 20:10:50 +00:00
Igor Nikonov
ebd9c294aa Fix build 2024-09-06 20:09:48 +00:00
Igor Nikonov
fe5c0e127f
Merge pull request #69264 from ClickHouse/fix-pr-not-ready-set
Fix: Not-ready Set with parallel replicas
2024-09-06 18:48:02 +00:00
Igor Nikonov
b436057cba Merge remote-tracking branch 'origin/master' into pr-local-plan 2024-09-06 18:46:42 +00:00
Yarik Briukhovetskyi
a903e1a726
remove logging + fixing bug 2024-09-06 20:24:18 +02:00
Robert Schulze
fdf8ff0e66
Don't forget to call ucasemap_close for every ucasemap_open 2024-09-06 17:25:14 +00:00
Michael Stetsyuk
8544718d32 initialize max_log_ptr_at_creation on attach 2024-09-06 16:31:39 +00:00
Robert Schulze
a73eb1c177
Merge pull request #67013 from JackyWoo/add_statistics_minmax
Add `min_max` statistics type
2024-09-06 16:14:04 +00:00
Nikolai Kochetov
ee304c7fc3 Fix tidy 2024-09-06 16:02:47 +00:00
Michael Stetsyuk
06632b9bcd fxs 2024-09-06 15:58:46 +00:00
Yarik Briukhovetskyi
70cee20bf4
Merge branch 'ClickHouse:master' into time_buckets_impl 2024-09-06 17:57:47 +02:00
Kseniia Sumarokova
0c18c38cac
Merge branch 'master' into fix-segfault-deltalake 2024-09-06 16:57:32 +02:00
Antonio Andelic
03c7f3817b Correct lock order 2024-09-06 15:41:04 +02:00
Mikhail Artemenko
81972b97e7 support test keeper 2024-09-06 13:23:57 +00:00
Robert Schulze
84a5c88b50
Minor follow-up to #66933 2024-09-06 12:39:05 +00:00
Mikhail Artemenko
068ada57ba update api 2024-09-06 12:23:57 +00:00
vdimir
1b71ad26ee
Merge pull request #69186 from ClickHouse/vdimir/client-context-race2
Fix possible timeouts in `sh` tests with tsan, att. 2
2024-09-06 11:09:24 +00:00
JackyWoo
3974e9060a Fix docs and some fixups 2024-09-06 18:50:02 +08:00
Nikolai Kochetov
fdbf8e71ab Stable explain 2024-09-06 10:30:09 +00:00
Robert Schulze
8c9cf37858
Merge pull request #69090 from ucasfl/fix-vector-index
Fix bug that vector similarity index does not work for cosine distance
2024-09-06 10:24:46 +00:00
Robert Schulze
d9d83fd56b
Merge pull request #69065 from ucasfl/vector-index
Disable alter table add vector similarity index if setting does not enabled
2024-09-06 10:11:38 +00:00
Alexander Tokmakov
e2a7a1f662
Update StackTrace.cpp 2024-09-06 12:08:14 +02:00
Yarik Briukhovetskyi
eb540da247
Merge branch 'ClickHouse:master' into time_buckets_impl 2024-09-06 11:56:22 +02:00
Mikhail Artemenko
cf0e0b766d add test for watches 2024-09-06 09:34:26 +00:00
Mikhail Artemenko
2bbe933531 fix watches logic 2024-09-06 09:33:47 +00:00
Igor Nikonov
2de3a6175a Merge remote-tracking branch 'origin/master' into fix-pr-not-ready-set 2024-09-06 08:36:04 +00:00
Mikhail Artemenko
231a7c97cc move code 2024-09-06 08:34:59 +00:00
Antonio Andelic
f44eaa808d Merge branch 'master' into keeper-some-improvement2 2024-09-06 09:35:56 +02:00
Antonio Andelic
e388f6f99b Remove useless log 2024-09-06 09:35:02 +02:00
kevinyhzou
02e129f0d1 modify test 2024-09-06 10:15:43 +08:00