alesapin
4d8660f270
Remove obsolete comment
2020-05-01 13:05:37 +03:00
alesapin
15e8f37839
Merge pull request #10531 from CurtizJ/polymorphic-parts-2
...
Fix index corruption in merges with compact parts.
2020-04-30 12:15:25 +03:00
alesapin
5e2afad549
Merge pull request #10477 from ClickHouse/refactor_istorage
...
Remove getColumn and hasColumn from IStorage, better virtuals.
2020-04-30 10:42:52 +03:00
Anton Popov
6ed3092c8a
make fillIndexGranularity less complicated
2020-04-30 00:57:58 +03:00
alesapin
69fdf2a6a3
Review fixes and better test
2020-04-29 15:15:23 +03:00
robot-clickhouse
de4e88ff97
Auto version update to [20.5.1.1] [54435]
2020-04-28 20:12:16 +03:00
alesapin
f981649213
Fix pushing to views stream and refactor virtuals
2020-04-28 13:38:57 +03:00
Anton Popov
032a0aa282
fix clang-tidy
2020-04-27 21:12:17 +03:00
alesapin
7c2f4d121a
Fix func
2020-04-27 20:48:53 +03:00
alesapin
4badd0fd28
Better code
2020-04-27 20:46:51 +03:00
alesapin
228dbf475e
Finalize mutations in background ( #10526 )
2020-04-27 19:19:04 +03:00
alesapin
01db4877f6
Fix style check
2020-04-27 18:44:33 +03:00
alesapin
c24ab563d7
Fix several wrong usages
2020-04-27 18:38:35 +03:00
alesapin
b0c5c1d685
Fix style
2020-04-27 18:21:37 +03:00
alesapin
6cfe0f7046
Fix after refactoring
2020-04-27 18:20:03 +03:00
alesapin
cefc58e77c
Fix style
2020-04-27 18:17:08 +03:00
alesapin
5c6316afbc
Fix bug
2020-04-27 18:10:50 +03:00
alesapin
4c1ac83112
Fix in IStorage
2020-04-27 17:44:32 +03:00
alesapin
e85b50c911
Revert "Strange fix, how it was possible earlier?"
...
This reverts commit 8d20644c99
.
2020-04-27 17:17:12 +03:00
alesapin
8d20644c99
Strange fix, how it was possible earlier?
2020-04-27 17:12:54 +03:00
alesapin
18c550df15
Better virtuals logic
2020-04-27 16:55:30 +03:00
Anton Popov
bee343dae1
fix writing of index in compact parts
2020-04-27 16:36:50 +03:00
alesapin
2829774105
Merge branch 'master' into refactor_istorage
2020-04-27 15:34:21 +03:00
alexey-milovidov
c9334d3fde
Merge pull request #10491 from azat/dist-shutdown
...
Proper Distributed shutdown (fixes UAF, avoid waiting for sending all batches)
2020-04-25 23:47:59 +03:00
Azat Khuzhin
747a74215f
Avoid processing all batches before Distributed shutdown
2020-04-25 02:03:27 +03:00
Azat Khuzhin
8ad6b37913
Proper StorageDistributed shutdown to avoid UAF in DistributedMonitor
...
StorageDistributed::shutdown() does not acquire the lock, that controls
access to the cluster_nodes_data, thus it does not synced with the
requireDirectoryMonitor(), hence some monitors can be untracked that
will trigger UAF (use-after-free) after DROP TABLE dist:
This is for the SIGSEGV from the DirectoryMonitor (with already destroyed storage):
0 0x0000000008e9f760 in std::__1::__cxx_atomic_load<int> (__order=std::__1::memory_order::seq_cst, __a=0x0)
1 std::__1::__atomic_base<int, false>::load (__m=std::__1::memory_order::seq_cst, this=0x0) <-- this is nullptr
2 std::__1::__atomic_base<int, false>::operator int (this=0x0)
3 DB::ActionBlocker::isCancelled (this=0x7f85e31c9bb8) at ../src/Common/ActionBlocker.h:18
4 DB::StorageDistributedDirectoryMonitor::run (this=0x7f85f93b2a00) at ../src/Storages/Distributed/DirectoryMonitor.cpp:140
2020-04-25 02:03:26 +03:00
tavplubix
7928f2eaa1
Merge pull request #7512 from ClickHouse/database_atomic
...
DatabaseAtomic
2020-04-24 22:28:18 +03:00
alesapin
793f4b734a
Remove obsolete comment
2020-04-24 13:31:03 +03:00
alesapin
b4425c2dc4
Remove getColumn and hasColumn methods from IStorage
2020-04-24 13:20:03 +03:00
alesapin
0c622370c5
Better
2020-04-24 12:21:38 +03:00
alesapin
dc2dd77d2e
Remove redundant overrides from IStorage
2020-04-24 12:20:09 +03:00
Alexander Tokmakov
f413061e0d
remove Context from some IDatabase methods
2020-04-23 19:51:48 +03:00
alesapin
5ae25b68e4
Remove redundant virtual from function
2020-04-23 18:18:33 +03:00
alesapin
b0a73589b0
Remove virtual columns as separate field from IStorage
2020-04-23 18:09:00 +03:00
Alexander Tokmakov
04d6b59ac0
Merge branch 'master' into database_atomic
2020-04-23 17:31:37 +03:00
Nikita Mikhaylov
3520755ab5
fix c++20 usage
2020-04-23 12:00:43 +03:00
alexey-milovidov
4f6bb00424
Merge pull request #10420 from ClickHouse/clang-tidy-8
...
Fixes for clang-tidy on clang-10
2020-04-23 00:33:41 +03:00
Nikita Mikhaylov
3cf2016867
Merge pull request #10188 from nikitamikhaylov/quorum_bug
...
insert_quorum vs drop partition or ttl
2020-04-23 00:11:57 +04:00
Alexey Milovidov
73dd78bac1
Merge branch 'master' into clang-tidy-8
2020-04-22 21:04:47 +03:00
Alexander Tokmakov
fefbbd37df
Merge branch 'master' into database_atomic
2020-04-22 17:02:30 +03:00
zhang2014
0a0555d4d7
ISSUES-9623 fix failure test case
2020-04-22 18:34:42 +08:00
zhang2014
bfb87f0eab
ISSUES-9623 check the number and type of arguments when creating BloomFilter index
2020-04-22 16:17:09 +08:00
Alexey Milovidov
03e17405cd
Checkpoint
2020-04-22 10:03:43 +03:00
Alexey Milovidov
603d132d45
Checkpoint
2020-04-22 09:34:20 +03:00
Alexey Milovidov
1e325a9fd9
Checkpoint
2020-04-22 09:22:14 +03:00
Alexey Milovidov
be22a4b94e
Checkpoint
2020-04-22 08:39:31 +03:00
Ivan
555488a458
Fix build in Arcadia ( #10413 )
2020-04-21 23:23:44 +03:00
Nikita Mikhaylov
2173bcf28e
Merge branch 'master' of github.com:ClickHouse/ClickHouse into quorum_bug
2020-04-21 14:35:06 +03:00
Alexey Milovidov
4cc0269de0
Fix flattening of Array(Tuple(...)) #10259
2020-04-21 02:44:51 +03:00
alexey-milovidov
8c2839d3c9
Merge pull request #10308 from ClickHouse/shared-context-lifetime
...
Shared context lifetime
2020-04-21 00:12:45 +03:00