Commit Graph

86667 Commits

Author SHA1 Message Date
Azat Khuzhin
891c601589 Fix ProfileEvents overlaps (for multiple queries) in clickhouse-local
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 22:27:12 +03:00
Azat Khuzhin
54a1cea7fd Send ProfileEvents in clickhouse-local on query finish (like server does)
v2: send only for pulling pipelines
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 22:26:44 +03:00
Yakov Olkhovskiy
3d52afed71 only check columns sets intersection, some refactoring 2022-04-12 15:10:11 -04:00
Anton Popov
0679d4814d allow to convert empty string to objects 2022-04-12 18:58:40 +00:00
tavplubix
303ecc6f7d
Merge pull request #36136 from ClickHouse/transactions_fix_1
Minor fix for transactions
2022-04-12 21:38:47 +03:00
Azat Khuzhin
1a8b49b535 Remove redundant check from LocalConnection::finishQuery()
It is called from only one place, and under state->is_finished, so state
is there.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 21:18:52 +03:00
Azat Khuzhin
097e2f626d Do not overlap profile events snapshots for queries
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
Azat Khuzhin
e38057ddb0 Fix code alignment in ProfileEventsExt
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
Azat Khuzhin
d9dd8f5f65 Fix filtering out snapshots from profile events
This fixes POSITION_OUT_OF_BOUND error:

    $ clickhouse-client --print-profile-events --profile-events-delay-ms=-1 -n -q 'select sleep(1); select 1'
    0
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] ContextLock: 9 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] FunctionExecute: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] MemoryTrackerUsage: 2132102 (gauge)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] NetworkReceiveElapsedMicroseconds: 139 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] NetworkSendBytes: 4850 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] NetworkSendElapsedMicroseconds: 1844 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] Query: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] RWLockAcquiredReadLocks: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] SelectQuery: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] SelectedBytes: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] SelectedRows: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] OSCPUVirtualTimeMicroseconds: 1842 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] OSReadChars: 426 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] OSWriteChars: 322 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] RealTimeMicroseconds: 1002689 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] SleepFunctionCalls: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] SleepFunctionMicroseconds: 1000000 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] UserTimeMicroseconds: 1843 (increment)
    1
    Error on processing query: Code: 11. DB::Exception: Position out of bound in Block::erase(), max position = 5. (POSITION_OUT_OF_BOUND) (version 22.4.1.1)
    (query: select 1)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
Azat Khuzhin
1fa3e6a426 Fix printing ProfileEvents on client for multiple queries
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
Azat Khuzhin
d46eaadacc tests: do not use process substution in 02050_client_profile_events
bash does not waits then and so if the next line will be executed fast
enough, result of process substituted command can appers in stdout after
it.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
Azat Khuzhin
75789eb9a7 tests: improve 02050_client_profile_events
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
kssenii
cefa64a846 Fix 2022-04-12 17:56:22 +02:00
Julian Gilyadov
a4f56f3330
Throw exception when file cant be executed instead of displaying success 2022-04-12 17:52:44 +02:00
Kruglov Pavel
fead4c184f
Merge pull request #35237 from olejeglejeg/patch-1
Kafka engine kafka_num_consumers prop upper bound doc update
2022-04-12 17:09:42 +02:00
Kruglov Pavel
5b46e9655a
Merge pull request #36067 from ClickHouse/Avogar-patch-4
Try to turn off always green backward compatibility checks
2022-04-12 16:20:07 +02:00
Kruglov Pavel
2436ab8990
Merge pull request #36083 from Avogar/fix-tests
Try to avoid timeoutes in parallel parsing tests
2022-04-12 16:19:42 +02:00
Yakov Olkhovskiy
5868539605 check only if TO table exists 2022-04-12 10:17:39 -04:00
Antonio Andelic
1b4cebcfb6 Add new/delete overloads 2022-04-12 14:11:10 +00:00
avogar
de9c9462e5 Fix crash in ParallelReadBuffer 2022-04-12 13:54:53 +00:00
tavplubix
c14c9329bb
Merge pull request #36138 from ClickHouse/tavplubix-patch-4
Minor improvement for hung check
2022-04-12 16:54:35 +03:00
Yakov Olkhovskiy
25101de7e2 check only selected columns against destination table 2022-04-12 09:29:32 -04:00
tavplubix
090506a572
Merge pull request #36161 from ClickHouse/fix_mongo_test
Fix mongodb test with new cert
2022-04-12 15:48:08 +03:00
Azat Khuzhin
b91281455c clickhouse-client: properly cancel query in case of error during formatting data
One example of such error is NO_ROW_DELIMITER [1]:

    $ clickhouse-client --stacktrace --multiquery <<<"SELECT * FROM no_length_delimiter_protobuf_00825 FORMAT ProtobufSingle SETTINGS format_schema = '$PWD/tests/queries/0_stateless/format_schemas/00825_protobuf_format_no_length_delimiter:Message'"
    Error on processing query: Code: 546. DB::Exception: The ProtobufSingle format can't be used to write multiple rows because this format doesn't have any row delimiter. (NO_ROW_DELIMITER), Stack trace (when copying this message, always include the lines below):

    ...
    3. /build/build_docker/../src/Common/Exception.cpp:56: DB::Exception::Exception()
    4. /build/build_docker/../src/Processors/Formats/Impl/ProtobufRowOutputFormat.cpp:43: DB::ProtobufRowOutputFormat::write()
    5. /build/build_docker/../src/Processors/Formats/IRowOutputFormat.cpp:34: DB::IRowOutputFormat::consume()
    6. /build/build_docker/../src/Processors/Formats/IOutputFormat.cpp:115: DB::IOutputFormat::write()
    7. /build/build_docker/../src/Client/ClientBase.cpp:398: DB::ClientBase::onData()

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/35865/b862fa7f3ede7d30b7c606c06e7fe1e273b49d32/stateless_tests__thread__actions__[3/3].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 15:22:16 +03:00
Alexander Tokmakov
457a9e9691 fixes for ReplicatedMergeTree 2022-04-12 14:14:26 +02:00
alesapin
1b7b6af268
Merge pull request #36157 from bigo-sg/fixut_coo
Fix UT error sometimes
2022-04-12 14:12:24 +02:00
jewisliu
b2c10611d1 support UNSIGNED modifier with unused parameters of INT 2022-04-12 19:49:57 +08:00
tavplubix
2e95e0db3b
Merge pull request #36133 from Algunenano/osx_atomic_exchange
Add support for atomic exchange in OSX
2022-04-12 14:10:36 +03:00
Kseniia Sumarokova
abb498c9a5
Update ClientBase.cpp 2022-04-12 12:51:19 +02:00
Kseniia Sumarokova
50b5684d00
Update FileSegment.cpp 2022-04-12 11:59:58 +02:00
Kseniia Sumarokova
97baa250b6
Merge pull request #36131 from ClickHouse/kssenii-patch-3
Update 01171_mv_select_insert_isolation_long.sh
2022-04-12 11:56:13 +02:00
tavplubix
82713f347b
Update clickhouse-test 2022-04-12 12:55:57 +03:00
alesapin
8f822af358 Fix mongodb test with new cert 2022-04-12 11:47:22 +02:00
Nikolay Degterinsky
3547e3a376
Merge pull request #35978 from nic11/pr/runner-typo
Remove arg duplication and fix a typo
2022-04-12 11:45:52 +02:00
Alexander Tokmakov
6e4787560b fix another issue 2022-04-12 11:44:25 +02:00
tavplubix
ccb45ae943
Update stress 2022-04-12 12:42:45 +03:00
Nikolay Degterinsky
0a382c28e4
Merge pull request #36155 from bharatnc/ncb/fix-typo
fix typo in cmake message
2022-04-12 11:42:20 +02:00
Vladimir C
8873d7b0e7
Merge pull request #36082 from bigo-sg/cache_hive_files 2022-04-12 11:42:08 +02:00
alesapin
34b920adb0
Merge pull request #36159 from ClickHouse/cancel-lambda
Fix a logical error left after debugging
2022-04-12 11:33:13 +02:00
tavplubix
48f9b61bdb
Update stress 2022-04-12 12:22:03 +03:00
Kseniia Sumarokova
b29202ac88
Merge pull request #36150 from kssenii/fix-cache-test
Fix test 02241_remote_filesystem_cache_on_insert for database Ordinary
2022-04-12 11:08:44 +02:00
Mikhail f. Shiryaev
30a9fce67a
Rebuild the least docker layer 2022-04-12 11:01:25 +02:00
Mikhail f. Shiryaev
abf8c3c5ad
Fix and improve cancel-rerun lambda
- Fix rerun for DocsCheck
- Additional check for workflow head sha1
- Fix workflow debug info
- Fix event_data parsing
- Always print debug info
2022-04-12 11:00:01 +02:00
Kseniia Sumarokova
74515a3523
Merge pull request #36057 from azat/client-cancel
clickhouse-client: fix query cancellation if any result was not received yet
2022-04-12 09:40:20 +02:00
Kseniia Sumarokova
a77a228ab8
Update FileSegment.cpp 2022-04-12 09:37:03 +02:00
Kseniia Sumarokova
9d88f84180
Merge pull request #36153 from bigo-sg/fix_hdfs_read_buffer
Fix bug of read buffer from hdfs
2022-04-12 08:53:39 +02:00
Mikhail f. Shiryaev
280a2d847c
Merge pull request #36139 from ClickHouse/fasttest-ccache
Upload ccache for the first run in PR
2022-04-12 08:37:21 +02:00
zhanglistar
0ae820550d fix ut error sometimes 2022-04-12 14:30:53 +08:00
bharatnc
6b07105de6 fix typo in cmake message 2022-04-11 22:38:23 -07:00
bharatnc
e5494de63c h3Res0Indexes - remove unused array 2022-04-11 22:18:55 -07:00