thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-27 01:51:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
132,353 Commits 9,198 Branches 1,782 Tags 2.1 GiB
f4546a5eee
Commit Graph

132353 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Azat Khuzhin
9b6c8cd44f Fix possible NULL dereference during symbolizing inline frames 
It is possible sometimes:

<details>

```
2024.01.02 15:18:49.542342 [ 102142 ] {} <Fatal> BaseDaemon: Address: NULL pointer. Access: read. Address not mapped to object.
2024.01.02 15:18:49.542356 [ 102142 ] {} <Fatal> BaseDaemon: Stack trace: 0x0000000012817007 0x00000000120b3e88 0x000000001209c3e8 0x000000001209b7f3 0x000000001213d936 0x0000000011f71042 0x0000000011f6dd22 0x0000
000012496116 0x000000001249181c 0x00000000133197ec 0x000000001332bc79 0x0000000015d0eb14 0x0000000015d0fd11 0x0000000015e1b367 0x0000000015e195fc 0x00007f011cb31fa3 0x00007f011ca624cf
2024.01.02 15:18:50.052773 [ 102142 ] {} <Fatal> BaseDaemon: 2.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:603: shared_ptr<DB::Context, void>
2024.01.02 15:18:50.052829 [ 102142 ] {} <Fatal> BaseDaemon: 2.2. inlined from ./build_docker/./src/Planner/PlannerContext.h:56: DB::PlannerContext::getQueryContext() const
2024.01.02 15:18:50.052853 [ 102142 ] {} <Fatal> BaseDaemon: 2.3. inlined from ./build_docker/./src/Storages/StorageDistributed.cpp:666: DB::(anonymous namespace)::buildQueryTreeDistributed(DB::SelectQueryInfo&, s
td::shared_ptr<DB::StorageSnapshot> const&, DB::StorageID const&, std::shared_ptr<DB::IAST> const&)
2024.01.02 15:18:50.052872 [ 102142 ] {} <Fatal> BaseDaemon: 2. ./build_docker/./src/Storages/StorageDistributed.cpp:743: DB::StorageDistributed::read(DB::QueryPlan&, std::vector<String, std::allocator<String>> co
nst&, std::shared_ptr<DB::StorageSnapshot> const&, DB::SelectQueryInfo&, std::shared_ptr<DB::Context const>, DB::QueryProcessingStage::Enum, unsigned long, unsigned long) @ 0x0000000012817007 in /usr/lib/debug/usr
/bin/clickhouse.debug
2024.01.02 15:18:50.211769 [ 102142 ] {} <Fatal> BaseDaemon: 3.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:815: std::shared_ptr<DB::Context>::operator->[abi:v15000]()
 const
2024.01.02 15:18:50.211815 [ 102142 ] {} <Fatal> BaseDaemon: 3. ./build_docker/./src/Interpreters/InterpreterSelectQuery.cpp:2488: DB::InterpreterSelectQuery::executeFetchColumns(DB::QueryProcessingStage::Enum, DB
::QueryPlan&) @ 0x00000000120b3e88 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.295382 [ 102142 ] {} <Fatal> BaseDaemon: 4. ./build_docker/./src/Interpreters/InterpreterSelectQuery.cpp:1444: DB::InterpreterSelectQuery::executeImpl(DB::QueryPlan&, std::optional<DB::Pipe>) @
 0x000000001209c3e8 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.375779 [ 102142 ] {} <Fatal> BaseDaemon: 5.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/optional:260: ~__optional_destruct_base
2024.01.02 15:18:50.375820 [ 102142 ] {} <Fatal> BaseDaemon: 5. ./build_docker/./src/Interpreters/InterpreterSelectQuery.cpp:868: DB::InterpreterSelectQuery::buildQueryPlan(DB::QueryPlan&) @ 0x000000001209b7f3 in
/usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.403975 [ 102142 ] {} <Fatal> BaseDaemon: 6. ./build_docker/./src/Interpreters/InterpreterSelectWithUnionQuery.cpp:0: DB::InterpreterSelectWithUnionQuery::buildQueryPlan(DB::QueryPlan&) @ 0x0000
00001213d936 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.432051 [ 102142 ] {} <Fatal> BaseDaemon: 7.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:603: shared_ptr<DB::Context, void>
2024.01.02 15:18:50.432472 [ 102143 ] {} <Fatal> BaseDaemon: ########## Short fault info ############
2024.01.02 15:18:50.432500 [ 102143 ] {} <Fatal> BaseDaemon: (version 23.9.2.56 (official build), build id: 76109A79FA62B9BC630A6C39438DEA7D28147B68, git hash: a1bf3f1de5) (from threa
d 102142) Received signal 11
2024.01.02 15:18:50.432516 [ 102143 ] {} <Fatal> BaseDaemon: Signal description: Segmentation fault
2024.01.02 15:18:50.432526 [ 102143 ] {} <Fatal> BaseDaemon: Address: NULL pointer. Access: read. Address not mapped to object.
2024.01.02 15:18:50.432539 [ 102143 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f011cac5181 0x0000000015ccd934 0x000000000c76771e 0x000000000ca0fe32 0x000000000ca0ccf5 0x00007f011cb31fa3 0x00007f011ca624cf
2024.01.02 15:18:50.432547 [ 102143 ] {} <Fatal> BaseDaemon: ########################################
2024.01.02 15:18:50.432565 [ 102143 ] {} <Fatal> BaseDaemon: (version 23.9.2.56 (official build), build id: 76109A79FA62B9BC630A6C39438DEA7D28147B68, git hash: a1bf3f1de5) (from threa
d 102142) (no query) Received signal Segmentation fault (11)
```

```
2024.01.02 15:18:50.432588 [ 102143 ] {} <Fatal> BaseDaemon: Address: NULL pointer. Access: read. Address not mapped to object.
2024.01.02 15:18:50.432601 [ 102143 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f011cac5181 0x0000000015ccd934 0x000000000c76771e 0x000000000ca0fe32 0x000000000ca0ccf5 0x00007f011cb31fa3 0x00007f011ca624cf
2024.01.02 15:18:50.432638 [ 102143 ] {} <Fatal> BaseDaemon: 2. ? @ 0x000000000015c181 in /usr/lib/x86_64-linux-gnu/libc-2.28.so
2024.01.02 15:18:50.446953 [ 102143 ] {} <Fatal> BaseDaemon: 3.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/string:1955: String::__init(char const*, unsigned long)
2024.01.02 15:18:50.446981 [ 102143 ] {} <Fatal> BaseDaemon: 3.2. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/string:843: basic_string<std::nullptr_t>
2024.01.02 15:18:50.446998 [ 102143 ] {} <Fatal> BaseDaemon: 3. ./build_docker/./base/base/demangle.cpp:25: demangle(char const*, int&) @ 0x0000000015ccd934 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.458431 [ 102143 ] {} <Fatal> BaseDaemon: 4. ./build_docker/./src/Common/StackTrace.cpp:389: void toStringEveryLineImpl<std::function<void (std::basic_string_view<char, std::char_traits<char>>)>>(bool, StackTraceRefTriple const&, std::function<void (std::basic_string_view<char, std::char_traits<char>>)>&&) (.llvm.10713299015003964940) @ 0x000000000c76771e in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.474955 [ 102143 ] {} <Fatal> BaseDaemon: 5.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__functional/function.h:818: ~__policy_func
2024.01.02 15:18:50.474997 [ 102143 ] {} <Fatal> BaseDaemon: 5.2. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__functional/function.h:1174: ~function
2024.01.02 15:18:50.475010 [ 102143 ] {} <Fatal> BaseDaemon: 5. ./build_docker/./src/Daemon/BaseDaemon.cpp:415: SignalListener::onFault(int, siginfo_t const&, ucontext_t*, StackTrace const&, std::vector<std::array<void*, 45ul>, std::allocator<std::array<void*, 45ul>>> const&, unsigned int, DB::ThreadStatus*) const @ 0x000000000ca0fe32 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.512270 [ 102143 ] {} <Fatal> BaseDaemon: 6.1. inlined from ./build_docker/./src/Daemon/BaseDaemon.cpp:284: operator()
2024.01.02 15:18:50.512591 [ 102143 ] {} <Fatal> BaseDaemon: 6.2. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__functional/invoke.h:394: decltype(std::declval<SignalListener::run()::'lambda'()>()()) std::__invoke[abi:v15000]<SignalListener::run()::'lambda'()>(SignalListener::run()::'lambda'()&&)
2024.01.02 15:18:50.512648 [ 102143 ] {} <Fatal> BaseDaemon: 6.3. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/thread:284: void std::__thread_execute[abi:v15000]<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>(std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>&, std::__tuple_indices<>)
2024.01.02 15:18:50.512664 [ 102143 ] {} <Fatal> BaseDaemon: 6. ./build_docker/./contrib/llvm-project/libcxx/include/thread:295: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>>(void*) @ 0x000000000ca0ccf5 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.512698 [ 102143 ] {} <Fatal> BaseDaemon: 7. start_thread @ 0x0000000000007fa3 in /usr/lib/x86_64-linux-gnu/libpthread-2.28.so
2024.01.02 15:18:50.512721 [ 102143 ] {} <Fatal> BaseDaemon: 8. ? @ 0x00000000000f94cf in /usr/lib/x86_64-linux-gnu/libc-2.28.so
2024.01.02 15:18:50.666148 [ 102143 ] {} <Fatal> BaseDaemon: Integrity check of the executable successfully passed (checksum: 3A99FBFAA2DA54D46975E9ABC04E53E0)
2024.01.02 15:18:50.746677 [ 102143 ] {} <Fatal> BaseDaemon: Report this error to https://github.com/ClickHouse/ClickHouse/issues
```

**The problem is actually here** - [1].
Though to be precise here - [2].
See also - [3].

  [1]: 5e467b69c8/src/Common/StackTrace.cpp (L405)
  [2]: 4d734cf1e5/src/Common/StackTrace.cpp (L389)
  [3]: 5e467b69c8/src/Common/Dwarf.cpp (L1161)

_(It is not obvious from the patch, so will post a snippet)_

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-08 21:16:49 +03:00
Sema Checherinda
378602e1c8
Update 02675_profile_events_from_query_log_and_client.reference 2024-01-08 18:29:41 +01:00
Mikhail f. Shiryaev
5e467b69c8
Merge pull request #58600 from ClickHouse/release-script-simplify 
Simplify release.py script
 2024-01-08 21:12:45 +04:00
Antonio Andelic
4640049b4a
Merge pull request #58598 from ClickHouse/keeper-small-fix 
Small fix in Keeper
 2024-01-08 17:07:16 +01:00
jinjunzh
cf53d9a17c add USE_QAT into build_options 2024-01-08 11:05:36 -05:00
Anton Popov
3e933c9099 Merge remote-tracking branch 'upstream/master' into HEAD 2024-01-08 15:33:38 +00:00
Sema Checherinda
55ec1a17e7 remove debug logging 2024-01-08 15:58:47 +01:00
Sema Checherinda
9bd4851223 fix 02675_profile_events_from_query_log_and_client 2024-01-08 15:35:18 +01:00
Mikhail f. Shiryaev
a2a3783366
Small renaming to reflect the current release process 2024-01-08 15:31:59 +01:00
Mikhail f. Shiryaev
fe19f45974
Simplify --type argument for release.py 2024-01-08 15:31:58 +01:00
Mikhail f. Shiryaev
2232663216
Insignificant typing improvements 2024-01-08 15:31:57 +01:00
Mikhail f. Shiryaev
90a64ae5b8
Merge pull request #58384 from ClickHouse/reliable-tokens 
Do not fail the CI on an expired token
 2024-01-08 18:26:18 +04:00
Nikolai Kochetov
564847f9cf
Merge pull request #58602 from ClickHouse/KochetovNicolai-patch-1 
Update analyzer_tech_debt.txt
 2024-01-08 14:48:31 +01:00
Nikolai Kochetov
7abb850757
Update analyzer_tech_debt.txt 2024-01-08 14:46:22 +01:00
Nikolai Kochetov
9f50b43dd8
Merge pull request #58599 from ClickHouse/KochetovNicolai-patch-1 
Update analyzer_tech_debt.txt
 2024-01-08 14:40:04 +01:00
Nikolai Kochetov
2e7a0bfd1c
Update analyzer_tech_debt.txt 2024-01-08 14:27:05 +01:00
Nikolai Kochetov
7f84b76993
Update analyzer_tech_debt.txt 2024-01-08 14:26:18 +01:00
Robert Schulze
fb4fd29110
Merge pull request #58454 from rschu1ze/punycode-revert-revert 
Implement IDNA and punycode encoding/decoding (2nd attempt)
 2024-01-08 14:26:03 +01:00
Nikolai Kochetov
77b349b136
Update analyzer_tech_debt.txt 2024-01-08 13:25:28 +01:00
vdimir
e68fc2df7a
Remove spaces after insert in clickhouse-format 2024-01-08 12:16:53 +00:00
Antonio Andelic
a891750f53 Fix race 2024-01-08 12:08:17 +00:00
vdimir
cccc24c2fd
upd 2024-01-08 12:01:34 +00:00
vdimir
621d17b16f
Better clickhouse-format: support VALUES, comments 2024-01-08 12:01:33 +00:00
Robert Schulze
f3c77c046a
makeDateTime64(): Allow non-const fraction argument 2024-01-08 11:58:32 +00:00
Antonio Andelic
6aee18ced8
Merge pull request #58487 from ClickHouse/keeper-lower-log-levels-test 
Lower log levels for some Raft logs to new test level
 2024-01-08 12:19:02 +01:00
vdimir
631e16d8c3
Fix off-by-one error for max_joined_block_rows 2024-01-08 11:02:17 +00:00
vdimir
8dad3f1b22
Add test 02962_max_joined_block_rows 2024-01-08 10:58:26 +00:00
Raúl Marín
c1b95560db Add some missing LLVM includes 2024-01-08 11:25:57 +01:00
vdimir
0f2588334f
Disable max_joined_block_rows in ConcurrentHashJoin 2024-01-08 10:20:39 +00:00
Antonio Andelic
c7b9f4aaed
Merge pull request #58455 from ClickHouse/keeper-even-better-startup 
Avoid huge memory consumption during Keeper startup for more cases
 2024-01-08 10:46:17 +01:00
Mikhail f. Shiryaev
f38510be86
Do not fail the CI on an expired token 2024-01-08 10:43:55 +01:00
Raúl Marín
8f998eaa82
Merge pull request #58447 from canhld94/fix_symlink_in_user_files 
Allow users to work with symlinks in user_files_path (again)
 2024-01-08 10:40:36 +01:00
Robert Schulze
7e19577764
Minor fixups 2024-01-08 09:22:53 +00:00
Robert Schulze
6665d23243
Merge pull request #58029 from skyoct/feat/server_settings 
Add `changeable_without_restart` column to `system.server_settings`
 2024-01-08 10:09:51 +01:00
Duc Canh Le
fd809956f0 fix style check 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
 2024-01-08 08:14:09 +00:00
kevinyhzou
a293ade11b modify code 2024-01-08 14:43:29 +08:00
Alexey Milovidov
06274c7bc6
Merge pull request #58588 from ClickHouse/keeper-wrong-message 
Fix wrong message in Keeper
 2024-01-08 05:26:17 +01:00
Duc Canh Le
149de9aa93 discard fs::canonical return 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
 2024-01-08 03:40:48 +00:00
robot-clickhouse
29173a602e Automatic style fix 2024-01-08 02:39:19 +00:00
Alexey Milovidov
eb8217efb0 Fix wrong message in Keeper 2024-01-08 01:22:11 +01:00
Alexey Milovidov
174f07707a
Merge pull request #58586 from ClickHouse/don-t-load-database-engines-in-suggest 
Do not load database engines in suggest
 2024-01-07 23:07:07 +01:00
Alexey Milovidov
2c61015578 Do not load database engines in suggest 2024-01-07 23:06:36 +01:00
Sema Checherinda
6f626d8294 fix auth_settings.hasUpdates function 2024-01-07 23:00:26 +01:00
Alexey Milovidov
6bc27dfcf5 Enable all access control improvements by default 2024-01-07 20:56:16 +01:00
Eyal Halpern Shalev
14a869e518
Support CLICKHOUSE_PASSWORD_FILE environment variable in Dockerfile 
Implement #58575
 2024-01-07 21:10:57 +02:00
Alexander Tokmakov
ab82adfbea
Merge pull request #58574 from ClickHouse/tavplubix-patch-10 
Follow-up to #58482
 2024-01-07 19:51:50 +01:00
Robert Schulze
14cda082d2
Fix style 2024-01-07 18:08:52 +00:00
Robert Schulze
8a9d4cbf8a
Add method byte 2024-01-07 17:52:13 +00:00
Robert Schulze
0f51e32bb5
Rename from ZSTDQPL to ZSTD_QPL 2024-01-07 17:47:31 +00:00
Robert Schulze
21d14e488b
Cosmetics 2024-01-07 16:47:12 +00:00