Commit Graph

2901 Commits

Author SHA1 Message Date
Azat Khuzhin
82e0e9d27c Fix minmax partition index during merge in case of empty part in future parts
It is possible to get empty part in future parts, during merging, that
can be created in case of there is information about this part in
zookeeper, but no replicas has it
(StorageReplicatedMergeTree::createEmptyPartInsteadOfLost())

And this may incorrectly initialize min value, which will be updated
after one more merge (since during that merge there will be no more
information about empty part) or OPTIMIZE.
2021-12-04 21:49:49 +03:00
tavplubix
17f8193435
Merge pull request #32157 from ClickHouse/fix_active_replicas_count_quorum
Fix active replicas count in quorum inserts
2021-12-03 12:39:36 +03:00
Anton Popov
f6be3d16fd
Merge pull request #24820 from kssenii/versioning
Versioning of aggregate function states
2021-12-03 01:41:44 +03:00
tavplubix
4606376734
Update ReplicatedMergeTreeSink.cpp 2021-12-02 21:51:23 +03:00
Alexander Tokmakov
252192bc6d fix active replicas count in quorum inserts 2021-12-02 21:02:11 +03:00
Anton Ivashkin
98bae1b313 Fix tests 2021-12-02 16:25:45 +03:00
taiyang-li
2f4e7e1d4e merge master 2021-12-02 19:48:21 +08:00
tavplubix
5400c5899d
Merge pull request #32063 from ClickHouse/fix_detach_dir_exists
Fix 'directory exists' error when detaching part
2021-12-02 14:04:21 +03:00
kssenii
8edf146687 Merge branch 'master' of github.com:ClickHouse/ClickHouse into versioning 2021-12-02 07:57:14 +00:00
Anton Ivashkin
e0a16a483e Merge master 2021-12-01 19:03:31 +03:00
Amos Bird
8dbc7a8dae
Fix detaching parts with projections 2021-12-01 23:21:17 +08:00
tavplubix
7ae45b9d52
Update IMergeTreeDataPart.cpp 2021-12-01 18:00:40 +03:00
Alexander Tokmakov
57e4f3698c fix 'directory exists' error when detaching part 2021-12-01 17:24:26 +03:00
Anton Ivashkin
80ab73c691 Fix Zero-Copy replication lost locks, fix remove used remote data in DROP DETACHED PART 2021-12-01 16:11:26 +03:00
Anton Popov
54f51444c0 Merge remote-tracking branch 'upstream/master' into HEAD 2021-12-01 15:49:02 +03:00
tavplubix
b623a387af
Merge pull request #31887 from ClickHouse/fix_cannot_create_empty_part
Parse partition key value from `partition_id` when need to create part in empty partition
2021-12-01 15:38:46 +03:00
Alexander Tokmakov
caaae03df3 change to switch-case 2021-11-30 15:29:05 +03:00
mergify[bot]
d729cd50b3
Merge branch 'master' into fixnullablekey 2021-11-30 11:44:35 +00:00
tavplubix
78224ef273
Merge pull request #31738 from ClickHouse/fix_segfault_on_attach_partition
Fix segfault on attach parititon
2021-11-30 14:32:50 +03:00
Alexander Tokmakov
2cf4b51029 fix 2021-11-29 21:54:46 +03:00
Alexander Tokmakov
56b613068b fix 2021-11-29 21:47:08 +03:00
Anton Ivashkin
0f9038ebed Zero-copy: move shared mark outside table node in ZooKeeper 2021-11-29 19:05:31 +03:00
Amos Bird
29c87b2f44
Fix nullable key 2021-11-29 20:49:01 +08:00
Alexander Tokmakov
2fb00172a9 try parse partition key value from partition_id 2021-11-27 15:07:08 +03:00
kssenii
be3b4ca8fe Merge branch 'master' of github.com:ClickHouse/ClickHouse into versioning 2021-11-27 09:44:31 +00:00
kssenii
515261f5dd Better 2021-11-27 09:40:46 +00:00
Raúl Marín
f0ee0724ac Reduce dependencies on ASTSelectQuery.h
243 -> 152
2021-11-26 18:35:24 +01:00
Raúl Marín
b2cfa70541 Reduce dependencies on ASTFunction.h
481 -> 230
2021-11-26 18:21:54 +01:00
Raúl Marín
91bf938075 Reduce dependencies on ASTLiteral.h
590 -> 537
2021-11-26 17:54:57 +01:00
Raúl Marín
051dddd8df Reduce dependencies on ASTIdentifier.h
Goes from rebuilding 483 objects to 165 when it's modified
2021-11-26 16:49:40 +01:00
Alexander Tokmakov
1ab8b5d4df fix segfault on attach parititon 2021-11-25 13:04:39 +03:00
taiyang-li
89dcef69d5 merge master 2021-11-24 14:38:04 +08:00
tavplubix
7a43a87f5b
Use shard and replica name from Replicated database arguments (#31488)
* fix another issue

* use shard and replica name from Replicated database

* fix

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-23 12:41:54 +03:00
lgbo
996d7125c0
Merge branch 'master' into hive_table 2021-11-23 10:19:02 +08:00
Anton Popov
43cfa4467b
Merge pull request #31476 from CurtizJ/merging-constraints
Merging #18787 (Constraints)
2021-11-22 15:57:59 +03:00
Nikolai Kochetov
b814f54f50
Merge pull request #31474 from amosbird/projection-improve6
Allow partition column to be used for minmax_count projection
2021-11-22 13:01:57 +03:00
Anton Popov
c034491da9 fix style check 2021-11-21 23:02:33 +03:00
Anton Popov
afe8d3c424 refactor merged index conditions 2021-11-21 22:49:34 +03:00
tavplubix
711b738dd1
Merge pull request #31542 from ClickHouse/mutations_remove_multimap
Remove strange multimap for mutations in StorageMergeTree
2021-11-20 20:41:49 +03:00
Alexander Tokmakov
8d7413b0d6 remove strange multimap from mutations 2021-11-19 19:54:43 +03:00
Anton Popov
099c40d251 fix tests 2021-11-19 17:14:56 +03:00
taiyang-li
e8644807fe merge master and solve conflict 2021-11-19 15:01:58 +08:00
Amos Bird
c47ec31617
fix 2021-11-19 11:51:05 +08:00
Vitaly Baranov
6634fcbac7 Rename Quota::ResourceType -> QuotaType and move it to Access/Common. 2021-11-19 00:14:23 +03:00
alexey-milovidov
12a471507e
Merge pull request #31169 from sundy-li/notlike-fix
ISSUES-30801: Remove not like function into RPNElement
2021-11-18 23:40:57 +03:00
Amos Bird
d1a14d76f1
fix 2021-11-19 02:29:35 +08:00
Amos Bird
c988a4e770
fix again 2021-11-18 23:09:17 +08:00
Anton Popov
dfb9bc2a01 minor fixes in constraints 2021-11-17 18:43:02 +03:00
Amos Bird
feb3a12d34
fix 2021-11-17 23:11:23 +08:00
Amos Bird
4cfb105d5a
better 2021-11-17 22:07:56 +08:00
Amos Bird
7b9a19f066
enhance minmax_count projection 2021-11-17 22:05:57 +08:00
alexey-milovidov
1e058fb207
Merge pull request #30190 from azat/ReadBuffer-throw-on-empty
Do not allow zero-length reads
2021-11-17 10:21:08 +03:00
mergify[bot]
41fa94f482
Merge branch 'master' into notlike-fix 2021-11-17 07:14:21 +00:00
Amos Bird
30b06a969b
Cancel vertical merges (#31057)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-15 14:32:53 +03:00
alesapin
af820f85d3
Merge pull request #31259 from azat/temporary_directories_lifetime-message-fix
Print warning during old directories cleanup in MergeTree only if it is old
2021-11-15 12:56:31 +03:00
kssenii
37f482d478 Merge branch 'master' of github.com:ClickHouse/ClickHouse into versioning 2021-11-15 07:31:11 +00:00
alesapin
2a9ed85f23
Merge pull request #31300 from ClickHouse/fix_intersecting_parts_to_do3
Remove strange code from mutations
2021-11-15 10:08:32 +03:00
mergify[bot]
5d0306ed0c
Merge branch 'master' into notlike-fix 2021-11-12 22:35:10 +00:00
Maksim Kita
38be11a622
Merge pull request #31334 from kitaisreal/bloom-filter-index-check-fix
BloomFilter index check fix
2021-11-13 01:26:08 +03:00
Maksim Kita
1b5ff67eaa BloomFilter index check fix 2021-11-12 12:22:43 +03:00
Kseniia Sumarokova
2313981fd7
Merge pull request #31260 from azat/external-cleanup
Cleanup extern ProfileEvents/CurrentMetrics and add a style check
2021-11-12 00:02:57 +03:00
Azat Khuzhin
10fa34c73a Print warning during old directories cleanup in MergeTree only if it is old 2021-11-11 23:57:44 +03:00
Alexander Tokmakov
5858a4f74f remove strange code from mutations 2021-11-11 17:03:33 +03:00
Alexander Tokmakov
627dde7aba Merge branch 'master' into merge_selecting_backoff 2021-11-11 13:43:10 +03:00
taiyang-li
af78116c3f
Merge branch 'master' into hive_table 2021-11-11 11:52:28 +08:00
Azat Khuzhin
baf14444e6 Cleanup ProfileEvents and CurrentMetrics 2021-11-10 21:15:27 +03:00
Azat Khuzhin
47a18e8ac5 Remove non existing BackgroundPoolTask in ReplicatedMergeTreeQueue 2021-11-10 21:15:26 +03:00
Anton Popov
833652e8f4 Merge branch 'nikvas0/simple_optimizations' of git://github.com/nikvas0/ClickHouse into merging-constraints 2021-11-10 19:35:28 +03:00
Vitaly Baranov
1579bcfd20
Merge pull request #31178 from vitlibar/backup-engines-and-improvements
Backup engines and improvements
2021-11-10 18:20:41 +03:00
Vitaly Baranov
e0f475c724 Split backup implementation into two parts to help implementing other backup engines. 2021-11-10 11:03:03 +03:00
taiyang-li
26988ab757
Merge branch 'master' into hive_table 2021-11-10 11:01:03 +08:00
sundy-li
d8aaac36ec Add stable order by tests result 2021-11-09 21:34:55 +08:00
sundy-li
45cab9f3b0 Add stable order by tests result 2021-11-09 21:31:31 +08:00
Alexander Tokmakov
51bd98294e better merge selecting backoff 2021-11-09 15:26:51 +03:00
sundy-li
3a981de643 ISSUES-30801: Remove not like function into RPNElement 2021-11-09 10:57:37 +08:00
Kseniia Sumarokova
1167e5aae8
Merge pull request #31112 from kssenii/fix-async-reads
Fix threadpool read for remote disks
2021-11-08 22:10:30 +03:00
Anton Popov
13b35a6817 Merge remote-tracking branch 'upstream/master' into HEAD 2021-11-08 21:29:16 +03:00
Anton Popov
66973a2a28 Merge remote-tracking branch 'upstream/master' into HEAD 2021-11-08 21:27:45 +03:00
Anton Popov
a7f219b3aa better sampling in ColumnSparse and fix alter rename column 2021-11-08 21:25:31 +03:00
tavplubix
7079a6abff
Merge pull request #31060 from ClickHouse/fix_intersecting_parts_to_do2
Fix intersecting parts in `parts_to_do` 2
2021-11-08 20:08:13 +03:00
taiyang-li
c5bc968140 Merge remote-tracking branch 'ck/master' into bigo_hive_table 2021-11-08 18:38:14 +08:00
Amr Alaa
ad81977ace
Skip max_partition_size_to_drop check in case of ATTACH PARTITION ... FROM (#30995)
* Skip checkPartitionCanBeDropped check in case of ATTACH PARTITION ... FROM

* Add integration test

* Fix syntax error

* Fix integration test

* Fix integration test

* Fix integration test

* Skip max_partition_size_to_drop for MOVE PARTITION
2021-11-08 13:07:14 +03:00
kssenii
b4bebc5977 Add comments 2021-11-08 12:01:24 +03:00
mergify[bot]
9606b11903
Merge branch 'master' into fix_intersecting_parts_to_do2 2021-11-08 07:18:42 +00:00
kssenii
9189966106 Fix 2021-11-05 20:01:21 +03:00
taiyang-li
36ca0b296b implement hive table engine 2021-11-05 19:55:30 +08:00
Anton Popov
84e914e05a minor fixes near serializations 2021-11-05 01:46:00 +03:00
Anton Popov
f37d12d16e keep serialization infos after drops and renames 2021-11-03 23:29:48 +03:00
Alexander Tokmakov
d4677dc6d8 fix intersecting parts in parts_to_do 2 2021-11-03 21:48:17 +03:00
Nikita Mikhaylov
59c8ed9b0c
Fixed is_cancelled predicate inside MergeTask (#30996) 2021-11-03 13:25:45 +03:00
Anton Popov
46fa062a81 fix tests 2021-11-02 23:30:28 +03:00
Anton Popov
e1ab0ad383 fix tests 2021-11-02 20:46:03 +03:00
Anton Popov
1628f50e51
Merge branch 'master' into sparse-serialization 2021-11-02 06:26:18 +03:00
Anton Popov
9823f28855 fix nested 2021-11-02 06:03:52 +03:00
alexey-milovidov
af4a0a9ed2
Merge pull request #29528 from DimasKovas/allow_nulls_first_in_key_condition
Support NULLS FIRST in KeyCondition
2021-11-01 23:02:22 +03:00
alexey-milovidov
38f7d1ebc2
Update KeyCondition.cpp 2021-11-01 22:59:57 +03:00
Vitaly Baranov
3bc9bf28f4
Merge pull request #30688 from vitlibar/backup-and-restore-for-log-family
Implement BACKUP & RESTORE for Log family
2021-11-01 19:57:39 +03:00
Anton Popov
d50137013c Merge remote-tracking branch 'upstream/master' into HEAD 2021-11-01 16:55:53 +03:00
Anton Popov
a2b98f253e fix nested 2021-11-01 16:52:13 +03:00
Vitaly Baranov
a1f29d31ea Support BACKUP & RESTORE for log family. 2021-11-01 12:07:17 +03:00
Vladimir C
2e58a3bf62
Merge branch 'master' into MDB-15168 2021-11-01 11:59:13 +03:00
Anton Popov
8fe3de16c6 fix nested 2021-11-01 05:40:43 +03:00
Anton Popov
c66207f606 fix nested 2021-11-01 05:13:07 +03:00
mergify[bot]
3cb034880b
Merge branch 'master' into allow_nulls_first_in_key_condition 2021-10-31 12:19:08 +00:00
alexey-milovidov
34009ea4a3
Merge pull request #30310 from amosbird/projection-fix20
Fix IN set filtering when projection is used.
2021-10-31 15:00:45 +03:00
Amos Bird
b3a8ad124f
Fix index analysis for set index 2021-10-31 12:35:20 +08:00
Anton Popov
0099dfd523 refactoring of SerializationInfo 2021-10-29 20:21:02 +03:00
Amos Bird
211c3d4d49
Better Projection IN 2021-10-29 20:24:36 +08:00
kssenii
7e2ea97e3c Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read 2021-10-28 18:46:21 +03:00
Anton Ivashkin
6cda420b56 Cleanup after fail in localBackup 2021-10-28 17:50:59 +03:00
tavplubix
33ffe11d03
Merge pull request #30346 from ClickHouse/fix_some_fetches_may_stuck
Try fix 'some fetches may stuck'
2021-10-28 13:10:15 +03:00
kssenii
3d01fbf603 Review fixes 2021-10-28 11:32:37 +03:00
kssenii
9461e225bb Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read 2021-10-27 22:47:47 +03:00
Azat Khuzhin
a1926b3a55 Fix MergeTreeReaderCompact with empty buffer (max_read_buffer_size=0)
CI: https://clickhouse-test-reports.s3.yandex.net/30190/0682d80f603d934eda51c93959164ee29eb52c02/functional_stateless_tests_(debug).html#fail1
2021-10-27 22:25:03 +03:00
Alexander Tokmakov
5e622d4c98 fix another issue 2021-10-27 15:59:26 +03:00
alesapin
2af950d4d5
Merge pull request #30658 from ClickHouse/std_mutex_alter_lock
Change `alter_lock` from `RWLock` to `std::timed_mutex`
2021-10-27 11:14:11 +03:00
alesapin
a29711f1d0
Merge pull request #30651 from ClickHouse/fix_intersecting_parts_to_do
Fix intersecting parts in `parts_to_do`
2021-10-27 10:52:21 +03:00
alesapin
8749f4a31a
Merge pull request #29043 from nvartolomei/nv/parts-uuid-move-shard-kill
Part movements between shards improvements and cancel support
2021-10-27 10:46:00 +03:00
Dmitry Novik
e971871a95
Merge pull request #30668 from azat/prewhere-always-true-where
Fix PREWHERE with WHERE in case of always true PREWHERE
2021-10-26 17:18:50 +03:00
Alexander Tokmakov
6be1e98342 fix 2021-10-26 17:06:48 +03:00
mergify[bot]
ce88a84e88
Merge branch 'master' into nv/parts-uuid-move-shard-kill 2021-10-26 11:09:19 +00:00
Alexander Tokmakov
2e7e195e77 change alter_lock to std::timed_mutex 2021-10-26 13:37:00 +03:00
Azat Khuzhin
16cd70aee9 Fix PREWHERE with WHERE in case of always true PREWHERE 2021-10-26 00:02:41 +03:00
Alexander Tokmakov
5cdd9a4b99 fix intersecting parts in parts_to_do 2021-10-25 19:00:55 +03:00
Alexander Tokmakov
94088f8197 minor fixes 2021-10-25 17:01:36 +03:00
Alexander Tokmakov
075c3a37f4 Merge branch 'master' into fix_some_fetches_may_stuck 2021-10-25 15:28:54 +03:00
alesapin
28bde879ed
Merge pull request #30455 from kssenii/deprecate-setting
Deprecate write_final_mark setting
2021-10-25 10:51:49 +03:00
kssenii
52296e8b04 Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read 2021-10-25 00:22:32 +03:00
kssenii
13a2a3d307 Merge branch 'master' of github.com:ClickHouse/ClickHouse into deprecate-setting 2021-10-24 23:05:21 +03:00
kssenii
658b33717f A little nicer 2021-10-24 20:43:34 +03:00
Azat Khuzhin
f9b27608f5 Fix reading of columns if offset_in_compressed_file is the same for mark range
Fixes: 00078_group_by_arrays
2021-10-24 18:58:22 +03:00
Azat Khuzhin
93c34824c0 Fix explicit 0 size for createReadBufferFromFileBase() 2021-10-24 18:58:22 +03:00
Azat Khuzhin
4599e9191b Fix explicit 0 size for readFile() 2021-10-24 18:58:22 +03:00
Kseniia Sumarokova
153dd9a895
Update MergeTreeSettings.h 2021-10-22 16:27:01 +03:00
kssenii
39b9e9c258 Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read 2021-10-22 15:40:41 +03:00
Azat Khuzhin
496aa43a9f Remove check_columns argument from MergeTree code (false was never passed) 2021-10-21 21:24:59 +03:00
kssenii
56f0560c46 Asserts and read till end option 2021-10-21 20:54:03 +03:00
Dmitry Novik
58ee783be4
Merge pull request #30293 from amosbird/projection-fix19
Fix projections with JOIN alias columns
2021-10-21 17:49:21 +03:00
Anton Popov
b1a74af44d
Merge pull request #30180 from CurtizJ/remove-sample-by
Allow to remove `SAMPLE BY` expression
2021-10-21 17:09:53 +03:00
kssenii
e4e157688d Review fixes 2021-10-21 01:57:43 +03:00
Nikita Mikhaylov
56869c0ec4
Merge pull request #30360 from nikitamikhaylov/allow-graphite-final
Allow to use FINAL clause in SELECT from GraphiteMergeTree
2021-10-20 19:57:44 +03:00
kssenii
0a90be8317 Remove write_final_mark setting 2021-10-20 14:13:04 +00:00
Amos Bird
2f615e9176
Use original_query for projection analysis 2021-10-20 21:30:15 +08:00
Nikolai Kochetov
8986de7e50
Merge pull request #30384 from amosbird/projection-fix21
Fix crash when minmax_count projection is used with primary key in partition expr
2021-10-20 16:17:13 +03:00
Kseniia Sumarokova
5324cc8359
Merge pull request #30282 from kssenii/fix-local-less-threads
Less threads in clickhouse-local, fix Ok. printing
2021-10-19 22:54:28 +03:00
Amos Bird
05d93796dc
Fix minmax_count projection with primary key in partition expr 2021-10-19 23:36:07 +08:00
Nikita Mikhaylov
75487be899 White list of storages that supports final 2021-10-19 12:16:33 +00:00
Nikita Mikhaylov
4fbd332bf1 Done 2021-10-19 11:53:55 +00:00
Nikita Mikhaylov
ea2a647724
Merge pull request #30192 from azat/granula-adjust-LOGICAL_ERROR-fix
Fix reading from MergeTree with max_read_buffer_size=0
2021-10-19 13:25:55 +03:00
kssenii
e53335bc6f Better way 2021-10-19 08:21:38 +00:00