alesapin
d275d79947
Update KeeperDispatcher.cpp
2024-01-19 19:25:27 +01:00
yariks5s
76b43a6aba
small changes(revert)
2024-01-19 18:13:05 +00:00
Nikita Taranov
60a910e94f
better
2024-01-19 18:47:21 +01:00
Jiebin Sun
e9662d4d62
polish the code and adjust some code style
2024-01-20 01:43:06 +08:00
Nikita Taranov
f1efb29a66
better
2024-01-19 18:13:03 +01:00
Alexey Milovidov
044df784e0
Update getMaxFileDescriptorCount.cpp
2024-01-19 20:07:38 +03:00
Vitaly Baranov
1a1b0894eb
Rename function checkQueryNotCancelled() and add check for thread_group.
2024-01-19 18:05:30 +01:00
kssenii
4c8ced6af8
Fix log level
2024-01-19 18:04:58 +01:00
Alexey Milovidov
6a75641048
Merge pull request #58966 from ClickHouse/arseek
...
Fix seek in ReadBufferFromZipArchive
2024-01-19 18:04:03 +01:00
Alexey Milovidov
b249416671
Merge pull request #58968 from ClickHouse/clickhouse-local-less-threads
...
Less threads in `clickhouse-local`
2024-01-19 18:03:36 +01:00
Alexey Milovidov
3557bb6c73
Merge pull request #58971 from ClickHouse/better-error-message-tuples
...
Better error message about tuples
2024-01-19 18:03:13 +01:00
Antonio Andelic
0132455b39
Reduce Keeper memory usage
2024-01-19 17:00:53 +00:00
kssenii
f9fc4c9fe1
Fix style check
2024-01-19 17:59:44 +01:00
kssenii
226026e2aa
Fix
2024-01-19 17:55:03 +01:00
Nikita Taranov
a47d15ab62
impl
2024-01-19 16:59:01 +01:00
Alexey Milovidov
decdb62cef
Merge pull request #58800 from ZhiguoZh/20240115-combine-filter-bmi2
...
Optimize DB::combineFilters with BMI2/SSE intrinsics
2024-01-19 16:50:04 +01:00
Dmitry Novik
728276ab3f
Fix crash when indexHint() is used
2024-01-19 14:59:33 +00:00
zhongyuankai
cbb51659f6
Merge branch 'master' into limit_materialized_view_size
2024-01-19 22:00:12 +08:00
Nikita Taranov
0cafb58c47
impl
2024-01-19 14:17:50 +01:00
Kseniia Sumarokova
facbd89d48
Merge pull request #58986 from ClickHouse/fix-typo
...
Fix typo
2024-01-19 14:12:50 +01:00
Igor Nikonov
131f71b50a
Revert "Revert flaky"
2024-01-19 13:51:30 +01:00
Raúl Marín
477489a05d
Revert "Merge pull request #57235 from ClickHouse/pr-custom-key-failover"
...
This reverts commit 8ba9b4a7ef
, reversing
changes made to 0f39245cb8
.
2024-01-19 12:46:05 +00:00
Vitaly Baranov
19bc0b744f
Add comments and const after review.
2024-01-19 12:54:55 +01:00
Azat Khuzhin
d940afd6cd
Fix timeouts for HTTP/1.1 non-chunked requests (missing Connection: close)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-19 14:48:50 +03:00
kssenii
5113b719e9
Fix typo
2024-01-19 12:48:48 +01:00
kssenii
f055d668af
Merge remote-tracking branch 'origin/follow-up-disk-configuration' into follow-up-disk-configuration
2024-01-19 12:31:44 +01:00
kssenii
9dea75b1e7
Fix
2024-01-19 12:30:49 +01:00
avogar
b1c67f143e
Add more missing settings
2024-01-19 11:22:24 +00:00
Kseniia Sumarokova
7beb288b27
Update RegisterDiskObjectStorage.cpp
2024-01-19 12:09:58 +01:00
avogar
8f2d78bbbf
Merge branch 'master' of github.com:ClickHouse/ClickHouse into settings-changes-check
2024-01-19 11:04:50 +00:00
Azat Khuzhin
38ad4ef493
Fix timeout for prometheus exporter for HTTP/1.1 (due to keep-alive)
...
Before:
$ time curl -s --http1.1 127.1:9363/metrics > /dev/null
real 0m10.018s # default keep_alive_timeout is 10 seconds
user 0m0.005s
sys 0m0.001s
After
$ time curl -s --http1.1 127.1:9363/metrics > /dev/null
real 0m0.008s
user 0m0.006s
sys 0m0.000s
And if you will look at the test_prometheus_endpoint, you will see that
it takes > 30 seconds (it obtains metrics 3 times), after this patch it
should be finished more or less instantly.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-19 13:29:17 +03:00
kssenii
2f34ef6ff8
Follow up
2024-01-19 11:19:59 +01:00
vdimir
b8340afddf
Merge pull request #58943 from ClickHouse/vdimir/analyzer_column_not_found
...
Analyzer: fix join column not found with compound identifiers
2024-01-19 10:40:03 +01:00
Kseniia Sumarokova
1c74e7fa08
Merge pull request #58902 from ClickHouse/fs-cache-refactorings
...
fs cache: minor refactoring
2024-01-19 10:25:45 +01:00
Jiebin Sun
0fb7d2290c
Update src/Analyzer/Passes/RewriteSumFunctionWithSumAndCountPass.cpp
...
Co-authored-by: Raúl Marín <git@rmr.ninja>
2024-01-19 17:01:11 +08:00
Alexey Milovidov
e9acae7774
Merge pull request #58950 from ClickHouse/fix-data-race-in-slru-2
...
Fix data race in slru (2)
2024-01-19 09:31:25 +01:00
Alexey Milovidov
8a288055c9
Merge pull request #58949 from MikhailBurdukov/fix_s3_copy
...
Using the destination object for paths generation in S3copy.
2024-01-19 09:28:13 +01:00
Antonio Andelic
19ca00f233
Call getMaxFileDescriptorCount once
2024-01-19 08:19:20 +00:00
zhangyifan27
7e56a2d925
fix test failure when allow_experimental_analyzer=1
2024-01-19 16:11:30 +08:00
Alexey Milovidov
ff8e1d1595
Merge pull request #58930 from CurtizJ/fix-functions-to-subcolumns-pass
...
Fix `FunctionToSubcolumnsPass` in debug build
2024-01-19 08:40:55 +01:00
Alexey Milovidov
6792f72c6b
Better error message about tuples
2024-01-19 06:26:11 +01:00
Alexey Milovidov
0c1e92aea5
Less threads in clickhouse-local
2024-01-19 04:53:14 +01:00
Alexey Milovidov
dcdbaf9150
Merge pull request #58900 from MikhailBurdukov/restriction_for_s3_access_key_id
...
Restriction for the access key id for s3.
2024-01-19 04:13:17 +01:00
Alexey Milovidov
370815803e
Update Client.cpp
2024-01-19 06:12:44 +03:00
Alexey Milovidov
bcff1bac47
Merge pull request #58874 from ClickHouse/disk-minor-improvement
...
DiskWeb minor improvement in loading
2024-01-19 03:52:05 +01:00
Michael Kolupaev
3a19ea6e6c
Fix seek in ReadBufferFromZipArchive
2024-01-19 01:46:07 +00:00
Robert Schulze
1bfeee1954
Some fixups
2024-01-18 20:49:50 +00:00
Kseniia Sumarokova
7f92bf6f0b
Merge pull request #58921 from ClickHouse/add-a-test-for-azure
...
Fix and test for azure #58697
2024-01-18 21:41:54 +01:00
Vitaly Baranov
24ca8fbbec
Improve logs.
2024-01-18 21:15:39 +01:00
Vitaly Baranov
0caafe4810
Fix memory deallocation in copyDataToS3File()
...
- ReadBufferFromS3 is created now only when it's necessary and destroyed after that.
2024-01-18 20:48:56 +01:00
Robert Schulze
15700592f7
Merge remote-tracking branch 'ClickHouse/master' into column_level_compress_block
2024-01-18 19:12:57 +00:00
Nikita Taranov
b5e333df96
remove test
2024-01-18 19:56:02 +01:00
slvrtrn
0ec385064c
Add SIGNED/UNSIGNED aliases for Int64/UInt64
2024-01-18 17:28:47 +01:00
Anton Popov
d2142041cd
Merge remote-tracking branch 'upstream/master' into HEAD
2024-01-18 16:03:54 +00:00
Kseniia Sumarokova
bfe8037653
Merge branch 'master' into fix-data-race-in-slru-2
2024-01-18 16:54:52 +01:00
kssenii
d20a33424f
Fix race
2024-01-18 16:53:10 +01:00
yariks5s
6ad6d6a121
fix due to review
2024-01-18 15:41:25 +00:00
MikhailBurdukov
b3d74fc907
style
2024-01-18 15:39:25 +00:00
Robert Schulze
cf115e696b
Merge pull request #58929 from slvrtrn/mysql-show-warnings
...
Add `SHOW WARNINGS` support in MySQL interface
2024-01-18 16:24:50 +01:00
MikhailBurdukov
eac310fcb2
Review
2024-01-18 15:19:11 +00:00
Alexander Gololobov
e9919f47c1
Move paramaters from span name to attributes
2024-01-18 14:26:19 +01:00
Dmitry Novik
ba2dad98bb
Merge pull request #58913 from ClickHouse/fix-style
...
Style fix
2024-01-18 14:24:39 +01:00
Nikolai Kochetov
9db8b50753
Merge pull request #58838 from ClickHouse/allow-parallel-replicas-for-join-with-analyzer
...
Allow parallel replicas for JOIN with analyzer [part 1].
2024-01-18 14:01:08 +01:00
vdimir
f2e73c13a9
Analyzer: fix join column not found with compound identifiers
2024-01-18 12:30:28 +00:00
Vitaly Baranov
4c6d3e7efa
Add server settings "shutdown_wait_backups_and_restores" (default=true)
...
to set whether shutdown should wait for running backups to finish or just cancel them.
2024-01-18 13:27:14 +01:00
János Benjamin Antal
f34d1ae647
Use WithContext
2024-01-18 11:47:59 +00:00
MikhailBurdukov
7518241be4
Use dest object storage to native copy for path generation.
2024-01-18 11:46:16 +00:00
robot-ch-test-poll
2030d7f609
Merge pull request #58917 from azat/fix-fault-handler
...
Fix fault handler in case of thread (for fault handler) cannot be spawned
2024-01-18 12:46:03 +01:00
kssenii
dd396b678a
Fix data race
2024-01-18 12:23:40 +01:00
kssenii
9b674e640d
Fxi
2024-01-18 12:20:40 +01:00
Jiebin Sun
206e1c87e0
revise the comments
2024-01-18 19:07:02 +08:00
Robert Schulze
316669b90f
Merge pull request #58396 from zenmiao7/u/zhengmiao/AddArrayFunctionShingles
...
Add function `arrayShingles()`
2024-01-18 11:38:56 +01:00
vdimir
1595dd8a3f
Merge pull request #56396 from ClickHouse/vdimir/disable_max_rows_in_set_to_optimize_join
...
Disable max_rows_in_set_to_optimize_join
2024-01-18 10:32:28 +01:00
Duc Canh Le
b16a4cf361
add document
...
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-01-18 07:55:44 +00:00
Antonio Andelic
30a04471ac
Merge pull request #58806 from ClickHouse/fix-keeper-data-race
...
Fix data race in Keeper
2024-01-18 08:48:16 +01:00
Tim Liou
a5d15c10e8
use getPriorityName
2024-01-18 14:51:21 +08:00
robot-ch-test-poll
fba4d3f427
Merge pull request #58896 from ClickHouse/fix-data-race-aggregatetransform
...
Fix data race in `AggregatingTransform`
2024-01-18 07:46:49 +01:00
Duc Canh Le
22afcd46f4
add ALTER COLUMN MODIFY/RESET SETTING
...
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-01-18 05:17:07 +00:00
Srikanth Chekuri
c23c7e0b6f
feat: add DDSketch quantile ( #56342 )
...
* feat: add DDSketch quantile
* Fix StyleCheck
* Move quantileddsketch.md under right dir
* Update stateless test number and add stateful test
* Throw exception when relative accuracy is too low
* Update test number
* Fix undefined behaviour for empty store
* Fix quantileGK test
* Update test numbers
* Update src/AggregateFunctions/
* Throw exception on out of range values
* Update relative accuracy docs and add encoding details
* Address review comments and suggestions
* Remove unused function
* Address alexey review comments
* Remove unused function isFloat64FieldType
* Throw error on invalid relative accuracy
* Simplify mapping
* Address remaining review comments
* Add effective memory usage suggestions
* Fix Stylecheck
* Fix fast test
* Incorporate bins capacity suggestion
* Fix fuzzer
* Remove inheritance in Mapping, Store and DDSketch
* Add checks for bin resizing
* Add note about the binary compatible implementation
2024-01-17 19:51:32 -08:00
Yakov Olkhovskiy
490bb809c3
Merge pull request #58846 from ClickHouse/fix-compress-destructor
...
Fix HTTP compressors finalization
2024-01-17 17:49:12 -05:00
Anton Popov
94bb9a171d
fix FunctionToSubcolumnsPass
2024-01-17 21:36:23 +00:00
Alexey Milovidov
67f74b5520
Merge pull request #58362 from ClickHouse/fix-suspended-workers
...
Fix suspended workers for AsyncLoader
2024-01-17 22:10:43 +01:00
slvrtrn
cb8372a3f9
Add SHOW WARNINGS
support in MySQL interface
2024-01-17 22:00:48 +01:00
Alexey Milovidov
7731297aef
Merge pull request #58894 from ClickHouse/whitespace-4
...
Whitespaces
2024-01-17 21:01:22 +01:00
Alexey Milovidov
f499cf3fd5
Update Client.cpp
2024-01-17 22:30:18 +03:00
kssenii
ef48b90bca
Fix and test
2024-01-17 18:44:09 +01:00
Alexander Gololobov
0a42dbafe8
Add attributes
2024-01-17 17:46:15 +01:00
Anton Popov
72b0fed4ef
Merge pull request #58729 from CurtizJ/nested-size0
...
Fix reading of offsets subcolumn (`size0`) from `Nested`
2024-01-17 17:16:27 +01:00
Alexey Milovidov
4ac063ffe9
Merge pull request #58890 from chhetripradeep/pchhetri/add-keeper-soft-limit-metric
...
Add metric for keeper memory soft limit
2024-01-17 17:11:53 +01:00
Alexey Milovidov
1161dbbd54
Merge pull request #57993 from mkmkme/mkmkme/reload-config-again
...
Update `query_masking_rules` when reloading the config, attempt 2
2024-01-17 17:09:36 +01:00
Azat Khuzhin
c6225bdda2
Fix fault handler in case of thread (for fault handler) cannot be spawned
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-17 18:49:02 +03:00
Robert Schulze
226f1804b7
Fix spelling and style
2024-01-17 15:26:18 +00:00
Nikita Taranov
1db805dfa4
impl
2024-01-17 16:24:24 +01:00
Alexander Gololobov
7dda18c209
Spans in mergeBlock and finalizeImpl
2024-01-17 16:07:53 +01:00
Dmitry Novik
3a1c3638e8
Style fix
2024-01-17 15:04:50 +00:00
Yarik Briukhovetskyi
38914ef70c
Update QueryAnalysisPass.cpp
2024-01-17 15:48:26 +01:00
Yarik Briukhovetskyi
f05733e7b8
Update QueryAnalysisPass.cpp
2024-01-17 15:28:02 +01:00
Jiebin Sun
784cab638a
rename some function_name and add more tests
2024-01-17 22:10:08 +08:00
kssenii
dd9e56f08f
Better
2024-01-17 14:58:42 +01:00
Kruglov Pavel
c701633955
Merge pull request #58805 from ucasfl/avro-zstd
...
Avro format support Zstd codec
2024-01-17 14:55:54 +01:00
kssenii
591a9f9661
Update unit tests
2024-01-17 14:52:24 +01:00
Anton Popov
245e1cbd5c
Merge remote-tracking branch 'upstream/master' into better-read-buffers
2024-01-17 13:46:48 +00:00
kssenii
d5198c1b47
Better
2024-01-17 14:44:53 +01:00
Nikita Taranov
5485d2a2ec
impl
2024-01-17 14:38:06 +01:00
kssenii
a572fda873
Fix
2024-01-17 14:22:34 +01:00
Nikita Taranov
bbf070caa6
impl
2024-01-17 14:08:02 +01:00
Yakov Olkhovskiy
d5d060a17e
fix memory leak in bzip2
2024-01-17 12:53:37 +00:00
Kruglov Pavel
6d064512e1
Merge pull request #58614 from Blargian/58363_disable_ansi_pretty_automatically
...
58363 Automatically disable ANSI escape sequences in Pretty formats if the output is not a terminal
2024-01-17 13:45:41 +01:00
Nikita Taranov
bb124b544c
Merge pull request #58077 from nickitat/revert_rest
...
Remove unneeded parameter `use_external_buffer` from `AsynchronousReadBuffer*`
2024-01-17 13:45:07 +01:00
kssenii
c905937ef6
Refactoring
2024-01-17 13:22:59 +01:00
Robert Schulze
84ab20ff77
Some fixups
2024-01-17 12:01:52 +00:00
Antonio Andelic
c8a313da5a
Merge pull request #58873 from ClickHouse/fix-00089_group_by_arrays_of_fixed
...
Fix `00089_group_by_arrays_of_fixed` with external aggregation
2024-01-17 12:50:30 +01:00
Dmitry Novik
a5e0be484a
Merge pull request #58875 from ClickHouse/fix-indexhint-rpn-builder
...
Fix RPN construction for indexHint
2024-01-17 12:24:28 +01:00
Kseniia Sumarokova
2f68086db8
Merge pull request #58898 from ClickHouse/kssenii-patch-8
...
Update SLRUFileCachePriority.cpp
2024-01-17 12:01:52 +01:00
Raúl Marín
ae1e19f42b
Merge pull request #58849 from ClickHouse/fix-bad-log-message-3
...
Fix bad log message
2024-01-17 11:58:11 +01:00
Robert Schulze
22534c69c4
Merge remote-tracking branch 'ClickHouse/master' into u/zhengmiao/AddArrayFunctionShingles
2024-01-17 10:49:11 +00:00
MikhailBurdukov
e2729ed4c9
Restriction for the access key id for s3.
2024-01-17 10:43:58 +00:00
Kseniia Sumarokova
0b3ebcda08
Update SLRUFileCachePriority.cpp
2024-01-17 11:13:57 +01:00
Antonio Andelic
1e180d9a7e
Atomically test and set is_generate_initialized
2024-01-17 09:42:12 +00:00
Antonio Andelic
ded830ba33
Correctly handle shutdown
2024-01-17 08:56:36 +00:00
Alexey Milovidov
28b27e34ee
Whitespaces
2024-01-17 07:29:45 +01:00
Mikhail Koviazin
5ef9478a2e
SensitiveDataMasker: replace shared_ptr with MultiVersion
2024-01-17 08:10:50 +02:00
Mikhail Koviazin
a83f6be97c
SensitiveDataMasker: replace mutex with atomic_{load,store}
2024-01-17 08:10:50 +02:00
Mikhail Koviazin
9e0414f557
fix data race in SensitiveDataMasker
...
This commit fixes the data race that was introduced in 3067ca6
. That commit
added scope lock for `getInstance` and `setInstance`, but `getInstance`
returned a pointer that could be invalidated between call for `getInstance` and
actual usage of the pointer.
This commit changes `SensitiveDataMasker` singleton from `unique_ptr` to
`shared_ptr`, so even if `setInstance` will be called right after
`getInstance`, the pointer returned from `getInstance` will live long enough to
call `wipeSensitiveData` on it.
2024-01-17 08:10:50 +02:00
Mikhail Koviazin
6e6197019c
Reintroduce commit 3067ca6
...
Update `query_masking_rules` when reloading the config
This reverts commit 7e55eab1c3
.
2024-01-17 08:10:49 +02:00
Pradeep Chhetri
09f29b4502
Update nomenclature of variables
2024-01-17 13:52:10 +08:00
Alexey Milovidov
d85abfafa4
Update KeeperAsynchronousMetrics.cpp
2024-01-17 08:05:48 +03:00
Alexey Milovidov
90e35be861
Update KeeperAsynchronousMetrics.cpp
2024-01-17 08:04:32 +03:00
Pradeep Chhetri
eafaab3795
Add metric for keeper memory soft limit
2024-01-17 12:56:18 +08:00
Yakov Olkhovskiy
e6b3f69137
style fix
2024-01-17 02:58:18 +00:00
Yakov Olkhovskiy
e06e4695e1
refactoring bzip2 buffer and fix possible data loss in internal buffer
2024-01-17 01:55:38 +00:00
Anton Popov
299293c088
better interface in read buffers
2024-01-16 23:26:20 +00:00
Denny Crane
e4fa000f6f
Update Settings.h
2024-01-16 18:29:15 -04:00
Yakov Olkhovskiy
92d42567fa
separate explicit finalization for buffers
2024-01-16 22:15:35 +00:00
Nikita Taranov
7291674013
Merge pull request #58610 from azat/stacktrace-cleanup
...
Refactor stacktrace symbolizer to avoid copy-paste
2024-01-16 22:22:08 +01:00
Vitaly Baranov
c15edebadf
Use the same row in system.processes and the same query_id for both a BACKUP/RESTORE query started by user and its asynchronous execution in a separate thread.
2024-01-16 18:49:37 +01:00
Blargian
1b81efc337
fix failing 02421 stateless and (hopefully) fix failing integration tests
2024-01-16 19:48:23 +02:00
Yakov Olkhovskiy
73f1ed3b69
explicit finalization for chained buffer
2024-01-16 17:02:22 +00:00
János Benjamin Antal
c9b6d53948
Unify naming
2024-01-16 16:16:08 +00:00
Robert Schulze
9146391e48
Merge pull request #58731 from rschu1ze/qc-quota
...
Query cache: Fix per-user quota
2024-01-16 17:14:45 +01:00
Dmitry Novik
80291ec3f2
Add comments
2024-01-16 16:59:04 +01:00
yariks5s
66f71008b3
revert and fix
2024-01-16 15:36:43 +00:00
Dmitry Novik
c325f08e79
Fix RPN construction for indexHint
2024-01-16 15:34:45 +00:00
Antonio Andelic
4ce6b64d62
Fix 00089_group_by_arrays_of_fixed with external aggregation
2024-01-16 15:16:13 +00:00
János Benjamin Antal
1d34f4a304
Merge pull request #58809 from ClickHouse/print-entries-to-be-processed-in-trace
...
Increase log level to trace to help debug `00993_system_parts_race_condition_drop_zookeeper`
2024-01-16 16:14:22 +01:00
kssenii
e5d8b9b190
More lazy loading
2024-01-16 16:12:14 +01:00
Vitaly Baranov
085833aaae
Use special statuses BACKUP_CANCELLED and RESTORE_CANCELLED in system.backups
2024-01-16 15:07:24 +01:00
Vitaly Baranov
185f6cc37c
Add tests for cancelling backup/restore queries.
2024-01-16 15:07:20 +01:00
Alexander Tokmakov
661500a140
Revert "Add support for MySQL net_write_timeout
and net_read_timeout
settings"
2024-01-16 15:01:14 +01:00
Kruglov Pavel
74973c1b41
Merge pull request #58537 from sunny19930321/fix/hive-threadpool-query
...
Fix hive threadpool read ORC/Parquet/... Failed
2024-01-16 14:46:22 +01:00