thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-18 05:32:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
126,457 Commits 9,136 Branches 1,774 Tags 2 GiB
f85e82931d
Commit Graph

126457 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Robert Schulze
a7c7a25e0f
Fix a leftover 2023-10-11 15:49:16 +00:00
Robert Schulze
9c1e52e57d
Expand tests 2023-10-11 15:46:46 +00:00
Igor Nikonov
62060a0603 Merge remote-tracking branch 'origin/master' into pr-coordinator-usage-cleanup 2023-10-11 15:11:15 +00:00
Robert Schulze
97d8e16e8d
Fix MySQL packet row data type 
Cf. https://github.com/ClickHouse/ClickHouse/pull/55479#discussion_r1355175581
 2023-10-11 15:09:50 +00:00
Igor Nikonov
9d95f4e1b6 Cleanup: parallel replica coordinator usage 2023-10-11 15:04:59 +00:00
Robert Schulze
9d04d3c3ad
Merge remote-tracking branch 'rschu1ze/master' into better-use-mysql-types-in-show-columns 2023-10-11 15:04:03 +00:00
robot-ch-test-poll1
80aa9cad51
Merge pull request #55479 from slvrtrn/fix-mysql-datetime-incompatibilities 
Fix MySQL text protocol DateTime formatting and LowCardinality(Nullable(T)) types reporting
 2023-10-11 16:56:26 +02:00
Robert Schulze
bb637fa9af
Update docs 2023-10-11 14:34:28 +00:00
Robert Schulze
9741e7b175
Fix style 2023-10-11 14:32:42 +00:00
Robert Schulze
15a24b1f4c
Merge pull request #55492 from rschu1ze/curl-8.4 
Bump curl to 8.4
 2023-10-11 16:31:20 +02:00
robot-clickhouse-ci-2
1a601759e4
Merge pull request #55467 from ClickHouse/revert-54840-revert-54791-hanfei/duplicate_index 
Revert "Revert "refine error code of duplicated index in create query""
 2023-10-11 16:22:27 +02:00
Alexey Milovidov
59e4c223f3
Merge pull request #55277 from azat/fix-schema-cache-format 
Fix query formatting for SYSTEM queries
 2023-10-11 16:17:29 +02:00
Han Fei
03d139764c fix lots of 'Structure does not match' warnings in ci 2023-10-11 15:54:42 +02:00
Daniel Byta
5e86362abe
Update client-libraries.md 2023-10-11 15:46:42 +03:00
Daniel Byta
e6f5fb2ffe
Update zh client-libraries.md 2023-10-11 15:44:00 +03:00
Yakov Olkhovskiy
0738984edf
Merge pull request #42510 from ClibMouse/Kusto-phase2-oss-pr 
Support Kusto Query Language dialect - phase 2
 2023-10-11 08:35:26 -04:00
Robert Schulze
380ba7c9e5
Rewrite to avoid CYCLIC_ALIAS errors 2023-10-11 12:11:44 +00:00
Maksim Kita
0859fc8de9 AggregatingTransform initGenerate race condition fix 2023-10-11 14:28:22 +03:00
Maksim Kita
f6793e845f HashTable resize exception handle fix 2023-10-11 14:27:54 +03:00
vdimir
d3f9145351
Update src/Storages/MergeTree/MergeTreePartsMover.cpp 2023-10-11 13:17:54 +02:00
vdimir
b634711303
Update src/Storages/MergeTree/MergeTreePartsMover.cpp 2023-10-11 13:14:01 +02:00
vdimir
2875ea4bbc
[wip] Fixing 01049_join_low_card_bug_long 2023-10-11 10:54:53 +00:00
vdimir
1c70e04301
Fix 02242_join_rocksdb 2023-10-11 10:54:52 +00:00
vdimir
7a9c3ca98a
Fix 01353_low_cardinality_join_types 2023-10-11 10:54:52 +00:00
vdimir
57dfe29f15
Fix 02267_join_dup_columns_issue36199 2023-10-11 10:54:47 +00:00
Robert Schulze
3035862c6b
Fix build 2023-10-11 10:54:38 +00:00
alesapin
21e0cb0b18
Merge pull request #55468 from ClickHouse/fix_out_of_bound_disk_web 
Fix out of bound error in system.remote_data_paths + disk web
 2023-10-11 12:54:00 +02:00
vdimir
f5e3e2a6e6
Minor fixes for 02882_replicated_fetch_checksums_doesnt_match.sql 2023-10-11 10:27:27 +00:00
Robert Schulze
0ffdaeb1c4
Bump curl to 8.4 
Addresses:
- CVE-2023-38546
- CVE-2023-38545
 2023-10-11 10:13:16 +00:00
凌涛
3bcd0b559d fix tests 2023-10-11 16:32:03 +08:00
Yong Wang
16f992a06e Kusto-phase2: remove fuzzing test from KQL 2023-10-10 23:50:58 -07:00
Azat Khuzhin
9d26bd869c Fix SYSTEM query formatting 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-10-11 07:20:28 +02:00
Azat Khuzhin
ef2b5b9632 Fix query formatting for SYSTEM DROP SCHEMA CACHE FOR 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-10-11 07:20:28 +02:00
Ryadh DAHIMENE
7d003fe5be
Update mysql.md 
Remove the Private Preview Note
 2023-10-11 06:43:50 +02:00
凌涛
21afc422dd Merge branch 'master' into feature/function-getClientHttpHeader 2023-10-11 12:01:25 +08:00
Robert Schulze
bd43b84bf8
Make use_mysql_types_in_show_columns affect only SHOW COLUMNS 2023-10-10 23:09:49 +00:00
Alexey Milovidov
5ad055df98
Merge pull request #55372 from azat/web-disk-fix-race 
Fix data-race in web disk
 2023-10-11 01:03:48 +02:00
Robert Schulze
b7936cb953
Update src/Functions/byteSwap.cpp 
Co-authored-by: Priyansh Agrawal <agrawal.priyansh@yahoo.in>
 2023-10-10 23:45:57 +02:00
Robert Schulze
96e3a4f9b4
Update src/Functions/byteSwap.cpp 
Co-authored-by: Priyansh Agrawal <agrawal.priyansh@yahoo.in>
 2023-10-10 23:45:23 +02:00
Mike Kot
06f3b82cc9 remove moving/ dir if allow_remove_stale_ is off 2023-10-10 19:56:22 +00:00
Serge Klochkov
da3a9ac707
Add #pragma once 2023-10-10 21:44:49 +02:00
Azat Khuzhin
59569b62b9 Add a comment about thread-safety of getFileOffsetOfBufferEnd() 2023-10-10 21:12:31 +02:00
Azat Khuzhin
8021d8d747 Fix data-race in web disk 
TSan report:

    WARNING: ThreadSanitizer: data race (pid=8)
     Write of size 8 at 0x7b54002b0400 by thread T310:
       0 DB::ReadBufferFromWebServer::seek(long, int) build_docker/./src/Disks/IO/ReadBufferFromWebServer.cpp:159:12 (clickhouse+0x18a6a45b) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       1 DB::CachedOnDiskReadBufferFromFile::getImplementationBuffer(DB::FileSegment&) build_docker/./src/Disks/IO/CachedOnDiskReadBufferFromFile.cpp:471:47 (clickhouse+0x17f1aace) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       2 DB::CachedOnDiskReadBufferFromFile::nextImplStep() build_docker/./src/Disks/IO/CachedOnDiskReadBufferFromFile.cpp:844:33 (clickhouse+0x17f1f5af) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       3 DB::CachedOnDiskReadBufferFromFile::nextImpl() build_docker/./src/Disks/IO/CachedOnDiskReadBufferFromFile.cpp:774:16 (clickhouse+0x17f1f33a) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       4 DB::ReadBuffer::next() build_docker/./src/IO/ReadBuffer.h:70:20 (clickhouse+0x17f1307f) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       5 DB::ReadBufferFromRemoteFSGather::readImpl() build_docker/./src/Disks/IO/ReadBufferFromRemoteFSGather.cpp:188:32 (clickhouse+0x17f1307f)
       6 DB::ReadBufferFromRemoteFSGather::nextImpl() build_docker/./src/Disks/IO/ReadBufferFromRemoteFSGather.cpp:160:9 (clickhouse+0x17f12f89) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       7 DB::ReadBuffer::next() build_docker/./src/IO/ReadBuffer.h:70:20 (clickhouse+0x17d695ca) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       8 DB::ThreadPoolRemoteFSReader::execute(DB::IAsynchronousReader::Request) build_docker/./src/Disks/IO/ThreadPoolRemoteFSReader.cpp:95:25 (clickhouse+0x17d695ca)
       9 DB::ThreadPoolRemoteFSReader::submit(DB::IAsynchronousReader::Request)::$_0::operator()() const build_docker/./src/Disks/IO/ThreadPoolRemoteFSReader.cpp:70:80 (clickhouse+0x17d6ab48) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)

     Previous read of size 8 at 0x7b54002b0400 by thread T297:
       0 DB::ReadBufferFromWebServer::getFileOffsetOfBufferEnd() const build_docker/./src/Disks/IO/ReadBufferFromWebServer.h:36:63 (clickhouse+0x18a6ac9d) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       1 DB::CachedOnDiskReadBufferFromFile::getInfoForLog() build_docker/./src/Disks/IO/CachedOnDiskReadBufferFromFile.cpp:1223:71 (clickhouse+0x17f24835) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       2 DB::CachedOnDiskReadBufferFromFile::nextImplStep()::$_0::operator()() const build_docker/./src/Disks/IO/CachedOnDiskReadBufferFromFile.cpp:799:5 (clickhouse+0x17f2347c) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       3 BasicScopeGuard<DB::CachedOnDiskReadBufferFromFile::nextImplStep()::$_0>::invoke() build_docker/./base/base/../base/scope_guard.h:99:9 (clickhouse+0x17f2347c)
       4 BasicScopeGuard<DB::CachedOnDiskReadBufferFromFile::nextImplStep()::$_0>::~BasicScopeGuard() build_docker/./base/base/../base/scope_guard.h:48:26 (clickhouse+0x17f2347c)
       5 DB::CachedOnDiskReadBufferFromFile::nextImplStep() build_docker/./src/Disks/IO/CachedOnDiskReadBufferFromFile.cpp:1071:1 (clickhouse+0x17f22480) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       6 DB::CachedOnDiskReadBufferFromFile::nextImpl() build_docker/./src/Disks/IO/CachedOnDiskReadBufferFromFile.cpp:774:16 (clickhouse+0x17f1f33a) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       7 DB::ReadBuffer::next() build_docker/./src/IO/ReadBuffer.h:70:20 (clickhouse+0x17f1307f) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       8 DB::ReadBufferFromRemoteFSGather::readImpl() build_docker/./src/Disks/IO/ReadBufferFromRemoteFSGather.cpp:188:32 (clickhouse+0x17f1307f)
       9 DB::ReadBufferFromRemoteFSGather::nextImpl() build_docker/./src/Disks/IO/ReadBufferFromRemoteFSGather.cpp:160:9 (clickhouse+0x17f12f89) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       10 DB::ReadBuffer::next() build_docker/./src/IO/ReadBuffer.h:70:20 (clickhouse+0x17d695ca) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)
       11 DB::ThreadPoolRemoteFSReader::execute(DB::IAsynchronousReader::Request) build_docker/./src/Disks/IO/ThreadPoolRemoteFSReader.cpp:95:25 (clickhouse+0x17d695ca)
       12 DB::ThreadPoolRemoteFSReader::submit(DB::IAsynchronousReader::Request)::$_0::operator()() const build_docker/./src/Disks/IO/ThreadPoolRemoteFSReader.cpp:70:80 (clickhouse+0x17d6ab48) (BuildId: cb41845e0edd51bbbf1abf7c1716e74d12491aae)

CI: https://s3.amazonaws.com/clickhouse-test-reports/55261/de503f75dcbc5a4d0e7fbb2e6b08c2106d62848a/integration_tests__tsan__[5_6].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-10-10 21:11:57 +02:00
Azat Khuzhin
b107712e0c Fix filtering by virtual columns with OR filter in query 
The problem with the initial implementation #52653 was:
- OR can have multiple arguments
- It simply not correct to assume that if there are two arguments this is OK.
  Consider the following example:

    "WHERE (column_not_from_partition_by = 1) OR false OR false"

  Will be converted to:

    "WHERE false OR false"

And it will simply read nothing.

Yes, we could apply some optimization for bool, but this will not always
work, since to optimize things like "0 = 1" we need to execute it.

And the only way to make handle this correctly (with ability to ignore
some commands during filtering) is to make is_constant() function return
has it use something from the input block, so that we can be sure, that
we have some sensible, and not just "false".

Plus we cannot simply ignore the difference of the input and output
arguments of handling OR, we need to add always-true (1/true) if the
size is different, since otherwise it could break invariants (see
comment in the code).

This includes (but not limited to):
- _part* filtering for MergeTree
- _path/_file for various File/HDFS/... engines
- _table for Merge
- ...

P.S. analyzer does not have this bug, since it execute expression as
whole, and this is what filterBlockWithQuery() should do actually
instead, but this will be a more complex patch.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-10-10 20:47:52 +02:00
slvrtrn
76da9cf780 Remove old Java client tests 
Revert Java client docker image JDK bump (no AArch64 available)
 2023-10-10 20:35:51 +02:00
slvrtrn
e06d3ca1a5 Fix MySQL text protocol DateTime 
Introduce `removeLowCardinalityAndNullable` function
Fix incorrect removeLowCar/removeNullable usages
Add more MySQL text protocol tests
Deprecate old Java client tests
Use JDK 17 for test MySQL Java container
 2023-10-10 19:51:09 +02:00
Vitaly Baranov
2af66dd9e9
Merge pull request #55089 from vitlibar/improve-hiding-secrets-in-logs 
Improve hiding secrets in logs
 2023-10-10 19:02:40 +02:00
Nikita Mikhaylov
4456fe40f9
Remove the old code for projection analysis (#55112) 2023-10-10 17:13:32 +02:00
alesapin
36b4d028ef Merge branch 'fix_out_of_bound_disk_web' of github.com:ClickHouse/ClickHouse into fix_out_of_bound_disk_web 2023-10-10 17:10:41 +02:00
alesapin
3e2c9c662c Fix tabulation 2023-10-10 17:09:26 +02:00