Commit Graph

116129 Commits

Author SHA1 Message Date
Sema Checherinda
2d2b411c26 fix build 2023-05-30 12:26:20 +02:00
Sema Checherinda
0b4ea3e2e1 remove reminder comments 2023-05-30 12:26:20 +02:00
Sema Checherinda
b13990efcc fix build 2023-05-30 12:26:20 +02:00
Sema Checherinda
13dcb62ffb fix logs engins 2023-05-30 12:26:20 +02:00
Sema Checherinda
a5dcd8dabb do not call finalize in d-tor MergedBlockOutputStream::Finalizer 2023-05-30 12:26:20 +02:00
Sema Checherinda
d95e5b51af mark all finalize calls in buffers d-tors with issue id 2023-05-30 12:26:20 +02:00
Sema Checherinda
99ad481505 fix sizes.log writes 2023-05-30 12:26:20 +02:00
Sema Checherinda
fe3939287b add test, fix .gin_sid files 2023-05-30 12:26:20 +02:00
Sema Checherinda
0e019c8e83 turn off some d-tor finalize 2023-05-30 12:26:20 +02:00
Sema Checherinda
100b4d0969 cope with finalize in d-tors 2023-05-30 12:26:20 +02:00
Antonio Andelic
bb2acb50d2
Merge pull request #50186 from LiuYangkuan/support_fqdn_in_cluster_discovery
support passing fqdn to register cluster node in keeper
2023-05-30 11:54:09 +02:00
Alexey Milovidov
6ee3740410
Merge pull request #50331 from savezed/patch-1
Update first_value.md:remove redundant 's'
2023-05-30 12:16:31 +03:00
Robert Schulze
2d06947522
Better 2023-05-30 09:06:45 +00:00
Robert Schulze
fb6c4f2802
Fix msan issue, pt. II 2023-05-30 08:51:44 +00:00
Val Doroshchuk
ecea1ac090 Fix crash when Pool::Entry::disconnect() is called
Many Pool::Entry objects can keep the same pointer to Pool::Connection.
If Pool::Entry::disconnect() is called on one such object,
Pool::removeConnection() is called to remove Pool::Connection from the pool,
where connection->ref_count is cleared and connection->removed_from_pool is set.

Next Pool::Entry::~Entry() calls decrementRefCount() with

1. const auto ref_count = data->ref_count.fetch_sub(1);
   where data->ref_count will be negative, since it was cleared
2. checks removed_from_pool and deletes Pool::Connection
   but there might be multiple Entry objects still keep pointer to this Pool::Connection

Suggesting not to clear ref_count on disconnect()
and delete Pool::Connection only on the last Pool::Entry is being destroyed.

Fixes ea375ef989
2023-05-30 10:29:49 +02:00
SmitaRKulkarni
f2172ab8dd
Merge pull request #46661 from ClickHouse/42192_Lower_parallel_parsing_threads_with_globs
When reading from multiple files displace parallel parsing
2023-05-30 08:53:08 +02:00
sslouis
a278d13043
Update first_value.md:remove redundant 's'
remove redundant 's'
2023-05-30 10:09:12 +08:00
Victor Krasnov
9a8086a377 Reorder toLastDayOf* functions in settings.md 2023-05-29 22:12:44 +00:00
Victor Krasnov
6c94632d47 Deprive toStartOfWeek and toLastDayOfWeek functions of in-source documentation 2023-05-29 22:10:34 +00:00
Alexey Gerasimchuk
9714fa011e
Merge branch 'master' into ADQM-880 2023-05-30 07:45:09 +10:00
Alexey Milovidov
f97460b453
Merge branch 'master' into nickitat-patch-12 2023-05-30 00:27:56 +03:00
Robert Schulze
aefa9df1ce
Merge branch 'master' into rs/entropy-learned-hashing 2023-05-29 22:20:50 +02:00
Nikolay Degterinsky
e10f951467 Fix IS (NOT) NULL operator priority 2023-05-29 19:11:09 +00:00
Alexey Milovidov
701e2fb6e3
Merge pull request #50242 from ClickHouse/fix-max-parallel-replicas-custom-key
Fix `02535_max_parallel_replicas_custom_key`
2023-05-29 21:06:57 +03:00
Alexey Milovidov
32d4221097
Merge pull request #50270 from ClickHouse/evillique-patch-1
Docs: Add PostgreSQL and ODBC related settings
2023-05-29 20:52:44 +03:00
Alexey Milovidov
3cc9feafc2
Merge pull request #50285 from ucasfl/uniqExactIf
Parallel merge of uniqExactIf states
2023-05-29 19:42:44 +03:00
Alexey Milovidov
12ca383132
Merge pull request #50317 from ClickHouse/nickitat-patch-11
Update gtest_async_loader.cpp
2023-05-29 19:34:20 +03:00
Robert Schulze
516fa1c375
Merge branch 'master' into rs/entropy-learned-hashing 2023-05-29 17:40:14 +02:00
Nikita Taranov
437880d4c1
Enable enable_memory_bound_merging_of_aggregation_results by default 2023-05-29 15:52:50 +02:00
Nikita Taranov
87d6564b9b
Update gtest_async_loader.cpp 2023-05-29 15:50:06 +02:00
Sergei Trifonov
688f23b325
Merge pull request #50313 from ClickHouse/fix-flaky-async-loader-test
Fix flaky `AsyncLoader.StaticPriorities` unit test
2023-05-29 13:42:15 +02:00
Sergei Trifonov
0a42adfc18
Merge pull request #50310 from Algunenano/clang15_crash
Avoid clang 15 crash
2023-05-29 13:41:27 +02:00
Sergei Trifonov
c26b3b36ae
Merge branch 'master' into fix-flaky-async-loader-test 2023-05-29 13:38:35 +02:00
Sergei Trifonov
355f917daa
Update src/Common/tests/gtest_async_loader.cpp 2023-05-29 13:38:14 +02:00
Sergei Trifonov
df14ec4d58
Merge branch 'master' into clang15_crash 2023-05-29 13:36:08 +02:00
alesapin
6b7e2a0041
Merge pull request #49961 from CheSema/mem-consumption-s3-write
Introduce a limitation of async calls inside s3 write buffer, make a test that memory is bounded even when s3 is slow
2023-05-29 13:29:01 +02:00
serxa
bdb974ab3c Fix flaky AsyncLoader.StaticPriorities unit test 2023-05-29 11:21:44 +00:00
Raúl Marín
1ae1f1273a Avoid clang 15 crash 2023-05-29 11:40:45 +02:00
Han Fei
806ef08e5f
Merge pull request #50306 from helifu/master1
Fix a typo
2023-05-29 10:34:38 +02:00
Victor Krasnov
0ad5b9f598 Merge branch 'master' of github.com:ClickHouse/ClickHouse into ADQM-810-dev 2023-05-29 08:26:26 +00:00
Robert Schulze
41d60f0be3
Fix style 2023-05-29 08:08:47 +00:00
Robert Schulze
503105d4b1
Fix 02415_all_new_functions_must_be_documented 2023-05-29 08:07:46 +00:00
Robert Schulze
47daaad172
Merge pull request #49778 from helifu/master2
Support custom 'order by' expression for system log tables
2023-05-29 10:05:14 +02:00
Robert Schulze
a3ca8f9485
Merge pull request #50308 from rschu1ze/isal-cmake-comment
QPL: Add a comment about isal
2023-05-29 09:45:40 +02:00
Robert Schulze
f0ed55bac4
QPL: Add a comment about isal 2023-05-29 07:43:58 +00:00
helifu
1821933995 Fix a typo 2023-05-29 15:12:16 +08:00
flynn
758beda39a
Merge branch 'master' into uniqExactIf 2023-05-29 11:06:08 +08:00
flynn
f616314f8b fix typo 2023-05-29 02:22:13 +00:00
Alexey Milovidov
53de761e0e
Merge pull request #50272 from ClickHouse/inverse-async-loader-priority
Unify priorities: rework AsyncLoader
2023-05-29 05:01:44 +03:00
Alexey Milovidov
ef7e9e28b7
Merge pull request #50231 from ClickHouse/inverse-io-scheduler-priority-3
Unify priorities: rework IO scheduling subsystem
2023-05-29 04:34:23 +03:00