Vitaly Baranov
f944faec6f
Fix using table_id in StorageKeeperMap.
2024-02-23 20:27:19 +01:00
Alexander Tokmakov
ef3b19167f
Merge pull request #58036 from MikhailBurdukov/backoff_for_failed_mutations
...
Backoff policy for failed mutation.
2024-02-23 15:27:41 +01:00
Nikita Mikhaylov
8fef0b71c4
Merge pull request #60350 from ClickHouse/revert-54901-pufit/views-sql-security
...
Revert "Add definers for views"
2024-02-23 15:15:36 +01:00
Alexander Tokmakov
32607cc796
Merge pull request #60159 from ClickHouse/fix_create_replica
...
Skip sanity checks on secondary CREATE query
2024-02-23 13:53:47 +01:00
Sergei Trifonov
2c766cf75f
Merge pull request #59507 from ClickHouse/alter-table-forget-partition
...
Add `FORGET PARTITION` query to remove old partition nodes from ZooKeeper
2024-02-23 12:55:08 +01:00
Raúl Marín
464b5e0e15
Revert "Add definers for views ( #54901 )"
...
This reverts commit 57306706b3
2024-02-23 12:44:31 +01:00
Kseniia Sumarokova
6a7fef13ba
Merge pull request #60282 from ClickHouse/s3queue-fix-bug-and-flaky-test
...
s3queue: fix bug (also fixes flaky test_storage_s3_queue/test.py::test_shards_distributed)
2024-02-23 11:57:34 +01:00
Alexander Tokmakov
e56748a92c
Merge pull request #60044 from ClickHouse/fix_undead_sessions
...
Ability to detect undead ZooKeeper sessions
2024-02-22 18:13:15 +01:00
pufit
57306706b3
Add definers for views ( #54901 )
2024-02-22 17:47:50 +01:00
Alexander Tokmakov
97ed2c05b0
Merge branch 'master' into fix_undead_sessions
2024-02-22 14:36:36 +01:00
Nikolai Kochetov
0e6b55ad35
Merge pull request #60220 from kitaisreal/system-backups-system-backup-log-add-query-id-and-error-stacktrace
...
Tables system.backups and system.backup_log add query_id and error stacktrace
2024-02-22 12:43:52 +01:00
kssenii
222323f293
Fix
2024-02-22 12:38:13 +01:00
Azat Khuzhin
a4f765cae7
Improve performance of SELECTs with active mutations ( #59531 )
...
* Configure keeper for perf tests
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
* Improve performance of SELECTs with active mutations
getAlterMutationCommandsForPart() can be a hot path for query execution
when there are pending mutations.
- LOG_TEST - it is not only check one bool, but actually a bunch of
atomics as well.
- Return std::vector over std::map (map is not required there) - no
changes in performance.
- Copy only RENAME_COLUMN (since only this mutation is required by
AlterConversions).
And here are results:
run|result
-|-
SELECT w/o ALTER|queries: 1565, QPS: 355.259, RPS: 355.259
SELECT w/ ALTER unpatched|queries: 2099, QPS: 220.623, RPS: 220.623
SELECT w/ ALTER and w/o LOG_TEST|queries: 2730, QPS: 235.859, RPS: 235.859
SELECT w/ ALTER and w/o LOG_TEST and w/ RENAME_COLUMN only|queries: 2995, QPS: 290.982, RPS: 290.982
But there are still room for improvements, at least MergeTree engines
could implement getStorageSnapshotForQuery().
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
* Add AlterConversions::supportsMutationCommandType(), flatten vector<vector<MutationCommand>>
* Work around what appears to be a clang static analysis bug
---------
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Co-authored-by: Michael Kolupaev <michael.kolupaev@clickhouse.com>
2024-02-22 08:51:10 +00:00
Raúl Marín
453d4d30cf
Revert "Support resource request canceling"
2024-02-21 20:19:00 +01:00
Alexander Tokmakov
fcfea17657
Update gtest_storage_log.cpp
2024-02-21 20:16:14 +01:00
Sergei Trifonov
19e81c20ca
Merge pull request #59032 from ClickHouse/cpu-scheduler-and-cc
...
Support resource request canceling
2024-02-21 16:16:24 +01:00
serxa
69c5fae1bc
review fixes
2024-02-21 15:11:50 +00:00
serxa
8b7ef7c895
assert is not needed
2024-02-21 14:53:19 +00:00
Igor Nikonov
a0105e94ba
Merge pull request #60077 from ClickHouse/cleanup-connection-pool-priority
...
Cleanup: less confusion between config priority and balancing priority in connection pools
2024-02-21 15:22:08 +01:00
serxa
f92ec2cd5d
Merge branch 'master' into cpu-scheduler-and-cc
2024-02-21 14:05:37 +00:00
serxa
bf90da7057
Merge branch 'master' into cpu-scheduler-and-cc
2024-02-21 14:05:01 +00:00
Maksim Kita
ae91c655a0
Tables system.backups and system.backup_log add query_id and error stacktrace
2024-02-21 14:36:58 +03:00
Antonio Andelic
fee1565780
Revert "Check stack size in Parser"
2024-02-21 11:33:08 +01:00
Kseniia Sumarokova
d601534a4e
Merge pull request #60166 from ClickHouse/fix-s3-queue-system-table-uuid-column
...
Fix system.s3queue_log
2024-02-21 10:52:45 +01:00
Alexey Milovidov
c9686eb76c
Merge pull request #60123 from conicl/skip_log_empty_message
...
skip printing meaningless log
2024-02-21 09:02:26 +01:00
Alexander Tokmakov
45d407034f
Merge branch 'master' into fix_undead_sessions
2024-02-20 22:21:37 +01:00
Alexander Tokmakov
ec0986af0b
skip sanity checks on secondary create query
2024-02-20 21:59:28 +01:00
alesapin
392081256c
Merge pull request #60078 from kitaisreal/revert-60058-revert-59946-replicated-merge-tree-alter-update-metadata-version-in-single-transaction
...
Revert "Revert "ReplicatedMergeTree invalid metadata_version fix""
2024-02-20 19:24:35 +01:00
Kseniia Sumarokova
f7de95cec3
Merge pull request #59775 from ClickHouse/rabbitmq-fix-possible-channel-ack-timeout
...
rabbitmq: fix possible channel error state
2024-02-20 16:08:33 +01:00
Sergei Trifonov
d2aebe2c9a
Merge branch 'master' into alter-table-forget-partition
2024-02-20 13:56:50 +01:00
Antonio Andelic
34e8e673e9
Merge pull request #60144 from ClickHouse/per-user-s3-settings
...
Support specifying users for S3 settings
2024-02-20 13:20:07 +01:00
Igor Nikonov
b6277d5e87
Merge remote-tracking branch 'origin/master' into cleanup-connection-pool-priority
2024-02-20 12:13:10 +00:00
Robert Schulze
7e11fc79d9
Merge pull request #58023 from canhld94/materialize_non_override_past_values
...
Materializing an ordinary column with default expression should not override past values
2024-02-20 11:12:31 +01:00
kssenii
3dac4c9743
Fix
2024-02-20 11:10:11 +01:00
kssenii
5ef4a30d6f
Fix
2024-02-20 10:24:09 +01:00
MikhailBurdukov
c2d641c658
Merge branch 'master' into backoff_for_failed_mutations
2024-02-20 11:48:59 +03:00
Maksim Kita
9e0f607608
Revert "Revert "ReplicatedMergeTree invalid metadata_version fix""
2024-02-20 11:39:57 +03:00
MikhailBurdukov
7cdfedaedd
Enable setting by default
2024-02-20 08:39:11 +00:00
Alexey Milovidov
b216223aa0
Merge pull request #60139 from ClickHouse/revert-60093-lazy-primary-key-loading
...
Fix data race in `IMergeTreeDataPart`
2024-02-20 06:44:28 +01:00
Raúl Marín
9361946d15
Fix build in master
2024-02-19 17:48:53 +01:00
alesapin
31bc327005
Merge pull request #60111 from ClickHouse/buffer_bg_flush_parallel
...
Flush StorageBuffer into multiple threads if num_layers > 1
2024-02-19 16:56:24 +01:00
Antonio Andelic
175a1db787
Support specifying users for s3 settings
2024-02-19 16:43:27 +01:00
Vitaly Baranov
f10a8868e1
Merge pull request #60097 from vitlibar/move-thread-pool-callback-runner-to-common
...
Move threadPoolCallbackRunner to the "Common" folder
2024-02-19 14:10:36 +01:00
Antonio Andelic
7c2654f62e
Fix data race
2024-02-19 14:09:37 +01:00
Igor Nikonov
f06e15ce5f
Merge remote-tracking branch 'origin/master' into cleanup-connection-pool-priority
2024-02-19 11:33:55 +00:00
Alexey Milovidov
a10eddecef
Merge pull request #59697 from ClickHouse/check-stack-size-in-parser
...
Check stack size in Parser
2024-02-19 11:33:04 +01:00
Alexey Milovidov
df48106cd5
Merge pull request #60015 from azat/values-quote-escape
...
Fix INSERT into SQLite with single quote (by escaping single quotes with a quote instead of backslash)
2024-02-19 10:37:45 +01:00
alesapin
6565423b1a
Review fix
2024-02-19 10:32:36 +01:00
conicliu
b38ad8297c
skip log empty message
2024-02-19 16:11:42 +08:00
Alexey Milovidov
fa1ca348a4
Miscellaneous
2024-02-19 03:19:21 +01:00
