Commit Graph

4963 Commits

Author SHA1 Message Date
Anton Popov
f9b1661372 fix test 01702_system_query_log 2021-04-06 15:44:06 +03:00
Azat Khuzhin
42d858b7e5 Fix LOGICAL_ERROR for Log with nested types w/o columns in the SELECT clause
Found with fuzzer [1]:

<details>

    2021.04.04 10:25:46.762596 [ 135 ] {4b6b5de3-d242-4267-910a-76b235467356} <Fatal> : Logical error: 'Logical error: no information about file column%2Ename.size0 in StorageLog'.
    ...
    2021.04.04 10:25:46.763563 [ 44 ] {} <Trace> BaseDaemon: Received signal 6
    2021.04.04 10:25:46.765884 [ 165 ] {} <Fatal> BaseDaemon: 5. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.04.04 10:25:46.901540 [ 165 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:51: DB::handle_error_code() @ 0x11cc4f16 in /workspace/clickhouse
    2021.04.04 10:25:47.030755 [ 165 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:58: DB::Exception::Exception() @ 0x11cc5025 in /workspace/clickhouse
    2021.04.04 10:25:47.617201 [ 165 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../src/Storages/StorageLog.cpp:183: DB::LogSource::readData()

</details>

  [1]: https://clickhouse-test-reports.s3.yandex.net/22583/69296876005c0fa171c755f8b224e4d58192c402/fuzzer_debug/report.html#fail1

The problem here is that there is no column%2Ename.size0 there is
column.size0 instead, and it seems that reading sizeX file is not enough
in other places, so just filter them out in
ExpressionActions::getSmallestColumn() (fallback method for storages w/o
getColumnSizes() implemented)
2021-04-05 08:48:04 +03:00
alexey-milovidov
a16a09eb2f
Merge pull request #22596 from ClickHouse/fix-some-tests-aarch64
Fix some tests on AArch64
2021-04-05 07:40:33 +03:00
alexey-milovidov
6cefb8e620
Merge pull request #22583 from azat/log-rwlock-ub-fix
Avoid UB in *Log engines for rwlock unlock due to unlock from another thread
2021-04-05 05:20:16 +03:00
alexey-milovidov
a9eb7a7c7e
Merge pull request #22595 from ClickHouse/change-accurate-comparison
Change accurate comparison of integer and float to be more consistent across different CPU
2021-04-05 04:22:50 +03:00
Alexey Milovidov
d645c4d4e2 Whitespace 2021-04-05 03:52:44 +03:00
Alexey Milovidov
08f129c0d3 Mark test as long 2021-04-05 03:52:06 +03:00
Alexey Milovidov
e50d82ab45 Merge branch 'master' into change-accurate-comparison 2021-04-05 01:38:55 +03:00
Alexey Milovidov
b07d53640c Fix flaky test 00816_long_concurrent_alter_column 2021-04-05 00:34:51 +03:00
Anton Popov
0d03b8c0c4
Merge pull request #21889 from CurtizJ/fix-aggregation-in-order-1
Fix bugs in aggregation by primary key
2021-04-04 18:17:04 +03:00
Alexey Milovidov
cae21b8560 Fix test 2021-04-04 15:50:19 +03:00
alexey-milovidov
44e160596e
Merge pull request #22587 from ClickHouse/fix-flaky-test-15
Fix flaky test after #22427
2021-04-04 15:44:44 +03:00
alexey-milovidov
f6e6842383
Merge pull request #22590 from ClickHouse/fix-tests-aarch64
Fix CPU-dependent behaviour in tests
2021-04-04 15:43:12 +03:00
alexey-milovidov
0e1035735c
Merge pull request #22565 from ClickHouse/fix-assert-arena
Fix assert in Arena when doing GROUP BY Array of Nothing of non-zero size.
2021-04-04 15:38:17 +03:00
Alexey Milovidov
d18daa5919 Fix test 2021-04-04 15:18:17 +03:00
Alexey Milovidov
3ad3109ec5 Fix tests 2021-04-04 15:14:01 +03:00
Alexey Milovidov
9d47adbae6 Fix tests 2021-04-04 15:10:13 +03:00
Alexey Milovidov
9383fec50b Fix test 2021-04-04 15:07:52 +03:00
Alexey Milovidov
4a58055b2d Update test 2021-04-04 14:52:46 +03:00
Alexey Milovidov
eae9b978f8 Generate test files for accurate comparison int vs. float 2021-04-04 14:49:24 +03:00
Maksim Kita
0bfb429c42
Merge pull request #22479 from kitaisreal/clickhouse-dictionary-source-loop-fix
ClickHouseDictionarySource loop fix
2021-04-04 13:29:17 +03:00
Azat Khuzhin
44abb7588a StorageStripeLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
89a96cf14d StorageLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
5d795661ed StorageTinyLog: add regression test for UB due to unlock from different thread
Refs: #22560
2021-04-04 13:25:44 +03:00
Alexey Milovidov
729214c845 Fix some tests on AArch64 2021-04-04 13:11:36 +03:00
Alexey Milovidov
3ae0c7e17a Fix CPU-dependent behaviour in tests 2021-04-04 12:55:04 +03:00
Alexey Milovidov
41dfcb7bec Fix flaky test after #22427 2021-04-04 12:24:00 +03:00
Alexey Milovidov
e684b463ae Add test 2021-04-03 22:51:37 +03:00
alexey-milovidov
d0effbb0fc
Merge pull request #22534 from ClickHouse/minor-fixes-in-tests
Minor fixes in tests for AArch64
2021-04-03 22:10:43 +03:00
Maksim Kita
2f1f9692e6 Fixed test 2021-04-03 13:58:11 +03:00
alexey-milovidov
30ece2c28f
Merge pull request #22510 from vdimir/merge-join-lc-bug-fix
Convert right block to full in MergeJoin
2021-04-03 12:54:34 +03:00
Alexey Milovidov
0733144b4a Lower test scale 2021-04-03 12:53:57 +03:00
alexey-milovidov
143f4b59a0
Merge pull request #22527 from ClickHouse/fix-missing-nl-parse-tsv
Fix deserialization of empty string without newline at end of TSV format
2021-04-03 12:51:10 +03:00
alexey-milovidov
9f5cd35a69
Merge pull request #22323 from abyss7/poco-http2
Follow up to #19516
2021-04-03 02:09:10 +03:00
alexey-milovidov
3d860fc6ac
Merge pull request #22322 from abyss7/issue-21907
Do not limit HTTP chunk size
2021-04-03 01:58:22 +03:00
Alexey Milovidov
9c93ce7ff6 Minor fixes in tests 2021-04-03 01:57:04 +03:00
Maksim Kita
d84fd76f3f Fixed test 2021-04-03 00:40:31 +03:00
Maksim Kita
07d5a1ec21 ClickHouseDictionarySource loop fix 2021-04-03 00:40:07 +03:00
Alexey Milovidov
47a12a7b0b Add a test 2021-04-03 00:14:13 +03:00
alexey-milovidov
c3a9cbe01c
Merge pull request #22421 from ClickHouse/fix-buffer-overflow-in-token-extractor
Fix buffer overflow in token extractor
2021-04-02 22:08:28 +03:00
tavplubix
514a931c2c
try fix skip_list parsing 2021-04-02 20:23:41 +03:00
Alexander Kuzmenkov
d0037329cf
Merge pull request #22459 from ClickHouse/aku/window-frame-offset
fix window frame offset check and add more tests
2021-04-02 19:49:59 +03:00
Alexander Kuzmenkov
51bbc9c9ba
Update skip_list.json 2021-04-02 18:37:34 +03:00
vdimir
8dcfe119bf
Add test pmj_lc_bug 2021-04-02 18:18:36 +03:00
Alexander Kuzmenkov
e7df8893df
Merge pull request #22300 from ClickHouse/trying_parallel_func_tests
Trying parallel func tests
2021-04-02 18:09:58 +03:00
Alexander Kuzmenkov
414d6fb25d
Update skip_list.json 2021-04-02 18:08:20 +03:00
Ivan Lezhankin
059175217f Fix test a little bit 2021-04-02 13:57:56 +03:00
Alexander Kuzmenkov
3492e3c40c fixes 2021-04-02 13:50:09 +03:00
Vladimir
9b40f384e9
Merge pull request #20622 from vdimir/issue-20497 2021-04-02 11:48:29 +03:00
Maksim Kita
3b799c5d7d
Merge pull request #22413 from kitaisreal/added-function-dict-get-or-null
Added function dictGetOrNull
2021-04-02 11:39:01 +03:00