Robert Schulze
1d89738c6a
Remove performance workaround for old GCC
...
GCC support these days is experimental. GCCs main use is to keep the
code portable but I don't think it's used for performance tests. Hence
removing a performance workaround added in the GCC 7 days (we are now
using 11, soon: 12).
2022-05-18 22:44:37 +02:00
Michael Nutt
e453132db8
remove hashid define guard
2022-05-18 15:26:54 -04:00
avogar
cd6a29897e
Apply input_format_max_rows_to_read_for_schema_inference for all files in globs in total
2022-05-18 17:56:36 +00:00
Vitaly Baranov
9ccddc44c6
Merge pull request #35767 from azat/ON_CLUSTER-grant
...
RFC: Add separate CLUSTER grant
2022-05-18 19:19:54 +02:00
Maksim Kita
df0cb06209
Merge pull request #37289 from kitaisreal/unary-arithmetic-functions-improve-performance-dynamic-dispatch
...
Improve performance of unary arithmetic functions
2022-05-18 19:16:30 +02:00
Kruglov Pavel
d81616ff65
Remove unnecessary include
2022-05-18 17:44:39 +02:00
avogar
a0369fb9a6
Allow to use String type instead of Binary in Arrow/Parquet/ORC formats
2022-05-18 14:51:21 +00:00
Alexander Tokmakov
7ab0aa7882
Update src/Disks/DiskLocal.cpp
2022-05-18 17:46:28 +03:00
Alexander Tokmakov
6098cf7cfe
Update src/Disks/DiskLocal.cpp
2022-05-18 17:46:23 +03:00
Vxider
04f1b20229
init inner window names
2022-05-18 14:34:40 +00:00
mergify[bot]
d5f870eac8
Merge branch 'master' into client-dns-list
2022-05-18 12:40:02 +00:00
avogar
3c85e8b455
Fix tests
2022-05-18 12:36:13 +00:00
Anton Popov
715d5b0173
Merge pull request #37270 from Avogar/fix-bool-eof
...
Fix Nullable(String) to Nullable(Bool/IPv4/IPv6) conversion
2022-05-18 14:08:52 +02:00
Vladimir C
7d88b81622
Merge pull request #37193 from azat/fix-limit-by-in-dist-queries
...
Fix "Cannot create column of type Set" for distributed queries with LIMIT BY
2022-05-18 13:28:19 +02:00
Anton Popov
4def736ecb
Merge pull request #37275 from ernado/fix/open-telemetry-span-log-fix-alias
...
Fix attribute.values alias for OTEL table
2022-05-18 13:18:07 +02:00
Vxider
4b5eda4de9
fix cleanup
2022-05-18 11:14:08 +00:00
Nikolai Kochetov
64ecb3941c
Merge pull request #37259 from ClickHouse/clangtidies2
...
Activate more clangtidies
2022-05-18 13:01:40 +02:00
Kruglov Pavel
3c33db5d8b
Merge pull request #36981 from Avogar/fix-external-tables-in-hedged-connections
...
Fix sending external tables data in HedgedConnections
2022-05-18 12:50:11 +02:00
Kruglov Pavel
134821eff8
Fix build
2022-05-18 12:44:20 +02:00
Nicolae Vartolomei
32b9959dec
Allow a user to inspect grants from granted roles
2022-05-18 10:44:18 +00:00
Vladimir C
1779fb08ed
Merge pull request #36271 from yuuch/support_collation_in_create_query
2022-05-18 12:43:49 +02:00
Vladimir C
f979a03fbe
Merge pull request #37256 from vdimir/issue_37217
2022-05-18 12:42:47 +02:00
avogar
b33ad449a9
Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-defaults
2022-05-18 10:26:38 +00:00
Kruglov Pavel
aaace46da2
Merge pull request #37266 from CurtizJ/fix-mutations-with-object
...
Fix mutations in tables with columns of type `Object`
2022-05-18 12:19:55 +02:00
Kruglov Pavel
492de1076c
Merge pull request #37232 from zzsmdfj/fix-mysql-datatype-binary0
...
fix MySQL database engine to compatible with binary(0) dataType
2022-05-18 12:15:07 +02:00
lingo-xp
46fa56c25c
[bug-fix] wrong default value in copyThroughBuffers
2022-05-18 18:02:15 +08:00
Dmitry Novik
5f376995ea
Merge pull request #37299 from ClickHouse/fix-overcommit-deadlock
...
Fix possible deadlock in OvercommitTracker during logging
2022-05-18 12:01:32 +02:00
avogar
12010a81b7
Make better
2022-05-18 09:25:26 +00:00
Kseniia Sumarokova
f9b08ae5dd
Merge pull request #37281 from bigo-sg/hive_max_partition_query_check
...
Check max partitions to read for each hive table
2022-05-18 11:11:11 +02:00
Robert Schulze
6b2a72d451
Merge pull request #37228 from mrk-andreev/fix-rm-groupid-from-producer
...
Remove group.id from StorageKafka::createWriteBuffer
2022-05-18 11:04:40 +02:00
Robert Schulze
6ce8947417
GLOB with CONFIGURE_DEPENDS
...
Globbing generally misses to pick up files which were added/deleted
after CMake's configure. This is a nuissance but can be alleviated using
CONFIGURE_DEPENDS (available since CMake 3.12) which adds a check for
new/deleted files before each compile and - if necessary - restarts the
configuration. On my system, the check takes < 0.1 sec.
(Side note: CONFIGURE_DEPENDS is not guaranteed to work accross all
generators, but at least it works for Ninja which everyone @CH seems to
use.)
2022-05-18 10:34:10 +02:00
Vxider
f102497929
fix parser with join query
2022-05-18 08:05:06 +00:00
Kseniia Sumarokova
38c87ab9cd
Merge pull request #36493 from kssenii/fix-encrypted-buffer
...
Fix offset update ReadBufferFromEncryptedFile
2022-05-18 09:46:17 +02:00
mergify[bot]
37d6da7506
Merge branch 'master' into wv-engine
2022-05-18 01:56:56 +00:00
mergify[bot]
4900d2249f
Merge branch 'master' into wv-populate
2022-05-18 01:56:52 +00:00
Dmitry Novik
a82239984c
Remove include
2022-05-18 01:44:51 +00:00
Dmitry Novik
20c537addd
Make noncopyable
2022-05-18 01:42:13 +00:00
mergify[bot]
c33ca1f392
Merge branch 'master' into system-certificates
2022-05-17 19:52:28 +00:00
mergify[bot]
05305811f8
Merge branch 'master' into fix-bool-eof
2022-05-17 19:28:11 +00:00
Robert Schulze
0c55ac76d2
A few clangtidy updates
...
Enable:
- bugprone-lambda-function-name: "Checks for attempts to get the name of
a function from within a lambda expression. The name of a lambda is
always something like operator(), which is almost never what was
intended."
- bugprone-unhandled-self-assignment: "Finds user-defined copy
assignment operators which do not protect the code against
self-assignment either by checking self-assignment explicitly or using
the copy-and-swap or the copy-and-move method.""
- hicpp-invalid-access-moved: "Warns if an object is used after it has
been moved."
- hicpp-use-noexcept: "This check replaces deprecated dynamic exception
specifications with the appropriate noexcept specification (introduced
in C++11)"
- hicpp-use-override: "Adds override (introduced in C++11) to overridden
virtual functions and removes virtual from those functions as it is
not required."
- performance-type-promotion-in-math-fn: "Finds calls to C math library
functions (from math.h or, in C++, cmath) with implicit float to
double promotions."
Split up:
- cppcoreguidelines-*. Some of them may be useful (haven't checked in
detail), therefore allow to toggle them individually.
Disable:
- linuxkernel-*. Obvious.
2022-05-17 20:56:57 +02:00
mergify[bot]
36b4ed19c5
Merge branch 'master' into unary-arithmetic-functions-improve-performance-dynamic-dispatch
2022-05-17 18:08:24 +00:00
Dmitry Novik
a97ba9741e
Fix possible deadlock in OvercommitTracker during logging
2022-05-17 18:07:52 +00:00
Alexander Gololobov
38f291c70d
Merge pull request #37030 from bharatnc/ncb/h3-missing-traversal-funcs
...
add remaining h3 traversal funcs
2022-05-17 18:19:56 +02:00
Maksim Kita
31a29d8315
Fixed dynamic dispatch macro
2022-05-17 16:59:11 +02:00
Vxider
037db32e24
set alter query internal
2022-05-17 13:50:55 +00:00
avogar
46f4f8a457
Fix use of unitialized memory
2022-05-17 12:59:46 +00:00
kssenii
b53ca506e6
Add unit test
2022-05-17 14:55:42 +02:00
Alexander Gololobov
8cc41521ad
tidy build fix
2022-05-17 14:35:12 +02:00
Yakov Olkhovskiy
c8a4be4c64
refactoring
2022-05-17 08:31:31 -04:00
Maksim Kita
beb34e7062
Improve performance of unary arithmetic functions
2022-05-17 13:53:20 +02:00
lgbo-ustc
e4bc7e9979
use splitInto instead of Poco::Tokenizer
2022-05-17 19:31:59 +08:00
lgbo-ustc
1497e08301
update exception msg
2022-05-17 19:27:43 +08:00
Vitaly Baranov
f34a5cdee2
Merge branch 'master' into ON_CLUSTER-grant
2022-05-17 13:21:20 +02:00
Kruglov Pavel
515ae986e5
Fix special build
2022-05-17 12:15:41 +02:00
Antonio Andelic
639ceb84b1
Add comment and fix typo
2022-05-17 10:15:12 +00:00
alesapin
f958203b6c
Update src/Coordination/KeeperStorage.cpp
...
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-05-17 11:55:54 +02:00
Kseniia Sumarokova
8cb71d0172
Merge pull request #33332 from Michicosun/MeiliSearch
...
MeiliSearch
2022-05-17 11:47:56 +02:00
alesapin
e75aa445a6
Update src/Coordination/KeeperStorage.h
...
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-05-17 11:36:12 +02:00
alesapin
4d4634b12d
Merge pull request #37164 from kssenii/ficx-async-reads-assertions
...
fix async reads from remote fs internal setting not being always turned on
2022-05-17 11:29:14 +02:00
lgbo-ustc
0b3468a150
TOO_MANY_PARTITIONS
2022-05-17 15:50:03 +08:00
lgbo-ustc
f4f4a2d85b
reuse setting max_partitions_to_read
2022-05-17 15:49:14 +08:00
Alexander Gololobov
670a8bac29
Fixed required array size calculation and reduced number of reallocations
2022-05-17 09:45:49 +02:00
lgbo-ustc
4d64678963
Merge remote-tracking branch 'ck/master' into hive_max_partition_query_check
2022-05-17 15:42:10 +08:00
lgbo-ustc
a161a21992
add max partitions check for each hive table
2022-05-17 15:37:32 +08:00
Antonio Andelic
573e42d0dd
Address PR comments
2022-05-17 06:45:51 +00:00
Vxider
90bac2f004
add shutdown check
2022-05-17 06:20:08 +00:00
lgbo-ustc
bc81302bf4
fixed code-style
2022-05-17 12:10:55 +08:00
lgbo-ustc
3a32a22f39
support using multi disks for caching hive files
2022-05-17 11:55:30 +08:00
Vxider
f74c934a61
Merged with master
2022-05-17 02:53:59 +00:00
mergify[bot]
0d0fc23170
Merge branch 'master' into wv-engine
2022-05-17 02:24:18 +00:00
Vxider
3986e82b19
Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into wv-populate
2022-05-17 02:18:17 +00:00
lgbo-ustc
d8ad9ad2a6
update codes
2022-05-17 09:27:03 +08:00
Aleksandr Razumov
60693afb56
Fix attribute.values alias for OTEL table
2022-05-17 01:28:36 +03:00
Yakov Olkhovskiy
fc26505111
multiple client connection attempts if hostname resolves to multiple addresses
2022-05-16 17:47:07 -04:00
Kseniia Sumarokova
94683786dc
Merge branch 'master' into MeiliSearch
2022-05-16 22:42:09 +02:00
Kseniia Sumarokova
f073efc025
Merge pull request #37225 from Vxider/wv-fix-cleanup
...
Fix WindowView cleanup
2022-05-16 22:39:58 +02:00
Maksim Kita
20380fa87b
Merge pull request #37257 from kitaisreal/dynamic-dispatch-infrastructure-for-class-members
...
Dynamic dispatch infrastructure for class member functions
2022-05-16 22:15:10 +02:00
Vitaly Baranov
72bff5242a
Merge pull request #37168 from vitlibar/backup-improvements-5
...
Backups Improvements 5
2022-05-16 21:25:54 +02:00
Alexander Gololobov
e2e3536a80
Fixed handling of gridPathCellsSize() errors
2022-05-16 21:23:45 +02:00
avogar
415aabd4d0
Fix Nullable(String) to Nullable(Bool/IPv4/IPv6) conversion
2022-05-16 19:15:18 +00:00
Robert Schulze
43945cea1b
Fixing some warnings
2022-05-16 20:59:27 +02:00
Maksim Kita
fd28c19c1c
Update CompressedWriteBuffer.cpp
2022-05-16 20:44:22 +02:00
jinjunzh
f334cd371f
fixed code style issue
2022-05-16 17:21:20 -04:00
jinjunzh
2ae9e22248
Improve CompressedWriteBuffer to avoid unnecessary memcpy
2022-05-16 16:22:13 -04:00
Yakov Olkhovskiy
4f6c354c3f
refactoring
2022-05-16 14:38:47 -04:00
Anton Popov
b6c5ab4fcf
fix mutations in tables with columns of type Object
2022-05-16 18:26:53 +00:00
Yakov Olkhovskiy
863c52f0f4
refactoring, test added
2022-05-16 13:31:28 -04:00
Kruglov Pavel
8572879c37
Remove redundant code
2022-05-16 17:58:20 +02:00
Dmitry Novik
dd1e7b55b8
Merge pull request #37050 from azat/fix-optimize_aggregation_in_order-prefix-Array
...
Fix optimize_aggregation_in_order with prefix GROUP BY and *Array aggregate functions
2022-05-16 17:17:56 +02:00
Maksim Kita
032b5d3fc3
Dynamic dispatch infrastructure for class member functions
2022-05-16 17:05:16 +02:00
avogar
ce834b1086
Remove code duplication
2022-05-16 14:41:01 +00:00
vdimir
76852ae49c
Pass need_filter, has_null_map to joinRightColumns
2022-05-16 14:27:27 +00:00
avogar
2d4b4b9008
Fix inserting defaults for missing values in columnar formats
2022-05-16 14:19:44 +00:00
Vxider
8f271159bf
check null pointer
2022-05-16 13:59:55 +00:00
Kseniia Sumarokova
ff37d7d5c3
Update ErrorCodes.cpp
2022-05-16 15:30:07 +02:00
Kruglov Pavel
5e34f48a18
Merge pull request #37021 from excitoon-favorites/fixtdigest
...
Fixed problem with infs in `quantileTDigest`
2022-05-16 15:21:59 +02:00
Antonio Andelic
adb8ac4fda
Change log level
2022-05-16 13:15:31 +00:00
Mikhail Artemenko
535b3ea686
refactor code & change exception numbers
2022-05-16 16:13:05 +03:00
Antonio Andelic
e6f646b71e
Merge branch 'master' into keeper-preprocess-operations
2022-05-16 13:08:49 +00:00
Vxider
b3a731c226
fix build
2022-05-16 12:51:19 +00:00
mergify[bot]
b7d6d97e64
Merge branch 'master' into wv-alter
2022-05-16 12:44:46 +00:00
Robert Schulze
ed7df7cabd
Merge pull request #36960 from ClickHouse/clangtidies
...
Enable clangtidies
2022-05-16 14:22:50 +02:00
Vxider
6b3b744e3f
fix data race
2022-05-16 11:31:49 +00:00
alesapin
1829256ae2
Merge pull request #37178 from ClickHouse/ignore_auto_increment_in_create_table_2
...
Ignore AUTO_INCREMENT in CREATE TABLE to simplify migration from MySQL
2022-05-16 13:29:22 +02:00
Azat Khuzhin
01e1c5345a
Add separate CLUSTER grant
...
In case you have different roles for the same user on multiple clusters,
ON CLUSTER query can help to overcome some limitations.
Consider the following example:
- cluster_with_data, dev_user (readonly=2)
- stage_cluster, dev_user (readonly=0)
So when you will execute the following query from stage_cluster, it will
be successfully executed, since ON CLUSTER queries has different system
profile:
DROP DATABASE default ON CLUSTER cluster_with_data
This is not 100% safe, but at least something.
Note, that right now only ON CLUSTER query it self is supported, but
separate clusters are not (i.e. GRANT CLUSTER some_cluster_name TO
default), since right now grants sticked to database+.
v2: on_cluster_queries_require_cluster_grant
v3: fix test and process flags as bit mask
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-16 13:57:45 +03:00
alesapin
b10f26e3ed
Fix style
2022-05-16 12:25:25 +02:00
Vladimir C
75008d5903
Merge pull request #37166 from vdimir/issue_37141
2022-05-16 12:21:41 +02:00
Robert Schulze
d66dcdad79
Fix new occurrences of new clang-tidy warnings
2022-05-16 11:31:36 +02:00
kssenii
f7493965b7
Remove additional check for merge tree
2022-05-16 11:19:57 +02:00
kssenii
49201f217f
Revert
2022-05-16 11:17:56 +02:00
Vxider
31eee576a5
do not addDependency when table is dropped
2022-05-16 09:04:37 +00:00
Kseniia Sumarokova
128a0e15eb
Merge pull request #37226 from Vxider/wv-speedup-watch
...
Speed up WindowView WATCH
2022-05-16 10:42:02 +02:00
Vxider
95e6e5aef7
fix window view dependency
2022-05-16 08:41:32 +00:00
Robert Schulze
e3cfec5b09
Merge remote-tracking branch 'origin/master' into clangtidies
2022-05-16 10:12:50 +02:00
zzsmdfj
525b2b4511
to compatible with binary(0)
2022-05-16 11:36:39 +08:00
Vxider
9201df7cde
update code style
2022-05-16 02:00:39 +00:00
Mark Andreev
fa6a5ab6e4
Remove group.id from StorageKafka::createWriteBuffer
2022-05-15 23:51:11 +04:00
Vladimir Chebotarev
5bbab401c4
Added test.
2022-05-15 22:49:52 +03:00
Vxider
77ad48fee9
fix build
2022-05-15 17:40:42 +00:00
Vxider
15b35c1910
speed up windowview watch
2022-05-15 17:14:53 +00:00
Vxider
18ee285ce1
fix windowview cleanup
2022-05-15 16:50:34 +00:00
Vxider
93fec4ebc7
remove dependency when drop windowview
2022-05-15 16:12:24 +00:00
Dmitry Novik
a36f05d6b8
Merge pull request #32999 from ClickHouse/fix-gs-formating
...
Cleanup GROUPING SETS formating
2022-05-15 15:11:52 +02:00
Dmitry Novik
2259add1fa
Merge pull request #37197 from ClickHouse/overcommit-ratio-overflow
...
Fix possible overflow in OvercommitRatio
2022-05-15 15:09:19 +02:00
Robert Schulze
859f2f3391
Enclose large if block in {}
2022-05-15 14:49:20 +02:00
Vitaly Baranov
c1baad0763
Fix style.
2022-05-15 14:09:42 +02:00
Vxider
033b1e7f82
add lock for cleanup query
2022-05-15 11:18:42 +00:00
Vxider
6c2d78b802
rename var
2022-05-15 11:18:23 +00:00
Vxider
65779adf8b
update code style
2022-05-15 07:07:27 +00:00
Sergei Trifonov
811896446f
Update IVolume.h
2022-05-15 08:57:35 +02:00
Vxider
4ed79cd9e1
fix windowview watch
2022-05-15 06:45:25 +00:00
Alexey Milovidov
8334329dff
Merge pull request #37023 from ClickHouse/chained-or
...
Merging #34932 .
2022-05-15 04:32:31 +03:00
Yakov Olkhovskiy
6156047c83
some refactoring
2022-05-14 17:40:50 -04:00
Yakov Olkhovskiy
ef2d8d3d0e
bugfix, refactoring
2022-05-14 15:45:07 -04:00
Vxider
f459dd5aba
change windowview engine behaviour
2022-05-14 16:46:49 +00:00
Mikhail Artemenko
91edbf0f47
add subquery evaluation in getConfiguration
2022-05-14 14:44:35 +03:00
alesapin
ef35fa6a46
Merge pull request #37208 from ClickHouse/relax_logging_level_in_check_thread
...
Relax log level for some checks in check thread
2022-05-14 13:26:25 +02:00
Vitaly Baranov
ecbbfca698
Fix handling timeouts.
2022-05-14 12:38:19 +02:00
Vxider
f2ef27e5d6
rename windowview header
2022-05-14 09:21:54 +00:00
Vitaly Baranov
feb2de8542
Fix access checking for BACKUP and RESTORE.
2022-05-14 10:48:35 +02:00
Kseniia Sumarokova
f4a8a0cefe
Merge pull request #37200 from kssenii/add-s3-requests-metric
...
Add S3Requests metric
2022-05-14 10:08:21 +02:00
Vxider
b52cac970d
fix alter on replicated engine
2022-05-14 06:35:50 +00:00
mergify[bot]
4e184306c1
Merge branch 'master' into wv-alter
2022-05-14 02:11:46 +00:00
Michael Nutt
8bff9b8ce9
Merge branch 'master' into hashid
2022-05-14 09:52:05 +09:00
alesapin
1c082717a4
Relax log level for some checks in check thread
2022-05-13 23:29:36 +02:00
Maksim Kita
3f18d7da33
Merge pull request #37189 from kitaisreal/function-h3-k-ring-add-cast
...
Function h3kRing added cast
2022-05-13 22:53:20 +02:00
Yakov Olkhovskiy
d2ffd0e1c2
take certificate path from poco Context
2022-05-13 16:48:34 -04:00
Vladimir Chebotarev
a114ab7223
Fixed the bug and supported old states.
2022-05-13 22:38:35 +03:00
Vladimir Chebotarev
d519e83a4c
Proper work with infinities.
2022-05-13 22:25:57 +03:00
Azat Khuzhin
b29a0f3c84
Fix "Cannot create column of type Set" for distributed queries with LIMIT BY
...
The problem was that after #36454 it requires too much columns.
Fixes : #36454
Fixes : #37045
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-13 20:03:19 +03:00