Azat Khuzhin
151ba92a2e
Fix reading of non existing nested columns with multiple level in compact parts
...
Consider the following example:
CREATE TABLE data (root.array_str Array(UInt8)) ENGINE = MergeTree() ORDER BY tuple();
INSERT INTO data VALUES ([]);
ALTER TABLE data ADD COLUMN root.nested_array Array(Array(UInt8));
In this case the first part will not have data for root.nested_array,
and thanks to #37152 it will simply read offsets column from
root.array_str, however since root.nested_array is a nested array, it
will try to read elements from the same offsets stream and if you are
lucky enough you will get one of the following errors:
- Cannot read all data. Bytes read: 1. Bytes expected: 8.: (while reading column root.nested_array): While executing MergeTreeInOrder. (CANNOT_READ_ALL_DATA)
- DB::Exception: Array size is too large: 8233460228287709730: (while reading column serp.serp_features): While executing MergeTreeInOrder.
So to address this, findColumnForOffsets() had been changed to return
the level of the column too, to allow to read only up to this level.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-08 10:21:40 +01:00
Anton Popov
b40d9200d2
better semantic of constsness of DataPartStorage
2022-10-23 15:24:20 +00:00
kssenii
b7d751b782
Merge remote-tracking branch 'upstream/master' into improve-marks-cache-loading
2022-09-11 13:23:30 +02:00
Anton Popov
7c12b448b8
Merge remote-tracking branch 'upstream/master' into HEAD
2022-09-08 01:52:52 +00:00
Anton Popov
f76c1482bd
try to fix filling of missed Nested columns with multiple levels
2022-09-06 13:56:32 +00:00
kssenii
4c8aa04b73
Revert "Fix"
...
This reverts commit ec55c90f36
2022-09-05 20:12:40 +02:00
kssenii
83514fa2ef
Refactor
2022-09-05 20:08:22 +02:00
Anton Popov
464818c142
try to fix filling of missed Nested columns with multiple levels
2022-09-02 15:05:58 +00:00
Anton Popov
9dda9658a8
Merge remote-tracking branch 'upstream/master' into HEAD
2022-09-02 12:48:27 +00:00
kssenii
ec55c90f36
Fix
2022-09-01 17:04:34 +02:00
kssenii
a5f69517ae
Allow to load marks in threadpool
2022-08-30 20:20:05 +02:00
kssenii
7a9b0bc47f
Merge master
2022-08-05 01:48:52 +02:00
Anton Popov
4cf0353892
try to fix Nested
2022-07-27 14:05:16 +00:00
Anton Popov
e0d2c8fb37
fix json type with sparse columns
2022-07-21 14:47:19 +00:00
kssenii
a6655bea1c
Some fixes
2022-07-18 14:23:08 +02:00
Anton Popov
1523c9c9e5
fix filling of empty Nested + small refactoring
2022-06-17 01:10:52 +00:00
Nikolai Kochetov
5bc9b32025
Merge branch 'master' into refactor-something-in-part-volumes
2022-06-08 11:10:06 +00:00
Nikolai Kochetov
678d978acf
Merge branch 'master' into refactor-something-in-part-volumes
2022-06-07 15:23:00 +00:00
Anton Popov
df6882d2b9
Revert "Fix errors of CheckTriviallyCopyableMove type"
2022-06-07 13:53:10 +02:00
HeenaBansal2009
b7eb6bbd38
Fixed clang-tidy-CheckTriviallyCopyableMove-errors
2022-05-30 11:09:03 -07:00
Nikolai Kochetov
5574a3cc43
Fixing style.
2022-05-05 09:23:23 +00:00
Nikolai Kochetov
76870ad92a
Part 5
2022-04-12 18:59:49 +00:00
Anton Popov
df3b07fe7c
Merge remote-tracking branch 'upstream/master' into HEAD
2022-03-03 22:25:28 +00:00
Maksim Kita
b1a956c5f1
clang-tidy check performance-move-const-arg fix
2022-03-02 18:15:27 +00:00
Anton Popov
d7cd9aa69b
fix reading of missed subcolumns
2022-03-02 03:31:40 +03:00
Amos Bird
ba19c7cf44
Slightly better interface of compressed buffer
2022-02-17 14:31:22 +08:00
mergify[bot]
e229487817
Merge branch 'master' into mdha
2022-02-01 01:22:16 +00:00
Amos Bird
ec7d367814
DiskLocal checker
...
Add DiskLocal checker so that ReplicatedMergeTree can recover data when some of its disks are broken.
2022-02-01 05:55:27 +08:00
alesapin
4f1b902342
Fix compact parts as well
2022-01-30 22:36:19 +03:00
Kseniia Sumarokova
484a4d62dd
Merge pull request #32835 from kssenii/fising-s3
...
Fix optimization with lazy seek for async reads from remote fs
2021-12-22 09:38:23 +03:00
kssenii
40c266840c
Fixes
2021-12-17 18:16:29 +03:00
Anton Popov
54f51444c0
Merge remote-tracking branch 'upstream/master' into HEAD
2021-12-01 15:49:02 +03:00
alexey-milovidov
1e058fb207
Merge pull request #30190 from azat/ReadBuffer-throw-on-empty
...
Do not allow zero-length reads
2021-11-17 10:21:08 +03:00
Anton Popov
9823f28855
fix nested
2021-11-02 06:03:52 +03:00
Anton Popov
d50137013c
Merge remote-tracking branch 'upstream/master' into HEAD
2021-11-01 16:55:53 +03:00
Anton Popov
c66207f606
fix nested
2021-11-01 05:13:07 +03:00
Anton Popov
0099dfd523
refactoring of SerializationInfo
2021-10-29 20:21:02 +03:00
Azat Khuzhin
a1926b3a55
Fix MergeTreeReaderCompact with empty buffer (max_read_buffer_size=0)
...
CI: https://clickhouse-test-reports.s3.yandex.net/30190/0682d80f603d934eda51c93959164ee29eb52c02/functional_stateless_tests_(debug).html#fail1
2021-10-27 22:25:03 +03:00
kssenii
52296e8b04
Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read
2021-10-25 00:22:32 +03:00
Azat Khuzhin
4599e9191b
Fix explicit 0 size for readFile()
2021-10-24 18:58:22 +03:00
kssenii
39b9e9c258
Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read
2021-10-22 15:40:41 +03:00
kssenii
df5dc4e991
Adjust MergeTreeIndexReader
2021-10-19 10:51:45 +03:00
Azat Khuzhin
cd4b33c8c9
Verify that all rows was read in MergeTreeReaderCompact
...
v0: Use fmt-like style exception in MergeTreeReaderCompact
v2: Update the check
2021-10-18 21:19:34 +03:00
Anton Popov
d71ffc355a
Merge remote-tracking branch 'upstream/master' into HEAD
2021-10-18 15:18:22 +03:00
kssenii
3995506d37
Adjust range reader for remote fs reads
2021-10-15 11:36:26 +03:00
Anton Popov
92413aed68
better interfaces for IDataType and ISerialization
2021-10-14 05:36:49 +03:00
Anton Popov
6f9e53197c
Merge remote-tracking branch 'upstream/master' into HEAD
2021-09-20 17:17:05 +03:00
Anton Popov
1c80a95b36
slightly better code near reading of subcolumns
2021-09-18 22:34:54 +03:00
Anton Popov
eef436fe22
Merge remote-tracking branch 'upstream/master' into HEAD
2021-09-16 18:07:42 +03:00
Anton Popov
8999a83320
add comment
2021-09-10 20:22:28 +03:00
