Commit Graph

141454 Commits

Author SHA1 Message Date
avogar
fb20e80db4 Better test, fix style 2024-05-10 13:23:19 +00:00
avogar
60c721c21b Fix build after conflict resolution 2024-05-10 12:20:27 +00:00
Kruglov Pavel
6207f6f4a5
Merge branch 'master' into dynamic-data-type 2024-05-10 13:42:38 +02:00
avogar
4f1a97644e Use nested column properly in SerializationSparse::enumerateStreams 2024-05-10 11:34:16 +00:00
avogar
e7c7eb159a Apply suggestions from the code review 2024-05-10 11:32:27 +00:00
Raúl Marín
e5e55ff91c
Merge pull request #63596 from alexvanolst/fix-base58-links
Fix broken links in documentation to IETF Base58 draft
2024-05-10 10:47:12 +00:00
Kseniia Sumarokova
e2756e02c2
Merge pull request #63426 from ClickHouse/fix-backup-with-missing-projection
Fix backup/restore of projection part in case projection was removed from table metadata, but part still has projection
2024-05-10 10:11:56 +00:00
Mikhail f. Shiryaev
98dcef6389
Merge pull request #63400 from ClickHouse/docker-server-official-review
The Dockerfile is reviewed by docker-official
2024-05-10 10:03:01 +00:00
Kruglov Pavel
fbf8dcb7fe
Apply suggestions from code review
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2024-05-10 11:55:24 +02:00
alesapin
83ee9a6e3d
Merge pull request #63353 from ClickHouse/fix_unexpected_return_type_from
Fix logical error during SELECT query after ALTER in rare case
2024-05-10 09:50:33 +00:00
Alexander van Olst
0586952eca
Fix links to IETF Base58 draft 2024-05-10 11:29:18 +02:00
Mikhail f. Shiryaev
544875fd2f
Apply markdownfmt.sh from https://github.com/docker-library/docs 2024-05-10 10:55:24 +02:00
Mikhail f. Shiryaev
291bb14696
The Dockerfile is reviewed by docker-official
`apt-get upgrade` shouldn't be executed during the build
`apt-get clean` is a noop
`gpg` should use batch and download key by full fingreprints
The CI specific steps shouln't be presented in docker library
Using `COPY --chmod` instead of two layers is not possible yet, but
  entrypoint.sh already contains +x bit in the git repo
2024-05-10 10:54:27 +02:00
Antonio Andelic
78af18ac87
Merge pull request #63513 from ClickHouse/threadpool-runner-local-prefetch-read-pool
Make `MergeTreePrefetchedReadPool` safer
2024-05-10 07:38:33 +00:00
Alexey Milovidov
c34ae6d189
Merge pull request #63583 from ClickHouse/ij
Fix logical error in ColumnTuple::tryInsert()
2024-05-10 05:09:34 +00:00
Michael Kolupaev
3de1fc674f Fix logical error in ColumnTuple::tryInsert() 2024-05-10 02:30:18 +00:00
Michael Kolupaev
1b43c58489
Merge pull request #62087 from ClickHouse/checkmate
Avoid crashing on column type mismatch in a few dozen places
2024-05-09 23:59:59 +00:00
Alexey Milovidov
40b5aaa939
Merge pull request #63580 from ClickHouse/docs-data-replication-examples
[Docs] Use ReplicatedMergeTree not ReplicatedReplacingMergeTree for d…
2024-05-09 23:50:20 +00:00
Justin de Guzman
849dd825c5
[Docs] Use ReplicatedMergeTree not ReplicatedReplacingMergeTree for data replication examples 2024-05-09 15:33:40 -07:00
Alexey Milovidov
8ed245677d
Merge pull request #63493 from Volodyachan/fix-tabs-in-pretty-format
Tabs in pretty format
2024-05-09 15:24:56 +00:00
Alexey Milovidov
7be88cca1f
Merge pull request #63548 from azat/fix-sentry-crash-on-exit
Fix crash on exit with sentry enabled (due to openssl destroyed before sentry)
2024-05-09 15:24:20 +00:00
Alexey Milovidov
3ac5853fe8
Merge pull request #63574 from Algunenano/main_lz4
Go back to upstream lz4 submodule
2024-05-09 15:22:02 +00:00
Raúl Marín
2f00ad489a Go back to upstream lz4 2024-05-09 17:06:26 +02:00
Konstantin Bogdanov
6a00c0ec6b
Merge pull request #63551 from ClickHouse/thevar1able-patch-2
Add `jwcrypto` to integration tests runner
2024-05-09 12:40:57 +00:00
Mikhail f. Shiryaev
acae60b55f
Merge pull request #63543 from ClickHouse/find-proper-commit-for-a-sync
Find a proper commit for cumulative `A Sync` status
2024-05-09 12:08:50 +00:00
Mikhail f. Shiryaev
38604eb3bc
Add more logging about the status will be post 2024-05-09 13:40:56 +02:00
Mikhail f. Shiryaev
f294f6d16f
Move update_upstream_sync_status to commit_status_helper 2024-05-09 13:40:53 +02:00
Raúl Marín
83d8c1071a
Merge pull request #63522 from Algunenano/prefetch_projection_name
MergeTreePrefetchedReadPool: Print parent name when logging projection parts
2024-05-09 09:59:36 +00:00
Antonio Andelic
3fd8b46264
Merge pull request #63538 from ClickHouse/race-distributed-sink
Fix data race in `DistributedSink`
2024-05-09 06:53:44 +00:00
Antonio Andelic
d1c20d08c3
Merge pull request #63323 from ClickHouse/use-getparentpartname
Try fix segfault in `MergeTreeReadPoolBase::createTask`
2024-05-09 06:52:12 +00:00
Antonio Andelic
bc9d50cf16
Merge pull request #63523 from ClickHouse/leftover-threads-copy
Correctly stop `asyncCopy` tasks in all cases
2024-05-09 06:50:51 +00:00
Azat Khuzhin
27b41650f8 Fix crash on exit with sentry enabled (due to openssl destroyed before sentry)
The problem is tha openssl registers OPENSSL_cleanup() as atexit
handler, which called before destroying of SentryWriter, so to avoid
this problem, let's destroy it explicitly.

<details>

<summary>stack trace example</summary>

    Thread 2 (Thread 0x7ffff54006c0 (LWP 24847) "clickhouse-serv"):
    0  ___pthread_rwlock_rdlock (rwlock=0x0) at pthread_rwlock_rdlock.c:26
    1  0x00000000164c18a9 in CRYPTO_THREAD_read_lock (lock=0x0) at threads_pthread.c:93
    2  0x000000001642e6b9 in int_err_get_item (d=0x7ffff53f74e0) at err.c:192
    ...
    7  ossl_connect_common (cf=0x7ffff7812c80, data=0x7ffff70a4c00, nonblocking=bool_true, done=0x7ffff53f834c) at openssl.c:4486
    ...
    17 curl_easy_perform (data=data@entry=0x7ffff70a4c00) at easy.c:787
    18 0x000000000b4c3854 in sentry__curl_send_task (_envelope=<optimized out>, _state=0x7ffff7074300) at sentry_transport_curl.c:225
    19 0x000000000b4ba880 in worker_thread (data=0x7ffff70e5500) at sentry_sync.c:262

    Thread 1 (Thread 0x7ffff7cb2c80 (LWP 24842) "clickhouse-serv"):
    5  0x000000000b4bb0e2 in sentry__cond_wait_timeout (cv=0x7ffff70e5540, mutex=0x7ffff70e5570, msecs=250) at sentry_sync.h:332
    6  sentry__bgworker_shutdown (bgw=0x7ffff70e5500, timeout=2000) at sentry_sync.c:412
    7  0x000000000b4b3e95 in sentry_close () at sentry_core.c:238
    8  0x000000000b4a5f1f in SentryWriter::~SentryWriter (this=0x7ffff71a1240) at SentryWriter.cpp:147
    9  std::__1::default_delete<SentryWriter>::operator()[abi:v15000](SentryWriter*) const (this=0x7ffff70e5568, __ptr=0x7ffff71a1240) at unique_ptr.h:48
    10 std::__1::unique_ptr<SentryWriter, std::__1::default_delete<SentryWriter> >::reset[abi:v15000](SentryWriter*) (this=0x7ffff70e5568, __p=0x0) at unique_ptr.h:305
    11 std::__1::unique_ptr<SentryWriter, std::__1::default_delete<SentryWriter> >::~unique_ptr[abi:v15000]() (this=0x7ffff70e5568) at unique_ptr.h:259
    12 0x00007ffff7de62e6 in __run_exit_handlers (status=0, listp=<optimized out>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108
    13 0x00007ffff7de642e in __GI_exit (status=<optimized out>) at exit.c:138
    14 0x00007ffff7dccd51 in __libc_start_call_main (main=main@entry=0x6111c20 <main(int, char**)>, argc=argc@entry=13, argv=argv@entry=0x7fffffffb718) at libc_start_call_main.h:74
    15 0x00007ffff7dcce0c in __libc_start_main_impl (main=0x6111c20 <main(int, char**)>, argc=13, argv=0x7fffffffb718, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffb708) at libc-start.c:360

    (gdb) p req.body
    $7 = 0x7ffff7816000 "{\"dsn\":\"...\"}\n{\"type\":\"session\",\"length\":190}\n{\"init\":true,\"sid\":\"...\",\"status\":\"exited\",\"errors\":0,\"started\":\"2024-05-08T20:29:23.253Z\",\"duration\":17.213,\"attrs\":{\"release\":\"24.5\",\"environment\":\"test\"}}"

</details>

P.S. Likely started happens after conversion to OpenSSL (#59870).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-09 07:39:23 +02:00
Volodyachan
c52af8c259
Merge branch 'master' into fix-tabs-in-pretty-format 2024-05-09 05:22:51 +03:00
Konstantin Bogdanov
27551ca3c7
Add jwcrypto to integration tests runner 2024-05-09 04:08:21 +03:00
Nikita Mikhaylov
8a7c031cf5
Merge pull request #63546 from jkartseva/no-s3-storage-tag-plain-rw
Add `no-s3-storage` tag to local_plain_rewritable ut
2024-05-09 00:05:54 +00:00
Alexey Milovidov
536398a916
Merge pull request #63527 from ClickHouse/everything-should-work-on-aarch64-part-2
Almost everything should work on AArch64 (Part of #58061)
2024-05-08 22:46:06 +00:00
Alexey Milovidov
962d5e5bda
Merge pull request #63479 from yariks5s/add_setting_from_multiline_strings
Add setting for better rendering of multiline string for pretty format
2024-05-08 22:42:38 +00:00
Alexey Milovidov
8c4a5d3663
Merge pull request #61823 from ClickHouse/total-rows-in-system-zeros-generate-random
Set total_rows_approx for trivial queries with LIMIT from system.zeros and generateRandom
2024-05-08 21:32:35 +00:00
Alexey Milovidov
39b4411028
Merge pull request #63515 from ClickHouse/fix-rabbitmq-heap-use-after-free
Fix rabbitmq heap-use-after-free with clang18
2024-05-08 21:30:28 +00:00
Alexey Milovidov
a3e1506ee2
Merge pull request #63531 from ClickHouse/kssenii-patch-9
Update 02240_system_filesystem_cache_table.sh
2024-05-08 21:28:29 +00:00
Alexey Milovidov
e2ca4aaa09
Merge pull request #63530 from ClickHouse/tavplubix-patch-10
Update randomization of `old_parts_lifetime`
2024-05-08 23:29:22 +02:00
Julia Kartseva
afda3c24e4 Add no-s3-storage tag to local_plain_rewritable ut
This blacklists the test in the distributed cache build.
2024-05-08 19:47:51 +00:00
Mikhail f. Shiryaev
47473d77ab
Find a proper commit for cumulative A Sync status 2024-05-08 20:31:02 +02:00
Alexey Milovidov
8d2fcbd91d Remove check 2024-05-08 18:50:46 +02:00
Nikolai Kochetov
ff810ceb39 Try another fix and add simplier test. 2024-05-08 16:50:42 +00:00
alesapin
dc7f515945
Merge pull request #63540 from ClickHouse/run_azure_on_master
Fix azure tests run on master
2024-05-08 16:28:09 +00:00
Alexey Milovidov
c3b0a28513
Merge pull request #63528 from kitaisreal/recursive-cte-documentation-fix
Recursive CTE documentation fix
2024-05-08 16:24:21 +00:00
Alexey Milovidov
4f73b3b4cb
Merge pull request #63532 from ClickHouse/revert-63525-revert-63443-fix-index-analysis-datetime64
Revert "Revert "Fix index analysis for `DateTime64`""
2024-05-08 18:33:59 +02:00
alesapin
bbb8cc0e93 Fix azure tests run on master 2024-05-08 18:01:50 +02:00
Kseniia Sumarokova
96dd6c03cd
Update src/Storages/MergeTree/DataPartStorageOnDiskFull.h
Co-authored-by: SmitaRKulkarni <Smita.Kulkarni@clickhouse.com>
2024-05-08 18:01:47 +02:00