Commit Graph

77211 Commits

Author SHA1 Message Date
Amos Bird
30b06a969b
Cancel vertical merges (#31057)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-15 14:32:53 +03:00
alesapin
b45c8694f8 More workflows 2021-11-15 14:20:33 +03:00
Alexander Tokmakov
416a82b99a Merge branch 'master' into check_dependencies_on_drop 2021-11-15 13:35:45 +03:00
alesapin
7179b86dbb More CI checks 2021-11-15 13:22:02 +03:00
alesapin
af820f85d3
Merge pull request #31259 from azat/temporary_directories_lifetime-message-fix
Print warning during old directories cleanup in MergeTree only if it is old
2021-11-15 12:56:31 +03:00
alesapin
fe0cbd6036
Merge pull request #31340 from ClickHouse/get_rid_of_build_number
Remove some copypaste from CI
2021-11-15 12:46:07 +03:00
alesapin
a4c711ba8b
Merge pull request #31406 from ClickHouse/tavplubix-patch-5
Remove excessive debug info from the log message in DDLWorker
2021-11-15 12:38:03 +03:00
Azat Khuzhin
48e9456e75 Disable log_queries in clickhouse-copier
This will avoid calling Context::addQueryFactoriesInfo()

v2: disable it in ClusterCopier::reloadTaskDescription() too
v3: just create local context and pass it to the ClusterCopier instead
of global context
2021-11-15 10:32:30 +03:00
Azat Khuzhin
6274c7bfc2 Do not use global context for query execution in clickhouse-copier 2021-11-15 10:32:19 +03:00
Azat Khuzhin
fe36884110 Convert assert(!isGlobalContext()) to LOGICAL_ERROR 2021-11-15 10:32:19 +03:00
Azat Khuzhin
68068ff71d Remove check for clickhouse-local
From #26231 clickhouse-local uses local context for query execution.
2021-11-15 10:32:19 +03:00
Azat Khuzhin
fa317e96e8 Do not try to resolve temporary tables from global context 2021-11-15 10:32:19 +03:00
alesapin
69cd19a342
Merge pull request #31408 from den-crane/patch-43
Doc. More tips
2021-11-15 10:13:57 +03:00
alesapin
2a9ed85f23
Merge pull request #31300 from ClickHouse/fix_intersecting_parts_to_do3
Remove strange code from mutations
2021-11-15 10:08:32 +03:00
alesapin
6bd5540395 Fixes 2021-11-15 10:07:03 +03:00
Vladimir C
20e7a2ff99
Merge pull request #31101 from lehasm/alexey-sm-DOCSUP-14785-document-detach_not_byte_identical_parts 2021-11-15 09:53:57 +03:00
Vladimir C
324344430f
Update docs/ru/operations/settings/merge-tree-settings.md 2021-11-15 09:53:46 +03:00
Denny Crane
1853f501c8
Update tips.md 2021-11-14 15:07:18 -04:00
Denny Crane
849370f729
Update tips.md 2021-11-14 14:58:32 -04:00
Denny Crane
b332fed8c5
Update tips.md 2021-11-14 14:48:04 -04:00
tavplubix
b5b20f84bc
Update DDLWorker.cpp 2021-11-14 17:41:55 +03:00
Maksim Kita
f283d46e3a
Merge pull request #30931 from sevirov/sevirov-DOCSUP-14511-document_custom_query_for_database_dictionaries
DOCSUP-14511: Document custom query for database dictionaries
2021-11-14 15:24:35 +03:00
Kseniia Sumarokova
846fbd059b
Merge pull request #31403 from kssenii/fix-client-output
Fix client
2021-11-14 15:01:30 +03:00
kssenii
9ea8408d8d Add test 2021-11-14 07:58:19 +00:00
kssenii
ad1b7c83cd Fix 2021-11-14 07:19:59 +00:00
Alexey Milovidov
052a7a92e8 Whitespace 2021-11-14 10:05:20 +03:00
Alexey Milovidov
fe3ee85d80 Fix MaterializedMySQL 2021-11-14 10:04:45 +03:00
alexey-milovidov
cb6342025d
Merge pull request #31229 from zhanglistar/fsync
Change all fsync to fdatasync
2021-11-14 05:16:01 +03:00
alexey-milovidov
f4fda976ef
Merge pull request #31063 from azat/perf-spikes
perf: switch *_log tables to Memory engine (attempt to reduce cache misses)
2021-11-14 05:13:12 +03:00
Alexey Milovidov
bd684f02f2 Fix clang-tidy 2021-11-14 04:57:59 +03:00
Alexey Milovidov
1e4e36ff2d Remove thread_local std::string 2021-11-14 02:43:17 +03:00
Ivan Blinkov
e2b634835a
[blog] clarifications to clickhouse-v21.11-released.md headers (#31399) 2021-11-14 02:32:37 +03:00
alexey-milovidov
5712f9077d
Merge pull request #31393 from azat/fix-stderr-before-reopen
Check stderr is writable before reopining it (to avoid losing errors)
2021-11-14 01:44:08 +03:00
alexey-milovidov
e323b83f6a
Merge pull request #30876 from pmed/backslash_letter_interactive_input
add aliases for `\<letter>` interactive client commands
2021-11-14 01:43:13 +03:00
alexey-milovidov
f12020ee47
Merge pull request #31397 from ClickHouse/efs-ebs
Comparison between EBS and EFS
2021-11-14 01:35:30 +03:00
alexey-milovidov
f1fd01a95d
Merge pull request #31392 from azat/mysql-sync-thread-fix-QueryScope
Fix QueryScope in MaterializedMySQLSyncThread
2021-11-14 01:03:15 +03:00
Alexey Milovidov
2d57bba4ca Fix typo 2021-11-14 00:47:23 +03:00
Alexey Milovidov
e56504dacf Credits 2021-11-14 00:43:23 +03:00
Alexey Milovidov
5fc09a63a8 Comparison between EBS and EFS 2021-11-14 00:42:12 +03:00
Azat Khuzhin
ed4b5c7640 Check stderr is writable before reopining it (to avoid losing errors) 2021-11-13 22:26:05 +03:00
Azat Khuzhin
f2c74a81f7 Fix QueryScope in MaterializedMySQLSyncThread
QueryScope should exist for the whole query execution time.
2021-11-13 20:06:08 +03:00
Kseniia Sumarokova
59d4eb99c2
Merge pull request #31291 from kssenii/update-async-reads-setting
Make remote_filesystem_read_method=threadpool by default
2021-11-13 19:19:35 +03:00
alexey-milovidov
a29b0930f8
Merge pull request #31387 from azat/fix-test_kafka_insert_avro
Fix test_kafka_insert_avro by pinning avro version
2021-11-13 17:58:37 +03:00
kssenii
7c2315638c Remove checks for profile events because they are not updated the same way with async reads 2021-11-13 13:37:00 +03:00
Azat Khuzhin
11be942bb0 Fix possible data-race in case of query cancellation with async_socket_for_remote
RemoteQueryExecutor::cancel() (that is called in another thread), steal
the fiber, and process any pending packets, to leave the connection in
the correct state (so that it can be reused for further queries).

However this requires processing pending packets, and this will update
the RemoteQueryExecutorReadContext::packet field, which can be read in
another thread by the RemoteQueryExecutor::read().

This was pretty tricky due to fibers, but AFAICS I understand this
correctly and this should fix the race.

Note, that if you will look at the logs from the #28854, you will see,
that all those data races was triggered after query cancellation.

Fixes: #28854
Refs: #18715

v2: fix daedlock in case of duplicated parts
v3: do not hold the mutex, since was_cancelled is atomic
2021-11-13 12:44:02 +03:00
Kseniia Sumarokova
c7be79b4e7
Merge pull request #31136 from LiuYangkuan/IDiskRemote_metadata_disk
use DiskPtr instead of OS's file system API in class IDiskRemote
2021-11-13 12:16:05 +03:00
Azat Khuzhin
48b1b7b7ec Fix test_kafka_insert_avro by pinning avro version
New avro version has a code that does not allow to use BytesIO [1].

  [1]: https://github.com/apache/avro/commit/e8c61ba4f0#diff-ca721cc66db80ff81dcd7b8ad1bb0e83b2e5c2de80c207ebec79f5495d38db98R318-R319
2021-11-13 12:01:13 +03:00
alexey-milovidov
f653473083
Merge pull request #31007 from zhanghuajieHIT/master
support compile in arm machine with parameter "-DENABLE_TESTS=OFF"
2021-11-13 01:57:58 +03:00
alexey-milovidov
e0cf4bf568
Update iotest_nonblock.cpp 2021-11-13 01:31:37 +03:00
alexey-milovidov
558a1257e7
Merge pull request #31279 from RainbowDashy/patch-1
docs: Add descriptions for string aliases
2021-11-13 01:28:07 +03:00