Commit Graph

6820 Commits

Author SHA1 Message Date
Nikita Mikhaylov
ad42e610cb
Merge branch 'master' into welch 2020-10-12 16:23:09 +03:00
Mikhail Filimonov
87a8ba63f7
Few more CR fixes 2020-10-12 15:05:40 +02:00
tavplubix
748b75ab1b
Merge pull request #15767 from ClickHouse/fix_materialize_mysql_count_v2
Try fix select count() for MaterializeMySQL (another way)
2020-10-12 14:41:38 +03:00
Nikolai Kochetov
2a62a91af4
Merge pull request #15662 from ClickHouse/fix-15529
Fix read from Buffer table with empty nested table with different types.
2020-10-12 14:12:11 +03:00
alesapin
6732e5c217 Fix alter default validation 2020-10-12 14:02:35 +03:00
Nikolai Kochetov
7e58f99f64 Merge branch 'master' into storage-read-query-plan 2020-10-12 13:12:39 +03:00
Amos Bird
47fcd8bffb
Fix some problems introduced by refactoring. 2020-10-12 17:58:09 +08:00
Amos Bird
d2dcfc3f0d
Refactor processors. 2020-10-12 17:30:05 +08:00
hexiaoting
39367be57a Add Support for OFFSET_FETCH_CLAUSE 2020-10-12 16:46:49 +08:00
alesapin
5b5dd4fb28 Fix order by desc after alter 2020-10-12 11:28:47 +03:00
Mikhail Filimonov
7fb329713a
Avoid shadowing class member, set first_row flag after write 2020-10-12 07:52:38 +02:00
Mikhail Filimonov
f6b00f2cb6
After CR fixes 2020-10-12 07:52:09 +02:00
Mikhail Filimonov
c37a456c49
Refactoring WriteCallback->RowOutputFormatParams 2020-10-12 07:52:06 +02:00
Mikhail Filimonov
e17d4e1eeb
Tests and some docs 2020-10-12 07:51:46 +02:00
Mikhail Filimonov
6df42c580b
ProtobufSingle output format 2020-10-12 07:51:45 +02:00
Mikhail Filimonov
b602d18dd8
ProtobufSingle input format
Allows to read Single protobuf message at once (w/o length-delemeters).
2020-10-12 07:51:36 +02:00
Nikolai Kochetov
190fd88af9
Merge pull request #15785 from amosbird/e1
Code refactor.
2020-10-12 00:36:36 +03:00
Nikolai Kochetov
9b42bfdc36
Merge pull request #15817 from ClickHouse/new-block-for-functions-2
Use `ColumnsWithTypeAndName` instead of `Block` for function calls [part 2]
2020-10-12 00:32:58 +03:00
Nikolai Kochetov
23aec1f954 Fix build. 2020-10-11 22:44:20 +03:00
alexey-milovidov
760e2ca29c
Update formatReadableTimeDelta.cpp 2020-10-11 22:43:04 +03:00
Nikolai Kochetov
3a17c2a7ac Rename FunctionArguments to ColumnsWithTypeAndName 2020-10-11 22:20:20 +03:00
Nikolai Kochetov
0df08dcb36 Rename columns() to size(). 2020-10-11 21:11:39 +03:00
Alexey Milovidov
c8ae1d097a Add comments 2020-10-11 18:24:20 +03:00
Alexey Milovidov
8a252ebef8 Merge remote-tracking branch 'origin/master' into filipecaixeta-master 2020-10-11 17:29:50 +03:00
alexey-milovidov
a8708338f2
Merge pull request #15809 from amosbird/c1
add print_query_id support for native client
2020-10-11 13:29:35 +03:00
alexey-milovidov
10e9d14466
Merge pull request #15818 from ClickHouse/style-pragma-once
Check for #pragma once in headers
2020-10-11 13:14:09 +03:00
alexey-milovidov
e16c1c781e
Merge pull request #15816 from ClickHouse/change-level-of-some-log-messages
Change level of some log messages
2020-10-11 13:13:13 +03:00
Amos Bird
ff665c362f
Add print query id support to client 2020-10-11 10:09:08 +08:00
alexey-milovidov
39e58128cd
Merge pull request #15812 from ClickHouse/bigint-hash
Minor changes in BigInt hash
2020-10-11 01:11:30 +03:00
alexey-milovidov
1187903b44
Merge pull request #15813 from ClickHouse/remove-useless-metrics
Remove useless metrics to avoid confusion
2020-10-11 01:11:17 +03:00
alexey-milovidov
717c48cbf3
Merge pull request #15814 from ClickHouse/cleanups
Cleanups
2020-10-11 01:11:03 +03:00
Alexey Milovidov
452a1b5218 Simplifications 2020-10-11 01:03:03 +03:00
Ivan Lezhankin
7ea393ada8 Fix build without libraries 2020-10-10 23:41:27 +03:00
Alexey Milovidov
7541be86cd Fix "Arcadia" 2020-10-10 23:26:36 +03:00
Nikolai Kochetov
3f446b9713 Fix build. 2020-10-10 22:19:46 +03:00
Nikolai Kochetov
780bd424ad Fix build. 2020-10-10 22:11:39 +03:00
Nikolai Kochetov
3099d44a96 Merge branch 'master' into new-block-for-functions-2 2020-10-10 22:09:50 +03:00
Nikolai Kochetov
6d8dc1f8ed Fix style. 2020-10-10 21:44:51 +03:00
Alexey Milovidov
269b6383f5 Check for #pragma once in headers 2020-10-10 21:37:02 +03:00
Nikolai Kochetov
d28325a353 Replace getByPosition to [] 2020-10-10 21:24:57 +03:00
Alexey Milovidov
f42b471de8 Moved functions to separate files; remove copy-paste 2020-10-10 21:23:54 +03:00
Alexey Milovidov
9ca9855f96 Merge branch 'master' into filipecaixeta-master 2020-10-10 20:52:34 +03:00
Alexey Milovidov
7502fad77c Change level of some log messages 2020-10-10 20:47:34 +03:00
alexey-milovidov
1f6c2c8efc
Merge pull request #15803 from ucasFL/tid-function
Add `tid` and `logTrace` function
2020-10-10 19:37:04 +03:00
Alexey Milovidov
5b482f4191 Cleanups 2020-10-10 19:31:10 +03:00
Alexey Milovidov
06fcf437fe Addition to prev. revision 2020-10-10 19:02:13 +03:00
Alexey Milovidov
09a31e01e4 Addition to prev. revision 2020-10-10 18:55:42 +03:00
Alexey Milovidov
9f15daf45c Remove useless metrics to avoid confusion 2020-10-10 18:52:44 +03:00
Alexey Milovidov
a2ef0f6cba Minor changes in BigInt hash 2020-10-10 18:46:41 +03:00
robot-clickhouse
554fa482e6 Auto version update to [20.11.1.1] [54442] 2020-10-10 18:39:58 +03:00
Amos Bird
8e0862a0c3
BlockIO can be empty. 2020-10-10 23:25:50 +08:00
feng lv
9438f2f4d2 fix
fix

fix
2020-10-10 19:21:11 +08:00
Alexey Milovidov
4f2d4988c6 Fix build on Mac OS 2020-10-10 13:51:57 +03:00
Amos Bird
dbc14655fc
Code refactoring. 2020-10-10 18:22:33 +08:00
Alexey Milovidov
2c71327ff5 Fix build on Mac OS 2020-10-10 11:02:02 +03:00
alexey-milovidov
59cfb87a96
Merge pull request #15799 from ClickHouse/fix-links-in-docs
Fix ugliness in docs
2020-10-10 10:48:11 +03:00
Nikolai Kochetov
76a04fb4b4
Merge pull request #15762 from ClickHouse/new-block-for-functions
Use `ColumnsWithTypeAndName` instead of `Block` for function calls
2020-10-10 08:50:38 +03:00
feng lv
45925f60c7 fix 2020-10-10 11:20:45 +08:00
feng lv
d39868b853 fix 2020-10-10 10:56:21 +08:00
feng lv
ec87254abe add test 2020-10-10 10:48:15 +08:00
Nikita Mikhaylov
6ac5431804
Merge pull request #15783 from nikitamikhaylov/copier-backquotes
Merging  #14939
2020-10-10 02:32:27 +03:00
alexey-milovidov
9d02347e2e
Update FunctionsFormatting.h 2020-10-09 22:55:02 +03:00
alexey-milovidov
0fd007ad9e
Merge pull request #15601 from alexelex/alexelex-master
Improvement of Quorum Inserts in ClickHouse
2020-10-09 22:43:53 +03:00
Alexey Milovidov
bd805300bb Whitespace 2020-10-09 22:33:23 +03:00
Azat Khuzhin
064f901ea8 Add ability to preallocate hashtables for hashed/sparsehashed dictionaries
preallocation can be used only when we know number of rows, and for this
we need:
- source clickhouse
- no filtering (i.e. lack of <where>), since filtering can filter
  too much rows and eventually it may allocate memory that will
  never be used.

For sparse_hash the difference is quite significant, preallocated
sparse_hash hashtable allocates ~33% faster (7.5 seconds vs 5 seconds
for insert, and the difference is more significant for higher number of
elements):

    $ ninja bench-sparse_hash-run
    [1/1] cd /src/ch/hashtable-bench/.cmake && ...ch/hashtable-bench/.cmake/bench-sparse_hash
    sparse_hash/insert: 7.574 <!--
    sparse_hash/find  : 2.14426
    sparse_hash/maxrss: 174MiB
    sparse_hash/time:   9710.51 msec (user+sys)

    $ time ninja bench-sparse_hash-preallocate-run
    [1/1] cd /src/ch/hashtable-bench/.cmake && ...-bench/.cmake/bench-sparse_hash-preallocate
    sparse_hash/insert: 5.0522 <!--
    sparse_hash/find  : 2.14024
    sparse_hash/maxrss: 174MiB
    sparse_hash/time:   7192.06 msec (user+sys)

P.S. the difference for sparse_hashed dictionary with 4e9 elements
(uint64, uint16) is ~18% (4975.905 vs 4103.569 sec)

v2: do not reallocate the dictionary from the progress callback
    Since this will access hashtable in parallel.
v3: drop PREALLOCATE() and do this only for source=clickhouse and empty
    <where>
2020-10-09 22:28:14 +03:00
Nikolai Kochetov
ef3640c3f7
Merge pull request #15451 from amosbird/scopewith
Global WITH and WITH propagation.
2020-10-09 22:16:45 +03:00
Azat Khuzhin
f4f79aa84a Add HashTable::reserve() (for preallocated hashed/sparse_hashed dictionaries) 2020-10-09 21:53:57 +03:00
filipe
09b5e1dbc3 fix FunctionsFormatting error for ARM 2020-10-09 13:46:59 -03:00
Nikolai Kochetov
3898a8ac5f Try fix tests. 2020-10-09 19:05:11 +03:00
feng lv
8a1a41f77b add tid function 2020-10-09 23:49:14 +08:00
alesapin
35165c8ea4
Merge pull request #15756 from CurtizJ/fix-prewhere-with-virtuals
Fix prewhere with virtual columns
2020-10-09 18:07:41 +03:00
nikitamikhaylov
88a5302759 Merge branch 'master' of github.com:ClickHouse/ClickHouse into copier-backquotes 2020-10-09 16:26:31 +03:00
Alexandra Latysheva
f6f33168aa fix compilation error 2020-10-09 12:11:21 +00:00
Nikolai Kochetov
9328cea4f1 Supress pvs 2020-10-09 14:35:58 +03:00
Alexandra Latysheva
0594a77b57 fix thread restart for parallel quorum inserts 2020-10-09 11:20:20 +00:00
Nikolai Kochetov
a7fb2e38a5 Use ColumnWithTypeAndName as function argument instead of Block. 2020-10-09 10:41:28 +03:00
filipe
3861a03927 fix pvs check 2020-10-08 20:14:54 -03:00
Denis Glazachev
e348ec17b2 Refactor role handling 2020-10-09 00:57:23 +04:00
Alexander Tokmakov
a6178cc876 try fix select count() for MaterializeMySQL 2020-10-08 23:39:24 +03:00
tavplubix
7b5f2b2bb0
Merge pull request #15701 from ClickHouse/better_clone_replica
Improvements in lost replica recovery
2020-10-08 23:19:23 +03:00
alexey-milovidov
c693c653a5
Merge pull request #15639 from GrigoryPervakov/tmp-s3-merge
Use tmp disk for vertical merge files
2020-10-08 20:58:07 +03:00
Alexandra Latysheva
6877f4aa9c for parallel and non-parallel quorum insertion at the same time 2020-10-08 15:35:41 +00:00
tavplubix
6065a5b65c
Update StorageReplicatedMergeTree.cpp 2020-10-08 16:37:32 +03:00
alexey-milovidov
8ae2bc06a1
Merge pull request #15378 from amosbird/realfix
Fix multiple column transformers.
2020-10-08 16:26:48 +03:00
Anton Popov
4bc40421e2
Merge pull request #15731 from CurtizJ/fix-tranform-null-in
Fix assertion with setting transform_null_in
2020-10-08 16:12:56 +03:00
Anton Popov
1a6d2bc538 fix prewhere with virtuals columns 2020-10-08 15:59:47 +03:00
Pervakov Grigorii
3a2068f19d Use tmp disk for vertical merge files 2020-10-08 13:49:41 +03:00
alexey-milovidov
9b9a5d9dc8
Merge pull request #15643 from azat/remove-obsolete-settings
Remove obsolete settings
2020-10-08 13:30:36 +03:00
alexey-milovidov
342f3b07dc
Merge pull request #15737 from azat/profile-events-fixes
Fix RealTimeMicroseconds ProfileEvents
2020-10-08 13:14:15 +03:00
alexey-milovidov
c0cb18b445
Merge pull request #15740 from azat/kafka-memory-accounting
Take memory allocations from librdkafka threads into account
2020-10-08 13:12:54 +03:00
Amos Bird
867216103f
Extend trivial count optimization. 2020-10-08 18:08:17 +08:00
Amos Bird
c9ab87ed17
Fix explain syntax 2020-10-08 17:06:04 +08:00
Amos Bird
ac102540d0
Global WITH and WITH propagation. 2020-10-08 15:03:34 +08:00
Azat Khuzhin
1f51de362f Take memory allocations from librdkafka threads into account 2020-10-07 23:18:20 +03:00
alexey-milovidov
e465ce3d49
Merge pull request #15642 from azat/force_data_skipping_indices
Implement force_data_skipping_indices setting
2020-10-07 23:14:51 +03:00
Alexander Tokmakov
ffb19fa4bc fix 2020-10-07 22:47:31 +03:00
Azat Khuzhin
3cd71f3357 Cleanup interceptors for librdkafka in StorageKafka
Wrap them into StorageKafkaInterceptors to allow access to private
fields and add logging inside interceptors if something fails.

This is also preparation for ThreadStatus interceptor.
2020-10-07 21:42:13 +03:00
Azat Khuzhin
c0e15ba348 Fix RealTimeMicroseconds ProfileEvents
RUsageCounters::real_time (RealTimeMicroseconds) was constructed from
CLOCK_REALTIME (or similar) in the ThreadStatus::initPerformanceCounters()
(ThreadStatusExt.cpp), while the intention is to store CLOCK_MONOTONIC
(time from boot, i.e. /proc/uptime) values there (in ThreadProfileEvents.h)
2020-10-07 21:32:36 +03:00
Azat Khuzhin
553f6aa4cd Remove unused functions 2020-10-07 21:30:53 +03:00
alesapin
d093d4c535
Merge pull request #15675 from ClickHouse/fix_races_in_hdfs
Fix races in libhdfs
2020-10-07 20:39:40 +03:00
Artem Zuikov
eb1cb506c9
minor code improvement (#15668) 2020-10-07 20:20:07 +03:00
Nikolai Kochetov
54e77e906e
Merge pull request #15717 from ClickHouse/fix-array-join-optimisation-for-mv
Fix array join optimisation for MV
2020-10-07 20:19:35 +03:00
Anton Popov
cc451e41f5 fix assertion with transform_null_in 2020-10-07 18:36:34 +03:00
Latysheva Alexandra
f43ad338ed
Merge pull request #12 from alexelex/quorum_inserts_2
style check
2020-10-07 18:56:14 +06:00
Alexandra Latysheva
8f8872dc42 style check 2020-10-07 12:24:46 +00:00
Nikolai Kochetov
d94d88a6c0 Fix style. 2020-10-07 15:04:15 +03:00
Latysheva Alexandra
6c26f77380
Merge pull request #11 from alexelex/quorum_inserts_2
changing the condition for updateQuorum, specialized it and reduced t…
2020-10-07 17:49:20 +06:00
Pavel Kovalenko
69c126f1f1 Possibility to move part to another disk/volume if first attempt was failed. 2020-10-07 14:35:28 +03:00
Artem Zuikov
403a5320f5
enable bigint float division (#15691) 2020-10-07 14:32:57 +03:00
Alexandra Latysheva
a43cac2c1a changing the condition for updateQuorum, specialized it and reduced the number of calls to the zk 2020-10-07 11:28:48 +00:00
Nikolai Kochetov
7e02152b50 Merge branch 'master' into storage-read-query-plan 2020-10-07 14:27:21 +03:00
Nikolai Kochetov
c5cb05f5f3 Try fix tests. 2020-10-07 14:26:29 +03:00
tavplubix
041015545c
Merge pull request #15537 from ClickHouse/mutation_hangs_after_replace_partition
Fix mutation may hang after REPLACE/DROP PARTITION
2020-10-07 14:25:29 +03:00
Nikolai Kochetov
df02573c92 Fix ARRAY JOIN optimisation when reading from MV. 2020-10-07 13:11:58 +03:00
Nikolai Kochetov
5f7aeddfe5
Merge pull request #15682 from ClickHouse/akz/storage_memory_less_locks
Less locking in StorageMemory: totalRows + totalBytes
2020-10-07 12:59:20 +03:00
Vasily Kozhukhovskiy
b8aa440912 style fixes 2020-10-07 12:24:54 +03:00
alexey-milovidov
e00961f882
Merge pull request #15657 from Jokser/disk-s3-write-error-handling
Proper error handling during insert into MergeTree with S3
2020-10-07 11:17:32 +03:00
Alexander Tokmakov
47e9fe9ff1 fix 2020-10-07 03:05:48 +03:00
Alexander Tokmakov
ea16370024 improvements in lost replica recovery 2020-10-07 02:29:33 +03:00
Azat Khuzhin
75e612fc16 Use full featured parser for force_data_skipping_indices 2020-10-07 01:44:14 +03:00
Azat Khuzhin
ef6d12967f Implement force_data_skipping_indices setting 2020-10-07 01:42:31 +03:00
Latysheva Alexandra
991e51a80e
Merge pull request #10 from alexelex/quorum_inserts_2
style check fix
2020-10-07 04:38:30 +06:00
Alexandra Latysheva
9077c92862 style check fix 2020-10-06 22:36:42 +00:00
Latysheva Alexandra
85bcc07c0b
Merge pull request #9 from alexelex/quorum_inserts_2
Quorum inserts [version 3]
2020-10-07 04:04:41 +06:00
Alexandra Latysheva
644091459f style fixes and remove small changes 2020-10-06 22:01:30 +00:00
Azat Khuzhin
675c70acbc Remove obsolete settings
Came to this when looking at allow_experimental_data_skipping_indices,
for implementing force_data_skipping_indices
2020-10-07 00:56:22 +03:00
Alexandra Latysheva
f549ecf9d1 insert_quorum_parallel: status nodes in /quorum/parallel and allow merges 2020-10-06 21:49:48 +00:00
Denis Glazachev
555f056a4c Revert "user not found" detection in loginImpl() and getIDOfLoggedUserImpl() 2020-10-06 20:32:06 +04:00
Nikolai Kochetov
1f2e867ce6
Merge pull request #15645 from ClickHouse/read-from-storage-step-field-order
Ensure resource destruction order in ReadFromStorageStep.
2020-10-06 19:17:38 +03:00
Denis Glazachev
54446eeec6 Use ErrorCodes::UNKNOWN_USER 2020-10-06 20:00:29 +04:00
Denis Glazachev
fed6080273 Implement custom getIDOfLoggedUserImpl() 2020-10-06 19:54:22 +04:00
Vasily Kozhukhovskiy
dfc13ca8e7 Enable parsing enum values by their ids for CSV, TSV and JSON input formats
* for CSV and TSV input formats input_format_csv_enum_as_number,
    input_format_tsv_enum_as_number settings should be enabled in order to
    treat input value as enum id
2020-10-06 18:37:54 +03:00
Denis Glazachev
e2f444ae85 Simplify loginImpl() and getIDOfLoggedUserImpl() 2020-10-06 19:37:35 +04:00
Denis Glazachev
950a07835f Stylistic changes 2020-10-06 19:23:08 +04:00
Alexander Kazakov
cabab90ab2 Get back to moving args 2020-10-06 17:54:22 +03:00
Alexander Kazakov
ae2c106f94 Minor fixes 2020-10-06 17:04:08 +03:00
Alexander Kazakov
e54ff6e60a Lock-less totalRows/totalBytes + more clear postponed init 2020-10-06 16:45:17 +03:00
alesapin
00f29e400f Fix race condition in hdfs 2020-10-06 16:29:08 +03:00
Azat Khuzhin
9594e463b4
Cancel other processors on query exception (#15578)
* Add a test for canceling distributed queries on error

* Cancel other processors on exception in PipelineExecutor

Fixes: 01514_distributed_cancel_query_on_error
2020-10-06 14:24:55 +03:00
Nikolai Kochetov
3564ba1c63 Remove moves. 2020-10-06 13:02:07 +03:00
Pavel Kovalenko
69b4bc6f33 Proper error handling during insert into MergeTree with S3. 2020-10-06 12:38:00 +03:00
Nikolai Kochetov
7caf6da363 Fix build. 2020-10-06 11:56:21 +03:00
Nikolai Kochetov
efd1f10a6d Fix build. 2020-10-06 11:55:03 +03:00
Nikolai Kochetov
8320efc189 Fix read from Buffer table with empty nested table with different types. 2020-10-06 11:24:12 +03:00
Nikolai Kochetov
d968f276b5 Fix buffer table. 2020-10-06 11:21:05 +03:00
Vladimir Chebotarev
d98366ed79 Better initialization of S3 storage. 2020-10-06 11:20:47 +03:00
Artem Zuikov
bad8171f24
Fix distributed IN without database on initiator (#15538) 2020-10-06 11:18:25 +03:00
Nikolai Kochetov
5bbae0953a Fix order of resource destruction in SettingQuotaAndLimitsStep. 2020-10-06 09:53:51 +03:00
Nikolai Kochetov
f9bf1e3406 Merge branch 'master' into storage-read-query-plan 2020-10-06 09:50:10 +03:00
Nikolai Kochetov
28e12c559c Ensure resource desrtuction order in ReadFromStorageStep. 2020-10-06 09:35:35 +03:00
Latysheva Alexandra
d495a2fb2d
Merge pull request #7 from alexelex/quorum_inserts_2
build checker fix (style) and change comments
2020-10-06 02:33:29 +06:00
Alexandra Latysheva
41e0148d72 build checker fix (style) and change comments 2020-10-05 20:30:50 +00:00
Alexander Tokmakov
418766e92b fix another bug in mutations 2020-10-05 22:16:28 +03:00
Latysheva Alexandra
3b952aff7d
Merge pull request #6 from alexelex/quorum_inserts_2
fix test_00814
2020-10-05 23:01:18 +06:00
Alexandra Latysheva
2be62bbd1b fix test_00814 2020-10-05 16:58:26 +00:00
alesapin
8ec58c17f3 More consistent metadata usage 2020-10-05 19:41:46 +03:00
Alexander Tokmakov
30a18f7567 make it better 2020-10-05 16:52:03 +03:00
Anton Popov
a49591b250
Merge pull request #15543 from azat/optimize_aggregation_in_order-fix-memory-usage
[RFC] Significantly reduce memory usage in AggregatingInOrderTransform
2020-10-05 16:34:12 +03:00
Latysheva Alexandra
18007622a1
Merge pull request #5 from alexelex/quorum_inserts_2
style check fix
2020-10-05 19:00:39 +06:00
Alexandra Latysheva
aa391a47eb style check fix 2020-10-05 12:59:07 +00:00
Latysheva Alexandra
7e7cedd73f
Merge pull request #4 from alexelex/quorum_inserts_2
style check fix
2020-10-05 16:43:14 +06:00
Alexandra Latysheva
0662432c5c style check 2020-10-05 10:41:49 +00:00
alexey-milovidov
2fcf2e0fbe
Merge pull request #15443 from ucasFL/pretty_row_numbers
Add setting `output_format_pretty_row_numbers`
2020-10-05 11:49:55 +03:00
Latysheva Alexandra
a63084adaf
Merge pull request #3 from alexelex/quorum_inserts_2
Quorum inserts 2
2020-10-05 03:28:58 +06:00
Alexandra Latysheva
d54b6c9542 add question in comments 2020-10-04 20:32:08 +00:00
Denis Glazachev
2fc6a4ea9c Add log_and_mask_exceptions flag to login() 2020-10-05 00:24:09 +04:00
Alexandra Latysheva
ff8cbe6745 remove debug things 2020-10-04 20:19:05 +00:00
Denis Glazachev
1eb8ecf050 Fix compilation 2020-10-04 23:56:25 +04:00
Denis Glazachev
7f47719768 Refactor exception handling in login() et al.
Simplify LDAPClient and LDAPAccessStorage
2020-10-04 23:55:58 +04:00
Alexandra Latysheva
8263e62298 working copy (with some debug info) 2020-10-04 19:55:39 +00:00
Denis Glazachev
00a354cd37 Manually remove storages in reverse order in MultipleAccessStorage d-tor 2020-10-04 22:00:56 +04:00
alexey-milovidov
a005ec4c89
Merge pull request #15589 from ClickHouse/tavplubix-patch-1
Use default implemetation for constants in JSON* functions
2020-10-04 16:02:08 +03:00
alexey-milovidov
6b39d248a0
Merge pull request #15542 from Avogar/quantile_t_digest
Improve quantileTDigest performance
2020-10-04 15:53:36 +03:00
alexey-milovidov
53ce5e3892
Merge pull request #15551 from azat/for-user-limits-over-distributed
Pass through *_for_user settings via Distributed with cluster-secure
2020-10-04 04:18:20 +03:00
filipe
0436e0f8f1 fix style and pvs check 2020-10-03 20:50:44 -03:00
filipe
bab7c762bc fix style and pvs check 2020-10-03 20:38:21 -03:00
filipe
146f973437 add maximum_unit arg to formatReadableTimeDelta function 2020-10-03 19:38:51 -03:00
tavplubix
e219162b82
Update FunctionsJSON.h 2020-10-03 21:09:22 +03:00
alexey-milovidov
6f3aab8f09
Merge pull request #15319 from bharatnc/ncb/fix-14509
Fix bug in queries like SELECT toStartOfDay(today())
2020-10-03 17:02:57 +03:00
alexey-milovidov
f7b390465b
Merge branch 'master' into realfix 2020-10-03 16:54:23 +03:00
Denis Glazachev
82475088f9 Fix "user has been dropped" issue 2020-10-03 17:31:02 +04:00
alexey-milovidov
97d97f6b2e
Merge pull request #15513 from ClickHouse/aku/error-context
Add some context to an error message
2020-10-03 16:24:19 +03:00
alexey-milovidov
ca05425a87
Merge pull request #15535 from nvartolomei/patch-2
Add missing entry to client packet stringify
2020-10-03 16:22:04 +03:00
alexey-milovidov
46fa5ff53e
Merge pull request #15557 from ClickHouse/statvfs-eintr
Handle EINTR in statvfs
2020-10-03 15:57:56 +03:00
alexey-milovidov
ae61f8f7a6
Update filesystemHelpers.cpp 2020-10-03 15:57:35 +03:00
alexey-milovidov
4d6402525a
Update filesystemHelpers.h 2020-10-03 15:57:12 +03:00
alexey-milovidov
9551562889
Merge pull request #15442 from ClickHouse/add_alter_version
Add ability to alter version column in VersionedCollapsingMergeTree.
2020-10-03 05:40:15 +03:00
alexey-milovidov
75fb73956e
Merge pull request #15238 from ianton-ru/multi_delete_in_s3
Use S3 multi object delete
2020-10-03 03:48:06 +03:00
alexey-milovidov
5e37ba4335
Update DiskS3.cpp 2020-10-03 03:47:45 +03:00
alexey-milovidov
3ca7fca48a
Update DiskS3.cpp 2020-10-03 03:42:33 +03:00
Alexey Milovidov
d426ba3074 Step 4: cleanup 2020-10-03 03:07:55 +03:00
Alexey Milovidov
b6ca8a0676 Step 3: check other usages, add a comment 2020-10-03 03:05:54 +03:00
Alexey Milovidov
2441be4b66 Step 2: move code to .cpp 2020-10-03 03:02:47 +03:00
Alexey Milovidov
6608de470d Step 1: handle EINTR in statvfs 2020-10-03 03:01:32 +03:00
alexey-milovidov
cb708212a8
Merge pull request #15536 from ClickHouse/fix_ilike
Separate cache for ilike after like
2020-10-03 02:07:40 +03:00
Azat Khuzhin
f25c1742b8 Pass through *_for_user settings via Distributed with cluster-secure
In cluster-secure case the user on shards (remote) is equal to the user
on the initiator, so those settings can be safely applied.
2020-10-03 02:04:47 +03:00
Azat Khuzhin
2a2f858365 Significantly reduce memory usage in AggregatingInOrderTransform
Clean the aggregates pools (Arena's objects) between flushes, this will
reduce memory usage significantly (since Arena is not intended for
memory reuse in the already full Chunk's)

Before this patch you cannot run SELECT FROM huge_table GROUP BY
primary_key SETTINGS optimize_aggregation_in_order=1 (and the whole
point of optimize_aggregation_in_order got lost), while after, this
should be possible.
2020-10-03 00:56:58 +03:00
Denis Glazachev
44916af70a Merge branch 'master' into ldap-any-user-authentication
* master: (279 commits)
  Convert to python3 (#15007)
  update en and ru docs: add 128/256 types (#15515)
  Drop unused code for numeric_limits<int128> in MergeTreeDataSelectExecutor (#15519)
  Fix comment
  More defaults on defaults
  Recursive defaults
  Fix bash
  Update ActionsVisitor.cpp
  Don't add memcpy for sanitizers builds
  Fix gRPC build scripts.
  Neutrialize thinlto's memcpy libcall gen.
  Revert "Add fno-builtin-memcpy"
  Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it
  Update SECURITY.md
  Update tsan_suppressions.txt
  Update ActionsVisitor.cpp
  remove unrelated changes
  Update SECURITY.md
  fixes
  Update ActionsVisitor.cpp
  ...
2020-10-03 00:45:57 +04:00
Denis Glazachev
68ccd59a74 Synch with internal memory_storage
Fix exception message
2020-10-03 00:32:13 +04:00
Denis Glazachev
ab2c37cead Serialize all calls to ldap lib 2020-10-03 00:31:14 +04:00
Azat Khuzhin
b838214a35 Pass non-const SelectQueryInfo (and drop mutable qualifiers) 2020-10-02 22:42:35 +03:00
Azat Khuzhin
587cde853e Avoid skipping unused shards twice (for query processing stage and read itself) 2020-10-02 22:42:09 +03:00
Pavel Kruglov
7acd85d2b1 Fix style error 2020-10-02 22:20:35 +03:00
alesapin
77c9f7af79
Merge pull request #15532 from ClickHouse/substitute_defaults_recursively
Fix defaults substitution for absent columns which depend on other defaults
2020-10-02 21:42:01 +03:00
Alexander Tokmakov
6b2da861dc Merge branch 'master' into write_structure_of_table_functions 2020-10-02 20:46:58 +03:00
Pavel Kruglov
f6f4285348 Improve quantileTDigest performance 2020-10-02 20:13:55 +03:00
Azat Khuzhin
9cb3c743bd
Convert to python3 (#15007) 2020-10-02 19:54:07 +03:00
feng lv
d2f75f8508 fix 2020-10-02 23:13:28 +08:00
Nikolai Kochetov
404c199448
Merge pull request #15509 from markpapadakis/patch-6
Update ActionsVisitor.cpp
2020-10-02 18:07:46 +03:00
alesapin
8c0581c503 Fix ilike cache 2020-10-02 17:27:47 +03:00
Nikolai Kochetov
11c0c2864f Fix build. 2020-10-02 17:23:06 +03:00
nvartolomei
d35ac3c3fb
Add missing entry to client packet stringify
(noticed while reading the code)
2020-10-02 15:10:19 +01:00
Azat Khuzhin
21deb6812c
Drop unused code for numeric_limits<int128> in MergeTreeDataSelectExecutor (#15519) 2020-10-02 16:46:20 +03:00
alesapin
ef9728da79 Fix comment 2020-10-02 15:54:51 +03:00
alesapin
17b86dec96 Recursive defaults 2020-10-02 15:38:50 +03:00
Nikolai Kochetov
bef96faa1a Tru fix tests. 2020-10-02 15:38:33 +03:00
Alexander Kuzmenkov
0635841dc9 Merge remote-tracking branch 'origin/aku/error-context' into HEAD 2020-10-02 14:38:55 +03:00
Alexander Kuzmenkov
a9a7b065a0 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-02 14:38:47 +03:00
Alexander Kuzmenkov
3a963c988d fixup 2020-10-02 14:38:32 +03:00
Nikolai Kochetov
5ea4dc0850 Try fix tests. 2020-10-02 14:25:16 +03:00
Alexander Kuzmenkov
3be7c7745e Use a separate overload for formatting with fmt 2020-10-02 14:06:38 +03:00
Nikolai Kochetov
56141a1e6b
Update ActionsVisitor.cpp 2020-10-02 12:13:26 +03:00
alesapin
c0d1416bbd
Merge pull request #15516 from nvartolomei/nv/error-out-for-wrong-parameters-replicatedmergetree
Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it
2020-10-02 10:18:28 +03:00
Nikolai Kochetov
ea131989be Try fix test. 2020-10-01 21:47:20 +03:00
Nikolai Kochetov
5134028140 Fix style. 2020-10-01 21:19:38 +03:00
Nikolai Kochetov
f02ad3dc8e Use QueryPlan while reading from MergeTree. 2020-10-01 21:02:22 +03:00
Nikolai Kochetov
ec64def384 Use QueryPlan while reading from MergeTree. 2020-10-01 20:34:22 +03:00
Nicolae Vartolomei
eb1d253355 Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it 2020-10-01 17:59:50 +01:00
Alexander Kuzmenkov
244687bfc1 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-01 18:41:48 +03:00
Alexander Kuzmenkov
6e07bfe7bc return the comment 2020-10-01 17:29:22 +03:00
Alexander Kuzmenkov
c20053351c Make the test throw more comprehensive errors 2020-10-01 17:23:48 +03:00
alesapin
0f92f60ab2
Update ActionsVisitor.cpp 2020-10-01 14:35:56 +03:00
Alexander Kuzmenkov
c5d6e2e67c Add context to error messages 2020-10-01 14:02:53 +03:00
Alexander Kuzmenkov
99915fa444 remove unrelated changes 2020-10-01 14:00:58 +03:00
Alexander Kuzmenkov
608b6e3a25 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-01 14:00:22 +03:00
Nicolae Vartolomei
7197a0c803 Possibly fix the issue with quorum 2020-10-01 11:38:50 +01:00
Nikolai Kochetov
3792d688c0
Merge pull request #14741 from ClickHouse/expression-dag
ActionsDAG
2020-10-01 12:50:32 +03:00
Alexander Kuzmenkov
bc66dc99d1 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-01 12:28:30 +03:00
Mark Papadakis
b642bd494d
Update ActionsVisitor.cpp
Refactoring: eliminated a local, throws if it matches the column name as opposed to iterating to the end of the container.
2020-10-01 12:03:19 +03:00
alesapin
8bc9ede711 Fix clang tidy 2020-10-01 09:53:47 +03:00
alesapin
5622a0769f
Merge pull request #15477 from ClickHouse/fix_ddl_worker_wait
Fix wait event subscription in DDLWorker
2020-10-01 09:51:47 +03:00
filipe
077ee81177 add an SQL function formatReadableTimeDelta to format time delta 2020-09-30 23:55:46 -03:00
alexey-milovidov
9808d0be81
Merge pull request #15376 from excitoon-favorites/fixs3storage
Fixed compression in S3 storage
2020-10-01 04:30:32 +03:00
Alexandra Latysheva
e89a56969f first part 2020-09-30 23:16:27 +00:00
tavplubix
2f95609f98
Merge pull request #15448 from ClickHouse/allow_synchronous_drop_for_atomic_db
Allow synchronous DROP/DETACH TABLE for Atomic
2020-10-01 01:14:31 +03:00
Artem Zuikov
0f6a6453fe
Remove multiple_joins_rewriter v1 (#15472) 2020-09-30 23:11:49 +03:00
Artem Zuikov
0ac18a382f
Fix JOIN with GROUP BY over StorageMerge (#15242) 2020-09-30 23:11:27 +03:00
alesapin
97c2579fb9 Use separate function 2020-09-30 22:50:23 +03:00
alesapin
ac9f0ff4da More strict check for version column 2020-09-30 22:44:35 +03:00
Alexander Kuzmenkov
16ab4d59e6 don't shadow local var 2020-09-30 20:36:02 +03:00
Alexander Kuzmenkov
e45edd57f2 Add reinterpretAsUUID function 2020-09-30 20:19:32 +03:00
Alexander Kuzmenkov
626c2a3e28 microsecond precision for start/finish time 2020-09-30 19:16:33 +03:00
Nikolai Kochetov
cb22152878 Fix build. 2020-09-30 18:54:16 +03:00
Vladimir Chebotarev
0497ce4f9c Possibly better fix. 2020-09-30 18:29:10 +03:00
alesapin
cfe9a0c4a1 Fix event subscription in DDLWorker 2020-09-30 17:58:27 +03:00
Nikolai Kochetov
45618c9d4c
Merge pull request #15437 from ClickHouse/azat-ThreadPool-UAF-fixes
Destroy resources captured by lambda after `ThreadFromGlobalPool::join()`
2020-09-30 16:50:30 +03:00
Nikolai Kochetov
0b1fe69ad7 Fix build. 2020-09-30 16:31:06 +03:00
Vladimir Chebotarev
b460024356 Fixed bug in GZIP compression in S3 storage. 2020-09-30 16:09:55 +03:00
Nikolai Kochetov
a1aca04711 Fix build. 2020-09-30 15:32:37 +03:00
Nikolai Kochetov
2efde179e9 Merge branch 'master' into storage-read-query-plan 2020-09-30 15:23:46 +03:00
Nikolai Kochetov
5ac6bc071d QueryPlan for StorageBuffer and StorageMaterializedView read. 2020-09-30 15:22:57 +03:00
Nikolai Kochetov
576ffadb17 Fix explain for ISourceStep. 2020-09-30 15:22:30 +03:00
Vladimir Chebotarev
a38c7ff2a8 Somehow uncompressed PUT works and gzipped PUT doesn't, in S3 storage. 2020-09-30 15:04:42 +03:00
Nikolai Kochetov
782823de4d Fix build. 2020-09-30 14:45:47 +03:00
Vladimir Chebotarev
698768add0 Fixed format argument in S3 storage when compression method is selected. 2020-09-30 13:55:44 +03:00
alesapin
01d8a36cd6
Merge pull request #15456 from ClickHouse/more-exception-safety-in-shellcommand
Fix exception safety in ShellCommand
2020-09-30 12:56:55 +03:00
tavplubix
c9eeb149fd
Merge pull request #15384 from zhang2014/fix/ISSUES-15365
ISSUES-15365 fix attach mysql database database
2020-09-30 11:27:15 +03:00
Nikolai Kochetov
0e412686bc Better comments. 2020-09-30 11:25:22 +03:00
alexey-milovidov
0c07c2d3a3
Merge pull request #15089 from ClickHouse/codecs_for_nested_types
Codecs for nested types
2020-09-30 07:18:19 +03:00
feng lv
c857b5dd5d fix 2020-09-30 09:50:23 +08:00
alexey-milovidov
412a54e356
Merge pull request #14693 from hustnn/zk_exist_fix2
Fix potential memory leak caused by zookeeper exist calling
2020-09-30 04:48:11 +03:00
alexey-milovidov
b6bccfc4f4
Merge pull request #14776 from Vxider/disable_set_and_join_persistency
Support memory only mode for StorageJoin and StorageSet.
2020-09-30 04:35:43 +03:00
alexey-milovidov
ac989f3a8f
Merge pull request #15285 from ucasFL/now-with-timezone
function `now` allow an argument with timezone
2020-09-30 04:32:36 +03:00
Alexey Milovidov
78dbf10c7b Fix exception safety in ShellCommand 2020-09-30 03:00:45 +03:00
Alexander Tokmakov
e156e6115e add setting 2020-09-30 01:30:34 +03:00
alexey-milovidov
b658f348a7
Update MergeTreeDataPartWriterWide.cpp 2020-09-30 01:23:42 +03:00
alexey-milovidov
9f944424cf
Merge pull request #15364 from ClickHouse/format-raw-blob
Add format RawBLOB
2020-09-30 01:14:40 +03:00
alexey-milovidov
3e99ca797b
Merge pull request #15426 from ClickHouse/format-regexp-escaping-rule-change-default-to-raw
Format Regexp: change default escaping rule to Raw
2020-09-30 01:14:08 +03:00
Nikolai Kochetov
727289cb09 Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 23:43:02 +03:00
Nikolai Kochetov
a2c70c4611 Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 22:11:40 +03:00
Artem Zuikov
86cfc6f914
change error code (#15452) 2020-09-29 20:36:14 +03:00
alesapin
4ab39d2bee
Fix style 2020-09-29 18:19:30 +03:00
Alexander Tokmakov
cf86e19f38 fix build 2020-09-29 17:15:05 +03:00
Alexander Tokmakov
8692c10495 add alias 2020-09-29 17:12:40 +03:00
Alexander Tokmakov
5d19ed04f6 allow synchronous drop/detach table for Atomic 2020-09-29 16:47:08 +03:00
Nikolai Kochetov
33487c0e4a
Merge pull request #15422 from ClickHouse/query-plan-header-remove-columns
Remove column from header descriotion for EXPLAIN PLAN
2020-09-29 15:51:09 +03:00
feng lv
4f000388a7 add setting output_format_pretty_row_numbers 2020-09-29 20:30:36 +08:00
alesapin
65a05a970d Better message on error 2020-09-29 15:07:01 +03:00
Alexander Kuzmenkov
2d456e2cd6
Merge pull request #15407 from detailyang/master
bugfix:aggregate:fix boundingratio args check
2020-09-29 14:12:54 +03:00
Nikolai Kochetov
a7e7fd084f Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 13:48:11 +03:00
Nikolai Kochetov
de56c02525 Merge branch 'master' into expression-dag 2020-09-29 12:18:29 +03:00
Nikolai Kochetov
53d4e5d195 Merge branch 'master' into expression-dag 2020-09-29 12:15:50 +03:00
Azat Khuzhin
1fcc36ef80 Use ThreadPool to ensure that everything has been finished in PipelineExecutor
This will fix possible UAF, since ThreadFromGlobalPool cannot wait until
the job will be reseted, for this you need to call ThreadPool::wait()
(that waits until scheduled_jobs will be zero), and this guarantee that
the job was reseted, otherwise some variables that job is referencing
may be already destroyed, while job hasn't been destoyed yet (example
that I found PipelineExecutor -> ThreadGroupStatusPtr -> MemoryTracker
-> ~MemoryTracker -> log, while log had been destroyed already, here is
TSAN report --
https://gist.github.com/azat/d480dc3af5a0a44de4b038e20807c4b9, copied
from
https://clickhouse-test-reports.s3.yandex.net/15035/79133a426fdf042e383ea0cdccc4dc8273baa3a7/functional_stateless_tests_(thread)/test_run.txt.out.log)
2020-09-29 11:00:03 +03:00
Azat Khuzhin
789434994a Reset job on failure too in ThreadPool::worker()
job should be reseted before decrementing scheduled_jobs to
ensure that the Job destroyed before wait() returns.
2020-09-29 10:56:36 +03:00
zhang2014
9e94c077e7 IESSUES-15365 try fix integration test 2020-09-29 10:39:30 +08:00
Alexey Milovidov
dee57d7976 Format Regexp: change default escaping rule to Raw 2020-09-29 00:19:13 +03:00
Alexey Milovidov
e4800e7b35 Fix comment 2020-09-29 00:10:36 +03:00
Nikolai Kochetov
347080ff9a Remove column from header descriotion for EXPLAIN PLAN and EXPLAIN PIPELINE 2020-09-28 20:37:11 +03:00
Alexander Kuzmenkov
51b9aaf4d8
Merge pull request #15363 from ClickHouse/format-regexp-raw
Add support for "Raw" column format for Regexp format
2020-09-28 20:03:32 +03:00
tavplubix
4578d89819
Merge pull request #15348 from ClickHouse/replicate_default_args
Continuation of #14791
2020-09-28 18:53:02 +03:00
tavplubix
421d3b0b86
Merge pull request #14760 from bharatnc/ncb/event_time_microsec_p2
add event_time_microseconds field for system.{trace,text,query,query_thread}_log tables
2020-09-28 18:34:21 +03:00
Alexander Kuzmenkov
218d86de7e Merge remote-tracking branch 'origin/master' into tmp 2020-09-28 16:29:51 +03:00
zhang2014
e5a6d06820 ISSUES-15365 try fix integration test failure 2020-09-28 21:15:02 +08:00
detailyang
6e70f2ce7a bugfix:aggregate:fix boundingratio args check 2020-09-28 19:56:42 +08:00
zhang2014
e40d23cfe5 ISSUES-15365 add ya make 2020-09-28 19:11:40 +08:00
Nikita Mikhaylov
72e4b10c00
Merge pull request #14842 from hexiaoting/hxt_dev
Fix bug for LineAsString Format
2020-09-28 14:02:23 +03:00
Nikita Mikhaylov
a4832ed5ce
Merge branch 'master' into HyaZz-master 2020-09-28 13:55:45 +03:00
zhang2014
d3047d0783 ISSUES-15365 fix attach mysql database failure 2020-09-28 18:02:30 +08:00
Amos Bird
8eb8175258
Fix multiple column transformers. 2020-09-28 17:53:39 +08:00
Nikita Mikhaylov
73573472e9
Merge pull request #15299 from CurtizJ/fix-mysql-hung
Fix hang of queries with a lot of subqueries to same mysql table
2020-09-28 12:51:35 +03:00
Anton Ivashkin
c2b692f2c7 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into multi_delete_in_s3 2020-09-28 12:00:34 +03:00
Anton Ivashkin
c18cdec77c Use S3 multi object delete
Some strange with s3_with_proxy test
2020-09-28 11:47:04 +03:00
tavplubix
ffc0499952
Merge pull request #15243 from ClickHouse/tavplubix-patch-1
Try fix race on Context::settings
2020-09-28 11:44:27 +03:00
alesapin
bc662ac4e0
Merge pull request #15293 from amosbird/bc3
Replace useless multiset with unordered_set
2020-09-28 10:30:04 +03:00
hustnn
a7024134dd Merge remote-tracking branch 'upstream/master' into zk_exist_fix2 2020-09-28 14:44:55 +08:00
Alexey Milovidov
57c6af479c Fix "Arcadia" 2020-09-28 03:26:15 +03:00
Alexey Milovidov
79f510d63a Fix error in LowCardinality; add test 2020-09-28 03:22:50 +03:00
Alexey Milovidov
a7ddd8489a Added format RawBLOB 2020-09-28 03:11:19 +03:00
Alexey Milovidov
b800a7fdf1 Add support for "Raw" column format for Regexp format 2020-09-28 01:09:32 +03:00
Alexander Tokmakov
b0d99217fb Merge branch 'master' into write_structure_of_table_functions 2020-09-27 14:26:47 +03:00
Alexander Tokmakov
3bc8d9daa9 fix sync 2020-09-27 14:10:45 +03:00
Alexander Tokmakov
34addcf61f add review suggestions 2020-09-26 22:18:28 +03:00
alexey-milovidov
bbbe51033d
Merge pull request #15321 from ClickHouse/query-obfuscator
Query obfuscator
2020-09-26 19:43:36 +03:00
tavplubix
df6221f7bf
Merge pull request #15302 from ClickHouse/tavplubix-patch-2
Fix ASTColumnsReplaceTransformer::Replacement::clone()
2020-09-26 19:10:00 +03:00
alesapin
59f2bbe2a3
Merge pull request #15304 from ClickHouse/fix_race_condition_on_rename
Fix race condition between write ahead log cleanup and rename
2020-09-26 10:43:26 +03:00
alesapin
adf8c94d70
Merge pull request #15300 from ClickHouse/fix_race_on_default_database
Fix for default database race on server startup
2020-09-26 10:43:17 +03:00
Alexey Milovidov
da8a938069 Replace unit test to functional test 2020-09-26 09:50:34 +03:00
feng lv
6d5cd95d3f fix 2020-09-26 14:48:59 +08:00
alexey-milovidov
fc1cf426dd
Merge pull request #15048 from markpapadakis/patch-5
Update ForkProcessor.cpp
2020-09-26 07:35:31 +03:00
alexey-milovidov
d1fce06292
Merge pull request #15297 from hexiaoting/build_bugfix
fix build bug for merge_selector2.cpp
2020-09-26 07:32:33 +03:00
Alexey Milovidov
57b480e65d Fix PVS warning 2020-09-26 07:03:55 +03:00
Alexey Milovidov
5e146eda04 Fix error 2020-09-26 06:02:05 +03:00
Alexey Milovidov
f3349c8d13 Keywords are case-insensitive 2020-09-26 05:13:20 +03:00
Alexey Milovidov
c51502bce4 Remove words with dashes 2020-09-26 05:06:14 +03:00
Alexey Milovidov
f97d40584d Fix "Arcadia" 2020-09-26 04:10:26 +03:00
Alexey Milovidov
bda2c2f58f Remove sensitive words 2020-09-26 03:53:26 +03:00
Alexey Milovidov
fc10803def Fix comment 2020-09-26 03:50:56 +03:00
Alexey Milovidov
d78fc63deb Remove duplicate word 2020-09-26 03:50:00 +03:00
Alexey Milovidov
22861b0c3d Remove some profanity 2020-09-26 03:49:30 +03:00
Alexey Milovidov
673f72cf8c Remove some profanity 2020-09-26 03:48:09 +03:00
Alexey Milovidov
ed4ff51ed8 Integrate into clickhouse-format; add test and comments 2020-09-26 03:38:59 +03:00
Alexey Milovidov
62c2c2000c Query obfuscator: development 2020-09-26 03:00:54 +03:00
bharatnc
5c8c636cf1 Fix - allow empty tz in exp like toStartOf*(today()) 2020-09-25 11:03:16 -07:00
bharatnc
4f8266c7a1 Make trace_log test to pass 2020-09-25 10:39:37 -07:00
bharatnc
b27579e3f7 Use std::chrono instead of clock_gettime 2020-09-25 10:39:37 -07:00
bharatnc
24ea6b2380 TraceCollector - time s&us using same timespec 2020-09-25 10:39:37 -07:00
bharatnc
324a06145c EventTime - construct time in s and us from same timespec 2020-09-25 10:39:37 -07:00
bharatnc
f252523442 Query,QueryThread Logs - add event_time_microseconds field 2020-09-25 10:39:37 -07:00
bharatnc
b0d4fe5114 TraceLog - add field event_time_microseconds 2020-09-25 10:39:37 -07:00
bharatnc
a351980717 TextLog - add event_time_microseconds field 2020-09-25 10:39:37 -07:00
alexey-milovidov
6ec5bcc88f
Merge pull request #15286 from zlobober/public_create_block_for_set
Put createBlockForSet declaration to header file.
2020-09-25 20:12:44 +03:00
Maxim Akhmedov
6914a86673 Put createBlockForSet declaration to header file. 2020-09-25 17:49:54 +03:00
Denis Glazachev
8f2c23e6de Merge branch 'master' into ldap-any-user-authentication
* master: (224 commits)
  Update in.md
  Add a test for embedded configs
  Allow to run without /proc/self/maps
  Update adopters.md
  More convenient
  Enable embedded configs for AArch64
  More results
  More handy
  More handy
  Added a comment
  Adjustments
  Adjustments
  Adjustments
  Added new results
  Step 1: make adding hardware benchmark results more convenient
  Revert "Avoid deadlocks in Log/TinyLog"
  Fix MSan report in QueryLog
  add some disabled tests from arcadia to skip_list.json
  Update skip_list.json
  Bump CI. [2]
  ...

# Conflicts:
#	docker/test/testflows/runner/Dockerfile
2020-09-25 17:33:50 +04:00
Nikolai Kochetov
dea90009e3 Fix build 2020-09-25 16:03:12 +03:00
Alexander Tokmakov
68669b8a92 Merge branch 'master' into replicate_default_args 2020-09-25 15:52:17 +03:00
alesapin
f5c38b34ae Fix race condition during write ahead log cleanup and rename 2020-09-25 15:07:38 +03:00
tavplubix
d4c8ba8410
Update ASTColumnsTransformers.h 2020-09-25 14:58:04 +03:00
Alexander Tokmakov
8f21c73b76 Revert "Update ASTColumnsTransformers.h"
This reverts commit b30e860166.
2020-09-25 14:52:55 +03:00
tavplubix
b30e860166
Update ASTColumnsTransformers.h 2020-09-25 14:51:00 +03:00
alesapin
97671a1771 Ugly fix for default database race 2020-09-25 14:27:00 +03:00
Anton Popov
085f63a9bf fix hang of queries with a lot of subqueries to same mysql table 2020-09-25 14:12:48 +03:00
tavplubix
b96157e32b
Merge branch 'master' into enable_atomic_database_by_default 2020-09-25 13:42:39 +03:00
hexiaoting
4666ae3211 fix build bug for merge_selector2.cpp 2020-09-25 17:59:19 +08:00
Amos Bird
81d08b59e5
Replace useless multiset with unordered_set 2020-09-25 16:38:09 +08:00
feng lv
87726a7af2 function allow an argument with timezone 2020-09-25 15:20:42 +08:00
alesapin
2bacb6f6c8
Merge pull request #15220 from amosbird/fixjgc
Fix joinGet crash with LowCardinality types
2020-09-25 10:09:05 +03:00
alexey-milovidov
9446e43146
Merge pull request #15258 from ClickHouse/fix-msan-failure-2
Fix MSan report in QueryLog
2020-09-25 08:06:45 +03:00
alexey-milovidov
13529265c4
Revert "Avoid deadlocks in Log/TinyLog" 2020-09-25 02:28:57 +03:00
Alexey Milovidov
e51d9dd2e7 Fix MSan report in QueryLog 2020-09-25 02:24:58 +03:00
Alexander Tokmakov
fb826557b7 Merge branch 'master' into enable_atomic_database_by_default 2020-09-25 02:04:01 +03:00
tavplubix
2566478349
Merge pull request #15240 from ClickHouse/fix-random-seed
Fix strange code
2020-09-25 01:26:22 +03:00
Nikita Mikhaylov
788b62b931
Merge pull request #14879 from nikitamikhaylov/yet_another_dictionary_bugfix
Segfault in CacheDictionary
2020-09-24 20:23:42 +03:00
tavplubix
5ff5ca1fa6
Update Context.cpp 2020-09-24 20:08:15 +03:00
tavplubix
ab01fb36da
Update ProcessList.cpp 2020-09-24 20:05:13 +03:00
Alexey Milovidov
dce6a436f3 Fix strange code 2020-09-24 19:35:17 +03:00
Vitaly Baranov
0605808ed1
Merge pull request #14492 from vitlibar/use-previous-users-xml-if-failed-to-reload
Use previous users.xml if failed to reload
2020-09-24 16:25:19 +03:00
Alexander Kuzmenkov
813a876e93
Merge pull request #14962 from ClickHouse/log-avoid-deadlock
Avoid deadlocks in Log/TinyLog
2020-09-24 13:54:11 +03:00
Amos Bird
a2845acf37
Fix joinGet crash with LowCardinality types. 2020-09-24 17:29:52 +08:00
Nikolai Kochetov
e0c7cf842b
Merge pull request #15201 from ClickHouse/explain-optimize-pipeline-setting
Add optimize setting to explain plan.
2020-09-24 10:35:50 +03:00
alesapin
96c419974c Merge branch 'master' into codecs_for_nested_types 2020-09-24 10:28:20 +03:00
alesapin
7e6536097f
Merge pull request #15192 from ClickHouse/fix_storage_buffer_alter
Fix insert into storage Buffer after alter.
2020-09-24 10:22:58 +03:00
tavplubix
aff7ec2df5
Merge pull request #15152 from maqroll/master
decimal field in mysql column definition packet shouldn't have size 1?
2020-09-23 22:22:40 +03:00
Alexander Tokmakov
f0f91f84af Merge branch 'master' into enable_atomic_database_by_default 2020-09-23 21:50:15 +03:00
Alexander Tokmakov
a8266a3d3c fix DDDL with cross-replication and Atomic 2020-09-23 21:28:59 +03:00
Nikolai Kochetov
74e785a2fe Add optimize setting to explain plan. 2020-09-23 20:42:46 +03:00
alexey-milovidov
3bc09bb867
Merge pull request #15178 from amosbird/dtcf
Fix performance issue when doing datetime comparison
2020-09-23 20:33:23 +03:00
alesapin
39f23fbb8f
Merge pull request #14711 from myrrc/feature/cmake-flags-doc-generator
CMake flags reference generator, the guide for adding new options, and the attempt to correct the existing options
2020-09-23 18:56:32 +03:00
alesapin
87b64baea5 Fix again 2020-09-23 16:21:06 +03:00
alesapin
f404925397 More optimal 2020-09-23 15:19:45 +03:00
alesapin
1eb8f0a495 Fix bug in storage buffer during alter 2020-09-23 15:06:54 +03:00
alesapin
74671c909c Merge branch 'master' into codecs_for_nested_types 2020-09-23 13:12:23 +03:00
alesapin
bb4b739f43 Fix PVS-Studio warning 2020-09-23 13:11:48 +03:00
Alexander Kuzmenkov
f6316e2612 Merge remote-tracking branch 'origin/master' into tmp 2020-09-23 11:53:13 +03:00
alesapin
50eba27d1a
Update CompressionFactory.h 2020-09-23 10:24:25 +03:00
Alexander Kuzmenkov
1321832673
Merge pull request #15135 from amosbird/ctefix
Fix ASTWithElement clone.
2020-09-23 09:51:55 +03:00
Alexander Kuzmenkov
27036f5079
Merge pull request #15158 from ClickHouse/aku/rethrow-copy
Rethrow copy of exception in SSD dictionaries
2020-09-23 09:50:26 +03:00
Amos Bird
ee45395942
Fix datetime comparison 2020-09-23 10:29:55 +08:00
alexey-milovidov
31ece3bda5
Merge pull request #15145 from 4ertus2/debt
Better min/max for Int128
2020-09-23 02:03:51 +03:00
filimonov
cc24ef9f83
Better debug message from MergeTreeDataSelectExecutor
See #15168
2020-09-22 21:35:29 +02:00
Alexander Kuzmenkov
74f3c592c7
update comment after #14940 2020-09-22 19:20:37 +03:00
Alexander Kuzmenkov
0752fa0137 Rethrow copy of exception in SSD dictionaries
A follow-up to https://github.com/ClickHouse/ClickHouse/pull/14689 ,
that should fix asan reports in stress test in master.
2020-09-22 18:54:11 +03:00
Alexander Tokmakov
7fcf20e48c enable more tests 2020-09-22 17:29:09 +03:00
alesapin
269d225637 Merge branch 'master' into myrrc-feature-cmake-flags-doc-generator 2020-09-22 17:00:02 +03:00
alesapin
7015f272e7 Better comment 2020-09-22 16:48:38 +03:00
Alexander Kuzmenkov
679c0988a5 Merge remote-tracking branch 'origin/master' into HEAD 2020-09-22 16:25:52 +03:00
Nikolai Kochetov
62ef40394a
Merge pull request #14856 from ClickHouse/query-plan-for-creating-sets
Query plan for creating sets
2020-09-22 16:19:20 +03:00
maqroll
85cf3e798a decimal field in column definition packet shouldn't have size 1? 2020-09-22 15:05:43 +02:00
alesapin
fd394f699c Better comments 2020-09-22 15:49:55 +03:00
alesapin
96d06c6ae6 Less changes 2020-09-22 15:16:15 +03:00
Artem Zuikov
2e6edc250c better min/max for Int128 2020-09-22 14:35:46 +03:00
Amos Bird
def110f835
Fix ASTWithElement clone. 2020-09-22 19:05:23 +08:00
Alexander Kuzmenkov
dde4cf70e1 Merge remote-tracking branch 'origin/master' into HEAD 2020-09-22 14:03:59 +03:00
Alexander Kuzmenkov
7b64ca33b1 Merge remote-tracking branch 'origin/master' into tmp 2020-09-22 14:02:20 +03:00
Alexander Kuzmenkov
bfc3be9e43 Merge remote-tracking branch 'origin/aku/tcp-versio' into tmp 2020-09-22 14:02:15 +03:00
Alexander Kuzmenkov
478c7309d4
Merge pull request #14843 from ClickHouse/aku/global-pool
Exception on double init of global thread pool
2020-09-22 13:44:39 +03:00
Artem Zuikov
2280482530
Keep LowCardinality in MergeJoin left key result type (#15088) 2020-09-22 13:16:22 +03:00
Alexander Kuzmenkov
c0241b617a Merge remote-tracking branch 'origin/master' into HEAD 2020-09-22 13:14:31 +03:00
Alexander Tokmakov
dc1cc11764 Merge branch 'master' into enable_atomic_database_by_default 2020-09-22 12:40:32 +03:00
alesapin
b57708c3dd Merge branch 'master' into codecs_for_nested_types 2020-09-22 09:52:31 +03:00
hustnn
3a59a7d5b6 Remove root path before adding to watches 2020-09-22 09:28:13 +08:00
Niu Zhaojie
76e0147bf4 Use opt num to identify request type 2020-09-22 09:28:12 +08:00
hustnn
35f1db0043 Fix potential memory leak caused by zookeeper exist calling 2020-09-22 09:28:12 +08:00
Alexander Tokmakov
91cbd49e85 fix tests 2020-09-22 00:09:50 +03:00
Nikita Mikhaylov
123f389f1a
Merge pull request #14689 from ClickHouse/aku/broken-perf
Add context to errors in ExpressionAction
2020-09-21 23:33:42 +03:00
Alexey Milovidov
1e65105b06 Merge branch 'master' into log-avoid-deadlock 2020-09-21 21:09:06 +03:00
alexey-milovidov
e29c4c3cc4
Merge pull request #15024 from ClickHouse/fix_renameat2_einval_on_macos
Fix EINVAL in renameat2 on MacOS
2020-09-21 21:08:17 +03:00
alexey-milovidov
c240f464d2
Merge pull request #15061 from azat/UAF-from-ThreadPool-jobs
Fix possible UAF from jobs in the ThreadPool on shutdown
2020-09-21 20:49:46 +03:00
alexey-milovidov
10d3a1d730
Update ThreadPool.cpp 2020-09-21 20:49:15 +03:00
alesapin
263d570f7e
Merge pull request #15076 from ClickHouse/fix_modifying_ast_create_in_database_memory
Fix data race when using DatabaseMemory::getCreateTableQueryImpl(...)
2020-09-21 20:49:06 +03:00
alesapin
e87b961095 Trying to add same logic for compact parts 2020-09-21 20:35:09 +03:00
Nikolai Kochetov
c77a6967a3 Remove commented code. 2020-09-21 19:22:23 +03:00
alesapin
fbd6f10ff7 Use default codec instead of throwing exception 2020-09-21 19:07:14 +03:00
alesapin
bcea1a4207 Remove redundant change 2020-09-21 18:55:21 +03:00
alesapin
8517dda807 First working test 2020-09-21 17:47:10 +03:00
alesapin
4debccb7fe Almost working version 2020-09-21 17:22:13 +03:00
Nikolai Kochetov
334289fd57
Merge pull request #15082 from ClickHouse/try-improve-array-has-built-time
Update SourceVisitor for GatherUtils.
2020-09-21 17:08:14 +03:00
Nikolai Kochetov
0f3eab1e48
Merge pull request #15084 from amosbird/lef
Don't hide interface symbols
2020-09-21 17:07:52 +03:00
Amos Bird
741912cafd
Don't hide interface symbols 2020-09-21 21:03:17 +08:00
tavplubix
fd2cc343e6
Update renameat2.cpp 2020-09-21 15:37:34 +03:00
alesapin
a3e999784b Buildable code 2020-09-21 14:24:10 +03:00
tavplubix
7f629c8185
Update DatabaseMemory.cpp 2020-09-21 14:12:45 +03:00
Alexander Tokmakov
13e41cdd20 try enable atomic database by default 2020-09-21 13:55:34 +03:00
Nikolai Kochetov
efa493fbcb Update SourceVisitor for GatherUtils. 2020-09-21 13:29:31 +03:00
tavplubix
450c1a5709
Update renameat2.cpp 2020-09-21 13:19:02 +03:00
Alexander Tokmakov
ef85ce90c3 fix build 2020-09-21 13:17:33 +03:00
Nikolai Kochetov
54c1f04b38 Review fixes. 2020-09-21 11:36:12 +03:00
alesapin
387b97aba5 Merge branch 'master' into codecs_for_nested_types 2020-09-21 11:06:28 +03:00
alesapin
7fc5a2dae1 Some intermediate stage 2 2020-09-21 10:18:23 +03:00
alesapin
09f6a454ae Some intermediate stage 2020-09-21 10:17:58 +03:00
Denis Glazachev
2c6b6673f2 Remove extra declaration 2020-09-21 02:57:34 +04:00
Denis Glazachev
03481f7a3a Synchronize the code with respect to IAccessStorage::login() functionality 2020-09-21 02:51:38 +04:00
alexey-milovidov
3e0509af69
Merge pull request #13573 from amosbird/rms
specific ReplicatedMergeTree settings
2020-09-21 01:36:33 +03:00
Azat Khuzhin
30f96dc525 Fix possible UAF from jobs in the ThreadPool on shutdown
ThreadPoolImpl<>::worker signaling that job is done while still storing
std::function<> object, and this can lead to problems on shutdown, since
in in this cast std::function<> can refers to some global/static object
that had been already destroyed (typical example is Logger).

I believe that this is exactly what TSAN reports about (decoded
manually, since llvm-symbolizer does not work in the test env):

<details>

```

- 2020-09-20 17:44:43   Write of size 8 at 0x7b1000008f78 by main thread (mutexes: write M1432):
    operator delete(void*, unsigned long)
    ??:0:0

    Poco::Logger::~Logger()
    /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Logger.cpp:39:1
    non-virtual thunk to Poco::Logger::~Logger()
    /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Logger.cpp:0:0

    Poco::RefCountedObject::release() const
    /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/RefCountedObject.h:82:24
    Poco::Logger::shutdown()
    /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Logger.cpp:346:16

    Poco::AutoLoggerShutdown::~AutoLoggerShutdown()
    /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Logger.cpp:459:4

    cxa_at_exit_wrapper(void*)
    ??:0:0

```

```
- 2020-09-20 17:44:43   Previous atomic read of size 4 at 0x7b1000008f78 by thread T116:

    __tsan_atomic32_load
    ??:0:0

    int std::__1::__cxx_atomic_load<int>(std::__1::__cxx_atomic_base_impl<int> const*, std::__1::memory_order)
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/atomic:970:12
    std::__1::__atomic_base<int, false>::load(std::__1::memory_order) const
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/atomic:1487:17
    std::__1::__atomic_base<int, false>::operator int() const
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/atomic:1491:53
    Poco::Logger::is(int) const
    /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/Logger.h:1264:9
    MemoryTracker::logPeakMemoryUsage() const
    /build/obj-x86_64-linux-gnu/../src/Common/MemoryTracker.cpp:59:5

    MemoryTracker::~MemoryTracker()
    /build/obj-x86_64-linux-gnu/../src/Common/MemoryTracker.cpp:46:13

    DB::ThreadGroupStatus::~ThreadGroupStatus()
    /build/obj-x86_64-linux-gnu/../src/Common/ThreadStatus.h:51:7
    std::__1::__shared_ptr_emplace<DB::ThreadGroupStatus, std::__1::allocator<DB::ThreadGroupStatus> >::__on_zero_shared()
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3602:23

    std::__1::__shared_count::__release_shared()
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3440:9
    std::__1::__shared_weak_count::__release_shared()
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3482:27
    std::__1::shared_ptr<DB::ThreadGroupStatus>::~shared_ptr()
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:4207:19
    DB::PipelineExecutor::executeImpl(unsigned long)::$_4::~$_4()
    /build/obj-x86_64-linux-gnu/../src/Processors/Executors/PipelineExecutor.cpp:720:34
    ThreadFromGlobalPool::ThreadFromGlobalPool<DB::PipelineExecutor::executeImpl(unsigned long)::$_4>(DB::PipelineExecutor::executeImpl(unsigned long)::$_4&&)::'lambda'()::~()
    /build/obj-x86_64-linux-gnu/../src/Common/ThreadPool.h:161:54
    std::__1::__compressed_pair_elem<ThreadFromGlobalPool::ThreadFromGlobalPool<DB::PipelineExecutor::executeImpl(unsigned long)::$_4>(DB::PipelineExecutor::executeImpl(unsigned long)::$_4&&)::'lambda'(), 0, false>::~__compressed_pair_elem()
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2188:8
    std::__1::__function::__alloc_func<ThreadFromGlobalPool::ThreadFromGlobalPool<DB::PipelineExecutor::executeImpl(unsigned long)::$_4>(DB::PipelineExecutor::executeImpl(unsigned long)::$_4&&)::'lambda'(), std::__1::allocator<ThreadFromGlobalPool::ThreadFromGlobalPool<DB::Pip>
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/functional:1559:38
    std::__1::__function::__func<ThreadFromGlobalPool::ThreadFromGlobalPool<DB::PipelineExecutor::executeImpl(unsigned long)::$_4>(DB::PipelineExecutor::executeImpl(unsigned long)::$_4&&)::'lambda'(), std::__1::allocator<ThreadFromGlobalPool::ThreadFromGlobalPool<DB::PipelineE>
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/functional:1706:10

    std::__1::__function::__value_func<void ()>::~__value_func()
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/functional:1828:19
    std::__1::function<void ()>::~function()
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/functional:2460:43
    ThreadPoolImpl<std::__1::thread>::worker(std::__1::__list_iterator<std::__1::thread, void*>)
    /build/obj-x86_64-linux-gnu/../src/Common/ThreadPool.cpp:268:5

    void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, int, std::__1::optional<unsigned long>)::'lambda1'()::operator()() const
    /build/obj-x86_64-linux-gnu/../src/Common/ThreadPool.cpp:116:73
    decltype(std::__1::forward<void>(fp)(std::__1::forward<void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, int, std::__1::optional<unsigned long>)::'lambda1'()>(fp0)...)) std::__1::__invoke<void ThreadPoolImpl<std::__1::thread>::scheduleI>
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/type_traits:3519:1
    void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, int, std::__1::optional<unsigned long>)::'lambda1'(>
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/thread:273:5
    void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, int, std::__1::optional<unsigned lon>
    /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/thread:284:5

    __tsan_thread_start_func
    ??:0:0
```

```
- 2020-09-20 17:44:43   Mutex M1432 (0x0000181213a8) created at:
    pthread_mutex_init
    ??:0:0

    Poco::MutexImpl::MutexImpl()
    /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Mutex_POSIX.cpp:64:6

    Poco::Mutex::Mutex()
    /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Mutex.cpp:34:8

    __cxx_global_var_init
    /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Logger.cpp:28:15
    _GLOBAL__sub_I_Logger.cpp
    /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Logger.cpp:0:0

    __libc_csu_init
    ??:0:0
```

</details>
2020-09-20 23:46:28 +03:00
Denis Glazachev
442b1407cf Merge branch 'master' into ldap-any-user-authentication
* master: (375 commits)
  Update type-conversion-functions.md
  Update maxmap.md
  Update maxmap.md
  Update maxmap.md
  Update single_fixed_string_groupby.xml
  Alter remove column properties and TTLs (#14742)
  better fixed string group by support
  Fix incorrect key condition of fixed strings.
  constant output order
  more tests for  #14646
  Maybe fix MSan report in base64
  Proper exception message for wrong number of arguments of CAST
  Added a test
  Fix buffer overflow in "bar" function
  Update convertMySQLDataType.cpp
  Fix clang-tidy
  Remove obsolete code from performance test
  Slightly better code
  Even more
  Even more
  ...

# Conflicts:
#	src/Interpreters/Context.cpp
2020-09-21 00:31:04 +04:00
alexey-milovidov
ffe4f4b366
Update ForkProcessor.cpp 2020-09-20 22:59:26 +03:00
Mark Papadakis
25a1f82631
Update ForkProcessor.cpp
Got rid of an unnecessary local
2020-09-20 20:26:44 +03:00
alexey-milovidov
8630d1baf4
Merge pull request #15033 from amosbird/fixstringkey
Fix incorrect key condition of fixed strings.
2020-09-20 19:51:24 +03:00
alexey-milovidov
85483f8532
Merge pull request #14853 from ClickHouse/akz/optimized_index_binary_search
Optimized marks selection algorithm for continuous marks ranges
2020-09-20 19:48:45 +03:00
alexey-milovidov
f7cae4a57d
Merge pull request #14975 from ClickHouse/fix_merge_tree_settings_check
Fix check for merge tree settings sanity on server startup
2020-09-20 19:43:40 +03:00
alexey-milovidov
55eb533fda
Merge pull request #15034 from amosbird/fff
Improve performance of grouping by single LowCardinality(FixedString)
2020-09-20 19:42:38 +03:00
alexey-milovidov
7b35a6a59a
Merge pull request #15028 from ClickHouse/fix-bar
Fix buffer overflow in "bar" function
2020-09-20 19:04:15 +03:00
alexey-milovidov
3f5d7843f6
Merge pull request #15029 from ClickHouse/cast-single-argument
Proper exception message for wrong number of arguments of CAST
2020-09-20 19:03:47 +03:00
alexey-milovidov
068e9f372e
Merge pull request #15030 from ClickHouse/base64-unpoison
Maybe fix MSan report in base64
2020-09-20 19:03:28 +03:00
Vitaly Baranov
46ab2f76cd
Merge pull request #14919 from vitlibar/add-login-function-to-access-storage
Add login() function to IAccessStorage
2020-09-20 16:58:22 +03:00
alesapin
5ffee8808a
Alter remove column properties and TTLs (#14742) 2020-09-20 16:27:33 +03:00
philip.han
3122455b4d BloomFilter is used just in specific cases of indexof() 2020-09-20 19:04:33 +09:00
Amos Bird
8ca4d6634e
better fixed string group by support 2020-09-20 15:20:09 +08:00
Amos Bird
fcee786320
Fix incorrect key condition of fixed strings. 2020-09-20 11:53:29 +08:00
alexey-milovidov
1474b80ecc
Merge pull request #15008 from ClickHouse/clang-tidy-11-without-enabling
Fix terribly wrong code
2020-09-20 02:00:54 +03:00
Alexey Milovidov
0029c5512d Maybe fix MSan report in base64 2020-09-19 22:43:26 +03:00
Alexey Milovidov
5a47e64685 Proper exception message for wrong number of arguments of CAST 2020-09-19 22:34:24 +03:00
Alexey Milovidov
dae3b40a55 Fix buffer overflow in "bar" function 2020-09-19 22:15:16 +03:00
alexey-milovidov
c185db46f9
Merge pull request #15023 from ClickHouse/remove-opencl
Remove OpenCL
2020-09-19 21:31:40 +03:00
myrrc
146dd0f3f0 fixed comments parser 2020-09-19 20:14:37 +03:00
myrrc
c78d9f9f38 moved the generators to docs/ folder 2020-09-19 19:42:36 +03:00
alexey-milovidov
cd7354117c
Update StorageJoin.cpp 2020-09-19 19:38:36 +03:00
alexey-milovidov
7ae4d01744
Update convertMySQLDataType.cpp 2020-09-19 19:31:08 +03:00
Alexey Milovidov
9fa49a6843 Fix clang-tidy 2020-09-19 19:29:15 +03:00
Alexey Milovidov
c7a98132ac Slightly better code 2020-09-19 18:13:51 +03:00
Alexey Milovidov
b87ecc2ec1 Even more 2020-09-19 18:09:12 +03:00
Alexey Milovidov
c304032707 Even more 2020-09-19 18:02:11 +03:00
Alexey Milovidov
772eccf03d Move code to .cpp 2020-09-19 17:55:08 +03:00
Alexey Milovidov
059646743b Remove OpenCL 2020-09-19 17:20:00 +03:00
Alexander Tokmakov
46aa307d0a fix EINVAL in renameat2 on MacOS 2020-09-19 17:19:06 +03:00
alexey-milovidov
2cab30ba8d
Merge pull request #14521 from hexiaoting/dev_like
Add new feature: SHOW DATABASES like 'xxx'
2020-09-19 16:34:37 +03:00
alexey-milovidov
acbdc51460
Merge pull request #14771 from amosbird/withsub
First attempt of supporting CTE
2020-09-19 16:25:34 +03:00
Vitaly Baranov
33efb36714 Use previous users.xml if failed to reload. 2020-09-19 16:21:12 +03:00
Alexander Tokmakov
de540c6955 minor fixes 2020-09-19 15:59:37 +03:00
Alexey Milovidov
76147cc0c1 Generate ya.make 2020-09-19 15:52:17 +03:00
Alexey Milovidov
3003ebabc2 Merge branch 'master' into Vxider-disable_set_and_join_persistency 2020-09-19 15:51:40 +03:00
alexey-milovidov
eb9ee723c3
Merge pull request #11913 from ClickHouse/compact-parts-by-default
Enable compact parts by default for small parts
2020-09-19 15:31:15 +03:00
Alexey Milovidov
2264622f69 Fix clang-tidy 2020-09-19 15:24:43 +03:00
tavplubix
6e0bdaf46d
Merge pull request #14535 from zhang2014/fix/datetime
ISSUES-4006 support decimal data type for MaterializedMySQL
2020-09-19 14:05:32 +03:00
Alexey Milovidov
4d06bc62b1 Allow concurrent reads while writing to TinyLog 2020-09-19 14:02:11 +03:00
Alexey Milovidov
111acdc63b Continuation 2020-09-19 14:02:11 +03:00
Alexey Milovidov
bc8fc3e280 Simplification 2020-09-19 14:02:11 +03:00
Alexey Milovidov
66ea3c0c43 Remove useless method 2020-09-19 14:02:11 +03:00
Alexey Milovidov
8193da847b Simplification 2020-09-19 14:02:11 +03:00
Alexey Milovidov
3bb0088c86 Whitespace 2020-09-19 14:02:11 +03:00
Alexey Milovidov
dc7e3b75d3 Whitespace 2020-09-19 14:02:11 +03:00
Alexey Milovidov
8a8284ce31 Avoid deadlocks in Log/TinyLog 2020-09-19 14:02:11 +03:00
alexey-milovidov
65517da62b
Merge pull request #14495 from nikitamikhaylov/update-permutation-bugfix-3
updatePermumation with Nullable
2020-09-19 13:53:55 +03:00
alexey-milovidov
c461d782e4
Merge pull request #14929 from ClickHouse/mlock-code-segment
Only mlock code segment
2020-09-19 13:46:49 +03:00
alexey-milovidov
0d26228599
Merge pull request #15002 from 4ertus2/bugs
Fix crash in RIGHT or FULL JOIN switch
2020-09-19 13:45:10 +03:00
alexey-milovidov
1fcebce926
Merge pull request #15000 from Jokser/disable-ttl-move-on-insert
Option to disable TTL move on data part insert
2020-09-19 13:45:02 +03:00
alexey-milovidov
3463d97f8c
Merge pull request #14973 from amosbird/bm2
Ignore key constraints when doing mutations.
2020-09-19 13:44:30 +03:00
alexey-milovidov
20a294e392
Merge pull request #14959 from ClickHouse/storages-small-improvements
Small improvements for IStorage::rename
2020-09-19 13:44:08 +03:00
Alexey Milovidov
eb260f6a89 Fix bad code 2020-09-19 13:43:26 +03:00
Alexey Milovidov
1238822785 Fix clang-tidy 2020-09-19 13:37:40 +03:00
Alexey Milovidov
ef5363b87f Fix terribly wrong code 2020-09-19 02:05:13 +03:00
alexey-milovidov
4e77c2e48e
Update MergeTreeDataMergerMutator.cpp 2020-09-19 01:29:31 +03:00
Vitaly Baranov
02acedd6a3 Use initial_address for quota calculation when the interserver-secret mode enabled. 2020-09-19 01:04:25 +03:00
Vitaly Baranov
dbc837c148 IAccessStorage now can override the login() function. 2020-09-19 01:04:20 +03:00
Alexey Milovidov
7d0f3db639 Fix annoying "Arcadia" 2020-09-18 23:19:41 +03:00
Alexey Milovidov
24b334258b Resolve review comment 2020-09-18 22:25:56 +03:00
alexey-milovidov
988b20a32c
Merge pull request #14684 from azat/parallel-distributed_ddl
Allow parallel execution of distributed DDL
2020-09-18 22:18:17 +03:00
Alexey Milovidov
e1ffa07a39 Resolve review comments 2020-09-18 22:08:53 +03:00
Alexey Milovidov
21ca9fce63 Merge branch 'master' into storages-small-improvements 2020-09-18 22:03:19 +03:00
Alexey Milovidov
8a8e4f8a41 Attempt to speed-up clang build 2020-09-18 21:58:57 +03:00
alexey-milovidov
456c970929
Merge pull request #14808 from ClickHouse/remove-header
Remove one header
2020-09-18 21:57:00 +03:00
Alexey Milovidov
6e6909f47d Fix "Arcadia" 2020-09-18 21:54:54 +03:00
alexey-milovidov
322e63971d
Update MergeTreeIndexConditionBloomFilter.cpp 2020-09-18 21:47:32 +03:00
Amos Bird
d842cb704f
Allow mutations to work with key constraints. 2020-09-19 02:40:02 +08:00
Alexander Tokmakov
1ca9a92b21 Merge branch 'master' into write_structure_of_table_functions 2020-09-18 21:09:23 +03:00
myrrc
800ad407e8 fix 2020-09-18 20:49:59 +03:00
Pavel Kovalenko
da04a130ed Add option to disable ttl move on data part insert - minor fixes. 2020-09-18 20:45:30 +03:00
tavplubix
1762535ffc
Merge pull request #14797 from Vxider/add_tablefunction_null
Add table function null
2020-09-18 20:34:35 +03:00
Artem Zuikov
28afbafa08 fix crash in RIGHT or FULL JOIN switch 2020-09-18 19:25:20 +03:00
Pavel Kovalenko
6b4b5898a7 Renaming. 2020-09-18 18:41:14 +03:00
Pavel Kovalenko
0da19ab46d Add option to disable ttl move on data part insert 2020-09-18 18:30:00 +03:00
nikitamikhaylov
2530b71aa6 style 2020-09-18 17:48:05 +03:00
Alexey Milovidov
72c2201287 Fix "Arcadia" 2020-09-18 17:39:33 +03:00
Alexey Milovidov
122e34cf19 Fix "Arcadia" 2020-09-18 17:38:28 +03:00
nikitamikhaylov
822a78fa58 call under mutex 2020-09-18 17:25:45 +03:00
myrrc
f6bce8bd1e reverted USE to ENABLE 2020-09-18 17:18:59 +03:00
Nikolai Kochetov
b26f11c00c Support StorageDistributed::read for QueryPlan. 2020-09-18 17:16:53 +03:00
alesapin
e38b537017
Merge pull request #11684 from ClickHouse/manual-write-duplicate-parts-to-replicas
Don't ignore duplicate parts written to replicas
2020-09-18 16:50:00 +03:00
myrrc
3953ed485b added sub-tables in report, replaced some USE_ -> ENABLE_ for
consistency
2020-09-18 16:09:22 +03:00
Alexander Kazakov
1ee2e3d2b3 Review fix 2020-09-18 16:03:48 +03:00
Vxider
c9249f77c7 rename persistency to persistent 2020-09-18 20:58:27 +08:00
Vxider
0c535062fc rename disable_persistency to persistency 2020-09-18 20:48:55 +08:00
Nikolai Kochetov
2ffc2b6927 Refactor IStorage::read with query plan. 2020-09-18 15:10:59 +03:00
tavplubix
1f54fdfb7c
Update TableFunctionNull.cpp 2020-09-18 14:52:30 +03:00
Nikolai Kochetov
50674a320f Refactor IStorage::read with query plan. 2020-09-18 14:39:07 +03:00
alesapin
e96a3ac5f3 DataType in enumerate streams 2020-09-18 14:37:58 +03:00
Vitaly Baranov
f43714cd76
Merge pull request #14880 from vitlibar/fix-removing-live-view-after-watching
Fix removing a live view after watching and after timeout has passed.
2020-09-18 14:17:44 +03:00
Nikolai Kochetov
2491f0e1c5 Merge branch 'master' into storage-read-query-plan 2020-09-18 14:07:03 +03:00
Alexander Tokmakov
e1cf60990a minor fixes 2020-09-18 14:06:30 +03:00
Nikolai Kochetov
c7aff19937
Merge pull request #14221 from hagen1778/settings-leaf-limits
[settings]: introduce new query complexity settings for leaf-nodes
2020-09-18 14:05:10 +03:00
Alexander Kuzmenkov
a9b2bff8ba Merge remote-tracking branch 'origin/master' into HEAD 2020-09-18 13:43:29 +03:00
Alexander Kuzmenkov
173c8eab9f
Merge pull request #14924 from ClickHouse/aku/logical-core
Use logical core id ('processor') for CPU freq metric
2020-09-18 13:17:49 +03:00
philip.han
cbedd44a60 Fix indexOf() to use BloomFilter 2020-09-18 17:43:07 +09:00
alesapin
96a693baec Better message 2020-09-18 10:46:23 +03:00
alesapin
e6914acb3b Fix check for merge tree settings on server startup 2020-09-18 10:44:17 +03:00
alesapin
3536ac1b17
Merge pull request #14926 from ClickHouse/better-drop-replicated-table
Better drop for Replicated tables
2020-09-18 09:51:39 +03:00
Alexey Milovidov
0ad44b821e Fix build 2020-09-18 01:45:12 +03:00
Alexey Milovidov
fe7a84745f Merge branch 'master' into mlock-code-segment 2020-09-18 01:29:27 +03:00
Alexey Milovidov
1752bbc1ed Fix "Arcadia" build 2020-09-18 01:29:15 +03:00
alexey-milovidov
76a3cc2dae
Merge pull request #14937 from filimonov/finalizeAggregation_statefullness
Fix enable_optimize_predicate_expression for finalizeAggregation
2020-09-18 01:24:02 +03:00
Alexey Milovidov
9df338f37b Merge branch 'master' into remove-header 2020-09-18 01:18:53 +03:00
roman
ddca262fe6 fix review comments 2020-09-17 20:54:21 +01:00
Alexey Milovidov
7fb4dfea2c Small improvements for IStorage::rename 2020-09-17 22:50:43 +03:00
alesapin
447205c525 More comments 2020-09-17 22:30:45 +03:00
alesapin
dc677b93fb Comments and fix test 2020-09-17 22:30:17 +03:00
tavplubix
0597ad3150
fix typo 2020-09-17 21:47:21 +03:00
Alexey Milovidov
799a675b5d Merge branch 'master' into AES_encrypt_decrypt 2020-09-17 21:42:51 +03:00
alexey-milovidov
7152fec241
Update JoinSettings.cpp 2020-09-17 21:24:14 +03:00
Alexey Milovidov
a783fe110f Fix build 2020-09-17 21:15:19 +03:00
Alexey Milovidov
eb523f1a7c Merge branch 'master' into mlock-code-segment 2020-09-17 21:15:09 +03:00
Azat Khuzhin
c9baceb760 Change thread name for DDLWorker executor threads 2020-09-17 21:07:14 +03:00
Alexey Milovidov
20d07ed405 Update comment 2020-09-17 21:04:11 +03:00
alexey-milovidov
9b6c62e82b
Merge pull request #14867 from amosbird/lbo
Explicit define what first replica is.
2020-09-17 19:37:15 +03:00
zhang2014
64032e22a2 Merge branch 'master' into fix/datetime 2020-09-18 00:28:09 +08:00
tavplubix
a76d8fb96b
Merge pull request #14898 from zhang2014/fix/ISSUES-14894
ISSUES-14894 fix MaterializeMySQL temp metadata file exists
2020-09-17 19:18:10 +03:00
tavplubix
5a890d7377
Merge pull request #14852 from zhang2014/fix/mysql_protocol_parser
Fix parse MySQL binlog event for MaterializeMySQL
2020-09-17 19:17:30 +03:00
myrrc
7cd5c0d34f Merge remote-tracking branch 'upstream/master' into feature/cmake-flags-doc-generator 2020-09-17 19:17:09 +03:00
alesapin
b07c00ef7c Ugly, but probably working implementation 2020-09-17 18:33:50 +03:00
Alexander Kuzmenkov
fd33fa7f39 fixup 2020-09-17 17:55:41 +03:00
Vxider
3da806f8f6 Throws LOGICAL_ERROR if argument is not a literal 2020-09-17 22:49:27 +08:00
alexey-milovidov
84eece69ba
Merge pull request #14876 from amosbird/ns
Get rid of query settings after initialization.
2020-09-17 17:49:25 +03:00
Alexey Milovidov
c1e9ce2cf2 Remove questionable code 2020-09-17 17:38:06 +03:00
Alexander Kuzmenkov
fb64cf210a straighten the protocol version 2020-09-17 17:37:29 +03:00
Vitaly Baranov
3356d75b23
Merge pull request #13156 from azat/cluster-secure
Secure inter-cluster query execution (with initial_user as current query user) [v3]
2020-09-17 17:11:00 +03:00
alexey-milovidov
496df5b3e9
Merge pull request #14678 from sundy-li/patch-2
dynamic zookeeper config when session expired
2020-09-17 17:05:22 +03:00
alesapin
d09fd8ca8b Add comment 2020-09-17 17:01:17 +03:00
Mikhail Filimonov
22bd22702e
Fix enable_optimize_predicate_expression for finalizeAggregation
finalizeAggregation was wrongly marked as stateful, preventing pushing the conditions down.
2020-09-17 15:59:14 +02:00
Nikolai Kochetov
e013acb6b6 Fix build. 2020-09-17 16:26:34 +03:00
Nikolai Kochetov
0bf4e8e6e9 Support reading with QueryPlan for StorageView. 2020-09-17 16:22:24 +03:00
alexey-milovidov
2413caa7d5
Merge pull request #14889 from ClickHouse/extract-all-groups-empty-match
Fix error in "extractAllGroups" function
2020-09-17 16:02:30 +03:00
Alexey Milovidov
068e8576b7 Corrections 2020-09-17 15:53:52 +03:00
Nikolai Kochetov
c2906e3871
Merge pull request #14918 from ClickHouse/revert-14362
Revert #14362
2020-09-17 15:41:08 +03:00
Alexey Milovidov
8bce20076c Only mlock code segment 2020-09-17 15:39:37 +03:00
Alexander Kuzmenkov
a374541214 straighten the protocol version 2020-09-17 15:15:05 +03:00
Alexander Kuzmenkov
7b8ad02a12 cleanup 2020-09-17 15:14:49 +03:00
Nikolai Kochetov
193b572a05 Add MaterializingStep. 2020-09-17 15:11:23 +03:00
alesapin
6601f4f786 Better errors, fix merge 2020-09-17 15:10:06 +03:00
Nikolai Kochetov
959d755a1b
Update Visitor.h 2020-09-17 15:08:55 +03:00
alesapin
6c369c8dc6 Fix merge error 2020-09-17 15:01:03 +03:00
Alexey Milovidov
a5560cd62d Better drop replicated tables 2020-09-17 14:27:17 +03:00
Alexander Kuzmenkov
4773bf57ea Use logical core id ('processor') for CPU freq metric
See https://github.com/ClickHouse/ClickHouse/issues/14923
2020-09-17 13:47:29 +03:00
alesapin
40b2f203b6 Merge branch 'master' into manual-write-duplicate-parts-to-replicas 2020-09-17 13:21:00 +03:00
Nikolai Kochetov
bd92284b4e Push ci. 2020-09-17 13:18:01 +03:00
Nikolai Kochetov
21bd45fb22
Update InterpreterSelectQuery.cpp 2020-09-17 12:57:48 +03:00
roman
b41421cb1c [settings]: introduce new query complexity settings for leaf-nodes
The new setting should allow to control query complexity on leaf nodes
excluding the final merging stage on the root-node. For example, distributed
query that reads 1k rows from 5 shards will breach the `max_rows_to_read=5000`,
while effectively every shard reads only 1k rows. With setting `max_rows_to_read_leaf=1500`
this limit won't be reached and query will succeed since every shard reads
not more that ~1k rows.
2020-09-17 10:37:05 +01:00
Alexander Kuzmenkov
6217dd77b5 Merge remote-tracking branch 'origin/master' into tmp 2020-09-17 12:35:10 +03:00
Nikolai Kochetov
35e8ee5f85 Rollback inlining. 2020-09-17 12:20:23 +03:00
Nikolai Kochetov
6d3e6dadfa Update has. 2020-09-17 11:18:00 +03:00
Nikolai Kochetov
225b85624e Merge branch 'master' into inline-gather-utils 2020-09-17 11:17:32 +03:00
alesapin
f104c382f8
Merge pull request #14887 from azat/StorageFile-write-to-fd
Fix SIGSEGV for an attempt to INSERT into StorageFile(fd)
2020-09-17 10:25:02 +03:00
alesapin
5f9e7ed169
Merge pull request #14834 from ClickHouse/fix_compression_codec_perf
Fix performance degradation during parts selection for merge
2020-09-17 10:09:41 +03:00
alesapin
73544a3781
Merge pull request #14845 from ClickHouse/fix_alias_array
Fix recursive column defaults
2020-09-17 10:02:39 +03:00
zhang2014
c5b56c24f8 ISSUES-14894 fix MaterializeMySQL temp metadata file exists 2020-09-17 14:44:05 +08:00
zhang2014
0c81a8777e Fix review comment 2020-09-17 14:21:38 +08:00
Nikolai Kochetov
7384733144 Fix style. 2020-09-17 09:01:35 +03:00
Nikolai Kochetov
a67986791f
Merge pull request #14848 from ClickHouse/test-gather-utils-build-time
Improve GatherUtils build time
2020-09-17 08:58:00 +03:00
sundy-li
544b2cb20d add configChanged method for zookeeper
fix logic error && skip reload testkeeper
2020-09-17 13:33:45 +08:00
sundyli
9c2a8ea6d0 dynamic zookeeper config 2020-09-17 13:26:36 +08:00
Azat Khuzhin
138e953429 Fix SIGSEGV for an attempt to INSERT into StorageFile(fd) 2020-09-17 01:26:34 +03:00
alexey-milovidov
200bc9b9b2
Update FunctionsAES.h 2020-09-17 00:57:26 +03:00
alexey-milovidov
60f91332b3
Update FunctionsAES.h 2020-09-17 00:52:01 +03:00
alexey-milovidov
d97426fe9a
Update FunctionsAES.cpp 2020-09-17 00:47:43 +03:00
alexey-milovidov
a93c579798
Update ColumnString.cpp 2020-09-17 00:36:57 +03:00
Alexey Milovidov
c37b55c3b1 Fix error in "extractAllGroups" function 2020-09-17 00:19:58 +03:00
Anton Popov
8e9828d2ff Merge remote-tracking branch 'upstream/master' into HEAD 2020-09-16 21:07:35 +03:00
Nikolai Kochetov
9fc594a4c5 Fix tests. 2020-09-16 20:32:56 +03:00
Alexey Milovidov
26eb49b48d Fix typo 2020-09-16 20:02:55 +03:00
Nikolai Kochetov
fe1056579f Fix tests. 2020-09-16 19:45:56 +03:00
Nikolai Kochetov
73ad505735 Fix tests. 2020-09-16 19:38:33 +03:00
Nikolai Kochetov
2f7ab2bca4 Fix tests. 2020-09-16 19:30:48 +03:00
Nikolai Kochetov
8a26251f94 Fix tests. 2020-09-16 19:11:16 +03:00
Nikolai Kochetov
8fed50b1db Fix GenericSource 2020-09-16 18:03:47 +03:00
Nikolai Kochetov
42c543a64d Fix GenericSource 2020-09-16 17:58:54 +03:00
Nikolai Kochetov
8de76709fb Fix tests. 2020-09-16 17:41:01 +03:00
Amos Bird
96a202c0fb
Get rid of query settings after initialization. 2020-09-16 22:35:39 +08:00
Nikolai Kochetov
17ec88da84 Split has. 2020-09-16 17:02:28 +03:00
Nikolai Kochetov
9a6b4b3355 Split has. 2020-09-16 16:49:09 +03:00
Nikolai Kochetov
ec6390231a Split has. 2020-09-16 16:43:36 +03:00
Nikolai Kochetov
0eff356c38 Split has. 2020-09-16 16:37:16 +03:00
Nikolai Kochetov
bc1031be9b Split has. 2020-09-16 16:33:28 +03:00
alesapin
cbe85327e2 Check stack size 2020-09-16 16:24:07 +03:00
Nikolai Kochetov
715b1a41ed Update arrayConcat 2020-09-16 16:14:46 +03:00
Nikolai Kochetov
2a2e369c6e Update arrayConcat 2020-09-16 16:11:42 +03:00
Nikolai Kochetov
d362ced0b5 Update arrayConcat 2020-09-16 16:09:32 +03:00
Nikolai Kochetov
e94b814606 Update arrayConcat 2020-09-16 16:07:32 +03:00
Vitaly Baranov
d99a011d07 Fix removing a live view after watching and after timeout has passed. 2020-09-16 15:53:58 +03:00
Amos Bird
3e576a29c9
explict column list in columns matcher (#14775) 2020-09-16 15:44:05 +03:00
tavplubix
28a6b7e622
Merge pull request #14831 from bharatnc/ncb/fix-timespec-construct
construct query_start_time & query_start_time_microseconds from the same timespec
2020-09-16 15:42:19 +03:00
Nikolai Kochetov
bbb89d10de Fix build. 2020-09-16 15:40:18 +03:00
Nikolai Kochetov
d36e84cde9 Fix build. 2020-09-16 15:36:54 +03:00
nikitamikhaylov
b33a5e0d14 done 2020-09-16 15:32:33 +03:00
Nikolai Kochetov
e9de8c8875 Fix build. 2020-09-16 15:21:26 +03:00
Nikolai Kochetov
b31ce6a536 Fix build. 2020-09-16 15:19:00 +03:00
Nikolai Kochetov
589fd67146 Fix build. 2020-09-16 15:15:14 +03:00
Nikolai Kochetov
4079a7f319 Fix build. 2020-09-16 15:13:34 +03:00
Nikolai Kochetov
dcb52c1d1d Fix build. 2020-09-16 15:05:24 +03:00
Nikolai Kochetov
5acf73d873 Fix build. 2020-09-16 15:00:34 +03:00
Nikolai Kochetov
675b2c44af Fix build. 2020-09-16 14:56:37 +03:00
Nikolai Kochetov
8bc45c9d42 Fix build. 2020-09-16 14:49:59 +03:00
Nikolai Kochetov
0800ceab5a Fix build. 2020-09-16 14:39:42 +03:00
Nikolai Kochetov
9a92e5eabb Fix build. 2020-09-16 14:33:29 +03:00
Nikolai Kochetov
22e3d471b6 Fix build. 2020-09-16 14:29:43 +03:00
Nikolai Kochetov
6c6e0a88c6 Fix build. 2020-09-16 14:22:08 +03:00
Nikolai Kochetov
b6756472d7 Merge branch 'master' into test-gather-utils-build-time 2020-09-16 14:11:27 +03:00
Nikolai Kochetov
85698e04fa Update slice for arrays. 2020-09-16 13:57:23 +03:00
Nikolai Kochetov
8be45dd3cc Update QueryPipeline::addDelayingPipeline 2020-09-16 13:25:01 +03:00
Nikolai Kochetov
9e00fb44b5 Update creating sink. 2020-09-16 13:18:28 +03:00
Alexander Kuzmenkov
da2a3fffe8 fixup 2020-09-16 13:00:15 +03:00
Amos Bird
38d53c38f6
Explicit define what first replica is. 2020-09-16 17:54:41 +08:00
alesapin
18398c1510 Fix style 2020-09-16 12:08:39 +03:00
Alexander Kuzmenkov
bcea99f2e5
Update ThreadPool.cpp 2020-09-16 11:59:58 +03:00
Nikolai Kochetov
a8e671f015 Fix MutationsInterpreter. 2020-09-16 11:58:27 +03:00
alesapin
78cb39ff92
Update ICompressionCodec.h 2020-09-16 11:21:39 +03:00
alesapin
af8ed46261
Update CompressionCodecGorilla.cpp 2020-09-16 11:20:39 +03:00
alesapin
cf45eb1545
Update CompressionCodecDoubleDelta.cpp 2020-09-16 11:20:22 +03:00
alesapin
e3299d9249
Update CompressionCodecMultiple.cpp 2020-09-16 11:19:59 +03:00
alesapin
da386990fe
Update ICompressionCodec.cpp 2020-09-16 11:18:42 +03:00
alesapin
97baa67f2b
Merge pull request #14839 from Jokser/distributed-storage-multiple-volumes
Don't throw exception if Distributed storage has multi-volume storage policy configuration
2020-09-16 10:13:14 +03:00
zhang2014
9246e77b05 Remove CHECKSUM_CRC32_SIGNATURE_LENGTH in mysql event parser 2020-09-16 15:05:44 +08:00
alesapin
74c0b6eb76
Update CompressionCodecGorilla.cpp 2020-09-16 10:00:41 +03:00
zhang2014
172bc46c63 Fix format and dryrun event parse failure 2020-09-16 14:52:59 +08:00
zhang2014
85e990f518 Fix code style 2020-09-16 11:30:14 +08:00
zhang2014
9100dcd37a fix build and test failure 2020-09-16 11:13:17 +08:00
Azat Khuzhin
a35c1f8ed0 Do not check client's host when user comes from interserver secret 2020-09-16 00:35:49 +03:00
myrrc
29ac26f0f2 separated ch parts table 2020-09-16 00:12:37 +03:00
Nikolai Kochetov
13edfeea1f Fix build. 2020-09-15 20:23:49 +03:00
Nikolai Kochetov
3cc89d467c Merge branch 'master' into query-plan-for-creating-sets 2020-09-15 20:15:41 +03:00
Nikolai Kochetov
118a8a513e Update mutations interpreter. 2020-09-15 20:13:13 +03:00
Alexander Kuzmenkov
5afb19faf1
Update ThreadPool.cpp 2020-09-15 19:58:09 +03:00
bharatnc
dc765b77e7 Use std::chrono instead of clock_gettime 2020-09-15 09:37:32 -07:00
Nikolai Kochetov
e29f27e333
Merge pull request #14815 from ClickHouse/storage-read-query-plan
Return query plan from storage.
2020-09-15 18:34:11 +03:00
zhang2014
0c06ccc35e Fix parse error packet on event 2020-09-15 23:26:13 +08:00
Vitaly Baranov
74d5b43fe6
Merge pull request #14828 from vitlibar/change-columns-of-system-user-directories
Add 'params' column to system.user_directories table.
2020-09-15 18:25:50 +03:00
Alexander Kuzmenkov
a792850ecd
Update ThreadPool.cpp 2020-09-15 18:05:42 +03:00
zhang2014
30352f096d Init buffer in constructor 2020-09-15 22:59:21 +08:00
zhang2014
9c329996ff Revert param name in header file 2020-09-15 22:56:57 +08:00
Alexander Kazakov
7465e00163 Optimized marks selection algorithm for continuous marks ranges 2020-09-15 17:22:32 +03:00
zhang2014
fb92c56beb Fix bad and nice buffer size 2020-09-15 22:22:23 +08:00
zhang2014
84c68947b9 Add test for MySQLBinlogReadBuffer 2020-09-15 22:07:03 +08:00
Nikolai Kochetov
69b02c7500 Remove space. 2020-09-15 16:35:04 +03:00
alesapin
e20c54998c Better exception on non physical columns 2020-09-15 16:29:11 +03:00
Nikolai Kochetov
4c783f19ee Use QueryPlan for SubqueryForSet. 2020-09-15 16:25:14 +03:00
alexey-milovidov
88ac9bef1b
Delete gtest_openssl.cpp 2020-09-15 15:45:52 +03:00
Anton Popov
3e855daefd Merge remote-tracking branch 'upstream/master' into HEAD 2020-09-15 15:31:29 +03:00
Alexander Kuzmenkov
b1741dd87e Merge remote-tracking branch 'origin/master' into HEAD 2020-09-15 15:30:26 +03:00
zhang2014
c517df0b1a Merge branch 'master' into fix/mysql_protocol_parser 2020-09-15 20:29:27 +08:00
zhang2014
106e05ab2f Try fix mysql protocol parse failure 2020-09-15 20:28:42 +08:00
alexey-milovidov
018f596d21
Merge pull request #14685 from ClickHouse/remap-executable
Attempt to make performance test more reliable
2020-09-15 15:09:47 +03:00
alesapin
8828a78174 Fix alias on default columns 2020-09-15 14:17:58 +03:00
Vxider
e136eba3f8 fix style check 2020-09-15 18:58:16 +08:00
Alexander Kuzmenkov
3399028de2 Merge remote-tracking branch 'origin/master' into HEAD 2020-09-15 13:55:12 +03:00
Nikolai Kochetov
6eac433c55 Review fixes. 2020-09-15 13:40:39 +03:00
Artem Zuikov
1ba67ea8a1
Improve DecimalBinaryOperation specializations (#14743) 2020-09-15 13:31:15 +03:00
Alexander Kuzmenkov
d943bac1a4 Exception on double init of global thread pool 2020-09-15 13:30:16 +03:00
hexiaoting
023daddbea Fix bug for LineAsString Format 2020-09-15 18:13:39 +08:00
Nikolai Kochetov
dd4d5bc931 Fix build 2020-09-15 13:10:41 +03:00
Artem Zuikov
51ba12c2c3
Try speedup build (#14809) 2020-09-15 12:55:57 +03:00
Nikolai Kochetov
c1f61984e5
Merge pull request #14513 from amosbird/mf1
Binary operator monotonicity
2020-09-15 12:45:23 +03:00
Pavel Kovalenko
01ab28a182 Don't throw exception if Distributed storage has multi-volume storage policy configuration. 2020-09-15 12:26:56 +03:00
Nikolai Kochetov
8c2aa7ce8c Added comment. 2020-09-15 12:22:45 +03:00
Vxider
1c82d2eb23 use table-level setting 2020-09-15 17:16:10 +08:00
tavplubix
1d8ee50769
Merge pull request #14628 from ClickHouse/enable_some_tests_with_database_atomic
Enable more tests with Atomic database
2020-09-15 12:13:40 +03:00
Nikolai Kochetov
fe9c451966 Fix build. 2020-09-15 10:20:34 +03:00
alesapin
6f8da7dfdf Merge branch 'master' into fix_compression_codec_perf 2020-09-15 09:59:45 +03:00
Nikolai Kochetov
2e7da0e2f9 Fix build. 2020-09-15 09:56:49 +03:00
Nikolai Kochetov
c044c040a8 Fix build. 2020-09-15 09:53:14 +03:00
alesapin
a75254766e
Merge pull request #14609 from ClickHouse/update_to_gcc_10
Update default build to gcc-10
2020-09-15 09:49:43 +03:00
bharatnc
e4e3105014 Construct query_start_time(_microseconds) from same timespec 2020-09-14 20:04:16 -07:00
Nikolai Kochetov
95ae1105d9 Remove virtual destructors for Visitor. 2020-09-15 02:05:43 +03:00
Vitaly Baranov
0f53b449fd Add 'params' column to system.user_directories table. 2020-09-15 01:51:53 +03:00
Azat Khuzhin
85b63ecadf Bump revision manually (to make it compatible with other version from this tag)
As @alexey-milovidov wrote.

P.S. I did not use ./utils/release/release_lib.sh (via ./release), since
it is pretty complex (it fetches tags and so on)

The following macros has been updated:
- VERSION_REVISION -- usually bumped with utils/release/release_lib.sh
  (interesting that even if there were no changes)
- DBMS_MIN_REVISION_WITH_INTERSERVER_SECRET
- DBMS_TCP_PROTOCOL_VERSION -- does not affect anything, some internal
  yandex stuff
2020-09-15 01:36:28 +03:00
Azat Khuzhin
3fb548b3bb Cluster: use boost::range::remove_erase() over std::erase (c++20)
@vitlibar:

  "Yandex synchronization check says

  src/Interpreters/Cluster.cpp:299:10: error: no member named 'erase' in namespace 'std'
      std::erase(config_keys, "secret");
      ~~~~~^
  1 error generated.
  Please replace std::erase with boost::range::remove_erase."

  "That's quite an unusual build which links ClickHouse with a lot of closed source code and which still can't use most of C++20 features."
2020-09-15 01:36:28 +03:00
Azat Khuzhin
785d1b2a75 OpenSSLHelpers cleanup
Add few more specializations for encodeSHA256():
- std::string encodeSHA256(const std::string_view &);
- std::string encodeSHA256(const void *, size_t);
- void encodeSHA256(const void *, size_t, unsigned char *);
2020-09-15 01:36:28 +03:00
Azat Khuzhin
0159c74f21 Secure inter-cluster query execution (with initial_user as current query user) [v3]
Add inter-server cluster secret, it is used for Distributed queries
inside cluster, you can configure in the configuration file:

  <remote_servers>
      <logs>
          <shard>
              <secret>foobar</secret> <!-- empty -- works as before -->
              ...
          </shard>
      </logs>
  </remote_servers>

And this will allow clickhouse to make sure that the query was not
faked, and was issued from the node that knows the secret. And since
trust appeared it can use initial_user for query execution, this will
apply correct *_for_user (since with inter-server secret enabled, the
query will be executed from the same user on the shards as on initator,
unlike "default" user w/o it).

v2: Change user to the initial_user for Distributed queries if secret match
v3: Add Protocol::Cluster package
v4: Drop Protocol::Cluster and use plain Protocol::Hello + user marker
v5: Do not use user from Hello for cluster-secure (superfluous)
2020-09-15 01:36:28 +03:00
Azat Khuzhin
ec9d7745f3 Break the query loop on UNEXPECTED_PACKET_FROM_CLIENT 2020-09-15 01:36:28 +03:00
Azat Khuzhin
d53bbd3394 Not only send the exception to the client but also log it
Otherwise there will be only tricky "Unknown packet" exception after
exception during handling INSERT queries.
2020-09-15 01:36:28 +03:00
Nikolai Kochetov
65a1057aae Revert "Try simplify Visitor."
This reverts commit 9fcfa560ae.
2020-09-15 00:40:41 +03:00
Nikolai Kochetov
31660ddb4d Fix build 2020-09-15 00:30:55 +03:00
Alexey Milovidov
b676733b53 Merge branch 'master' into remove-header 2020-09-15 00:18:30 +03:00
Nikolai Kochetov
1b618fd130 Fix build 2020-09-14 23:56:56 +03:00
Nikolai Kochetov
9fcfa560ae Try simplify Visitor. 2020-09-14 23:35:45 +03:00
Nikolai Kochetov
45098f7112 Fix build. 2020-09-14 23:32:38 +03:00
Alexander Tokmakov
da6beb1a91 Merge branch 'master' into enable_some_tests_with_database_atomic 2020-09-14 23:00:14 +03:00
Nikolai Kochetov
d09422e60f Fix build. 2020-09-14 22:49:46 +03:00
alesapin
e96256d367 Trying to improve performance 2020-09-14 22:15:25 +03:00
Nikolai Kochetov
d418ee48a4
Merge pull request #14783 from amosbird/fix3
Fix signedness conversion monotonicity
2020-09-14 21:40:51 +03:00
Nikita Mikhaylov
ddea62211d
Merge pull request #11948 from CurtizJ/fsync-parts
Experiment. Allow to turn on fsync on inserts, merges and fetches.
2020-09-14 22:37:14 +04:00
Alexey Milovidov
3530f83c01 Remove debug output 2020-09-14 21:12:09 +03:00
Alexey Milovidov
f9361acb88 Disable in shared libraries mode 2020-09-14 21:00:45 +03:00
Alexey Milovidov
0e73b8acf3 Merge branch 'master' into remap-executable 2020-09-14 20:26:16 +03:00
Alexey Milovidov
038ae02126 Fix for #14761, part 2 2020-09-14 20:24:55 +03:00