Commit Graph

10166 Commits

Author SHA1 Message Date
Han Fei
3a697544c9
Merge pull request #51272 from ClickHouse/Update_check_for_parameterized_view
Updated check for parameterized view
2023-06-23 12:57:07 +02:00
kssenii
fbc1a80ebe Merge remote-tracking branch 'upstream/master' into min-file-segment-size 2023-06-23 12:52:29 +02:00
Nikolai Kochetov
e44b544ac0
Merge pull request #51301 from ClickHouse/fix-fuzz-actions-dag
Fix fuzzer failure in ActionsDAG
2023-06-23 12:30:34 +02:00
Nikolai Kochetov
efcf8d6389
Merge pull request #51266 from kssenii/less-loggers
Avoid too many calls to Poco::Logger::get
2023-06-23 09:56:26 +02:00
Alexey Milovidov
c958a1a77b Fix fuzzer failure in ActionsDAG 2023-06-23 01:23:25 +02:00
Alexey Milovidov
550784e6a0 Support clang-17 2023-06-23 01:08:51 +02:00
Nikolai Kochetov
f226397fa3 Fix check. 2023-06-22 19:21:08 +00:00
Alexey Milovidov
369ad0aea3 Remove ALTER of LIVE VIEW 2023-06-22 20:32:29 +02:00
Nikolai Kochetov
75391afbd8 Fix typo. 2023-06-22 18:16:48 +00:00
Nikolai Kochetov
ba4b5c3350 Fix stupid bug. 2023-06-22 18:15:16 +00:00
kssenii
dd49f4a565 Remove key 2023-06-22 17:07:52 +02:00
Nikolai Kochetov
22e49748b5 Cleanup. 2023-06-22 14:23:04 +00:00
Smita Kulkarni
3c7d749d2c Added check of StorageView before checking parameterized view to fix seg fault when materialized view is used with brackets 2023-06-22 14:47:04 +02:00
Robert Schulze
a9f1393862
Make the fix more minimal 2023-06-22 11:46:27 +00:00
Robert Schulze
a1c131c0da
Query Cache: Try to fix bad cast from ColumnConst to ColumnVector<char8_t>
Resolves #49445

The query cache buffers query result chunks and eventually squashes
them before insertion into the cache. Here, squashing failed because not
all chunks were of the same type. Looks like chunks of the same
underlying type (e.g. UInt8) in a query result be of mixed const, sparse
or low-cardinality type. Fix this by always materializing the data
regardless of the compression. Strange thing is that the failing query
in the stress test (*) isn't able to reproduce the bug, and I haven't
managed to trigger the issue otherwise, so no test case is added.

(*) SELECT 1 UNION ALL SELECT 1 INTERSECT SELECT 1
    E.g. here: https://s3.amazonaws.com/clickhouse-test-reports/0/18817517ed6f8849e3d979e10fbb273e0edf0eaa/stress_test__debug_/fatal_messages.txt
2023-06-22 11:46:22 +00:00
kssenii
8ff8125ebd Better 2023-06-22 13:25:47 +02:00
kssenii
4fbf52f2de Less loggers 2023-06-22 13:08:53 +02:00
Kseniia Sumarokova
b7ef782335
Merge pull request #51242 from kssenii/fix-possible-incorrect-elements-limit
Fix sometimes incorrect current_elements count in fs cache
2023-06-22 12:51:43 +02:00
Nikolai Kochetov
a940031878 Merge branch 'master' into refactor-subqueries-for-in 2023-06-22 12:18:48 +02:00
Alexey Milovidov
a050b9e9d9
Update FileCache.cpp 2023-06-22 01:28:52 +03:00
Igor Nikonov
e3b43c2b88 Move instead of copy 2023-06-21 21:54:44 +00:00
Igor Nikonov
ad0677147f Trying slightly improve eviction path
+ less copying of shared pointers
+ less indirection in overflow check
2023-06-21 21:48:58 +00:00
Nikolai Kochetov
0af028ab3f Refactor a bit more. 2023-06-21 20:55:27 +00:00
Sema Checherinda
01de36f1fa
Merge pull request #50395 from CheSema/better-log
require `finalize()` call before d-tor for all writes buffers
2023-06-21 21:12:02 +02:00
kssenii
78ea4feca0 Merge remote-tracking branch 'upstream/master' into delete-non-evictable-feature 2023-06-21 20:52:08 +02:00
kssenii
9aa4647f4f Delete feature 2023-06-21 20:48:12 +02:00
Kseniia Sumarokova
45d7f39566
Merge pull request #51222 from ClickHouse/kssenii-patch-7
Disable cache setting do_not_evict_index_and_mark_files
2023-06-21 20:17:33 +02:00
Anton Popov
022b85ba0b
Merge pull request #51164 from CurtizJ/better-check-part-with-cache
Better checking of data parts on disks with filesystem cache
2023-06-21 20:08:53 +02:00
kssenii
38466169c7 Better 2023-06-21 20:07:45 +02:00
kssenii
3ce17fd570 Fix log message 2023-06-21 18:30:46 +02:00
kssenii
509a50f651 Merge remote-tracking branch 'origin/fix-possible-incorrect-elements-limit' into fix-possible-incorrect-elements-limit 2023-06-21 18:29:16 +02:00
kssenii
b007c9f194 Review comments 2023-06-21 18:28:14 +02:00
Kseniia Sumarokova
d18da7098a
Update LRUFileCachePriority.cpp 2023-06-21 17:25:09 +02:00
kssenii
b723f9e7bf Fix sometimes not correct current_elements_num 2023-06-21 16:45:52 +02:00
Kseniia Sumarokova
5c38231a14
One more profile event for fs cache (#51223) 2023-06-21 15:18:25 +02:00
Robert Schulze
dcfcbd8345
Merge remote-tracking branch 'rschu1ze/master' into inefficient-query-cache 2023-06-21 09:23:31 +00:00
Kseniia Sumarokova
b60520ec55
Disable cache setting do_not_evict_index_and_mark_files 2023-06-21 11:15:55 +02:00
Robert Schulze
06e8590c8e
Merge pull request #50775 from rschu1ze/non-experimental-qpl-deflate
Mark QPL_DEFLATE non-experimental but default: off-by-default
2023-06-21 10:43:16 +02:00
kssenii
b8085dfa0e Fix bad merge 2023-06-21 00:20:40 +02:00
Nikolai Kochetov
266e81702a Fixing clang-tidy 2023-06-20 19:48:39 +00:00
Nikolai Kochetov
c0b1d7f4f2 Fixing 01774_tuple_null_in 2023-06-20 19:12:22 +00:00
Sema Checherinda
9b0c3359cf
Merge branch 'master' into better-log 2023-06-20 20:37:36 +02:00
Alexey Milovidov
c097e6e53d
Merge pull request #50531 from kitaisreal/jit-infrastructure-refactoring
JIT infrastructure refactoring
2023-06-20 21:13:44 +03:00
Robert Schulze
bc7df2baca
Merge branch 'master' into non-experimental-qpl-deflate 2023-06-20 20:06:01 +02:00
Nikolai Kochetov
5a1f819e7b Fix more tests. 2023-06-20 17:33:09 +00:00
Nikolai Kochetov
518ba6cbf6 Fix more tests. 2023-06-20 16:43:22 +00:00
Nikolai Kochetov
b4273a1963 Fixing some tests. 2023-06-20 14:53:13 +00:00
kssenii
44377b0180 Rename 2023-06-20 13:36:11 +02:00
kssenii
7df815d280 Fix 2023-06-20 13:33:16 +02:00
kssenii
5c4c2a3982 Merge remote-tracking branch 'upstream/master' into min-file-segment-size 2023-06-20 13:33:08 +02:00
Kseniia Sumarokova
c3227fd44f
Merge pull request #51161 from kssenii/more-metrics-in-cache
More profile events for fs cache
2023-06-20 12:44:00 +02:00
Maksim Kita
7e5017dd31 Fixed tests 2023-06-20 11:42:22 +03:00
Maksim Kita
6e26fde707 Updated tests 2023-06-20 11:42:22 +03:00
Maksim Kita
129b97c727 JIT infrastructure refactoring 2023-06-20 11:42:22 +03:00
Nikolai Kochetov
7280078bc6 Refactoring a bit more. 2023-06-19 19:01:56 +00:00
Han Fei
959f66eb8a
Merge pull request #50697 from kitaisreal/sort-block-improvements
Sort block improvements
2023-06-19 19:02:03 +02:00
Anton Popov
1ef19dbe4d drop cache on check of broken part 2023-06-19 16:32:51 +00:00
kssenii
ec86028fd8 Change to microseconds 2023-06-19 17:48:56 +02:00
kssenii
0ca2916163 More metrics in cache 2023-06-19 17:22:41 +02:00
Sergei Trifonov
5867f39fc7
Merge pull request #50675 from ClickHouse/unify-priorities-pools
Unify priorities for connection pools
2023-06-19 17:16:15 +02:00
Nikolai Kochetov
8e7d06e0a4 Remove isReady from FutureSet iface. 2023-06-19 12:56:24 +00:00
Nikolai Kochetov
880c9aea09 Fixing style. 2023-06-19 10:47:43 +00:00
Alexander Tokmakov
caceb7c862
Revert "Added ability to implicitly use file/hdfs/s3 table functions in clickhouse-local" 2023-06-19 13:21:09 +03:00
Maksim Kita
4c72995537 Fixed build 2023-06-19 13:02:35 +03:00
Sema Checherinda
2bbfa279ec fix gtest_lru_file_cache, fix remove from pending 2023-06-18 21:05:00 +02:00
Sema Checherinda
ce7cd67981 finalize CascadeWriteBuffer 2023-06-18 17:35:12 +02:00
Maksim Kita
977cd65cfb Fixed build 2023-06-18 12:52:08 +03:00
Maksim Kita
2f3dce5fe6 Fixed tests 2023-06-18 12:52:08 +03:00
Maksim Kita
7d17a70d17 Fixed tests 2023-06-18 12:52:08 +03:00
Maksim Kita
8d3212363e Fixed tests 2023-06-18 12:52:08 +03:00
Maksim Kita
ca298d66cb Sort block improvements 2023-06-18 12:52:08 +03:00
Robert Schulze
5311ebe1d2
Make query cache work effective with nested queries. 2023-06-17 20:27:25 +00:00
Robert Schulze
24717ed908
Factorize check if query cache exists 2023-06-17 18:24:20 +00:00
Robert Schulze
69e7c1cc82
Introduce convenience ctor for Key construction during read 2023-06-17 18:22:15 +00:00
Robert Schulze
6e8af09289
Provide query cache reader with dummy block 2023-06-17 12:48:29 +00:00
Robert Schulze
0adc98865d
Add variable for access to found key components 2023-06-17 12:43:14 +00:00
Robert Schulze
840e73eb74
Update #includes 2023-06-17 12:28:18 +00:00
Robert Schulze
83e2196a17
Make is_shared const 2023-06-17 12:26:53 +00:00
Alexey Milovidov
df9abccfaa
Merge branch 'master' into localfilefunction 2023-06-17 00:45:54 +03:00
Nikolai Kochetov
afa74f697c Refactor a bit. 2023-06-16 19:38:50 +00:00
Nikolai Kochetov
1cb7ba4895 Revert "Trying to fix a test."
This reverts commit d0d39c8f61.
2023-06-15 16:42:38 +00:00
Nikolai Kochetov
d34b6e5f35 Try to fix analyzer tests. 2023-06-15 16:27:51 +00:00
Zhiguo Zhou
ff6629d1d1 Enhance safety of function generateOptimizedDateFilterAST
This commit checks the corner case where the comparator is none
of equals, notEquals, less, lessOrEquals, greater, greaterOrEquals,
and throws LOGICAL_ERROR exception if so.
2023-06-15 22:04:13 +08:00
Zhiguo Zhou
d14299eb09 The general optimization of predicates with date/datetime converters
As is suggested in issue #15257, the function preimage is a general
solution to the optimization problem with predicates containing the
date and datetime converters. This commit implements the idea by
adding the new methods, hasInformationAboutPreimage and getPreimage,
to IFunction/IFunctionBase, and having the specific convert functions
define their own preimage. Moreover, we added a new pass in the
TreeOptimizer and a new AST visitor for in-place rewriting the AST
with the converters' preimage.

Specifically, the optimization is applied to toYear and toYYYYMM.
2023-06-15 21:48:02 +08:00
kssenii
b8a4a784de Fix unit test, add check 2023-06-15 14:22:13 +02:00
Kseniia Sumarokova
31e08635bf
Merge branch 'master' into unify-priorities-pools 2023-06-15 12:51:45 +02:00
kssenii
0023bf69cb Fix 2023-06-15 12:22:50 +02:00
kssenii
8c610275c2 Review fixes 2023-06-14 23:35:09 +02:00
kssenii
0aa363f525 Fix style check 2023-06-14 23:13:09 +02:00
Nikolai Kochetov
d0d39c8f61 Trying to fix a test. 2023-06-14 18:10:30 +00:00
kssenii
96fb7f04cb Finish download of partially downloaded file segments in the background instead of resizing 2023-06-14 19:06:13 +02:00
Dmitry Novik
1d88b16830
Merge pull request #50584 from ClickHouse/analyzer-optimizations-on-shards
Analyzer: Do not apply Query Tree optimizations on shards
2023-06-14 14:31:46 +02:00
kssenii
739dc6739f Progress 2023-06-14 13:51:13 +02:00
Antonio Andelic
4825286b0c
Merge branch 'master' into keeper-with-disks 2023-06-14 10:48:53 +02:00
Nikita Mikhaylov
52a460df67
Tests with parallel replicas are no more "always green" (#50896) 2023-06-13 16:43:35 +02:00
Robert Schulze
3617316026
Merge branch 'master' into non-experimental-qpl-deflate 2023-06-12 16:01:45 +02:00
Dmitry Novik
26c9bda144 Add a comment 2023-06-12 13:54:45 +00:00
Antonio Andelic
cb3ac81110
Merge branch 'master' into keeper-with-disks 2023-06-12 15:14:24 +02:00
Anton Popov
32caf87163
Merge pull request #50104 from amosbird/fix_43107_47549
Proper mutation of skip indices and projections
2023-06-12 15:09:18 +02:00
Robert Schulze
8222861f2e
Merge remote-tracking branch 'rschu1ze/master' into non-experimental-qpl-deflate 2023-06-11 14:39:30 +00:00