Commit Graph

102126 Commits

Author SHA1 Message Date
Arthur Passos
79d5759da9 Add test that covers the case of data being shared across multiple chunks and offsets being monotonically increasing 2022-11-22 17:38:53 -03:00
Alexey Milovidov
26d7b234b7
Merge pull request #43166 from azat/build/libcxx-only-for-cxx
Do not include libcxx library for C
2022-11-22 20:11:07 +01:00
Alexey Milovidov
25780be0c6
Merge pull request #42265 from taofengliu/group_by_all
Support GROUP BY ALL
2022-11-22 20:08:23 +01:00
Alexey Milovidov
8cb34913a1
Merge pull request #42461 from Enmk/ldap_fix_search_limit
fix LDAP in case of many roles on user
2022-11-22 20:05:14 +01:00
Azat Khuzhin
2cfbc27f13 Fix incorrect memory accounting because of merges/mutations
In case of merges/mutations, separate MemoryTracker object is used, to
track memory separately, to report this metrics.

However, the tail of those allocations hadn't been taken into account,
and in case of lots of mutations/merges it can be significant.

100% reproducible with the following example:

Start the server w/o frequent sync with RSS:

    $ clickhouse-server -C /src/programs/server/config.xml -- --asynchronous_metrics_update_period_s=86400

Run the following snippet:

    create table data (key Int, value Nullable(Decimal(38, 0))) engine=ReplicatedMergeTree('/ch/data', '1') order by key
    insert into data values (1, -13028236692093846346337460743176821145)
    alter table data modify column value UInt256
    Code: 341. DB::Exception: Received from localhost:9000. DB::Exception: Exception happened during execution of mutation 'mutation_2.txt' with part 'all_1_1_0' reason: 'Code: 407. DB::Exception: Convert overflow: while executing 'FUNCTION _CAST(value :: 1, 'UInt256' :: 2) -> _CAST(value, 'UInt256') UInt256 : 3': (while reading from part ./store/dd9/dd9ef183-1270-4877-af22-8a000bdcc1b8/all_1_1_0/): While executing MergeTreeInOrder. (DECIMAL_OVERFLOW) (version 22.12.1.1)'. This error maybe retryable or not. In case of unretryable error, mutation can be killed with KILL MUTATION query. (UNFINISHED)

And track the memory:

    select value/1e9 from system.metrics where metric like 'MemoryTracking'

Reported-by: @filimonov
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:40:35 +01:00
Azat Khuzhin
5da2f52722 Use Int64 over UInt64 for prev_untracked_memory* in MemoryTrackerThreadSwitcher
Since those types originally is Int64

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:40:35 +01:00
Azat Khuzhin
05f30aaad4 Fix logger name for MutateFromLogEntryTask
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:40:35 +01:00
Alexey Milovidov
b6fd28cd85
Merge pull request #43409 from azat/local/fix-uaf
Fix possible heap-use-after-free in local if history file cannot be created
2022-11-22 19:27:08 +01:00
Alexey Milovidov
c23b8c69db
Merge pull request #42791 from azat/fix-pe-overflow
Fix incorrect UserTimeMicroseconds/SystemTimeMicroseconds accounting
2022-11-22 19:22:51 +01:00
Alexey Milovidov
75dbd6828a
Merge pull request #43082 from Algunenano/werror_base
Add global flags to base/ libraries
2022-11-22 19:18:44 +01:00
Alexey Milovidov
f42be5ffd3
Merge pull request #43275 from azat/build/sanitize-targets
Sanitize thirdparty libraries for public flags
2022-11-22 19:18:26 +01:00
alesapin
41d3825770 Merge branch 'Enable_compress_marks_and_primary_key' of https://github.com/ClickHouse/ClickHouse into Enable_compress_marks_and_primary_key 2022-11-22 19:12:00 +01:00
alesapin
31142808de Disable compressed marks and index in stress tests 2022-11-22 19:10:51 +01:00
Alexander Tokmakov
d52870fe90 add a test with weird strings 2022-11-22 18:57:47 +01:00
Alexey Milovidov
7dae1b08c6
Merge pull request #43448 from ClickHouse/modify-test
Modify test slightly
2022-11-22 18:31:00 +01:00
Alexey Milovidov
0165f56a5c
Merge pull request #43435 from ClickHouse/fix-flaky-test-3
Fix flaky test
2022-11-22 18:30:39 +01:00
Alexey Milovidov
b7e4547f53
Merge branch 'master' into fix-typo-3 2022-11-22 18:30:06 +01:00
Alexey Milovidov
c8b068b4ff
Merge pull request #43447 from ClickHouse/netlink-remove-noise
Remove noise from logs about NetLink in Docker
2022-11-22 18:29:43 +01:00
Alexey Milovidov
ae8391c5dc
Merge pull request #43436 from ClickHouse/fix-bc-check
Fix backward compatibility check
2022-11-22 18:08:59 +01:00
Alexander Gololobov
c636c323ea
Merge pull request #43400 from socketpair/sd_notify
Fix #8685 - added systemd sd_notify implementation
2022-11-22 18:07:50 +01:00
Kseniia Sumarokova
cef9e5108e
Merge pull request #43325 from kssenii/named-collections-access-fix
Restrict default access to show named collections
2022-11-22 16:51:17 +01:00
Kseniia Sumarokova
d9975c9d13
Update .reference 2022-11-22 16:50:10 +01:00
zvonand
92100c9aa4 fix typos 2022-11-22 18:01:54 +03:00
Alexander Tokmakov
fc15ae95a4
Merge branch 'master' into revert_SingleValueDataString_followup 2022-11-22 17:52:38 +03:00
zvonand
faef0699b6 fix issues 2022-11-22 17:30:44 +03:00
Yatsishin Ilya
37bebcbe20 Add information about written rows in progress indicator 2022-11-22 14:29:22 +00:00
Alexander Gololobov
32d66659e5
Merge pull request #43364 from azat/server-stacktrace-on-fail
Provide full stacktrace in case of uncaught exception during server startup
2022-11-22 15:07:57 +01:00
Sergei Trifonov
1f615e4588
Merge pull request #42660 from ClickHouse/storage-system-moves
Add active moves system table
2022-11-22 15:07:22 +01:00
Alexander Tokmakov
2924f3ba7e
Merge branch 'master' into drop-fix 2022-11-22 17:05:12 +03:00
Sergei Trifonov
59f422f10c
Merge branch 'master' into storage-system-moves 2022-11-22 14:46:00 +01:00
Kruglov Pavel
98d6b96c82
Merge pull request #42033 from mark-polokhov/BSONEachRow
Add BSONEachRow input/output format
2022-11-22 14:45:21 +01:00
Azat Khuzhin
e7d6b9ccca Avoid possible DROP hung due to attached web disk
While dropping the table server scans all disk for existence of data to
remove, but in case of unavailable web disk it will fail, and also not
instantly but after 10 retries (by default, after #42800), that can take
~30 seconds.

But scanning read only disks does not makes any sense, so reorder
conditions to avoid this.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 14:44:56 +01:00
Maksim Kita
1e1492e480 Fixed build 2022-11-22 14:35:44 +01:00
Kseniia Sumarokova
5c90d5aa7e
Merge pull request #43253 from xiedeyantu/fix-s3-glob
fix s3 support question mark wildcard
2022-11-22 14:26:56 +01:00
Kseniia Sumarokova
392963012a
Merge pull request #43404 from azat/part.log.uuid
Add table_uuid to system.parts
2022-11-22 14:25:34 +01:00
Alexander Tokmakov
91b2cdb94a
Merge branch 'master' into tavplubix-patch-5 2022-11-22 16:17:55 +03:00
Kruglov Pavel
62bfb5547c
Merge pull request #43368 from Avogar/fix-if-nothing
Fix possible `Cannot create non-empty column with type Nothing` in functions if/multiIf
2022-11-22 14:11:13 +01:00
Sergei Trifonov
3177ed050f
Merge pull request #43307 from ClickHouse/cpu-progress-protocol-fix
fix CPU load indication on client
2022-11-22 14:09:55 +01:00
Alexander Gololobov
31bffdd735
Merge pull request #43460 from ClickHouse/smaller_buffer_for_small_files
Use smaller buffer for small files
2022-11-22 14:00:22 +01:00
Alexander Tokmakov
4f28334b5c fix mess with signed sizes 2022-11-22 13:57:05 +01:00
Anton Popov
2572202a16
Merge pull request #43461 from CurtizJ/merging-42064
Merging #42064
2022-11-22 13:55:01 +01:00
Mikhail f. Shiryaev
8ce5d90c91
Merge pull request #43467 from ClickHouse/use-bots-tokens
Use all parameters with prefixes from ssm
2022-11-22 13:46:27 +01:00
Kseniia Sumarokova
f9092a640c
Update 02473_infile_progress.py 2022-11-22 13:37:20 +01:00
Mikhail f. Shiryaev
7048f36fc7
Save unnecessary API requests 2022-11-22 13:37:08 +01:00
Dmitry Novik
e67bda65a0
Merge pull request #43453 from ClickHouse/fix-hard-limit-in-test
Do not reuse jemalloc memory in test_global_overcommit
2022-11-22 13:24:34 +01:00
Mikhail f. Shiryaev
fb95ca43d8
Use all parameters with prefixes from ssm 2022-11-22 12:43:17 +01:00
Alexander Tokmakov
7417d8b7c0
Merge pull request #43038 from Algunenano/revert_SingleValueDataString
Fix regression on SingleValueDataString
2022-11-22 14:28:30 +03:00
Alexander Tokmakov
cab33c02af
Merge branch 'master' into revert_SingleValueDataString 2022-11-22 14:27:58 +03:00
Nikolai Kochetov
9e84a351c7 Fixing special build. Disable setting by default. 2022-11-22 11:24:24 +00:00
Maksim Kita
04f597c29c Fixed style check 2022-11-22 11:14:55 +01:00