Commit Graph

56818 Commits

Author SHA1 Message Date
Raúl Marín
5355decc73 Give the server a chance 2024-04-29 21:08:56 +02:00
Raúl Marín
16727097b2 Fix client crash 2024-04-29 20:55:53 +02:00
Raúl Marín
987558e18d Improvements based on review 2024-04-29 20:46:37 +02:00
Raúl Marín
ff1c0023e8 Use TSA and mutex instead of object copy 2024-04-29 20:05:57 +02:00
Alexey Petrunyaka
29e70f5004 In-source and Russian .md UUIDv7 docs synced with English .md docs 2024-04-29 21:04:44 +03:00
Julia Kartseva
3c1207ed4d remove path normalization 2024-04-29 18:01:21 +00:00
Julia Kartseva
508a42bc8f use ordered map for path map 2024-04-29 18:01:21 +00:00
Julia Kartseva
24d5abba10 extract plain_rewritable metadata type
Make PlainRewritableObjectStorage generic;

Support config type
```
<s3_plain_rewritable>
    <type>object_storage</type>
    <object_storage_type>s3</object_storage_type>
    <metadata_type>plain_rewritable</metadata_type>
    <endpoint>https://s3.eu-west-1.amazonaws.com/clickhouse-eu-west-1.clickhouse.com/data/</endpoint>
    <use_environment_credentials>1</use_environment_credentials>
</s3_plain_rewritable>
```
2024-04-29 18:01:21 +00:00
Julia Kartseva
d1217af389 address feedback - pt.4 2024-04-29 18:01:21 +00:00
Julia Kartseva
802ee27b1b address feedback - pt.3
non-functional changes
2024-04-29 18:01:21 +00:00
Julia Kartseva
4a7f28f6bd address feedback - pt.2 2024-04-29 18:01:21 +00:00
Julia Kartseva
36a1cae910 address feedback - pt.1 2024-04-29 18:01:21 +00:00
Julia Kartseva
4f6a3e27b7 Update src/Disks/ObjectStorages/MetadataStorageFromPlainObjectStorageOperations.cpp
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2024-04-29 18:01:21 +00:00
Julia Kartseva
70d55aa618 Update src/Disks/ObjectStorages/CommonPathPrefixKeyGenerator.h
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2024-04-29 18:01:21 +00:00
Julia Kartseva
89f28f3c18 explicitly disallow ALTERs and mutations for plain 2024-04-29 18:01:21 +00:00
Julia Kartseva
01ee500b06 improvements, cleanups, comments 2024-04-29 18:01:21 +00:00
Julia Kartseva
a67a8299ce Do not list prefix.path in listDirectory 2024-04-29 18:01:21 +00:00
Julia Kartseva
d1e5a09b18 better transaction rollback 2024-04-29 18:01:21 +00:00
Julia Kartseva
b4375131cb concurrency control 2024-04-29 18:01:21 +00:00
Julia Kartseva
7916792baa Do not create directory metadata recursively 2024-04-29 18:01:21 +00:00
Julia Kartseva
75147f3ac7 S3-plain based disk supporting directory rename
Fixes: https://github.com/ClickHouse/ClickHouse/issues/58347
2024-04-29 18:01:21 +00:00
Alexey Milovidov
cf9954035d Extend syntax highlight to 10 KB 2024-04-29 19:53:50 +02:00
Alexander Gololobov
39001cce0e Use user specified db instead of "config" 2024-04-29 18:05:37 +02:00
Maksim Kita
8d9541b8d7 JIT sort description crash fix 2024-04-29 18:59:56 +03:00
Nikita Taranov
8fd38f2abc
Merge pull request #62752 from ClickHouse/log_profile_events_send_timings
Log profile events send timings
2024-04-29 15:41:28 +00:00
Maksim Kita
d237133ec0 Recursive CTE data race fix 2024-04-29 18:29:18 +03:00
Duc Canh Le
05eab7b204
Fix style 2024-04-29 21:54:50 +08:00
Igor Nikonov
20884efdcc Merge remote-tracking branch 'origin/master' into pr-receive-timeout-on-handshake 2024-04-29 13:36:13 +00:00
Alexander Gololobov
5b2f726a71 Set server name for SSL handshake 2024-04-29 15:24:48 +02:00
Raúl Marín
97774571f1 Merge remote-tracking branch 'blessed/master' into 03132_rewrite_aggregate_function_with_if_implicit_cast 2024-04-29 14:54:23 +02:00
Raúl Marín
30d10bf242 Style 2024-04-29 14:46:42 +02:00
Raúl Marín
97c781e365 Sanity check: Clamp values instead of throwing 2024-04-29 14:34:47 +02:00
Igor Nikonov
f22c27c76b
Merge pull request #62610 from ClickHouse/fix-msan-uuid-string-to-num
Fix: msan in UUIDStringToNum
2024-04-29 11:56:10 +00:00
Raúl Marín
3b0c4dc671
Update SettingsChangesHistory.h 2024-04-29 12:56:50 +02:00
Duc Canh Le
98d606298b better way to deduplicate keys while creating sst files
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-04-29 10:53:50 +00:00
Duc Canh Le
084f917bf8 fix clang-tidy and better test
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-04-29 10:37:45 +00:00
vdimir
3a8ca9a68b
bind only full identifier 2024-04-29 10:01:08 +00:00
Slach
fff871ac63 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix_mysql81 2024-04-29 13:54:51 +04:00
Raúl Marín
379fea9a30
Merge pull request #62972 from ClickHouse/tavplubix-patch-10
Fix race in `executeJob` when updating exception message
2024-04-29 09:53:40 +00:00
Raúl Marín
8df67eb7ed
Merge branch 'master' into optimize_rewrite_sum_if_to_count_if 2024-04-29 11:51:09 +02:00
Azat Khuzhin
119e000873 Fix subsequent use of external tables in client
Before this patch it fails on the second and all other invocations:

    $ chc --external --file=/tmp/test-no-lf.tsv --name=t --structure='x String'
    azat.local$ select * from t limit 1
       ┌─x───┐
    1. │ foo │
       └─────┘

    azat.local$ select * from t limit 1
    Exception on client:
    Code: 27. DB::Exception: Cannot parse input: expected '\t' at end of stream.: (at row 1)
    : Buffer has gone, cannot extract information about what has been parsed.: (in file/uri /tmp/test-no-lf.tsv): While executing TabSeparatedRowInputFormat. (CANNOT_PARSE_INPUT_ASSERTION_FAILED)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-29 11:43:29 +02:00
Azat Khuzhin
437621cbe5 Remove superfluous condition from ClientBase::sendExternalTables()
send_external_tables already checked by the callers.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-29 11:43:29 +02:00
Eduard Karacharov
979efcad49 allow YAML sources in include_from 2024-04-29 12:42:56 +03:00
alesapin
4701429db4
Merge pull request #62773 from hileef/fix/update/nested-columns-size-check
fix: update: nested materialized columns: size check fixes
2024-04-29 09:27:39 +00:00
Shaun Struwig
40f33b6236
Merge branch 'ClickHouse:master' into 59557_form_input_format 2024-04-29 10:25:47 +02:00
Slach
76293754db log_bin_use_v1_row_events was removed in MySQL 8.3, fix https://github.com/ClickHouse/ClickHouse/issues/60479, duplicate https://github.com/ClickHouse/ClickHouse/pull/62793 to make PR properly 2024-04-29 08:15:33 +04:00
Duc Canh Le
4b7abbce68 fix abs monotonicity
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-04-29 01:33:48 +00:00
Alexey Milovidov
c570316c87
Merge branch 'master' into analyzer-support-recursive-cte 2024-04-29 02:26:59 +02:00
Alexey Milovidov
eaf3b91ab6
Merge pull request #62907 from kitaisreal/query-plan-convert-outer-join-to-inner-join-optimization
QueryPlan convert OUTER JOIN to INNER JOIN optimization
2024-04-28 23:07:44 +00:00
Alexey Milovidov
2d7c8948de Also highlight tables in string literals 2024-04-29 00:26:46 +02:00
Alexey Milovidov
f891da8db8 Merge remote-tracking branch 'origin/master' into better-highlighting-of-keywords 2024-04-29 00:26:34 +02:00
Alexey Milovidov
4e7f95babb Merge branch 'master' of github.com:ClickHouse/ClickHouse into tacit 2024-04-29 00:14:21 +02:00
p1rattttt
cde04df8af
Merge branch 'ClickHouse:master' into cross_join_compression 2024-04-28 23:10:43 +03:00
kssenii
3e4d9bf73a Better result condition 2024-04-28 14:08:20 +02:00
kssenii
8c4476d7db Merge remote-tracking branch 'origin/master' into less-contentaion-in-cache-part4 2024-04-28 13:36:16 +02:00
Maksim Kita
56037ffaca Fixed build 2024-04-28 12:52:17 +03:00
Maksim Kita
f5cfe597f2 Fixed tests 2024-04-28 12:52:17 +03:00
Maksim Kita
bd1189de70 Fixed tests 2024-04-28 12:52:17 +03:00
Maksim Kita
0111f30ed2 Fixed clang-tidy 2024-04-28 12:52:17 +03:00
Maksim Kita
85dc0cf20a Fixed tests 2024-04-28 12:52:17 +03:00
Maksim Kita
06d2c18f26 Analyzer support recursive CTEs 2024-04-28 12:52:17 +03:00
Maksim Kita
b080adb586 Fixed build 2024-04-28 12:52:05 +03:00
Maksim Kita
8ed6f4c27a Fixed code review issues 2024-04-28 12:52:05 +03:00
Maksim Kita
ab0842347d Fixed code review issues 2024-04-28 12:52:04 +03:00
Maksim Kita
16887ce802 Fixed tests 2024-04-28 12:52:04 +03:00
Maksim Kita
bc6db79737 QueryPlan convert OUTER JOIN to INNER JOIN optimization 2024-04-28 12:52:04 +03:00
Robert Schulze
fcc77379ae
Cosmetics, pt. IV 2024-04-28 09:50:42 +00:00
Duc Canh Le
c4e0cf2e7d rocksdb: implement ALTER SETTING
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-04-28 06:37:53 +00:00
Azat Khuzhin
cf1451ecde Fix possible CHECKSUM_DOESNT_MATCH during replicated fetches
Previously HTTP server does not tries to send exception if something had
been written to the client already, but after rewriting to "zero-copy"
HTTP implementation (back in #19516) this got broken, and you can get
pretty "dangerous" at least at first glance errors, like:
- Malformed chunked encoding
- or most likely to CHECKSUM_DOESNT_MATCH error

This is not crucial because it will never pass checksum checks, but
still icky. So let's fix it.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-28 07:34:08 +02:00
Azat Khuzhin
478ba92ddd Improve error message on checksum mismatch during fetches
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-28 07:34:07 +02:00
Azat Khuzhin
d278866d52 Add copy_data_failpoint failpoint
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-28 07:34:07 +02:00
LiuNeng
4f9dba8535
Merge branch 'master' into feature/adaptive_merged_block_size 2024-04-28 12:54:43 +08:00
Alexey Milovidov
fae8080130 Allow using clickhouse-local with a positional argument 2024-04-28 04:39:56 +02:00
lgbo-ustc
0070d6fc71 fixed: converting filter column type 2024-04-28 09:27:16 +08:00
lgbo-ustc
352d7a443b fixed: filter column is a const column 2024-04-28 09:27:16 +08:00
lgbo-ustc
5431e272c9 update 2024-04-28 09:27:16 +08:00
lgbo-ustc
6fa6c0261b apply 27a2b19 2024-04-28 09:27:16 +08:00
lgbo-ustc
7ee720ffb0 update settting 2024-04-28 09:27:15 +08:00
lgbo-ustc
6c30774ce5 disable when join_use_nulls=1
update setting

update
2024-04-28 09:26:11 +08:00
lgbo-ustc
c51e9163a5 reduce hash join code size
add check

debug

fixed

fixed

fixed

fixed

fixed

debug

debug

update

rename full_expression

rollback ExecutionContext

experiment: support join_use_nulls
2024-04-28 09:26:11 +08:00
lgbo-ustc
cd9c87811f fixed bugs for all right join
add test cases

fixed typos

add document

fixed stype error and rename some variables

fixed test error

add test cases

try to recude hash join code size

debug

fixed

fixed coredump

fixed. condition result type is not bool

enable when allow_experimental_analyzer=0

fixed tests

fixed

update tests

update tests

roll backup when use the old analyzer

fixed typos

fixed

test

large obj check

test

test
2024-04-28 09:26:11 +08:00
lgbo-ustc
f7dd4deca0 Optimization for cutting left blocks into processed and not_processed parts. 2024-04-28 09:26:11 +08:00
lgbo-ustc
4a2ad7beb5 fixed bugs 2024-04-28 09:26:11 +08:00
lgbo-ustc
2692784585 support inequal join for left/right/inner all 2024-04-28 09:26:11 +08:00
Alexey Milovidov
5a9c5b7d50 Better highlighting of keywords 2024-04-28 00:19:42 +02:00
Alexey Milovidov
f7b6a1149a
Merge pull request #61357 from canhld94/fix_count
Fix parser error when using COUNT(*) with FILTER clause
2024-04-27 21:53:47 +00:00
Shaun Struwig
a69658b1dd
Merge branch 'ClickHouse:master' into 59557_form_input_format 2024-04-27 21:40:58 +02:00
Alexey Petrunyaka
74a9b713a8
Update generateUUIDv7.cpp 2024-04-27 21:47:14 +03:00
Alexey Milovidov
d59175b6ad Even less directories 2024-04-27 20:43:22 +02:00
Nikita Taranov
c14fb847da
Merge pull request #62047 from azat/dist/fix-IN-rewrite
Fix optimize_skip_unused_shards_rewrite_in for composite sharding key
2024-04-27 18:39:34 +00:00
Alexey Milovidov
64fff163f7 Less directories 2024-04-27 19:54:37 +02:00
Alexey Milovidov
6a083ebed0 Even less directories 2024-04-27 19:13:17 +02:00
Alexey Milovidov
089cc25d9b Less directories 2024-04-27 19:05:58 +02:00
Alexey Milovidov
39118ef461 Hopefully better 2024-04-27 18:47:03 +02:00
Alexey Petrunyaka
6ef5df9845
Update generateUUIDv7.cpp 2024-04-27 19:43:08 +03:00
Alexey Milovidov
14e32aa1a1 Less directories in clickhouse-local 2024-04-27 18:24:05 +02:00
Alexey Petrunyaka
1c5c97f648
Update generateUUIDv7.cpp 2024-04-27 18:50:41 +03:00
Alexey Petrunyaka
e351b51ca3
Update generateUUIDv7.cpp 2024-04-27 18:42:08 +03:00
Alexey Petrunyaka
113ad9b8ba
Update generateUUIDv7.cpp 2024-04-27 18:16:21 +03:00
Alexey Milovidov
58792a1935
Merge pull request #60302 from azat/INSERT-receive-timeout
Change back how receive_timeout is handled for INSERTs
2024-04-27 14:55:28 +00:00
Alexey Petrunyaka
9235845988
Performance optimizations + docs and tests changes (#4) 2024-04-27 17:30:27 +03:00
Alexey Milovidov
06d21ab028
Merge pull request #62420 from ClickHouse/too-many-parts-in-move-partition
Add back-pressure for `MOVE PARTITION TO TABLE` as for `INSERT`s
2024-04-27 14:07:10 +00:00
Alexey Milovidov
5a7e7a9f2f Merge branch 'master' into too-many-parts-in-move-partition 2024-04-27 16:02:02 +02:00
Alexey Milovidov
a75a9e37be
Merge pull request #62534 from ClickHouse/Azure_write_buffer_parallel_upload
Support parallel write buffer for AzureBlobStorage
2024-04-27 13:59:55 +00:00
Alexey Milovidov
da2b9f2cbb
Merge pull request #63040 from vitlibar/fix-unhandled-exception-in-restorer-from-backup-destructor
Fix unhandled exception in ~RestorerFromBackup
2024-04-27 13:47:38 +00:00
Blargian
6a8852f942 Fix style check 2024-04-27 15:26:35 +02:00
Blargian
d8ace22c3a Implement review changes 2024-04-27 15:14:58 +02:00
Pablo Marcos
f6b19e143a Remove unnecessary const hinted by clang-tidy
Removing the reference for Index makes the const unnecessary.
Constness for it is still preserved correctly because Columns
are inmutable pointers to IColumn.
2024-04-27 09:30:51 +02:00
Pablo Marcos
9002d4c751 Merge branch 'master' into pamarcos/system-unload-primary-key 2024-04-27 08:57:29 +02:00
Konstantin Bogdanov
64de52397e
Merge pull request #62978 from ClickHouse/fix-grpc-ipv6-crash
gRPC: fix crash on IPv6 peer connection
2024-04-27 06:22:41 +00:00
Alexey Milovidov
8cc67f7c95
Merge pull request #62973 from yariks5s/reduce_help_messages
Reduce verbosity of `clickhouse client --help`
2024-04-27 03:43:33 +00:00
Alexander Tokmakov
8c282b63ae
Update ExecutionThreadContext.cpp 2024-04-26 20:30:41 +02:00
Konstantin Bogdanov
2768b4f611
Fix comment 2024-04-26 19:58:34 +02:00
Konstantin Bogdanov
822a57cb83
Fix integration tests 2024-04-26 19:56:24 +02:00
Nikita Mikhaylov
ed7e4291ab
Merge pull request #62937 from ClickHouse/docs-remove-replicated-experimental-tag
Remove experimental tag from Replicated database engine
2024-04-26 17:56:06 +00:00
Alexander Tokmakov
87537c1303
Merge pull request #63000 from ClickHouse/tavplubix-patch-14
Remove incorrect assertion from DatabaseReplicated
2024-04-26 17:48:56 +00:00
Alexander Tokmakov
7fb78aa4d4
Merge pull request #60856 from azat/alter-select-throughtput-v2
[RFC] Reduce overhead of the mutations for SELECTs (v2)
2024-04-26 17:46:57 +00:00
Konstantin Bogdanov
6d805d094c
Fix harder 2024-04-26 19:37:14 +02:00
Nikita Taranov
51a0ec9b30
Merge branch 'master' into dont_merge_just_created_aggr_projection_block 2024-04-26 19:32:14 +02:00
Nikita Taranov
2dadb164c4
Merge pull request #62853 from nickitat/fix_gcd
Fix GCD codec
2024-04-26 17:26:00 +00:00
Nikolai Kochetov
48213c2c3e Do not remove server constants from GROUP BY key for secondary query. 2024-04-26 16:19:51 +00:00
Nikita Mikhaylov
ec787a68e8
Merge pull request #60153 from azat/access-controls-enable-by-default
Enable all access control improvements by default (even without config.xml)
2024-04-26 16:09:30 +00:00
Konstantin Bogdanov
4c607147ba
Fix 2024-04-26 17:38:02 +02:00
Konstantin Bogdanov
466633729f
Support user expiration 2024-04-26 17:03:40 +02:00
Konstantin Bogdanov
07e4e7fa73
Check for protocol prefix 2024-04-26 16:45:30 +02:00
Smita Kulkarni
f474c29b4d Fix build with new master 2024-04-26 15:33:27 +02:00
Vitaly Baranov
929f474496 Fix unhandled exception in ~RestorerFromBackup. 2024-04-26 15:18:13 +02:00
Raúl Marín
25d7f24f0f
Merge pull request #63004 from Algunenano/remove_optimize_monotonous_functions_in_order_by
Remove optimize_monotonous_functions_in_order_by setting
2024-04-26 12:13:50 +00:00
alesapin
56039c91f9
Update src/Interpreters/MutationsInterpreter.cpp 2024-04-26 13:51:25 +02:00
Nikita Mikhaylov
b204e43554
Merge pull request #62000 from ClickHouse/keywords-2
Use keywords structure in all places - `obfuscateQueries.cpp` / `Suggest.cpp`
2024-04-26 11:47:14 +00:00
Yarik Briukhovetskyi
819b5aab55
Merge pull request #62901 from KevinyhZou/fix_fromUnixTimestamp_beyond_uint32
Fix fromUnixtimestamp in joda syntax while the input value beyond UInt32
2024-04-26 11:31:24 +00:00
Igor Nikonov
dd5dc25e65 Remove unnecessary check 2024-04-26 11:26:05 +00:00
Yarik Briukhovetskyi
eee6fa4242
cosmetic fixes, comments for tests, user hints fixes 2024-04-26 13:19:22 +02:00
Duc Canh Le
41351222e7 Merge branch 'master' into rocksdb_bypass_memtable
Resolve conflicts

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-04-26 10:47:49 +00:00
Robert Schulze
c68a96eec3
Cosmetics, pt. III 2024-04-26 10:21:44 +00:00
Kseniia Sumarokova
75bbb67069
Merge pull request #62842 from ClickHouse/fix-check-in-http-handler
Allow quota key with different auth scheme in HTTPHandler
2024-04-26 10:21:02 +00:00
Kseniia Sumarokova
ce5ea3b05a
Merge pull request #62925 from ClickHouse/fix-temporary-data-in-cache-base-directory-creation
Fix temporary data in cache incorrectly processing failure of cache key directory creation
2024-04-26 10:17:45 +00:00
Robert Schulze
c3be6728c8
Cosmetics, pt. II 2024-04-26 10:12:16 +00:00
Smita Kulkarni
3ace11f92d Merge branch 'master' into Azure_write_buffer_parallel_upload 2024-04-26 10:27:41 +02:00
liuneng
f2ab23780f fix bug and add test case 2024-04-26 16:24:06 +08:00
liuneng
3696d05de9 change default value 2024-04-26 14:17:23 +08:00
liuneng
f06cb0d42f add minimum block size limitation 2024-04-26 13:38:30 +08:00
liuneng
49740451f7 reduce memory usage during merging external sorted file 2024-04-26 13:38:30 +08:00
Nikita Mikhaylov
a3e746c438 Fix style 2024-04-25 20:17:20 +00:00
Nikita Mikhaylov
8e63946b6d Fix clang-tidy 2024-04-25 19:57:29 +00:00
Raúl Marín
09ff42de0f Remove optimize_monotonous_functions_in_order_by 2024-04-25 21:46:15 +02:00
Raúl Marín
052713db3b Fix order and reference files 2024-04-25 21:14:40 +02:00
Raúl Marín
93be6c4a2a Merge remote-tracking branch 'blessed/master' into optimize_rewrite_sum_if_to_count_if 2024-04-25 20:38:48 +02:00
Alexander Tokmakov
9de7a95178
Update DatabaseReplicated.cpp 2024-04-25 20:34:08 +02:00
Raúl Marín
3941d69c6b Fix optimize_rewrite_aggregate_function_with_if implicit cast 2024-04-25 20:25:40 +02:00
kssenii
acd7292be0 Fix abort in temporary data in cache 2024-04-25 20:00:40 +02:00
Pablo Marcos
39deb3ee7f Convert index to a shared_ptr to allow unloading primary keys while queries use them 2024-04-25 19:56:21 +02:00
Yarik Briukhovetskyi
64cb638717
add tests and changed implementation 2024-04-25 19:46:20 +02:00
Kseniia Sumarokova
f85d967f11
Merge pull request #62967 from ClickHouse/better-assertion-message-in-cache
Better exception message
2024-04-25 17:16:40 +00:00
Igor Nikonov
a4a6581be3 UUIDStringToNum/UUIDNumToString: enforce second parameter to be constant 2024-04-25 17:12:50 +00:00
vdimir
64dba76afe
Analyzer: prefer column name to alias from array join 2024-04-25 16:54:49 +00:00
Yarik Briukhovetskyi
5b4b4087e3
fixed build, moved verbose to help, fixed exception message 2024-04-25 18:51:17 +02:00
Yarik Briukhovetskyi
281fe68622
allow all settings if not --help 2024-04-25 18:28:09 +02:00
Pablo Marcos
24b84ef68a Merge branch 'master' into pamarcos/system-unload-primary-key 2024-04-25 18:26:14 +02:00
Alexander Tokmakov
1e1bac513a
Update ExecutionThreadContext.cpp 2024-04-25 18:13:09 +02:00
Nikita Mikhaylov
239f9e2059 Better 2024-04-25 15:50:29 +00:00
Alexander Tokmakov
8fc69974d8
Update PushingAsyncPipelineExecutor.cpp 2024-04-25 17:43:39 +02:00
Alexander Tokmakov
84402f4b5b
Update ExecutionThreadContext.cpp 2024-04-25 17:06:08 +02:00
Yarik Briukhovetskyi
a36d86f63a
add --verbose for help and suggest to use system.settings 2024-04-25 17:01:34 +02:00
Konstantin Bogdanov
7326e2a0fa
Fix aborting on IPv6 peer address 2024-04-25 16:44:16 +02:00
Nikolai Kochetov
0038f322e8
Merge pull request #62916 from ClickHouse/fix-prewhere-for-storage-buffer-with-different-types
Fix PREWHERE for StorageBuffer with different source table column types.
2024-04-25 14:40:11 +00:00
Nikolai Kochetov
e1da9114fb
Merge pull request #62811 from canhld94/fix_cte_final
Fix FINAL modifier is not respected in CTE with analyzer
2024-04-25 14:37:50 +00:00
Nikita Mikhaylov
9c3ebc5a99 Added setting change to the history 2024-04-25 15:39:42 +02:00
yariks5s
0cc404a74c init 2024-04-25 13:39:09 +00:00
Alexander Tokmakov
5c9427f625
Update ExecutionThreadContext.cpp 2024-04-25 15:28:57 +02:00
Nikita Mikhaylov
2724a08cbc Better 2024-04-25 13:06:09 +00:00
Nikita Mikhaylov
f43a155aa9 Make allow_experimental_database_replicated obsolete. 2024-04-25 13:05:14 +00:00
kssenii
6dc48de031 Fix 2024-04-25 14:55:09 +02:00
Azat Khuzhin
5d72a34561 Add some comments for getAlterMutationCommandsForPart()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
Azat Khuzhin
e5650f8af3 Move add_to_result() out from loop
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
Azat Khuzhin
e0b83bde50 Consider alter_conversions_mutations as valid only if part metadata version matches
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
Azat Khuzhin
d2a922bd44 Revert "Fix processing INSERT after metadata mutations that had not been applied yet"
The problem is that the atomic counter (alter_conversions_mutations) is
not accounted correctly for IMergeTreeDataPart::getMetadataVersion()

This reverts commit 0124642b39f538eaf2b1c7cfab9a0a917b1b12f6.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
Azat Khuzhin
c048ab9d6d Fix processing INSERT after metadata mutations that had not been applied yet
The problem is that right now INSERT may write old columns even after
metadata mutation (i.e. RENAME), because it will simply write the new
block number that is bigger then metadata version, and so this part
won't be mutated.

To fix this, it should get the mutation version from metadata - this is
quite a major change!

Fixes: 2555_davengers_rename_chain
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
Azat Khuzhin
be6777bc86 Reduce overhead of the mutations for SELECTs (v2)
SELECTs are affected by the mutations, since it tries to apply them on
fly, and scanning over existing mutations can take significant amount of
time (for simple queries, i.e. count())

And also even after mutation had been finished, it still a problem,
because mutations are not removed instantly.

So instead introduce an atomic counter alter_conversions_mutations, that
is incremented for new mutations and decremented once mutation
finished/killed, that way once the mutation finished they will not
affect queries.

Here are some numbers for non-RENAME mutations:

    rmt vanilla w/o mutations | queries: 3693, QPS: 494.813
    rmt vanilla w/ mutations  | queries: 2190, QPS: 388.256
    rmt patched w/o mutations | queries: 3168, QPS: 620.061
    rmt patched w/ mutations  | queries: 3155, QPS: 614.424
    mt vanilla w/o mutations  | queries: 3498, QPS: 656.399
    mt vanilla w/ mutations   | queries: 3821, QPS: 600.425
    mt patched w/o mutations  | queries: 5732, QPS: 745.585
    mt patched w/ mutations   | queries: 4719, QPS: 715.034

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
Robert Schulze
d2c1dfff09
Merge pull request #62543 from tomershafir/cow-examples-assert
Add asserts to COW example programs
2024-04-25 12:07:47 +00:00
Nikita Mikhaylov
6fe4203d44 Merge branch 'master' of github.com:ClickHouse/ClickHouse into keywords-2 2024-04-25 11:59:06 +00:00
Igor Nikonov
ee7f862155 Merge remote-tracking branch 'origin/master' into fix-msan-uuid-string-to-num 2024-04-25 11:22:11 +00:00
Nikita Mikhaylov
5ea95cbbec
Merge branch 'master' into access-controls-enable-by-default 2024-04-25 13:21:23 +02:00
Nikita Mikhaylov
0543312542
Merge pull request #62954 from ClickHouse/mac-clang-18
Fix build on Mac using clang-18
2024-04-25 10:42:28 +00:00
Kruglov Pavel
e1941202b2
Merge pull request #62866 from amosbird/fix-62848
Fix LowCardinality(Nullable) key in hyperrectangle
2024-04-25 10:25:56 +00:00
alesapin
8a82277a03
Merge pull request #62920 from ClickHouse/some_keeper_changes
Add some functions to zookeeper client
2024-04-25 10:04:27 +00:00
Nikita Mikhaylov
d1c8f0af82 Better 2024-04-25 11:33:36 +02:00
Kseniia Sumarokova
8cea79ac91
Merge pull request #62868 from kitaisreal/system-drop-uninitialized-cache-fix
SYSTEM DROP uninitialized cache fix
2024-04-25 09:28:44 +00:00
Raúl Marín
921073d848
Merge pull request #62912 from Algunenano/sum_if_nullable
Disable optimize_rewrite_aggregate_function_with_if for sum(nullable)
2024-04-25 09:25:09 +00:00
Robert Schulze
ef6585adf5
Fix compiler warnings 2024-04-25 07:48:57 +00:00
tomershafir
1cbba5c0e2
fix style 2024-04-25 07:37:49 +00:00
tomershafir
7a25e186bb
COW: assert in examples 2024-04-25 07:37:45 +00:00
kevinyhzou
cd2ad69101 review fix 2024-04-25 12:13:08 +08:00
kevinyhzou
a5d85398f9 Fix bug in from_unixtimestamp by joda syntax 2024-04-25 09:43:47 +08:00
Igor Nikonov
33b9e589c6 Add test_skip_replicas_without_table 2024-04-24 21:13:07 +00:00
Nikita Mikhaylov
2ff562ebe2
Merge pull request #62899 from liuneng1994/fix-build-failed-on-clang-18
Fix build failed on clang-18
2024-04-24 20:22:53 +00:00
Igor Nikonov
6db303cea3 Merge remote-tracking branch 'origin/master' into pr-receive-timeout-on-handshake 2024-04-24 18:56:49 +00:00
Igor Nikonov
abf5be05b8 Set table for parallel replicas with analyzer 2024-04-24 18:56:03 +00:00
Alexey Petrunyaka
3344f4342f
UUIDv7 tests & fix for MS UUID representation in UUIDToNum (#2)
* Update 02310_generate_multi_columns_with_uuid.sql
* Update 02310_generate_multi_columns_with_uuid.reference
* Update 00396_uuid.sql
* Update 00396_uuid.reference
* Update FunctionsCodingUUID.cpp
2024-04-24 21:47:07 +03:00
Alexander Tokmakov
26b9c99328
Merge pull request #59619 from alexkats/add-values-to-text-log
Add columns for values used in the formatting message into system.text_log
2024-04-24 18:20:30 +00:00
alesapin
1b562ce569
Merge pull request #61769 from kirillgarbar/modify-engine
Search for convert_to_replicated flag at the correct path
2024-04-24 18:17:29 +00:00
Raúl Marín
aba8649500 Merge remote-tracking branch 'blessed/master' into optimize_rewrite_sum_if_to_count_if 2024-04-24 19:42:33 +02:00
Raúl Marín
1ba7e5942b Enable optimize_rewrite_sum_if_to_count_if by default 2024-04-24 19:24:36 +02:00
Yarik Briukhovetskyi
fcb33a705b
Merge pull request #62812 from Hexta/fix-take_full_part
Fix taking full part if part contains less than 'limit' rows
2024-04-24 17:06:50 +00:00
Raúl Marín
3ddaa8e846 Merge remote-tracking branch 'blessed/master' into sum_if_nullable 2024-04-24 18:53:46 +02:00
kssenii
7530dd57f1 Fix 2024-04-24 18:51:45 +02:00
alesapin
da4690f1da Add some functions to zookeeper client 2024-04-24 17:52:23 +02:00
Nikolai Kochetov
01d8dda773 Fix PREWHERE for StorageBuffer with different source table column types. 2024-04-24 15:07:14 +00:00
Maksim Kita
a4055ae879 SYSTEM DROP uninitialized cache fix 2024-04-24 17:46:15 +03:00
Raúl Marín
70135abe70 Disable optimize_rewrite_aggregate_function_with_if for sum(nullable) 2024-04-24 15:51:11 +02:00
Raúl Marín
0d06d69377 Fix parsing of nested proto messages 2024-04-24 13:32:13 +02:00
Artur Malchanau
52d4cd82d9
Merge branch 'ClickHouse:master' into fix-take_full_part 2024-04-24 12:11:35 +02:00
liuneng
76b989ebbc fix missing-field-initializers 2024-04-24 17:13:08 +08:00
Nikolai Kochetov
8f45abd167
Merge pull request #62874 from kitaisreal/planner-joins-remove-unused-comments
PlannerJoins remove unused comments
2024-04-24 09:10:40 +00:00
Robert Schulze
56e32e0f99
Rename MergeTreeIndexInverted* to MergeTreeIndexFullText* 2024-04-24 07:20:08 +00:00
Raúl Marín
3df253cb0a
Merge pull request #62850 from danipozo/fix-building-endpoint-from-storage-account-url
Azure: fix building final url from endpoint object
2024-04-23 17:26:22 +00:00
Nikita Taranov
0143497460 fix tidy 2024-04-23 17:29:10 +01:00
Alexey Katsman
ca4e2f581a Add columns for values used in the formatting message into system.text_log 2024-04-23 17:26:56 +01:00
Robert Schulze
0ae422d33c
Rename MergeTreeIndexFullText --> MergeTreeIndexBloomFilterText 2024-04-23 14:17:54 +00:00
Robert Schulze
f0faac2e8b
Move MergeTree*BloomFilter into the same header/source file 2024-04-23 14:02:26 +00:00
Alexey Petrunyaka
35d700a5af
Update generateUUIDv7.cpp small fixes for clang-tidy checks 2024-04-23 14:22:58 +03:00
Maksim Kita
7c13ea020c PlannerJoins remove unused comments 2024-04-23 14:17:30 +03:00
Dani Pozo
771219a118 Apply suggestion to use pop_back 2024-04-23 12:34:26 +02:00
Alexey Petrunyaka
9c744e50ec
Update generateUUIDv7.cpp for style check test 2024-04-23 12:55:17 +03:00
Alexey Petrunyaka
2ba6be6d8b
Small style fix in generateUUIDv7.cpp 2024-04-23 12:39:29 +03:00
Alexey Petrunyaka
447aa5bf69
Mistypes fixes in generateUUIDv7.cpp 2024-04-23 12:32:08 +03:00
Amos Bird
d44062edb2
Fix LowCardinality(Nullable) key in hyperrectangle 2024-04-23 15:24:28 +08:00
Alexey Milovidov
642da7934a
Merge pull request #62751 from ClickHouse/block-cannot-allocate-thread-fault-injection-in-transaction
Block cannot allocate thread fault in noexcept functions in `MergeTreeTransaction`
2024-04-23 02:38:46 +00:00
Alexey Milovidov
27aa03983a
Merge pull request #62840 from CurtizJ/fix-format-row
Fix crash in function `formatRow` with `JSON` format and HTTP  interface
2024-04-23 02:07:09 +00:00
Alexey Milovidov
d731838246
Merge pull request #62619 from kitaisreal/analyzer-support-qualify-clause
Analyzer support QUALIFY clause
2024-04-23 01:05:16 +00:00
Nikita Taranov
aaaff1f2ea
Merge pull request #62067 from nickitat/stronger_optimize_final_with_rmt
Wait for currently active merges when executing `OPTIMIZE FINAL` on RMT
2024-04-22 19:54:48 +00:00
Nikita Taranov
28c4ce1a67
Merge pull request #61876 from arthurpassos/forbid_attach_table_duplicated_replica_path
Do not allow table to be attached if there already is an active replica path
2024-04-22 19:44:20 +00:00
Nikita Taranov
252a82dc38 impl 2024-04-22 19:16:43 +01:00
Alexey Petrunyaka
c053d5e58e
Small fix in generateUUIDv7WithFastCounter documentation 2024-04-22 20:01:27 +03:00
Dani Pozo
c75574a1d6 Azure: fix building final url from endpoint object 2024-04-22 18:49:46 +02:00
pet74alex
142ce60b4a
Added UUIDToNum and UUDv7ToDateTime functions 2024-04-22 19:26:15 +03:00
pet74alex
d3a58ffbbd
Added generateUUIDv7* functions 2024-04-22 19:22:40 +03:00
kssenii
730995f2a4 Review suggestion 2024-04-22 13:44:36 +01:00
kssenii
4a68b2a877 Allow quota key with different auth scheme 2024-04-22 13:19:59 +01:00
Maksim Kita
0e28d20791 Fixed code review issues 2024-04-22 14:37:04 +03:00
Anton Popov
59125601a1 fix crash in function formatRow 2024-04-22 11:36:45 +00:00
Nikita Taranov
d8b3b48a25
Merge pull request #62697 from nickitat/fix_parallel_replicas_with_aggregation_by_partitions
Disable aggregation-by-partitions optimisation with parallel replicas
2024-04-22 11:02:56 +00:00
Robert Schulze
8880427817
Merge pull request #62836 from rschu1ze/fix-tybo
Fix typo
2024-04-22 10:08:51 +00:00
Robert Schulze
580a581415
Fix typo 2024-04-22 09:56:46 +00:00
Anton Popov
f29f3b9ba9
Merge pull request #62117 from pamarcos/pamarcos/copy_comment_in_create_as_statement
Copy comment when using CREATE AS statement
2024-04-22 09:52:21 +00:00
Maksim Kita
f1660fa8bb Analyzer support QUALIFY clause 2024-04-22 12:12:02 +03:00
Alexey Milovidov
5898761b58
Merge pull request #62818 from vitlibar/allow-special-macros-in-replicated-database-zk-path
Allow special macros {uuid} and {database} in a Replicated database ZooKeeper path
2024-04-21 11:32:44 +00:00
Alexey Milovidov
788e4d35ee
Merge pull request #62813 from ClickHouse/kafka-log-consumer-id-with-librdkafka-logs
Add `client.id` to librdkafka logs
2024-04-20 21:06:14 +00:00
Vitaly Baranov
79619adc6c Allow special macros {uuid} and {database} in the ZooKeeper path of a Replicated database. 2024-04-20 16:47:55 +01:00
János Benjamin Antal
e5ca964808 Add client.id to librdkafka logs 2024-04-20 10:42:27 +00:00