thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 16:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
63,598 Commits 9,168 Branches 1,781 Tags 2.1 GiB
ffdc2b22a5
Commit Graph

8501 Commits

Author SHA1 Message Date
Azat Khuzhin
f1aebbe927 Check that totals correctly calculated in 01865_aggregator_overflow_row 
Change aggregation function to uniqCombined() to check this.
 2021-05-08 20:43:01 +03:00
Maksim Kita
0a2ea38cc9
Merge pull request #23916 from azat/dict-found_rate 
Measure found rate for dictionaries
 2021-05-08 19:23:52 +03:00
Alexander Kuzmenkov
308c4657ce support longer query ids in trace log for perf tests 2021-05-08 18:20:42 +03:00
Azat Khuzhin
4cecc238d6 Fix SIGSEGV for external GROUP BY and overflow row 
Overflow row is used for GROUP BY if all of the above is true:
- WITH TOTALS is requested
- max_rows_to_group_by > 0
- group_by_overflow_mode = any
- totals_mode != after_having_exclusive

And in case of overflow row and external GROUP BY, once the temporary
file dumps to disk it resets without_key data variant to nullptr, so any
subsequent dump to disk will cause SIGSEGV.

Fix this, by recreating without_key data variant after dumping to disk,
instead of reseting to nullptr.

And also add sanity check (LOGICAL_ERROR) to make error more
deterministic in case of such error.

Found with fuzzer [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/23929/e7027e052998540ee660d186727e20f9555b729d/fuzzer_ubsan/report.html#fail1
 2021-05-08 17:48:24 +03:00
Maksim Kita
57d5f55d7f Added jit if test 2021-05-08 17:39:35 +03:00
Azat Khuzhin
bdb5dad3a3 Cover system.dictionaries.found_count 
v2: fix for ANTRL
v3: add all dictionaries layouts
 2021-05-08 17:09:01 +03:00
Maksim Kita
108c2022d9 Function arrayDifference decimal math overflow 2021-05-08 17:01:30 +03:00
Alexey Milovidov
47a4c101b9 Merge branch 'master' into normalize-bigint 2021-05-08 16:41:15 +03:00
Alexey Milovidov
b64f5b0419 Disable unreliable TestFlows 2021-05-08 16:40:54 +03:00
tavplubix
f8c7725ef5
Merge pull request #23742 from ClickHouse/update_metadata_on_replica_recovery 
Update metadata on replica recovery
 2021-05-08 16:34:03 +03:00
Maksim Kita
80dbb7ca4f
Merge pull request #23948 from azat/dict-range-min-max-check 
Check MIN/MAX attributes in the list of dictionary attributes
 2021-05-08 16:07:26 +03:00
FArthur-cmd
acb09f01d4 fixing details in code style and moving tests 2021-05-08 12:46:50 +03:00
Maksim Kita
b617c57ce8
Merge pull request #23929 from azat/dict-cache-source-dups-fix 
Fix keys metrics accounting for CACHE() dictionary with duplicates in the source
 2021-05-08 11:56:20 +03:00
FArthur-cmd
c6c80085b8 solving problem with same test naming 2021-05-08 10:15:55 +03:00
FArthur-cmd
13a6e03849 solving style-check problems 2021-05-08 10:15:14 +03:00
Azat Khuzhin
8e9655d513 Check MIN/MAX attributes in the list of dictionary attributes 
This way there will be proper exception instead of std::out_of_range
 2021-05-08 08:59:47 +03:00
Alexey Milovidov
dd4e002b5c Adjust a test after relaxed overflow checks 2021-05-08 03:38:56 +03:00
Alexey Milovidov
53637d7be0 Adjust a test after relaxed overflow checks 2021-05-08 03:38:15 +03:00
Alexey Milovidov
89d56f1668 Fix bad test 2021-05-08 03:36:28 +03:00
Alexey Milovidov
1f69f8c475 Make test for Decimal correct 2021-05-08 03:33:01 +03:00
Alexey Milovidov
e8c29bf15f Adjust test because rounding in conversion of Float to Decimal has changed 2021-05-08 03:27:23 +03:00
Alexey Milovidov
5f3377cb84 Adapt test after some overflow checks were removed 2021-05-08 03:24:56 +03:00
Alexey Milovidov
059bdd89dc Adapt test after some overflow checks were removed 2021-05-08 03:22:34 +03:00
FArthur-cmd
4ea9851e99 fixing dictionary http source by adding wrapper 2021-05-08 02:20:30 +03:00
Alexey Milovidov
e49b44a0fd Update generateRandom tests 2021-05-08 01:09:51 +03:00
Azat Khuzhin
c1b213b96e Fix 01863_dictionary_cache_duplicates under ANTLR parser 
By do not start name of table/dict from number.
 2021-05-08 00:59:55 +03:00
Kseniia Sumarokova
e6ac136c32
Merge pull request #23909 from kssenii/postgres-fixes 
Fix postgres connections issue
 2021-05-08 00:07:21 +03:00
Vladimir Chebotarev
a39314949e
Added solution for host network mode in Ubuntu 20.10+. 2021-05-07 23:36:15 +03:00
Alexey Milovidov
c404e6db2f Merge branch 'master' of github.com:yandex/ClickHouse into normalize-bigint 2021-05-07 18:25:12 +03:00
Anton Popov
01e99ab72e
Merge pull request #23871 from CurtizJ/cast-operator 
Add postgres-like cast operator
 2021-05-07 16:29:22 +03:00
Anton Popov
576728829d fix perf test 2021-05-07 16:23:46 +03:00
alexey-milovidov
fd56e0a984
Merge pull request #23919 from ucasFL/hint-enum 
Add hints for enum names
 2021-05-07 16:12:16 +03:00
kssenii
8662078b35 Review fixes 2021-05-07 09:55:18 +00:00
alexey-milovidov
617e71b3f2
Merge pull request #23704 from vzakaznikov/testflows_window_functions_tests 
TestFlows window functions tests
 2021-05-07 03:57:05 +03:00
Anton Popov
efd64c6d57 add test to skip list 2021-05-07 02:52:51 +03:00
Alexey Milovidov
ef280a2698 Update test 2021-05-07 01:47:20 +03:00
Vitaliy Zakaznikov
f067237fdd Fixing range frame tests for distributed tables. 2021-05-06 18:16:24 -04:00
Anton Popov
a8259a6158 fix perf test 2021-05-06 21:26:55 +03:00
Anton Popov
e51cd90c6f better cast operator 2021-05-06 21:21:10 +03:00
Azat Khuzhin
e7027e0529 Fix keys metrics accounting for CACHE() dictionary with duplicates in the source 2021-05-06 21:03:20 +03:00
feng lv
59f5f2d03c Add hints for enum names 
add test
 2021-05-06 14:22:54 +00:00
Maksim Kita
a979a86930
Merge pull request #23824 from kitaisreal/hashed-dictionary-complex-key-update-field-initial-load-fix 
HashedDictionary complex key update field initial load fix
 2021-05-06 17:12:04 +03:00
Vladimir Chebotarev
524113f497 Fixed bug with S3 URLs containing + symbol, data with such keys could not be read previously. 2021-05-06 11:28:55 +03:00
kssenii
8900e93bd8 New impl 2021-05-06 00:52:59 +00:00
Alexey Milovidov
a4f134fcab Update test (but not the reference) 2021-05-06 03:30:26 +03:00
Vitaliy Zakaznikov
bb2213fdac Updating range datetime tests for distributed tables. 2021-05-05 18:31:16 -04:00
Alexey Milovidov
206f9e0a4b Fix test that depends on configuration too much 2021-05-06 01:14:54 +03:00
Alexey Milovidov
d283870f3d Fix test that depends on configuration too much 2021-05-06 01:14:32 +03:00
Alexey Milovidov
8827857fc3 Fix bad test 2021-05-06 01:09:50 +03:00
Alexey Milovidov
969649c4e5 Fix bad test (tabs) 2021-05-06 01:09:50 +03:00
Alexey Milovidov
3bf9a1f5c0 Fix bad test 2021-05-06 01:09:08 +03:00
Alexey Milovidov
6959057393 Fix bad test (tabs) 2021-05-06 01:03:27 +03:00
Vitaliy Zakaznikov
75bd55073d Fixing rows frame tests for distributed tables. 2021-05-05 18:01:12 -04:00
Maksim Kita
ae47a7ccce Integration test increase wait before dictionary update 2021-05-05 23:39:40 +03:00
Vitaliy Zakaznikov
89de7c5847 Updates to tests. 2021-05-05 15:47:32 -04:00
Vitaliy Zakaznikov
0d67461f2d Updates. 2021-05-05 15:00:08 -04:00
Vitaliy Zakaznikov
ee4296510d Updates to fix more tests with distributed tables. 2021-05-05 14:34:51 -04:00
Azat Khuzhin
a958f4178b Fix test_insert_into_distributed flaps 
In [1] the order of the tests was different:

    Running pytest container as: 'docker run --net=host  --rm --name clickhouse_integration_tests --privileged         --volume=/place/sandbox-data/tasks/7/4/962738347/clickhouse-odbc-bridge:/clickhouse-odbc-bridge --volume=/place/sandbox-data/tasks/7/4/962738347/clickhouse:/clickhouse         --volume=/place/sandbox-data/tasks/7/4/962738347/clickhouse-library-bridge:/clickhouse-library-bridge --volume=/place/sandbox-data/tasks/7/4/962738347/clickhouse:/clickhouse         --volume=/place/sandbox-data/tasks/7/4/962738347/ClickHouse/programs/server:/clickhouse-config --volume=/place/sandbox-data/tasks/7/4/962738347/ClickHouse/tests/integration:/ClickHouse/tests/integration         --volume=/place/sandbox-data/tasks/7/4/962738347/ClickHouse/src/Server/grpc_protos:/ClickHouse/src/Server/grpc_protos         --volume=clickhouse_integration_tests_volume:/var/lib/docker -e DOCKER_MYSQL_GOLANG_CLIENT_TAG=latest -e DOCKER_MYSQL_JAVA_CLIENT_TAG=latest -e DOCKER_MYSQL_JS_CLIENT_TAG=latest -e DOCKER_MYSQL_PHP_CLIENT_TAG=latest -e DOCKER_POSTGRESQL_JAVA_CLIENT_TAG=latest -e DOCKER_BASE_TAG=latest -e DOCKER_KERBEROS_KDC_TAG=latest -e PYTEST_OPTS='-ss test_insert_into_distributed/test.py::test_inserts_batching test_insert_into_distributed/test.py::test_inserts_local test_insert_into_distributed/test.py::test_inserts_low_cardinality test_insert_into_distributed/test.py::test_inserts_single_replica_internal_replication test_insert_into_distributed/test.py::test_inserts_single_replica_local_internal_replication test_insert_into_distributed/test.py::test_inserts_single_replica_no_internal_replication test_insert_into_distributed/test.py::test_prefer_localhost_replica test_insert_into_distributed/test.py::test_reconnect test_insert_into_distributed/test.py::test_table_function -rfEp --color=no --durations=0 ' yandex/clickhouse-integration-tests-runner:latest '.

  [1]: https://clickhouse-test-reports.s3.yandex.net/23874/80065b08f8182936ac57408bd84492d95f2322c1/integration_tests_(asan).html#fail1

So the table should be TRUNCATEd to avoid failures in this case.
 2021-05-05 21:18:43 +03:00
Alexey Milovidov
35aba776e5 Merge branch 'master' into normalize-bigint 2021-05-05 15:01:23 +03:00
alexey-milovidov
542c940941
Merge pull request #23874 from filimonov/librdkafka161 
Update librdkafka 1.6.0-RC3 to 1.6.1
 2021-05-05 13:48:14 +03:00
alexey-milovidov
bf8c28a17f
Merge pull request #23885 from azat/dist-broken-metrics 
Add metrics for broken files during async distributed sends
 2021-05-05 13:41:15 +03:00
pingyu
46f809d07f Revert "Merge pull request #23334 from ClickHouse/revert-22609-datasketches-uniq" 
This reverts commit af2499359b, reversing
changes made to db82e9e3d5.
 2021-05-05 16:42:57 +08:00
Azat Khuzhin
74269882f7 Add broken_data_files/broken_data_compressed_bytes into distribution_queue 2021-05-04 22:48:07 +03:00
Alexey Milovidov
af41344cf5 @CurtizJ convinced me that this test has to be deleted 2021-05-04 20:59:42 +03:00
Alexey Milovidov
089027920f Fix perf test 2021-05-04 20:31:26 +03:00
Anton Popov
d4ea53f642 fix test 2021-05-04 17:28:40 +03:00
Mikhail Filimonov
80065b08f8
Revert "avoid race in librdkafka" 
This reverts commit bd8c3eb117.
 2021-05-04 10:06:33 +02:00
Anton Popov
2b79bf838f add postgres-like cast operator 2021-05-04 06:43:17 +03:00
alexey-milovidov
1862be7720
Merge pull request #23750 from azat/tests-hung-check 
clickhouse-test: send TERM to all childs (to avoid hung check triggering)
 2021-05-01 16:19:02 +03:00
Vladimir
3b7c68196b
Merge pull request #23429 from Jokser/disk-s3-restart-possibility 2021-05-01 15:28:14 +03:00
Maksim Kita
e0b74f2f85
Merge branch 'master' into hashed-dictionary-complex-key-update-field-initial-load-fix 2021-05-01 15:25:42 +03:00
Maksim Kita
a399ee88e1 Fixed test 2021-05-01 13:58:24 +03:00
alexey-milovidov
72d9e4d340
Merge pull request #23813 from nikitamikhaylov/move-partiton-lost 
Add test for #18170
 2021-05-01 11:31:36 +03:00
Azat Khuzhin
0b58a149d2 clickhouse-test: send TERM to all childs (to avoid hung check triggering) 
This is another try of not leaving child processes in clickhouse-test,
first one was in [1] by @akuzm:

  "I tried to do this earlier with a separate process group + atexit callbacks:
  573983d407 (diff-3a359de18cacf146f406a7ae332fb47196aa5e0aa430eb4b157a202a3cb8e6e3R578)

  But that commit was later reverted because it also tried to switch to
  multithreading instead of multiprocessing, and that didn't go good.
  SIG_IGN and SIG_DFL were broken then
  (https://bugs.python.org/issue23395), now they are fixed but not quite
  but maybe it's not relevant for us."

I looked (only briefly) through that bug report in python, but I don't
see any issues with killing child processes during testing this patch.

Plus to me it is better to get some unknown python error (and fix it
somehow) instead of leaving child processes.

v2: correctly catch INT/TERM/HUP too
 2021-05-01 08:46:59 +03:00
alexey-milovidov
711cc5f62b
Merge pull request #23823 from azat/tests-wait 
Improve 00840_long_concurrent_select_and_drop_deadlock
 2021-05-01 08:30:32 +03:00
alexey-milovidov
7ca42d2ce1
Merge pull request #23805 from ClickHouse/fix-hedged-requests-ext-tables 
Fix sending external table for hedged connections.
 2021-05-01 08:13:13 +03:00
Maksim Kita
3deb8cd410 HashedDictionary complex key update field initial load fix 2021-05-01 01:01:41 +03:00
Maksim Kita
fa1e9de7f7
Merge pull request #23782 from ClickHouse/merging-array-product-function 
Merging array product function
 2021-05-01 00:53:57 +03:00
Azat Khuzhin
2b7818ba6d Improve 00840_long_concurrent_select_and_drop_deadlock 
Improve waiting in the test to avoid hung check triggering [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/23744/73ab415c4c27e481cddf4d6d70b24e79fb8d8941/stress_test_(thread).html#fail1
 2021-04-30 23:50:13 +03:00
Azat Khuzhin
2cf931e08b clickhouse-test: add missing whitespace before printing database on error 2021-04-30 21:30:02 +03:00
Nikita Mikhaylov
080802e043 add test 2021-04-30 18:00:47 +03:00
Maksim Kita
14e879cef9
Merge pull request #23781 from ucasFL/fix-clear-column 
Fix CLEAR COLUMN does not work after #21303
 2021-04-30 17:28:59 +03:00
Nikolai Kochetov
352ec049ad Fix sending external table for hedged connections. 2021-04-30 17:19:48 +03:00
Nikolai Kochetov
4bb56849b3
Merge pull request #23763 from amosbird/rowfilterfix 
Fix crash when prewhere and row policy filter are both in effect with empty result
 2021-04-30 16:25:36 +03:00
Maksim Kita
44b966af5a Removed const path for arrayAggregation 2021-04-30 12:33:34 +03:00
Maksim Kita
aa71b4a6df
Merge pull request #22242 from hexiaoting/dev_arrayproduct 
Introduce arrayProduct function
 2021-04-30 09:55:21 +03:00
feng lv
aed2f337e9 Fix CLEAR COLUMN does not work after #21303 2021-04-30 05:02:32 +00:00
Pavel Kovalenko
0050dbb75b Apply disk settings on config reload. 2021-04-29 23:32:19 +03:00
Maksim Kita
c7bd69cc92
Merge pull request #23751 from azat/test_insert_into_distributed 
Improve test_insert_into_distributed
 2021-04-29 22:17:05 +03:00
alexey-milovidov
b029e9e4f6
Merge pull request #23050 from ClickHouse/remove-strange-code-fix-19283 
Remove wrong code, fix #19283
 2021-04-29 22:00:02 +03:00
Amos Bird
70ec13f3d3
Fix empty block with row_filter 2021-04-29 19:40:14 +08:00
tavplubix
1cecc0d724
Update 01184_long_insert_values_huge_strings.sh 2021-04-29 13:34:43 +03:00
Vladimir
1a8407e029
Merge pull request #23237 from vdimir/fix-join-lowcard-nullable 2021-04-29 13:18:04 +03:00
Azat Khuzhin
c4a1aa175c Improve test_insert_into_distributed 2021-04-29 10:35:09 +03:00
Maksim Kita
1db6eb3666
Merge pull request #23744 from azat/dist-INSERT-preserve-error 
Preserve errors for INSERT into Distributed
 2021-04-29 10:26:34 +03:00
alexey-milovidov
7a2f6f4277
Update 01184_long_insert_values_huge_strings.sh 2021-04-29 09:46:14 +03:00
Maksim Kita
9bf96a278d
Merge pull request #23711 from ClickHouse/remove-old-compilers 
Remove obsolete compilers
 2021-04-28 22:51:21 +03:00
Maksim Kita
1f1a443798
Merge pull request #23152 from amosbird/distributedwriteha 
Skip unavaiable replicas when writing to distributed tables
 2021-04-28 22:46:50 +03:00
Maksim Kita
4090c66e1c
Merge pull request #23722 from vdimir/odbc_test_disable_msan 
Disable test_odbc_interaction for MSan build
 2021-04-28 22:45:40 +03:00
Azat Khuzhin
73ab415c4c Preserve errors for INSERT into Distributed 
Before this patch (and after #22208) the INSERT may fail with "Cannot
schedule a task" because the pool in DistributedBlockOutputStream
already throws exception and simply fail in writeSuffix().
 2021-04-28 22:33:29 +03:00