#include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include namespace DB { namespace ErrorCodes { extern const int LOGICAL_ERROR; } namespace { struct JoinedElement { explicit JoinedElement(const ASTTablesInSelectQueryElement & table_element) : element(table_element) { if (element.table_join) join = element.table_join->as(); } void checkTableName(const DatabaseAndTableWithAlias & table, const String & current_database) const { if (!element.table_expression) throw Exception("Not a table expression in JOIN (ARRAY JOIN?)", ErrorCodes::LOGICAL_ERROR); ASTTableExpression * table_expression = element.table_expression->as(); if (!table_expression) throw Exception("Wrong table expression in JOIN", ErrorCodes::LOGICAL_ERROR); if (!table.same(DatabaseAndTableWithAlias(*table_expression, current_database))) throw Exception("Inconsistent table names", ErrorCodes::LOGICAL_ERROR); } void rewriteCommaToCross() { if (join && join->kind == ASTTableJoin::Kind::Comma) join->kind = ASTTableJoin::Kind::Cross; } bool rewriteCrossToInner(ASTPtr on_expression) { if (join->kind != ASTTableJoin::Kind::Cross) return false; join->kind = ASTTableJoin::Kind::Inner; join->strictness = ASTTableJoin::Strictness::All; join->on_expression = on_expression; join->children.push_back(join->on_expression); return true; } ASTPtr arrayJoin() const { return element.array_join; } const ASTTableJoin * tableJoin() const { return join; } bool canAttachOnExpression() const { return join && !join->on_expression; } bool hasUsing() const { return join && join->using_expression_list; } private: const ASTTablesInSelectQueryElement & element; ASTTableJoin * join = nullptr; }; bool isAllowedToRewriteCrossJoin(const ASTPtr & node, const Aliases & aliases) { if (node->as()) { auto idents = IdentifiersCollector::collect(node); for (const auto * ident : idents) { if (ident->isShort() && aliases.count(ident->shortName())) return false; } return true; } return node->as() || node->as(); } /// Return mapping table_no -> expression with expression that can be moved into JOIN ON section std::map> moveExpressionToJoinOn( const ASTPtr & ast, const std::vector & joined_tables, const std::vector & tables, const Aliases & aliases) { std::map> asts_to_join_on; for (const auto & node : collectConjunctions(ast)) { if (const auto * func = node->as(); func && func->name == NameEquals::name) { if (!func->arguments || func->arguments->children.size() != 2) return {}; /// Check if the identifiers are from different joined tables. /// If it's a self joint, tables should have aliases. auto left_table_pos = IdentifierSemantic::getIdentsMembership(func->arguments->children[0], tables, aliases); auto right_table_pos = IdentifierSemantic::getIdentsMembership(func->arguments->children[1], tables, aliases); /// Identifiers from different table move to JOIN ON if (left_table_pos && right_table_pos && *left_table_pos != *right_table_pos) { size_t table_pos = std::max(*left_table_pos, *right_table_pos); if (joined_tables[table_pos].canAttachOnExpression()) asts_to_join_on[table_pos].push_back(node); else return {}; } } if (!isAllowedToRewriteCrossJoin(node, aliases)) return {}; } return asts_to_join_on; } ASTPtr makeOnExpression(const std::vector & expressions) { if (expressions.size() == 1) return expressions[0]->clone(); std::vector arguments; arguments.reserve(expressions.size()); for (const auto & ast : expressions) arguments.emplace_back(ast->clone()); return makeASTFunction(NameAnd::name, std::move(arguments)); } bool getTables(ASTSelectQuery & select, std::vector & joined_tables, size_t & num_comma) { if (!select.tables()) return false; const auto * tables = select.tables()->as(); if (!tables) return false; size_t num_tables = tables->children.size(); if (num_tables < 2) return false; joined_tables.reserve(num_tables); size_t num_array_join = 0; size_t num_using = 0; for (const auto & child : tables->children) { auto * table_element = child->as(); if (!table_element) throw Exception("Logical error: TablesInSelectQueryElement expected", ErrorCodes::LOGICAL_ERROR); joined_tables.emplace_back(JoinedElement(*table_element)); JoinedElement & t = joined_tables.back(); if (t.arrayJoin()) { ++num_array_join; continue; } if (t.hasUsing()) { ++num_using; continue; } if (const auto * join = t.tableJoin()) { if (join->kind == ASTTableJoin::Kind::Cross || join->kind == ASTTableJoin::Kind::Comma) { if (!join->children.empty()) throw Exception("Logical error: CROSS JOIN has expressions", ErrorCodes::LOGICAL_ERROR); } if (join->kind == ASTTableJoin::Kind::Comma) ++num_comma; } } return !num_array_join && num_tables - num_using > 1; } } bool CrossToInnerJoinMatcher::needChildVisit(ASTPtr & node, const ASTPtr &) { return !node->as(); } void CrossToInnerJoinMatcher::visit(ASTPtr & ast, Data & data) { if (auto * t = ast->as()) visit(*t, ast, data); } void CrossToInnerJoinMatcher::visit(ASTSelectQuery & select, ASTPtr &, Data & data) { size_t num_comma = 0; std::vector joined_tables; if (!getTables(select, joined_tables, num_comma)) return; /// Check if joined_tables are consistent with known tables_with_columns { if (joined_tables.size() != data.tables_with_columns.size()) throw Exception("Logical error: inconsistent number of tables", ErrorCodes::LOGICAL_ERROR); for (size_t i = 0; i < joined_tables.size(); ++i) joined_tables[i].checkTableName(data.tables_with_columns[i].table, data.current_database); } /// COMMA to CROSS if (num_comma) { for (auto & table : joined_tables) table.rewriteCommaToCross(); } /// CROSS to INNER if (data.cross_to_inner_join_rewrite && select.where()) { auto asts_to_join_on = moveExpressionToJoinOn(select.where(), joined_tables, data.tables_with_columns, data.aliases); for (size_t i = 1; i < joined_tables.size(); ++i) { const auto & expr_it = asts_to_join_on.find(i); if (expr_it != asts_to_join_on.end()) { if (joined_tables[i].rewriteCrossToInner(makeOnExpression(expr_it->second))) data.done = true; } } } } }