mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-12-04 21:42:39 +00:00
118e94523c
This check suggests replacing <Container>.count() by <Container>.contains() which is more speaking and in case of multimaps/multisets also faster.
563 lines
19 KiB
C++
563 lines
19 KiB
C++
#include <Coordination/KeeperSnapshotManager.h>
|
|
#include <IO/WriteHelpers.h>
|
|
#include <Compression/CompressedReadBuffer.h>
|
|
#include <Compression/CompressedWriteBuffer.h>
|
|
#include <IO/ReadHelpers.h>
|
|
#include <Common/ZooKeeper/ZooKeeperIO.h>
|
|
#include <Coordination/ReadBufferFromNuraftBuffer.h>
|
|
#include <Coordination/WriteBufferFromNuraftBuffer.h>
|
|
#include <IO/WriteBufferFromFile.h>
|
|
#include <IO/ReadBufferFromFile.h>
|
|
#include <IO/copyData.h>
|
|
#include <Coordination/pathUtils.h>
|
|
#include <filesystem>
|
|
#include <memory>
|
|
|
|
namespace DB
|
|
{
|
|
|
|
namespace ErrorCodes
|
|
{
|
|
extern const int UNKNOWN_FORMAT_VERSION;
|
|
extern const int UNKNOWN_SNAPSHOT;
|
|
}
|
|
|
|
namespace
|
|
{
|
|
uint64_t getSnapshotPathUpToLogIdx(const String & snapshot_path)
|
|
{
|
|
std::filesystem::path path(snapshot_path);
|
|
std::string filename = path.stem();
|
|
Strings name_parts;
|
|
splitInto<'_'>(name_parts, filename);
|
|
return parse<uint64_t>(name_parts[1]);
|
|
}
|
|
|
|
std::string getSnapshotFileName(uint64_t up_to_log_idx, bool compress_zstd)
|
|
{
|
|
auto base = std::string{"snapshot_"} + std::to_string(up_to_log_idx) + ".bin";
|
|
if (compress_zstd)
|
|
base += ".zstd";
|
|
return base;
|
|
}
|
|
|
|
void writeNode(const KeeperStorage::Node & node, SnapshotVersion version, WriteBuffer & out)
|
|
{
|
|
writeBinary(node.getData(), out);
|
|
|
|
/// Serialize ACL
|
|
writeBinary(node.acl_id, out);
|
|
writeBinary(node.is_sequental, out);
|
|
/// Serialize stat
|
|
writeBinary(node.stat.czxid, out);
|
|
writeBinary(node.stat.mzxid, out);
|
|
writeBinary(node.stat.ctime, out);
|
|
writeBinary(node.stat.mtime, out);
|
|
writeBinary(node.stat.version, out);
|
|
writeBinary(node.stat.cversion, out);
|
|
writeBinary(node.stat.aversion, out);
|
|
writeBinary(node.stat.ephemeralOwner, out);
|
|
writeBinary(node.stat.dataLength, out);
|
|
writeBinary(node.stat.numChildren, out);
|
|
writeBinary(node.stat.pzxid, out);
|
|
|
|
writeBinary(node.seq_num, out);
|
|
|
|
if (version >= SnapshotVersion::V4)
|
|
{
|
|
writeBinary(node.size_bytes, out);
|
|
}
|
|
}
|
|
|
|
void readNode(KeeperStorage::Node & node, ReadBuffer & in, SnapshotVersion version, ACLMap & acl_map)
|
|
{
|
|
String new_data;
|
|
readBinary(new_data, in);
|
|
node.setData(std::move(new_data));
|
|
|
|
if (version >= SnapshotVersion::V1)
|
|
{
|
|
readBinary(node.acl_id, in);
|
|
}
|
|
else if (version == SnapshotVersion::V0)
|
|
{
|
|
/// Deserialize ACL
|
|
size_t acls_size;
|
|
readBinary(acls_size, in);
|
|
Coordination::ACLs acls;
|
|
for (size_t i = 0; i < acls_size; ++i)
|
|
{
|
|
Coordination::ACL acl;
|
|
readBinary(acl.permissions, in);
|
|
readBinary(acl.scheme, in);
|
|
readBinary(acl.id, in);
|
|
acls.push_back(acl);
|
|
}
|
|
node.acl_id = acl_map.convertACLs(acls);
|
|
}
|
|
|
|
/// Some strange ACLID during deserialization from ZooKeeper
|
|
if (node.acl_id == std::numeric_limits<uint64_t>::max())
|
|
node.acl_id = 0;
|
|
|
|
acl_map.addUsage(node.acl_id);
|
|
|
|
readBinary(node.is_sequental, in);
|
|
|
|
/// Deserialize stat
|
|
readBinary(node.stat.czxid, in);
|
|
readBinary(node.stat.mzxid, in);
|
|
readBinary(node.stat.ctime, in);
|
|
readBinary(node.stat.mtime, in);
|
|
readBinary(node.stat.version, in);
|
|
readBinary(node.stat.cversion, in);
|
|
readBinary(node.stat.aversion, in);
|
|
readBinary(node.stat.ephemeralOwner, in);
|
|
readBinary(node.stat.dataLength, in);
|
|
readBinary(node.stat.numChildren, in);
|
|
readBinary(node.stat.pzxid, in);
|
|
readBinary(node.seq_num, in);
|
|
|
|
if (version >= SnapshotVersion::V4)
|
|
{
|
|
readBinary(node.size_bytes, in);
|
|
}
|
|
}
|
|
|
|
void serializeSnapshotMetadata(const SnapshotMetadataPtr & snapshot_meta, WriteBuffer & out)
|
|
{
|
|
auto buffer = snapshot_meta->serialize();
|
|
writeVarUInt(buffer->size(), out);
|
|
out.write(reinterpret_cast<const char *>(buffer->data_begin()), buffer->size());
|
|
}
|
|
|
|
SnapshotMetadataPtr deserializeSnapshotMetadata(ReadBuffer & in)
|
|
{
|
|
size_t data_size;
|
|
readVarUInt(data_size, in);
|
|
auto buffer = nuraft::buffer::alloc(data_size);
|
|
in.readStrict(reinterpret_cast<char *>(buffer->data_begin()), data_size);
|
|
buffer->pos(0);
|
|
return SnapshotMetadata::deserialize(*buffer);
|
|
}
|
|
}
|
|
|
|
|
|
void KeeperStorageSnapshot::serialize(const KeeperStorageSnapshot & snapshot, WriteBuffer & out)
|
|
{
|
|
writeBinary(static_cast<uint8_t>(snapshot.version), out);
|
|
serializeSnapshotMetadata(snapshot.snapshot_meta, out);
|
|
writeBinary(snapshot.session_id, out);
|
|
|
|
/// Serialize ACLs MAP
|
|
writeBinary(snapshot.acl_map.size(), out);
|
|
for (const auto & [acl_id, acls] : snapshot.acl_map)
|
|
{
|
|
writeBinary(acl_id, out);
|
|
writeBinary(acls.size(), out);
|
|
for (const auto & acl : acls)
|
|
{
|
|
writeBinary(acl.permissions, out);
|
|
writeBinary(acl.scheme, out);
|
|
writeBinary(acl.id, out);
|
|
}
|
|
}
|
|
|
|
/// Serialize data tree
|
|
writeBinary(snapshot.snapshot_container_size, out);
|
|
size_t counter = 0;
|
|
for (auto it = snapshot.begin; counter < snapshot.snapshot_container_size; ++counter)
|
|
{
|
|
const auto & path = it->key;
|
|
const auto & node = it->value;
|
|
/// Benign race condition possible while taking snapshot: NuRaft decide to create snapshot at some log id
|
|
/// and only after some time we lock storage and enable snapshot mode. So snapshot_container_size can be
|
|
/// slightly bigger than required.
|
|
if (static_cast<size_t>(node.stat.mzxid) > snapshot.snapshot_meta->get_last_log_idx())
|
|
break;
|
|
|
|
writeBinary(path, out);
|
|
writeNode(node, snapshot.version, out);
|
|
|
|
/// Last iteration: check and exit here without iterator increment. Otherwise
|
|
/// false positive race condition on list end is possible.
|
|
if (counter == snapshot.snapshot_container_size - 1)
|
|
break;
|
|
|
|
++it;
|
|
}
|
|
|
|
/// Serialize sessions
|
|
size_t size = snapshot.session_and_timeout.size();
|
|
writeBinary(size, out);
|
|
for (const auto & [session_id, timeout] : snapshot.session_and_timeout)
|
|
{
|
|
writeBinary(session_id, out);
|
|
writeBinary(timeout, out);
|
|
|
|
KeeperStorage::AuthIDs ids;
|
|
if (snapshot.session_and_auth.contains(session_id))
|
|
ids = snapshot.session_and_auth.at(session_id);
|
|
|
|
writeBinary(ids.size(), out);
|
|
for (const auto & [scheme, id] : ids)
|
|
{
|
|
writeBinary(scheme, out);
|
|
writeBinary(id, out);
|
|
}
|
|
}
|
|
|
|
/// Serialize cluster config
|
|
if (snapshot.cluster_config)
|
|
{
|
|
auto buffer = snapshot.cluster_config->serialize();
|
|
writeVarUInt(buffer->size(), out);
|
|
out.write(reinterpret_cast<const char *>(buffer->data_begin()), buffer->size());
|
|
}
|
|
}
|
|
|
|
void KeeperStorageSnapshot::deserialize(SnapshotDeserializationResult & deserialization_result, ReadBuffer & in)
|
|
{
|
|
uint8_t version;
|
|
readBinary(version, in);
|
|
SnapshotVersion current_version = static_cast<SnapshotVersion>(version);
|
|
if (current_version > CURRENT_SNAPSHOT_VERSION)
|
|
throw Exception(ErrorCodes::UNKNOWN_FORMAT_VERSION, "Unsupported snapshot version {}", version);
|
|
|
|
deserialization_result.snapshot_meta = deserializeSnapshotMetadata(in);
|
|
KeeperStorage & storage = *deserialization_result.storage;
|
|
|
|
int64_t session_id;
|
|
readBinary(session_id, in);
|
|
|
|
storage.zxid = deserialization_result.snapshot_meta->get_last_log_idx();
|
|
storage.session_id_counter = session_id;
|
|
|
|
/// Before V1 we serialized ACL without acl_map
|
|
if (current_version >= SnapshotVersion::V1)
|
|
{
|
|
size_t acls_map_size;
|
|
|
|
readBinary(acls_map_size, in);
|
|
size_t current_map_size = 0;
|
|
while (current_map_size < acls_map_size)
|
|
{
|
|
uint64_t acl_id;
|
|
readBinary(acl_id, in);
|
|
|
|
size_t acls_size;
|
|
readBinary(acls_size, in);
|
|
Coordination::ACLs acls;
|
|
for (size_t i = 0; i < acls_size; ++i)
|
|
{
|
|
Coordination::ACL acl;
|
|
readBinary(acl.permissions, in);
|
|
readBinary(acl.scheme, in);
|
|
readBinary(acl.id, in);
|
|
acls.push_back(acl);
|
|
}
|
|
storage.acl_map.addMapping(acl_id, acls);
|
|
current_map_size++;
|
|
}
|
|
}
|
|
|
|
size_t snapshot_container_size;
|
|
readBinary(snapshot_container_size, in);
|
|
|
|
size_t current_size = 0;
|
|
while (current_size < snapshot_container_size)
|
|
{
|
|
std::string path;
|
|
readBinary(path, in);
|
|
KeeperStorage::Node node{};
|
|
readNode(node, in, current_version, storage.acl_map);
|
|
storage.container.insertOrReplace(path, node);
|
|
if (node.stat.ephemeralOwner != 0)
|
|
storage.ephemerals[node.stat.ephemeralOwner].insert(path);
|
|
|
|
current_size++;
|
|
}
|
|
|
|
for (const auto & itr : storage.container)
|
|
{
|
|
if (itr.key != "/")
|
|
{
|
|
auto parent_path = parentPath(itr.key);
|
|
storage.container.updateValue(parent_path, [path = itr.key] (KeeperStorage::Node & value) { value.addChild(getBaseName(path)); });
|
|
}
|
|
}
|
|
|
|
size_t active_sessions_size;
|
|
readBinary(active_sessions_size, in);
|
|
|
|
size_t current_session_size = 0;
|
|
while (current_session_size < active_sessions_size)
|
|
{
|
|
int64_t active_session_id, timeout;
|
|
readBinary(active_session_id, in);
|
|
readBinary(timeout, in);
|
|
storage.addSessionID(active_session_id, timeout);
|
|
|
|
if (current_version >= SnapshotVersion::V1)
|
|
{
|
|
size_t session_auths_size;
|
|
readBinary(session_auths_size, in);
|
|
|
|
KeeperStorage::AuthIDs ids;
|
|
size_t session_auth_counter = 0;
|
|
while (session_auth_counter < session_auths_size)
|
|
{
|
|
String scheme, id;
|
|
readBinary(scheme, in);
|
|
readBinary(id, in);
|
|
ids.emplace_back(KeeperStorage::AuthID{scheme, id});
|
|
|
|
session_auth_counter++;
|
|
}
|
|
if (!ids.empty())
|
|
storage.session_and_auth[active_session_id] = ids;
|
|
}
|
|
current_session_size++;
|
|
}
|
|
|
|
/// Optional cluster config
|
|
ClusterConfigPtr cluster_config = nullptr;
|
|
if (!in.eof())
|
|
{
|
|
size_t data_size;
|
|
readVarUInt(data_size, in);
|
|
auto buffer = nuraft::buffer::alloc(data_size);
|
|
in.readStrict(reinterpret_cast<char *>(buffer->data_begin()), data_size);
|
|
buffer->pos(0);
|
|
deserialization_result.cluster_config = ClusterConfig::deserialize(*buffer);
|
|
}
|
|
}
|
|
|
|
KeeperStorageSnapshot::KeeperStorageSnapshot(KeeperStorage * storage_, uint64_t up_to_log_idx_, const ClusterConfigPtr & cluster_config_)
|
|
: storage(storage_)
|
|
, snapshot_meta(std::make_shared<SnapshotMetadata>(up_to_log_idx_, 0, std::make_shared<nuraft::cluster_config>()))
|
|
, session_id(storage->session_id_counter)
|
|
, cluster_config(cluster_config_)
|
|
{
|
|
auto [size, ver] = storage->container.snapshotSizeWithVersion();
|
|
snapshot_container_size = size;
|
|
storage->enableSnapshotMode(ver);
|
|
begin = storage->getSnapshotIteratorBegin();
|
|
session_and_timeout = storage->getActiveSessions();
|
|
acl_map = storage->acl_map.getMapping();
|
|
session_and_auth = storage->session_and_auth;
|
|
}
|
|
|
|
KeeperStorageSnapshot::KeeperStorageSnapshot(KeeperStorage * storage_, const SnapshotMetadataPtr & snapshot_meta_, const ClusterConfigPtr & cluster_config_)
|
|
: storage(storage_)
|
|
, snapshot_meta(snapshot_meta_)
|
|
, session_id(storage->session_id_counter)
|
|
, cluster_config(cluster_config_)
|
|
{
|
|
auto [size, ver] = storage->container.snapshotSizeWithVersion();
|
|
snapshot_container_size = size;
|
|
storage->enableSnapshotMode(ver);
|
|
begin = storage->getSnapshotIteratorBegin();
|
|
session_and_timeout = storage->getActiveSessions();
|
|
acl_map = storage->acl_map.getMapping();
|
|
session_and_auth = storage->session_and_auth;
|
|
}
|
|
|
|
KeeperStorageSnapshot::~KeeperStorageSnapshot()
|
|
{
|
|
storage->disableSnapshotMode();
|
|
}
|
|
|
|
KeeperSnapshotManager::KeeperSnapshotManager(
|
|
const std::string & snapshots_path_, size_t snapshots_to_keep_,
|
|
bool compress_snapshots_zstd_,
|
|
const std::string & superdigest_, size_t storage_tick_time_)
|
|
: snapshots_path(snapshots_path_)
|
|
, snapshots_to_keep(snapshots_to_keep_)
|
|
, compress_snapshots_zstd(compress_snapshots_zstd_)
|
|
, superdigest(superdigest_)
|
|
, storage_tick_time(storage_tick_time_)
|
|
{
|
|
namespace fs = std::filesystem;
|
|
|
|
if (!fs::exists(snapshots_path))
|
|
fs::create_directories(snapshots_path);
|
|
|
|
for (const auto & p : fs::directory_iterator(snapshots_path))
|
|
{
|
|
const auto & path = p.path();
|
|
|
|
if (!path.has_filename())
|
|
continue;
|
|
|
|
if (startsWith(path.filename(), "tmp_")) /// Unfinished tmp files
|
|
{
|
|
std::filesystem::remove(p);
|
|
continue;
|
|
}
|
|
|
|
/// Not snapshot file
|
|
if (!startsWith(path.filename(), "snapshot_"))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
size_t snapshot_up_to = getSnapshotPathUpToLogIdx(p.path());
|
|
existing_snapshots[snapshot_up_to] = p.path();
|
|
}
|
|
|
|
removeOutdatedSnapshotsIfNeeded();
|
|
}
|
|
|
|
|
|
std::string KeeperSnapshotManager::serializeSnapshotBufferToDisk(nuraft::buffer & buffer, uint64_t up_to_log_idx)
|
|
{
|
|
ReadBufferFromNuraftBuffer reader(buffer);
|
|
|
|
auto snapshot_file_name = getSnapshotFileName(up_to_log_idx, compress_snapshots_zstd);
|
|
auto tmp_snapshot_file_name = "tmp_" + snapshot_file_name;
|
|
std::string tmp_snapshot_path = std::filesystem::path{snapshots_path} / tmp_snapshot_file_name;
|
|
std::string new_snapshot_path = std::filesystem::path{snapshots_path} / snapshot_file_name;
|
|
|
|
WriteBufferFromFile plain_buf(tmp_snapshot_path);
|
|
copyData(reader, plain_buf);
|
|
plain_buf.sync();
|
|
|
|
std::filesystem::rename(tmp_snapshot_path, new_snapshot_path);
|
|
|
|
existing_snapshots.emplace(up_to_log_idx, new_snapshot_path);
|
|
removeOutdatedSnapshotsIfNeeded();
|
|
|
|
return new_snapshot_path;
|
|
}
|
|
|
|
nuraft::ptr<nuraft::buffer> KeeperSnapshotManager::deserializeLatestSnapshotBufferFromDisk()
|
|
{
|
|
while (!existing_snapshots.empty())
|
|
{
|
|
auto latest_itr = existing_snapshots.rbegin();
|
|
try
|
|
{
|
|
return deserializeSnapshotBufferFromDisk(latest_itr->first);
|
|
}
|
|
catch (const DB::Exception &)
|
|
{
|
|
std::filesystem::remove(latest_itr->second);
|
|
existing_snapshots.erase(latest_itr->first);
|
|
tryLogCurrentException(__PRETTY_FUNCTION__);
|
|
}
|
|
}
|
|
|
|
return nullptr;
|
|
}
|
|
|
|
nuraft::ptr<nuraft::buffer> KeeperSnapshotManager::deserializeSnapshotBufferFromDisk(uint64_t up_to_log_idx) const
|
|
{
|
|
const std::string & snapshot_path = existing_snapshots.at(up_to_log_idx);
|
|
WriteBufferFromNuraftBuffer writer;
|
|
ReadBufferFromFile reader(snapshot_path);
|
|
copyData(reader, writer);
|
|
return writer.getBuffer();
|
|
}
|
|
|
|
nuraft::ptr<nuraft::buffer> KeeperSnapshotManager::serializeSnapshotToBuffer(const KeeperStorageSnapshot & snapshot) const
|
|
{
|
|
std::unique_ptr<WriteBufferFromNuraftBuffer> writer = std::make_unique<WriteBufferFromNuraftBuffer>();
|
|
auto * buffer_raw_ptr = writer.get();
|
|
std::unique_ptr<WriteBuffer> compressed_writer;
|
|
if (compress_snapshots_zstd)
|
|
compressed_writer = wrapWriteBufferWithCompressionMethod(std::move(writer), CompressionMethod::Zstd, 3);
|
|
else
|
|
compressed_writer = std::make_unique<CompressedWriteBuffer>(*writer);
|
|
|
|
KeeperStorageSnapshot::serialize(snapshot, *compressed_writer);
|
|
compressed_writer->finalize();
|
|
return buffer_raw_ptr->getBuffer();
|
|
}
|
|
|
|
|
|
bool KeeperSnapshotManager::isZstdCompressed(nuraft::ptr<nuraft::buffer> buffer)
|
|
{
|
|
static constexpr uint32_t ZSTD_COMPRESSED_MAGIC = 0xFD2FB528;
|
|
ReadBufferFromNuraftBuffer reader(buffer);
|
|
uint32_t magic_from_buffer;
|
|
reader.readStrict(reinterpret_cast<char *>(&magic_from_buffer), sizeof(magic_from_buffer));
|
|
buffer->pos(0);
|
|
return magic_from_buffer == ZSTD_COMPRESSED_MAGIC;
|
|
}
|
|
|
|
SnapshotDeserializationResult KeeperSnapshotManager::deserializeSnapshotFromBuffer(nuraft::ptr<nuraft::buffer> buffer) const
|
|
{
|
|
bool is_zstd_compressed = isZstdCompressed(buffer);
|
|
|
|
std::unique_ptr<ReadBufferFromNuraftBuffer> reader = std::make_unique<ReadBufferFromNuraftBuffer>(buffer);
|
|
std::unique_ptr<ReadBuffer> compressed_reader;
|
|
|
|
if (is_zstd_compressed)
|
|
compressed_reader = wrapReadBufferWithCompressionMethod(std::move(reader), CompressionMethod::Zstd);
|
|
else
|
|
compressed_reader = std::make_unique<CompressedReadBuffer>(*reader);
|
|
|
|
SnapshotDeserializationResult result;
|
|
result.storage = std::make_unique<KeeperStorage>(storage_tick_time, superdigest);
|
|
KeeperStorageSnapshot::deserialize(result, *compressed_reader);
|
|
return result;
|
|
}
|
|
|
|
SnapshotDeserializationResult KeeperSnapshotManager::restoreFromLatestSnapshot()
|
|
{
|
|
if (existing_snapshots.empty())
|
|
return {};
|
|
|
|
auto buffer = deserializeLatestSnapshotBufferFromDisk();
|
|
if (!buffer)
|
|
return {};
|
|
return deserializeSnapshotFromBuffer(buffer);
|
|
}
|
|
|
|
void KeeperSnapshotManager::removeOutdatedSnapshotsIfNeeded()
|
|
{
|
|
while (existing_snapshots.size() > snapshots_to_keep)
|
|
removeSnapshot(existing_snapshots.begin()->first);
|
|
}
|
|
|
|
void KeeperSnapshotManager::removeSnapshot(uint64_t log_idx)
|
|
{
|
|
auto itr = existing_snapshots.find(log_idx);
|
|
if (itr == existing_snapshots.end())
|
|
throw Exception(ErrorCodes::UNKNOWN_SNAPSHOT, "Unknown snapshot with log index {}", log_idx);
|
|
std::filesystem::remove(itr->second);
|
|
existing_snapshots.erase(itr);
|
|
}
|
|
|
|
std::pair<std::string, std::error_code> KeeperSnapshotManager::serializeSnapshotToDisk(const KeeperStorageSnapshot & snapshot)
|
|
{
|
|
auto up_to_log_idx = snapshot.snapshot_meta->get_last_log_idx();
|
|
auto snapshot_file_name = getSnapshotFileName(up_to_log_idx, compress_snapshots_zstd);
|
|
auto tmp_snapshot_file_name = "tmp_" + snapshot_file_name;
|
|
std::string tmp_snapshot_path = std::filesystem::path{snapshots_path} / tmp_snapshot_file_name;
|
|
std::string new_snapshot_path = std::filesystem::path{snapshots_path} / snapshot_file_name;
|
|
|
|
auto writer = std::make_unique<WriteBufferFromFile>(tmp_snapshot_path, O_WRONLY | O_TRUNC | O_CREAT | O_CLOEXEC| O_APPEND);
|
|
std::unique_ptr<WriteBuffer> compressed_writer;
|
|
if (compress_snapshots_zstd)
|
|
compressed_writer = wrapWriteBufferWithCompressionMethod(std::move(writer), CompressionMethod::Zstd, 3);
|
|
else
|
|
compressed_writer = std::make_unique<CompressedWriteBuffer>(*writer);
|
|
|
|
KeeperStorageSnapshot::serialize(snapshot, *compressed_writer);
|
|
compressed_writer->finalize();
|
|
compressed_writer->sync();
|
|
|
|
std::error_code ec;
|
|
std::filesystem::rename(tmp_snapshot_path, new_snapshot_path, ec);
|
|
if (!ec)
|
|
{
|
|
existing_snapshots.emplace(up_to_log_idx, new_snapshot_path);
|
|
removeOutdatedSnapshotsIfNeeded();
|
|
}
|
|
return {new_snapshot_path, ec};
|
|
}
|
|
|
|
}
|