mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-11-18 05:32:52 +00:00
42af45b2ba
This should fix the following SIGSEGV, that was found on CI [1]:
<Fatal> BaseDaemon: Address: NULL pointer. Access: read. Unknown si_code.
<Fatal> BaseDaemon: 4.4. inlined from ../contrib/rocksdb/utilities/object_registry.cc:19: rocksdb::ObjectLibrary::FindEntry() const
...
<Fatal> BaseDaemon: 7.3. inlined from ../contrib/rocksdb/options/cf_options.cc:678: rocksdb::$_7::operator()()
[1]: https://clickhouse-test-reports.s3.yandex.net/29341/2b2bec3679df7965af908ce3f1e8e17e39bd12fe/integration_tests_flaky_check_(asan).html#fail1
And also I checked manually with TSan binary, and here is a data race
reported by TSan:
WARNING: ThreadSanitizer: data race (pid=3356)
Read of size 8 at 0x7b0c0008cca8 by thread T40:
2 rocksdb::ObjectLibrary::FindEntry() const obj-x86_64-linux-gnu/../contrib/rocksdb/utilities/object_registry.cc:18:27 (clickhouse-tsan+0x1b839a6c)
...
6 rocksdb::$_7::operator()() const obj-x86_64-linux-gnu/../contrib/rocksdb/options/cf_options.cc:676:32 (clickhouse-tsan+0x1b6bfa63)
...
28 rocksdb::GetColumnFamilyOptionsFromMap() obj-x86_64-linux-gnu/../contrib/rocksdb/options/options_helper.cc:727:10 (clickhouse-tsan+0x1b6fffd2)
29 DB::StorageEmbeddedRocksDB::initDb() obj-x86_64-linux-gnu/../src/Storages/RocksDB/StorageEmbeddedRocksDB.cpp:359:26 (clickhouse-tsan+0x14195e31)
...
Previous write of size 8 at 0x7b0c0008cca8 by thread T41:
...
9 rocksdb::ObjectLibrary::AddEntry() obj-x86_64-linux-gnu/../contrib/rocksdb/utilities/object_registry.cc:31:19 (clickhouse-tsan+0x1b8392fc)
...
11 rocksdb::RegisterTableFactories()::$_0::operator()() const obj-x86_64-linux-gnu/../contrib/rocksdb/table/table_factory.cc:23:14 (clickhouse-tsan+0x1b7ea94c)
...
43 rocksdb::GetColumnFamilyOptionsFromMap() obj-x86_64-linux-gnu/../contrib/rocksdb/options/options_helper.cc:727:10 (clickhouse-tsan+0x1b6fffd2)
44 DB::StorageEmbeddedRocksDB::initDb() obj-x86_64-linux-gnu/../src/Storages/RocksDB/StorageEmbeddedRocksDB.cpp:359:26 (clickhouse-tsan+0x14195e31)
Refs: https://github.com/ClickHouse-Extras/rocksdb/pull/13
Fixes: #29341
|
||
|---|---|---|
| .. | ||
| abseil-cpp@b004a8a024 | ||
| abseil-cpp-cmake | ||
| AMQP-CPP@1a6c51f4ac | ||
| amqpcpp-cmake | ||
| arrow@078e21bad3 | ||
| arrow-cmake | ||
| avro@e43c46e87f | ||
| avro-cmake | ||
| aws@06aa8759d1 | ||
| aws-c-common@736a82d169 | ||
| aws-c-event-stream@3bc33662f9 | ||
| aws-checksums@519d6d9093 | ||
| aws-s3-cmake | ||
| base64@af9b331f2b | ||
| base64-cmake | ||
| boost@66d17f060c | ||
| boost-cmake | ||
| boringssl@a6a2e2ab3e | ||
| boringssl-cmake | ||
| brotli@63be8a9940 | ||
| brotli-cmake | ||
| bzip2@bf905ea225 | ||
| bzip2-cmake | ||
| capnproto@a00ccd91b3 | ||
| capnproto-cmake | ||
| cassandra@eb9b68dadb | ||
| cctz@c0f1bcb97f | ||
| cctz-cmake | ||
| cityhash102 | ||
| consistent-hashing | ||
| cppkafka@5a119f689f | ||
| cppkafka-cmake | ||
| croaring@2c867e9f9c | ||
| croaring-cmake | ||
| curl@3b8bbbbd16 | ||
| curl-cmake | ||
| cyrus-sasl@e6466edfd6 | ||
| cyrus-sasl-cmake | ||
| datasketches-cpp@7d73d7610d | ||
| double-conversion@cf2f0f3d54 | ||
| double-conversion-cmake | ||
| dragonbox@923705af6f | ||
| dragonbox-cmake | ||
| fast_float@7eae925b51 | ||
| fastops@012b777df9 | ||
| fastops-cmake | ||
| flatbuffers@eb3f827948 | ||
| fmtlib@c108ee1d59 | ||
| fmtlib-cmake | ||
| gcem@8d4f1b5d76 | ||
| googletest@e7e591764b | ||
| grpc@60c986e15c | ||
| grpc-cmake | ||
| h3@c7f46cfd71 | ||
| h3-cmake | ||
| hyperscan@e9f08df021 | ||
| hyperscan-cmake | ||
| icu@faa2f9f9e1 | ||
| icu-cmake | ||
| icudata@f020820388 | ||
| jemalloc@e6891d9746 | ||
| jemalloc-cmake | ||
| krb5@5149dea4e2 | ||
| krb5-cmake | ||
| lemmagen-c@59537bdcf5 | ||
| lemmagen-c-cmake | ||
| libc-headers@a720b7105a | ||
| libcpuid@8db3b8d2d3 | ||
| libcpuid-cmake | ||
| libcxx@2fa892f69a | ||
| libcxx-cmake | ||
| libcxxabi@df8f1e727d | ||
| libcxxabi-cmake | ||
| libdivide | ||
| libfarmhash | ||
| libgsasl@383ee28e82 | ||
| libhdfs3@082e55f17d | ||
| libhdfs3-cmake | ||
| libmetrohash | ||
| libpq@e071ea570f | ||
| libpq-cmake | ||
| libpqxx@357608d11b | ||
| libpqxx-cmake | ||
| librdkafka@b8554f1682 | ||
| librdkafka-cmake | ||
| libstemmer_c@c753054304 | ||
| libstemmer-c-cmake | ||
| libunwind@c4ea9848a6 | ||
| libunwind-cmake | ||
| libuv@e2e9b7e9f9 | ||
| libxml2@18890f471c | ||
| libxml2-cmake | ||
| llvm@f30bbecef7 | ||
| lz4@f39b79fb02 | ||
| lz4-cmake | ||
| magic_enum@38f86e4d09 | ||
| magic-enum-cmake | ||
| mariadb-connector-c@5f4034a3a6 | ||
| miniselect@be0af6bd0b | ||
| msgpack-c@46684265d5 | ||
| murmurhash | ||
| nanodbc@df52a1232d | ||
| nanodbc-cmake | ||
| NuRaft@7ecb16844a | ||
| nuraft-cmake | ||
| openldap@0208811b60 | ||
| openldap-cmake | ||
| orc@0a936f6bbd | ||
| pdqsort | ||
| poco@46c80daf1b | ||
| poco-cmake | ||
| protobuf@75601841d1 | ||
| protobuf-cmake | ||
| rapidjson@c4ef90ccdb | ||
| re2@13ebb377c6 | ||
| re2_st | ||
| replxx@f97765df14 | ||
| replxx-cmake | ||
| rocksdb@296c1b8b95 | ||
| rocksdb-cmake | ||
| s2geometry@20ea540d81 | ||
| s2geometry-cmake | ||
| sentry-native@94644e92f0 | ||
| simdjson@8df32cea33 | ||
| simdjson-cmake | ||
| snappy@3f194acb57 | ||
| sparsehash-c11@cf0bffaa45 | ||
| sqlite-amalgamation@9818baa5d0 | ||
| sqlite-cmake | ||
| stats@b6dd459c10 | ||
| stats-cmake | ||
| thrift@010ccf0a0c | ||
| unixodbc@b0ad30f7f6 | ||
| unixodbc-cmake | ||
| wordnet-blast@1d16ac2803 | ||
| wordnet-blast-cmake | ||
| xz@869b9d1b4e | ||
| yaml-cpp@0c86adac6d | ||
| yaml-cpp-cmake | ||
| zlib-ng@6a5e93b900 | ||
| zstd@a488ba114e | ||
| zstd-cmake | ||
| CMakeLists.txt | ||