ClickHouse/src/Interpreters/parseColumnsListForTableFunction.cpp
Kruglov Pavel 70bb85a754
Merge pull request #61999 from Avogar/variant-number-bool
Don't treat Bool and number variants as suspicious in Variant type
2024-03-28 14:33:24 +01:00

170 lines
7.0 KiB
C++

#include <DataTypes/DataTypeFixedString.h>
#include <DataTypes/DataTypeLowCardinality.h>
#include <DataTypes/DataTypeNullable.h>
#include <DataTypes/DataTypeVariant.h>
#include <DataTypes/getLeastSupertype.h>
#include <Interpreters/Context.h>
#include <Interpreters/InterpreterCreateQuery.h>
#include <Interpreters/parseColumnsListForTableFunction.h>
#include <Parsers/ASTExpressionList.h>
#include <Parsers/ParserCreateQuery.h>
#include <Parsers/parseQuery.h>
namespace DB
{
namespace ErrorCodes
{
extern const int LOGICAL_ERROR;
extern const int SUSPICIOUS_TYPE_FOR_LOW_CARDINALITY;
extern const int ILLEGAL_COLUMN;
}
void validateDataType(const DataTypePtr & type_to_check, const DataTypeValidationSettings & settings)
{
auto validate_callback = [&](const IDataType & data_type)
{
if (!settings.allow_suspicious_low_cardinality_types)
{
if (const auto * lc_type = typeid_cast<const DataTypeLowCardinality *>(&data_type))
{
if (!isStringOrFixedString(*removeNullable(lc_type->getDictionaryType())))
throw Exception(
ErrorCodes::SUSPICIOUS_TYPE_FOR_LOW_CARDINALITY,
"Creating columns of type {} is prohibited by default due to expected negative impact on performance. "
"It can be enabled with the \"allow_suspicious_low_cardinality_types\" setting.",
lc_type->getName());
}
}
if (!settings.allow_experimental_object_type)
{
if (data_type.hasDynamicSubcolumns())
{
throw Exception(
ErrorCodes::ILLEGAL_COLUMN,
"Cannot create column with type '{}' because experimental Object type is not allowed. "
"Set setting allow_experimental_object_type = 1 in order to allow it",
data_type.getName());
}
}
if (!settings.allow_suspicious_fixed_string_types)
{
if (const auto * fixed_string = typeid_cast<const DataTypeFixedString *>(&data_type))
{
if (fixed_string->getN() > MAX_FIXEDSTRING_SIZE_WITHOUT_SUSPICIOUS)
throw Exception(
ErrorCodes::ILLEGAL_COLUMN,
"Cannot create column with type '{}' because fixed string with size > {} is suspicious. "
"Set setting allow_suspicious_fixed_string_types = 1 in order to allow it",
data_type.getName(),
MAX_FIXEDSTRING_SIZE_WITHOUT_SUSPICIOUS);
}
}
if (!settings.allow_experimental_variant_type)
{
if (isVariant(data_type))
{
throw Exception(
ErrorCodes::ILLEGAL_COLUMN,
"Cannot create column with type '{}' because experimental Variant type is not allowed. "
"Set setting allow_experimental_variant_type = 1 in order to allow it",
data_type.getName());
}
}
if (!settings.allow_suspicious_variant_types)
{
if (const auto * variant_type = typeid_cast<const DataTypeVariant *>(&data_type))
{
const auto & variants = variant_type->getVariants();
chassert(!variants.empty());
for (size_t i = 0; i < variants.size() - 1; ++i)
{
for (size_t j = i + 1; j < variants.size(); ++j)
{
/// Don't consider bool as similar to something (like number).
if (isBool(variants[i]) || isBool(variants[j]))
continue;
if (auto supertype = tryGetLeastSupertype(DataTypes{variants[i], variants[j]}))
{
throw Exception(
ErrorCodes::ILLEGAL_COLUMN,
"Cannot create column with type '{}' because variants '{}' and '{}' have similar types and working with values "
"of these types may lead to ambiguity. "
"Consider using common single variant '{}' instead of these 2 variants or set setting allow_suspicious_variant_types = 1 "
"in order to allow it",
data_type.getName(),
variants[i]->getName(),
variants[j]->getName(),
supertype->getName());
}
}
}
}
}
};
validate_callback(*type_to_check);
if (settings.validate_nested_types)
type_to_check->forEachChild(validate_callback);
}
ColumnsDescription parseColumnsListFromString(const std::string & structure, const ContextPtr & context)
{
ParserColumnDeclarationList parser(true, true);
const Settings & settings = context->getSettingsRef();
ASTPtr columns_list_raw = parseQuery(parser, structure, "columns declaration list", settings.max_query_size, settings.max_parser_depth, settings.max_parser_backtracks);
auto * columns_list = dynamic_cast<ASTExpressionList *>(columns_list_raw.get());
if (!columns_list)
throw Exception(ErrorCodes::LOGICAL_ERROR, "Could not cast AST to ASTExpressionList");
auto columns = InterpreterCreateQuery::getColumnsDescription(*columns_list, context, LoadingStrictnessLevel::CREATE);
auto validation_settings = DataTypeValidationSettings(context->getSettingsRef());
for (const auto & [name, type] : columns.getAll())
validateDataType(type, validation_settings);
return columns;
}
bool tryParseColumnsListFromString(const std::string & structure, ColumnsDescription & columns, const ContextPtr & context, String & error)
{
ParserColumnDeclarationList parser(true, true);
const Settings & settings = context->getSettingsRef();
const char * start = structure.data();
const char * end = structure.data() + structure.size();
ASTPtr columns_list_raw = tryParseQuery(
parser, start, end, error, false, "columns declaration list", false, settings.max_query_size, settings.max_parser_depth, settings.max_parser_backtracks, true);
if (!columns_list_raw)
return false;
auto * columns_list = dynamic_cast<ASTExpressionList *>(columns_list_raw.get());
if (!columns_list)
{
error = fmt::format("Invalid columns declaration list: \"{}\"", structure);
return false;
}
try
{
columns = InterpreterCreateQuery::getColumnsDescription(*columns_list, context, LoadingStrictnessLevel::CREATE);
auto validation_settings = DataTypeValidationSettings(context->getSettingsRef());
for (const auto & [name, type] : columns.getAll())
validateDataType(type, validation_settings);
return true;
}
catch (...)
{
error = getCurrentExceptionMessage(false);
return false;
}
}
}