mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-11-10 09:32:06 +00:00
20bb8a248e
Wall of text, sorry, but I also had to document some stuff for myself: There are three ways to communicate data using HTTP: - the HTTP verb: for our purposes, PUT and GET, - the HTTP path: '/ping', '/request' etc., - the HTTP URL parameter(s), e.g. 'method=libNew&dictionary_id=1234' The bridge will use different handlers for communication with the external dictionary library and for communication with the catboost library. Handlers are created based on a combination of the HTTP verb and the HTTP method. More specifically, there will be combinations - GET + '/extdict_ping' - PUT + '/extdict_request' - GET + '/catboost_ping' - PUT + '/catboost_request'. For each combination, the bridge expects a certain set of URL parameters, e.g. for the first combination parameter "dictionary_id" is expected. Starting with this commit, the library-bridge creates handlers based on the first two combinations (the latter two combinations will be added later). This makes the handler creation mechanism consistent with it's counterpart in xdbc-bridge. For that, it was necessary to make both IBridgeHelper methods "getMainURI()" and "getPingURI()" pure virtual so that derived classes (LibraryBridgeHelper and XDBCBridgeHelper) must provide custom URLs with custom paths. Side note 1: Previously, LibraryBridgeHelper sent HTTP URL parameter "method=ping" during handshake (PING) but the library-bridge ignored that parameter. We now omit this parameter, i.e. LibraryBridgeHelper::PING was removed. Again, this makes things consistent with xdbc-bridge. Side note 2: xdbc-bridge is unchanged in this commit. Therefore, XDBCBridgeHelper now uses the HTTP paths previously in the base class. For funny reason, XDBCBridgeHelper did not use IBridgeHelper::getMainURI() - it generates the URLs by itself. I kept it that way for now but provided an implementation of getMainURI() anyways. |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| ExternalDictionaryLibraryAPI.cpp | ||
| ExternalDictionaryLibraryAPI.h | ||
| ExternalDictionaryLibraryHandler.cpp | ||
| ExternalDictionaryLibraryHandler.h | ||
| ExternalDictionaryLibraryHandlerFactory.cpp | ||
| ExternalDictionaryLibraryHandlerFactory.h | ||
| ExternalDictionaryLibraryUtils.h | ||
| library-bridge.cpp | ||
| LibraryBridge.cpp | ||
| LibraryBridge.h | ||
| LibraryBridgeHandlerFactory.cpp | ||
| LibraryBridgeHandlerFactory.h | ||
| LibraryBridgeHandlers.cpp | ||
| LibraryBridgeHandlers.h | ||