mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-09-30 05:30:51 +00:00
7da4083237
This will fix the following UB report [1]: "../src/Functions/bitAnd.cpp:24:61: runtime error: nan is outside the range of representable values of type 'long' Received signal -3 Received signal Unknown signal (-3)" [1]: https://clickhouse-test-reports.s3.yandex.net/19824/89c4055202b9d08459f90ee5791d4e3017b82fbf/fuzzer_ubsan/report.html#fail1
56 lines
1.8 KiB
C++
56 lines
1.8 KiB
C++
#include <Functions/FunctionFactory.h>
|
|
#include <Functions/FunctionBinaryArithmetic.h>
|
|
|
|
namespace DB
|
|
{
|
|
namespace ErrorCodes
|
|
{
|
|
extern const int NOT_IMPLEMENTED;
|
|
extern const int LOGICAL_ERROR;
|
|
}
|
|
|
|
namespace
|
|
{
|
|
|
|
template <typename A, typename B>
|
|
struct BitRotateLeftImpl
|
|
{
|
|
using ResultType = typename NumberTraits::ResultOfBit<A, B>::Type;
|
|
static const constexpr bool allow_fixed_string = false;
|
|
|
|
template <typename Result = ResultType>
|
|
static inline NO_SANITIZE_UNDEFINED Result apply(A a [[maybe_unused]], B b [[maybe_unused]])
|
|
{
|
|
if constexpr (is_big_int_v<A> || is_big_int_v<B>)
|
|
throw Exception("Bit rotate is not implemented for big integers", ErrorCodes::NOT_IMPLEMENTED);
|
|
else
|
|
return (static_cast<Result>(a) << static_cast<Result>(b))
|
|
| (static_cast<Result>(a) >> ((sizeof(Result) * 8) - static_cast<Result>(b)));
|
|
}
|
|
|
|
#if USE_EMBEDDED_COMPILER
|
|
static constexpr bool compilable = true;
|
|
|
|
static inline llvm::Value * compile(llvm::IRBuilder<> & b, llvm::Value * left, llvm::Value * right, bool)
|
|
{
|
|
if (!left->getType()->isIntegerTy())
|
|
throw Exception("BitRotateLeftImpl expected an integral type", ErrorCodes::LOGICAL_ERROR);
|
|
auto * size = llvm::ConstantInt::get(left->getType(), left->getType()->getPrimitiveSizeInBits());
|
|
/// XXX how is this supposed to behave in signed mode?
|
|
return b.CreateOr(b.CreateShl(left, right), b.CreateLShr(left, b.CreateSub(size, right)));
|
|
}
|
|
#endif
|
|
};
|
|
|
|
struct NameBitRotateLeft { static constexpr auto name = "bitRotateLeft"; };
|
|
using FunctionBitRotateLeft = BinaryArithmeticOverloadResolver<BitRotateLeftImpl, NameBitRotateLeft, true, false>;
|
|
|
|
}
|
|
|
|
void registerFunctionBitRotateLeft(FunctionFactory & factory)
|
|
{
|
|
factory.registerFunction<FunctionBitRotateLeft>();
|
|
}
|
|
|
|
}
|