ClickHouse/src/TableFunctions/ITableFunction.cpp
SmitaRKulkarni 16fca48f5b
Disable functions in readonly for inserts (#44290)
Implementation:
* Added a new parameter to ITableFunction::execute to check if query is insert query.
* Used the new parameter in InterpreterInsertQuery::getTable function when calling ITableFunction::execute .
Testing:
* Added test case for INSERT in 02473_functions_in_readonly_mode.sh.

Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-01-03 15:25:04 +01:00

54 lines
2.1 KiB
C++

#include <TableFunctions/ITableFunction.h>
#include <Interpreters/Context.h>
#include <Storages/StorageFactory.h>
#include <Storages/StorageTableFunction.h>
#include <Access/Common/AccessFlags.h>
#include <Common/ProfileEvents.h>
#include <TableFunctions/TableFunctionFactory.h>
namespace ProfileEvents
{
extern const Event TableFunctionExecute;
}
namespace DB
{
AccessType ITableFunction::getSourceAccessType() const
{
return StorageFactory::instance().getSourceAccessType(getStorageTypeName());
}
StoragePtr ITableFunction::execute(const ASTPtr & ast_function, ContextPtr context, const std::string & table_name,
ColumnsDescription cached_columns, bool use_global_context, bool is_insert_query) const
{
ProfileEvents::increment(ProfileEvents::TableFunctionExecute);
AccessFlags required_access = getSourceAccessType();
auto table_function_properties = TableFunctionFactory::instance().tryGetProperties(getName());
if (is_insert_query || !(table_function_properties && table_function_properties->allow_readonly))
required_access |= AccessType::CREATE_TEMPORARY_TABLE;
context->checkAccess(required_access);
auto context_to_use = use_global_context ? context->getGlobalContext() : context;
if (cached_columns.empty())
return executeImpl(ast_function, context, table_name, std::move(cached_columns));
if (hasStaticStructure() && cached_columns == getActualTableStructure(context))
return executeImpl(ast_function, context_to_use, table_name, std::move(cached_columns));
auto this_table_function = shared_from_this();
auto get_storage = [=]() -> StoragePtr
{
return this_table_function->executeImpl(ast_function, context_to_use, table_name, cached_columns);
};
/// It will request actual table structure and create underlying storage lazily
return std::make_shared<StorageTableFunctionProxy>(StorageID(getDatabaseName(), table_name), std::move(get_storage),
std::move(cached_columns), needStructureConversion());
}
}