mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-11-27 18:12:02 +00:00
98e3a99a88
Since this hides real problems, since destructor does final flush and if
it fails, then data will be lost.
One of such examples if MEMORY_LIMIT_EXCEEDED exception, so lock
exceptions from destructors, by using
MemoryTracker::LockExceptionInThread to block these exception, and allow
others (so std::terminate will be called, since this is c++11 with
noexcept for destructors by default).
Here is an example, that leads to empty block in the distributed batch:
2021.01.21 12:43:18.619739 [ 46468 ] {7bd60d75-ebcb-45d2-874d-260df9a4ddac} <Error> virtual DB::CompressedWriteBuffer::~CompressedWriteBuffer(): Code: 241, e.displayText() = DB::Exception: Memory limit (for user) exceeded: would use 332.07 GiB (attempt to allocate chunk of 4355342 bytes), maximum: 256.00 GiB, Stack trace (when copying this message, always include the lines below):
0. DB::Exception::Exception<>() @ 0x86f7b88 in /usr/bin/clickhouse
...
4. void DB::PODArrayBase<>::resize<>(unsigned long) @ 0xe9e878d in /usr/bin/clickhouse
5. DB::CompressedWriteBuffer::nextImpl() @ 0xe9f0296 in /usr/bin/clickhouse
6. DB::CompressedWriteBuffer::~CompressedWriteBuffer() @ 0xe9f0415 in /usr/bin/clickhouse
7. DB::DistributedBlockOutputStream::writeToShard() @ 0xf6bed4a in /usr/bin/clickhouse
59 lines
1.5 KiB
C++
59 lines
1.5 KiB
C++
#include <city.h>
|
|
#include <string.h>
|
|
|
|
#include <common/unaligned.h>
|
|
#include <common/types.h>
|
|
|
|
#include "CompressedWriteBuffer.h"
|
|
#include <Compression/CompressionFactory.h>
|
|
|
|
#include <Common/MemorySanitizer.h>
|
|
#include <Common/MemoryTracker.h>
|
|
|
|
|
|
namespace DB
|
|
{
|
|
|
|
namespace ErrorCodes
|
|
{
|
|
}
|
|
|
|
static constexpr auto CHECKSUM_SIZE{sizeof(CityHash_v1_0_2::uint128)};
|
|
|
|
void CompressedWriteBuffer::nextImpl()
|
|
{
|
|
if (!offset())
|
|
return;
|
|
|
|
size_t decompressed_size = offset();
|
|
UInt32 compressed_reserve_size = codec->getCompressedReserveSize(decompressed_size);
|
|
compressed_buffer.resize(compressed_reserve_size);
|
|
UInt32 compressed_size = codec->compress(working_buffer.begin(), decompressed_size, compressed_buffer.data());
|
|
|
|
// FIXME remove this after fixing msan report in lz4.
|
|
// Almost always reproduces on stateless tests, the exact test unknown.
|
|
__msan_unpoison(compressed_buffer.data(), compressed_size);
|
|
|
|
CityHash_v1_0_2::uint128 checksum = CityHash_v1_0_2::CityHash128(compressed_buffer.data(), compressed_size);
|
|
out.write(reinterpret_cast<const char *>(&checksum), CHECKSUM_SIZE);
|
|
out.write(compressed_buffer.data(), compressed_size);
|
|
}
|
|
|
|
|
|
CompressedWriteBuffer::CompressedWriteBuffer(
|
|
WriteBuffer & out_,
|
|
CompressionCodecPtr codec_,
|
|
size_t buf_size)
|
|
: BufferWithOwnMemory<WriteBuffer>(buf_size), out(out_), codec(std::move(codec_))
|
|
{
|
|
}
|
|
|
|
CompressedWriteBuffer::~CompressedWriteBuffer()
|
|
{
|
|
/// FIXME move final flush into the caller
|
|
MemoryTracker::LockExceptionInThread lock;
|
|
next();
|
|
}
|
|
|
|
}
|