mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-12-12 17:32:32 +00:00
c16707ff00
- The deleted function modelEvaluate() was superseded by catboostEvaluate(). - Also delete the external model repository, as modelEvaluate() was it's last user. Additionally remove the system view SYSTEM.MODELS for inspecting the repository. - SYSTEM RELOAD MODELS is also obsolete. HOWEVER, it was retained and made a no-op instead of deleted. Why? The reason is that RBAC in distributed setups works by storing privileges (granted and revoked) as plain SQL statements in Keeper. Nodes read these statements at startup and parse them. If a privilege for SYSTEM RELOAD MODELS exists but parser doesn't recognize it nodes would fail to come up. Considered but rejected alternatives: - Ignore SYSTEM RELOAD MODELS during parsing RBAC privileges and return an error for regular SYSTEM RELOAD MODELS SQL. Special-case of no-op behavior, too brittle. - Remove SYSTEM RELOAD MODELS manually from Keeper via command-line manipulation of Keeper nodes or via SQL by dropping the privileges. Needs user intervention during upgrade. |
||
---|---|---|
.. | ||
datatypes.dict | ||
functions.dict | ||
key_words.dict | ||
old.dict |