mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-09-30 05:30:51 +00:00
087d8ab020
The start was in https://github.com/ClickHouse/ClickHouse/pull/11026 It turned out that the problem was due to the incorrect mutate() implementation that lead to quadratic amount of column copying. This problem has since been fixed. Remove the excessively verbose logging, and also change appendToBlock of LogElement's to accept mutable columns instead of accepting a block and mutating it on each call. It looks wasteful, even though it is almost a noop.
54 lines
1.1 KiB
C++
54 lines
1.1 KiB
C++
#pragma once
|
|
|
|
#include <Interpreters/SystemLog.h>
|
|
#include <Common/ProfileEvents.h>
|
|
#include <Common/CurrentMetrics.h>
|
|
|
|
#include <vector>
|
|
#include <atomic>
|
|
#include <ctime>
|
|
|
|
|
|
namespace DB
|
|
{
|
|
|
|
/** MetricLog is a log of metric values measured at regular time interval.
|
|
*/
|
|
|
|
struct MetricLogElement
|
|
{
|
|
time_t event_time{};
|
|
UInt64 milliseconds{};
|
|
|
|
std::vector<ProfileEvents::Count> profile_events;
|
|
std::vector<CurrentMetrics::Metric> current_metrics;
|
|
|
|
static std::string name() { return "MetricLog"; }
|
|
static Block createBlock();
|
|
void appendToBlock(MutableColumns & columns) const;
|
|
};
|
|
|
|
|
|
class MetricLog : public SystemLog<MetricLogElement>
|
|
{
|
|
using SystemLog<MetricLogElement>::SystemLog;
|
|
|
|
public:
|
|
void shutdown() override;
|
|
|
|
/// Launches a background thread to collect metrics with interval
|
|
void startCollectMetric(size_t collect_interval_milliseconds_);
|
|
|
|
/// Stop background thread. Call before shutdown.
|
|
void stopCollectMetric();
|
|
|
|
private:
|
|
void metricThreadFunction();
|
|
|
|
ThreadFromGlobalPool metric_flush_thread;
|
|
size_t collect_interval_milliseconds;
|
|
std::atomic<bool> is_shutdown_metric_thread{false};
|
|
};
|
|
|
|
}
|