mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-11-27 18:12:02 +00:00
08d0a160ae
Due to the fact that integration tests are run in parallel and there might be no ClickHouse restart between several tests, relying on `system.events` in the test is fragile as it can be affected by previous tests. This commit removes any assumptions regarding `system.events` from the test and tries to keep it robust.
58 lines
1.8 KiB
Python
58 lines
1.8 KiB
Python
import pytest
|
|
import os
|
|
from helpers.cluster import ClickHouseCluster
|
|
from helpers.test_tools import assert_eq_with_retry, assert_logs_contain_with_retry
|
|
|
|
SCRIPT_DIR = os.path.dirname(os.path.realpath(__file__))
|
|
cluster = ClickHouseCluster(__file__)
|
|
node = cluster.add_instance("node", user_configs=["configs/empty_settings.xml"])
|
|
|
|
|
|
@pytest.fixture(scope="module", autouse=True)
|
|
def started_cluster():
|
|
try:
|
|
cluster.start()
|
|
yield cluster
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def reset_to_normal_settings_after_test():
|
|
try:
|
|
node.copy_file_to_container(
|
|
os.path.join(SCRIPT_DIR, "configs/empty_settings.xml"),
|
|
"/etc/clickhouse-server/config.d/z.xml",
|
|
)
|
|
node.query("SYSTEM RELOAD CONFIG")
|
|
yield
|
|
finally:
|
|
pass
|
|
|
|
|
|
# @pytest.mark.parametrize("reload_strategy", ["force", "timeout"])
|
|
def test_reload_query_masking_rules():
|
|
# At first, empty configuration is fed to ClickHouse. The query
|
|
# "SELECT 'TOPSECRET.TOPSECRET'" will not be redacted, and the new masking
|
|
# event will not be registered
|
|
node.query("SELECT 'TOPSECRET.TOPSECRET'")
|
|
assert_logs_contain_with_retry(node, "SELECT 'TOPSECRET.TOPSECRET'")
|
|
assert not node.contains_in_log(r"SELECT '\[hidden\]'")
|
|
node.rotate_logs()
|
|
|
|
node.copy_file_to_container(
|
|
os.path.join(SCRIPT_DIR, "configs/changed_settings.xml"),
|
|
"/etc/clickhouse-server/config.d/z.xml",
|
|
)
|
|
|
|
node.query("SYSTEM RELOAD CONFIG")
|
|
|
|
# Now the same query will be redacted in the logs and the counter of events
|
|
# will be incremented
|
|
node.query("SELECT 'TOPSECRET.TOPSECRET'")
|
|
|
|
assert_logs_contain_with_retry(node, r"SELECT '\[hidden\]'")
|
|
assert not node.contains_in_log("SELECT 'TOPSECRET.TOPSECRET'")
|
|
|
|
node.rotate_logs()
|