thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 16:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
a34f42ca22
ClickHouse/tests
History
Azat Khuzhin a34f42ca22 Remove lock from the ReadProgressCallback 
It looks redundant (added in 5ef51ed), though it has "fix tests" in the
log message, but CI reports is not available for the commits from that
PR [1], so let's try.

  [1]: https://github.com/ClickHouse/ClickHouse/pull/37543

Also this can be a big problem, since the code under that lock
(throttling or quotas with previous implementation that uses
boost::atomic_shared_ptr) may sleep.

Some numbers:

    run                     | time
    ------------------------|------
    max_threads=100 before  | 23.1
    max_threads=100 after   | 15.1
    max_threads=4500 before | 4.5
    max_threads=4500 after  | 2.3

Query:

    select sum(number) from numbers_mt(2000000) settings max_threads=X, max_block_size = 1

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-22 18:00:55 +01:00
..
ci Merge pull request #60245 from Algunenano/enforce_cloud_sync 2024-02-22 10:11:01 +01:00
config Fix cleanup 2024-02-19 15:09:10 +01:00
fuzz
instructions
integration Merge pull request #60233 from ClickHouse/hide-sensitive-info-in-s3-queue 2024-02-22 11:37:15 +01:00
jepsen.clickhouse
perf_drafts
performance Remove lock from the ReadProgressCallback 2024-02-22 18:00:55 +01:00
queries Merge remote-tracking branch 'rschu1ze/master' into vector-dot-product 2024-02-22 10:16:28 +00:00
sqllogic
.gitignore
.rgignore
analyzer_integration_broken_tests.txt Merge pull request #59921 from ClickHouse/analyzer-fix-test_distributed_backward_compatability 2024-02-16 13:58:45 +01:00
analyzer_tech_debt.txt Update analyzer_tech_debt.txt 2024-02-22 14:32:30 +01:00
clickhouse-test
README.md
tsan_suppressions.txt
ubsan_suppressions.txt

README.md

Find CI documents and instructions on running CI checks localy here.