mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-09-21 09:10:48 +00:00
a5a8ecfe42
fuzzer sometimes [1] may inserts tupleElement() created from ASTLiteral:
Function_tupleElement, 0xx
-ExpressionList_, 0xx
--Literal_Int64_255, 0xx
--Literal_Int64_100, 0xx
And in this case it will be printed as "255.100", which
later will be parsed as float, and formatting will be
inconsistent.
So instead of printing it as regular tuple,
let's print it as ExpressionList instead (i.e. with ", " delimiter).
Simple reproducer:
void ast()
{
auto arg1 = std::make_shared<ASTLiteral>(Field(255));
auto arg2 = std::make_shared<ASTLiteral>(Field(100));
auto func = makeASTFunction("tupleElement", arg1, arg2);
auto ast = func;
std::cerr << ast->formatForErrorMessage() << std::endl;
std::cerr << ast->dumpTree() << std::endl;
}
[1]: https://clickhouse-test-reports.s3.yandex.net/23517/f1187aeb69109c88f0be978b8083080c7a843820/fuzzer_debug/report.html#fail1
|
||
|---|---|---|
| .. | ||
| ci | ||
| config | ||
| external_models/catboost | ||
| fuzz | ||
| instructions | ||
| integration | ||
| jepsen.clickhouse-keeper | ||
| perf_drafts | ||
| performance | ||
| queries | ||
| testflows | ||
| users.d | ||
| .gitignore | ||
| clickhouse-client.xml | ||
| clickhouse-test | ||
| clickhouse-test-server | ||
| client-test.xml | ||
| CMakeLists.txt | ||
| decimals_dictionary.xml | ||
| ints_dictionary.xml | ||
| msan_suppressions.txt | ||
| server-test.xml | ||
| stress | ||
| strings_dictionary.xml | ||
| tsan_suppressions.txt | ||
| ubsan_suppressions.txt | ||
| users.xml | ||