mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-11-17 21:24:28 +00:00
98e3a99a88
Since this hides real problems, since destructor does final flush and if
it fails, then data will be lost.
One of such examples if MEMORY_LIMIT_EXCEEDED exception, so lock
exceptions from destructors, by using
MemoryTracker::LockExceptionInThread to block these exception, and allow
others (so std::terminate will be called, since this is c++11 with
noexcept for destructors by default).
Here is an example, that leads to empty block in the distributed batch:
2021.01.21 12:43:18.619739 [ 46468 ] {7bd60d75-ebcb-45d2-874d-260df9a4ddac} <Error> virtual DB::CompressedWriteBuffer::~CompressedWriteBuffer(): Code: 241, e.displayText() = DB::Exception: Memory limit (for user) exceeded: would use 332.07 GiB (attempt to allocate chunk of 4355342 bytes), maximum: 256.00 GiB, Stack trace (when copying this message, always include the lines below):
0. DB::Exception::Exception<>() @ 0x86f7b88 in /usr/bin/clickhouse
...
4. void DB::PODArrayBase<>::resize<>(unsigned long) @ 0xe9e878d in /usr/bin/clickhouse
5. DB::CompressedWriteBuffer::nextImpl() @ 0xe9f0296 in /usr/bin/clickhouse
6. DB::CompressedWriteBuffer::~CompressedWriteBuffer() @ 0xe9f0415 in /usr/bin/clickhouse
7. DB::DistributedBlockOutputStream::writeToShard() @ 0xf6bed4a in /usr/bin/clickhouse
51 lines
1.0 KiB
C++
51 lines
1.0 KiB
C++
#include <IO/WriteBufferFromOStream.h>
|
|
#include <Common/MemoryTracker.h>
|
|
|
|
|
|
namespace DB
|
|
{
|
|
|
|
namespace ErrorCodes
|
|
{
|
|
extern const int CANNOT_WRITE_TO_OSTREAM;
|
|
}
|
|
|
|
void WriteBufferFromOStream::nextImpl()
|
|
{
|
|
if (!offset())
|
|
return;
|
|
|
|
ostr->write(working_buffer.begin(), offset());
|
|
ostr->flush();
|
|
|
|
if (!ostr->good())
|
|
throw Exception("Cannot write to ostream at offset " + std::to_string(count()),
|
|
ErrorCodes::CANNOT_WRITE_TO_OSTREAM);
|
|
}
|
|
|
|
WriteBufferFromOStream::WriteBufferFromOStream(
|
|
size_t size,
|
|
char * existing_memory,
|
|
size_t alignment)
|
|
: BufferWithOwnMemory<WriteBuffer>(size, existing_memory, alignment)
|
|
{
|
|
}
|
|
|
|
WriteBufferFromOStream::WriteBufferFromOStream(
|
|
std::ostream & ostr_,
|
|
size_t size,
|
|
char * existing_memory,
|
|
size_t alignment)
|
|
: BufferWithOwnMemory<WriteBuffer>(size, existing_memory, alignment), ostr(&ostr_)
|
|
{
|
|
}
|
|
|
|
WriteBufferFromOStream::~WriteBufferFromOStream()
|
|
{
|
|
/// FIXME move final flush into the caller
|
|
MemoryTracker::LockExceptionInThread lock;
|
|
next();
|
|
}
|
|
|
|
}
|