mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-11-17 21:24:28 +00:00
98e3a99a88
Since this hides real problems, since destructor does final flush and if
it fails, then data will be lost.
One of such examples if MEMORY_LIMIT_EXCEEDED exception, so lock
exceptions from destructors, by using
MemoryTracker::LockExceptionInThread to block these exception, and allow
others (so std::terminate will be called, since this is c++11 with
noexcept for destructors by default).
Here is an example, that leads to empty block in the distributed batch:
2021.01.21 12:43:18.619739 [ 46468 ] {7bd60d75-ebcb-45d2-874d-260df9a4ddac} <Error> virtual DB::CompressedWriteBuffer::~CompressedWriteBuffer(): Code: 241, e.displayText() = DB::Exception: Memory limit (for user) exceeded: would use 332.07 GiB (attempt to allocate chunk of 4355342 bytes), maximum: 256.00 GiB, Stack trace (when copying this message, always include the lines below):
0. DB::Exception::Exception<>() @ 0x86f7b88 in /usr/bin/clickhouse
...
4. void DB::PODArrayBase<>::resize<>(unsigned long) @ 0xe9e878d in /usr/bin/clickhouse
5. DB::CompressedWriteBuffer::nextImpl() @ 0xe9f0296 in /usr/bin/clickhouse
6. DB::CompressedWriteBuffer::~CompressedWriteBuffer() @ 0xe9f0415 in /usr/bin/clickhouse
7. DB::DistributedBlockOutputStream::writeToShard() @ 0xf6bed4a in /usr/bin/clickhouse
136 lines
3.6 KiB
C++
136 lines
3.6 KiB
C++
#include <IO/ZlibDeflatingWriteBuffer.h>
|
|
#include <Common/MemorySanitizer.h>
|
|
#include <Common/MemoryTracker.h>
|
|
#include <Common/Exception.h>
|
|
|
|
|
|
namespace DB
|
|
{
|
|
|
|
namespace ErrorCodes
|
|
{
|
|
extern const int ZLIB_DEFLATE_FAILED;
|
|
}
|
|
|
|
|
|
ZlibDeflatingWriteBuffer::ZlibDeflatingWriteBuffer(
|
|
std::unique_ptr<WriteBuffer> out_,
|
|
CompressionMethod compression_method,
|
|
int compression_level,
|
|
size_t buf_size,
|
|
char * existing_memory,
|
|
size_t alignment)
|
|
: BufferWithOwnMemory<WriteBuffer>(buf_size, existing_memory, alignment)
|
|
, out(std::move(out_))
|
|
{
|
|
zstr.zalloc = nullptr;
|
|
zstr.zfree = nullptr;
|
|
zstr.opaque = nullptr;
|
|
zstr.next_in = nullptr;
|
|
zstr.avail_in = 0;
|
|
zstr.next_out = nullptr;
|
|
zstr.avail_out = 0;
|
|
|
|
int window_bits = 15;
|
|
if (compression_method == CompressionMethod::Gzip)
|
|
{
|
|
window_bits += 16;
|
|
}
|
|
|
|
#pragma GCC diagnostic push
|
|
#pragma GCC diagnostic ignored "-Wold-style-cast"
|
|
int rc = deflateInit2(&zstr, compression_level, Z_DEFLATED, window_bits, 8, Z_DEFAULT_STRATEGY);
|
|
#pragma GCC diagnostic pop
|
|
|
|
if (rc != Z_OK)
|
|
throw Exception(std::string("deflateInit2 failed: ") + zError(rc) + "; zlib version: " + ZLIB_VERSION, ErrorCodes::ZLIB_DEFLATE_FAILED);
|
|
}
|
|
|
|
ZlibDeflatingWriteBuffer::~ZlibDeflatingWriteBuffer()
|
|
{
|
|
/// FIXME move final flush into the caller
|
|
MemoryTracker::LockExceptionInThread lock;
|
|
|
|
finish();
|
|
|
|
try
|
|
{
|
|
int rc = deflateEnd(&zstr);
|
|
if (rc != Z_OK)
|
|
throw Exception(std::string("deflateEnd failed: ") + zError(rc), ErrorCodes::ZLIB_DEFLATE_FAILED);
|
|
}
|
|
catch (...)
|
|
{
|
|
/// It is OK not to terminate under an error from deflateEnd()
|
|
/// since all data already written to the stream.
|
|
tryLogCurrentException(__PRETTY_FUNCTION__);
|
|
}
|
|
}
|
|
|
|
void ZlibDeflatingWriteBuffer::nextImpl()
|
|
{
|
|
if (!offset())
|
|
return;
|
|
|
|
zstr.next_in = reinterpret_cast<unsigned char *>(working_buffer.begin());
|
|
zstr.avail_in = offset();
|
|
|
|
do
|
|
{
|
|
out->nextIfAtEnd();
|
|
zstr.next_out = reinterpret_cast<unsigned char *>(out->position());
|
|
zstr.avail_out = out->buffer().end() - out->position();
|
|
|
|
int rc = deflate(&zstr, Z_NO_FLUSH);
|
|
out->position() = out->buffer().end() - zstr.avail_out;
|
|
|
|
if (rc != Z_OK)
|
|
throw Exception(std::string("deflate failed: ") + zError(rc), ErrorCodes::ZLIB_DEFLATE_FAILED);
|
|
}
|
|
while (zstr.avail_in > 0 || zstr.avail_out == 0);
|
|
}
|
|
|
|
void ZlibDeflatingWriteBuffer::finish()
|
|
{
|
|
if (finished)
|
|
return;
|
|
|
|
next();
|
|
|
|
/// https://github.com/zlib-ng/zlib-ng/issues/494
|
|
do
|
|
{
|
|
out->nextIfAtEnd();
|
|
zstr.next_out = reinterpret_cast<unsigned char *>(out->position());
|
|
zstr.avail_out = out->buffer().end() - out->position();
|
|
|
|
int rc = deflate(&zstr, Z_FULL_FLUSH);
|
|
out->position() = out->buffer().end() - zstr.avail_out;
|
|
|
|
if (rc != Z_OK)
|
|
throw Exception(std::string("deflate failed: ") + zError(rc), ErrorCodes::ZLIB_DEFLATE_FAILED);
|
|
}
|
|
while (zstr.avail_out == 0);
|
|
|
|
while (true)
|
|
{
|
|
out->nextIfAtEnd();
|
|
zstr.next_out = reinterpret_cast<unsigned char *>(out->position());
|
|
zstr.avail_out = out->buffer().end() - out->position();
|
|
|
|
int rc = deflate(&zstr, Z_FINISH);
|
|
out->position() = out->buffer().end() - zstr.avail_out;
|
|
|
|
if (rc == Z_STREAM_END)
|
|
{
|
|
finished = true;
|
|
return;
|
|
}
|
|
|
|
if (rc != Z_OK)
|
|
throw Exception(std::string("deflate finish failed: ") + zError(rc), ErrorCodes::ZLIB_DEFLATE_FAILED);
|
|
}
|
|
}
|
|
|
|
}
|