mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-12-04 05:22:17 +00:00
b24ca8de52
When I tried to add cool new clang-tidy 14 warnings, I noticed that the current clang-tidy settings already produce a ton of warnings. This commit addresses many of these. Almost all of them were non-critical, i.e. C vs. C++ style casts.
271 lines
12 KiB
C++
271 lines
12 KiB
C++
#include <DataTypes/DataTypeDateTime.h>
|
|
#include <DataTypes/DataTypeDateTime64.h>
|
|
#include <DataTypes/DataTypesNumber.h>
|
|
#include <Columns/ColumnString.h>
|
|
#include <Columns/ColumnsNumber.h>
|
|
#include <Columns/ColumnDecimal.h>
|
|
|
|
#include <Functions/IFunction.h>
|
|
#include <Functions/FunctionHelpers.h>
|
|
#include <Functions/FunctionFactory.h>
|
|
#include <Functions/extractTimeZoneFromFunctionArguments.h>
|
|
#include <Functions/DateTimeTransforms.h>
|
|
#include <Functions/TransformDateTime64.h>
|
|
|
|
#include <IO/WriteHelpers.h>
|
|
|
|
#include <base/find_symbols.h>
|
|
|
|
#include <type_traits>
|
|
|
|
|
|
namespace DB
|
|
{
|
|
|
|
namespace ErrorCodes
|
|
{
|
|
extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH;
|
|
extern const int ILLEGAL_TYPE_OF_ARGUMENT;
|
|
extern const int ILLEGAL_COLUMN;
|
|
extern const int BAD_ARGUMENTS;
|
|
}
|
|
|
|
namespace
|
|
{
|
|
|
|
/** dateDiff('unit', t1, t2, [timezone])
|
|
* t1 and t2 can be Date or DateTime
|
|
*
|
|
* If timezone is specified, it applied to both arguments.
|
|
* If not, timezones from datatypes t1 and t2 are used.
|
|
* If that timezones are not the same, the result is unspecified.
|
|
*
|
|
* Timezone matters because days can have different length.
|
|
*/
|
|
class FunctionDateDiff : public IFunction
|
|
{
|
|
using ColumnDateTime64 = ColumnDecimal<DateTime64>;
|
|
public:
|
|
static constexpr auto name = "dateDiff";
|
|
static FunctionPtr create(ContextPtr) { return std::make_shared<FunctionDateDiff>(); }
|
|
|
|
String getName() const override
|
|
{
|
|
return name;
|
|
}
|
|
|
|
bool isVariadic() const override { return true; }
|
|
bool isSuitableForShortCircuitArgumentsExecution(const DataTypesWithConstInfo & /*arguments*/) const override { return true; }
|
|
size_t getNumberOfArguments() const override { return 0; }
|
|
|
|
DataTypePtr getReturnTypeImpl(const DataTypes & arguments) const override
|
|
{
|
|
if (arguments.size() != 3 && arguments.size() != 4)
|
|
throw Exception("Number of arguments for function " + getName() + " doesn't match: passed "
|
|
+ toString(arguments.size()) + ", should be 3 or 4",
|
|
ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH);
|
|
|
|
if (!isString(arguments[0]))
|
|
throw Exception("First argument for function " + getName() + " (unit) must be String",
|
|
ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);
|
|
|
|
if (!isDate(arguments[1]) && !isDateTime(arguments[1]) && !isDateTime64(arguments[1]))
|
|
throw Exception("Second argument for function " + getName() + " must be Date or DateTime",
|
|
ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);
|
|
|
|
if (!isDate(arguments[2]) && !isDateTime(arguments[2]) && !isDateTime64(arguments[2]))
|
|
throw Exception("Third argument for function " + getName() + " must be Date or DateTime",
|
|
ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);
|
|
|
|
if (arguments.size() == 4 && !isString(arguments[3]))
|
|
throw Exception("Fourth argument for function " + getName() + " (timezone) must be String",
|
|
ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);
|
|
|
|
return std::make_shared<DataTypeInt64>();
|
|
}
|
|
|
|
bool useDefaultImplementationForConstants() const override { return true; }
|
|
ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return {0, 3}; }
|
|
|
|
ColumnPtr executeImpl(const ColumnsWithTypeAndName & arguments, const DataTypePtr &, size_t input_rows_count) const override
|
|
{
|
|
const auto * unit_column = checkAndGetColumnConst<ColumnString>(arguments[0].column.get());
|
|
if (!unit_column)
|
|
throw Exception("First argument for function " + getName() + " must be constant String", ErrorCodes::ILLEGAL_COLUMN);
|
|
|
|
String unit = Poco::toLower(unit_column->getValue<String>());
|
|
|
|
const IColumn & x = *arguments[1].column;
|
|
const IColumn & y = *arguments[2].column;
|
|
|
|
size_t rows = input_rows_count;
|
|
auto res = ColumnInt64::create(rows);
|
|
|
|
const auto & timezone_x = extractTimeZoneFromFunctionArguments(arguments, 3, 1);
|
|
const auto & timezone_y = extractTimeZoneFromFunctionArguments(arguments, 3, 2);
|
|
|
|
if (unit == "year" || unit == "yy" || unit == "yyyy")
|
|
dispatchForColumns<ToRelativeYearNumImpl>(x, y, timezone_x, timezone_y, res->getData());
|
|
else if (unit == "quarter" || unit == "qq" || unit == "q")
|
|
dispatchForColumns<ToRelativeQuarterNumImpl>(x, y, timezone_x, timezone_y, res->getData());
|
|
else if (unit == "month" || unit == "mm" || unit == "m")
|
|
dispatchForColumns<ToRelativeMonthNumImpl>(x, y, timezone_x, timezone_y, res->getData());
|
|
else if (unit == "week" || unit == "wk" || unit == "ww")
|
|
dispatchForColumns<ToRelativeWeekNumImpl>(x, y, timezone_x, timezone_y, res->getData());
|
|
else if (unit == "day" || unit == "dd" || unit == "d")
|
|
dispatchForColumns<ToRelativeDayNumImpl>(x, y, timezone_x, timezone_y, res->getData());
|
|
else if (unit == "hour" || unit == "hh")
|
|
dispatchForColumns<ToRelativeHourNumImpl>(x, y, timezone_x, timezone_y, res->getData());
|
|
else if (unit == "minute" || unit == "mi" || unit == "n")
|
|
dispatchForColumns<ToRelativeMinuteNumImpl>(x, y, timezone_x, timezone_y, res->getData());
|
|
else if (unit == "second" || unit == "ss" || unit == "s")
|
|
dispatchForColumns<ToRelativeSecondNumImpl>(x, y, timezone_x, timezone_y, res->getData());
|
|
else
|
|
throw Exception("Function " + getName() + " does not support '" + unit + "' unit", ErrorCodes::BAD_ARGUMENTS);
|
|
|
|
return res;
|
|
}
|
|
|
|
private:
|
|
template <typename Transform>
|
|
void dispatchForColumns(
|
|
const IColumn & x, const IColumn & y,
|
|
const DateLUTImpl & timezone_x, const DateLUTImpl & timezone_y,
|
|
ColumnInt64::Container & result) const
|
|
{
|
|
if (const auto * x_vec_16 = checkAndGetColumn<ColumnUInt16>(&x))
|
|
dispatchForSecondColumn<Transform>(*x_vec_16, y, timezone_x, timezone_y, result);
|
|
else if (const auto * x_vec_32 = checkAndGetColumn<ColumnUInt32>(&x))
|
|
dispatchForSecondColumn<Transform>(*x_vec_32, y, timezone_x, timezone_y, result);
|
|
else if (const auto * x_vec_64 = checkAndGetColumn<ColumnDateTime64>(&x))
|
|
dispatchForSecondColumn<Transform>(*x_vec_64, y, timezone_x, timezone_y, result);
|
|
else if (const auto * x_const_16 = checkAndGetColumnConst<ColumnUInt16>(&x))
|
|
dispatchConstForSecondColumn<Transform>(x_const_16->getValue<UInt16>(), y, timezone_x, timezone_y, result);
|
|
else if (const auto * x_const_32 = checkAndGetColumnConst<ColumnUInt32>(&x))
|
|
dispatchConstForSecondColumn<Transform>(x_const_32->getValue<UInt32>(), y, timezone_x, timezone_y, result);
|
|
else if (const auto * x_const_64 = checkAndGetColumnConst<ColumnDateTime64>(&x))
|
|
dispatchConstForSecondColumn<Transform>(x_const_64->getValue<DecimalField<DateTime64>>(), y, timezone_x, timezone_y, result);
|
|
else
|
|
throw Exception("Illegal column for first argument of function " + getName() + ", must be Date, DateTime or DateTime64", ErrorCodes::ILLEGAL_COLUMN);
|
|
}
|
|
|
|
template <typename Transform, typename LeftColumnType>
|
|
void dispatchForSecondColumn(
|
|
const LeftColumnType & x, const IColumn & y,
|
|
const DateLUTImpl & timezone_x, const DateLUTImpl & timezone_y,
|
|
ColumnInt64::Container & result) const
|
|
{
|
|
if (const auto * y_vec_16 = checkAndGetColumn<ColumnUInt16>(&y))
|
|
vectorVector<Transform>(x, *y_vec_16, timezone_x, timezone_y, result);
|
|
else if (const auto * y_vec_32 = checkAndGetColumn<ColumnUInt32>(&y))
|
|
vectorVector<Transform>(x, *y_vec_32, timezone_x, timezone_y, result);
|
|
else if (const auto * y_vec_64 = checkAndGetColumn<ColumnDateTime64>(&y))
|
|
vectorVector<Transform>(x, *y_vec_64, timezone_x, timezone_y, result);
|
|
else if (const auto * y_const_16 = checkAndGetColumnConst<ColumnUInt16>(&y))
|
|
vectorConstant<Transform>(x, y_const_16->getValue<UInt16>(), timezone_x, timezone_y, result);
|
|
else if (const auto * y_const_32 = checkAndGetColumnConst<ColumnUInt32>(&y))
|
|
vectorConstant<Transform>(x, y_const_32->getValue<UInt32>(), timezone_x, timezone_y, result);
|
|
else if (const auto * y_const_64 = checkAndGetColumnConst<ColumnDateTime64>(&y))
|
|
vectorConstant<Transform>(x, y_const_64->getValue<DecimalField<DateTime64>>(), timezone_x, timezone_y, result);
|
|
else
|
|
throw Exception("Illegal column for second argument of function " + getName() + ", must be Date or DateTime", ErrorCodes::ILLEGAL_COLUMN);
|
|
}
|
|
|
|
template <typename Transform, typename T1>
|
|
void dispatchConstForSecondColumn(
|
|
T1 x, const IColumn & y,
|
|
const DateLUTImpl & timezone_x, const DateLUTImpl & timezone_y,
|
|
ColumnInt64::Container & result) const
|
|
{
|
|
if (const auto * y_vec_16 = checkAndGetColumn<ColumnUInt16>(&y))
|
|
constantVector<Transform>(x, *y_vec_16, timezone_x, timezone_y, result);
|
|
else if (const auto * y_vec_32 = checkAndGetColumn<ColumnUInt32>(&y))
|
|
constantVector<Transform>(x, *y_vec_32, timezone_x, timezone_y, result);
|
|
else if (const auto * y_vec_64 = checkAndGetColumn<ColumnDateTime64>(&y))
|
|
constantVector<Transform>(x, *y_vec_64, timezone_x, timezone_y, result);
|
|
else
|
|
throw Exception("Illegal column for second argument of function " + getName() + ", must be Date or DateTime", ErrorCodes::ILLEGAL_COLUMN);
|
|
}
|
|
|
|
template <typename Transform, typename LeftColumnType, typename RightColumnType>
|
|
void vectorVector(
|
|
const LeftColumnType & x, const RightColumnType & y,
|
|
const DateLUTImpl & timezone_x, const DateLUTImpl & timezone_y,
|
|
ColumnInt64::Container & result) const
|
|
{
|
|
const auto & x_data = x.getData();
|
|
const auto & y_data = y.getData();
|
|
|
|
const auto transform_x = TransformDateTime64<Transform>(getScale(x));
|
|
const auto transform_y = TransformDateTime64<Transform>(getScale(y));
|
|
for (size_t i = 0, size = x.size(); i < size; ++i)
|
|
result[i] = calculate(transform_x, transform_y, x_data[i], y_data[i], timezone_x, timezone_y);
|
|
}
|
|
|
|
template <typename Transform, typename LeftColumnType, typename T2>
|
|
void vectorConstant(
|
|
const LeftColumnType & x, T2 y,
|
|
const DateLUTImpl & timezone_x, const DateLUTImpl & timezone_y,
|
|
ColumnInt64::Container & result) const
|
|
{
|
|
const auto & x_data = x.getData();
|
|
const auto transform_x = TransformDateTime64<Transform>(getScale(x));
|
|
const auto transform_y = TransformDateTime64<Transform>(getScale(y));
|
|
const auto y_value = stripDecimalFieldValue(y);
|
|
|
|
for (size_t i = 0, size = x.size(); i < size; ++i)
|
|
result[i] = calculate(transform_x, transform_y, x_data[i], y_value, timezone_x, timezone_y);
|
|
}
|
|
|
|
template <typename Transform, typename T1, typename RightColumnType>
|
|
void constantVector(
|
|
T1 x, const RightColumnType & y,
|
|
const DateLUTImpl & timezone_x, const DateLUTImpl & timezone_y,
|
|
ColumnInt64::Container & result) const
|
|
{
|
|
const auto & y_data = y.getData();
|
|
const auto transform_x = TransformDateTime64<Transform>(getScale(x));
|
|
const auto transform_y = TransformDateTime64<Transform>(getScale(y));
|
|
const auto x_value = stripDecimalFieldValue(x);
|
|
|
|
for (size_t i = 0, size = y.size(); i < size; ++i)
|
|
result[i] = calculate(transform_x, transform_y, x_value, y_data[i], timezone_x, timezone_y);
|
|
}
|
|
|
|
template <typename TransformX, typename TransformY, typename T1, typename T2>
|
|
Int64 calculate(const TransformX & transform_x, const TransformY & transform_y, T1 x, T2 y, const DateLUTImpl & timezone_x, const DateLUTImpl & timezone_y) const
|
|
{
|
|
return static_cast<Int64>(transform_y.execute(y, timezone_y))
|
|
- static_cast<Int64>(transform_x.execute(x, timezone_x));
|
|
}
|
|
|
|
template <typename T>
|
|
static UInt32 getScale(const T & v)
|
|
{
|
|
if constexpr (std::is_same_v<T, ColumnDateTime64>)
|
|
return v.getScale();
|
|
else if constexpr (std::is_same_v<T, DecimalField<DateTime64>>)
|
|
return v.getScale();
|
|
|
|
return 0;
|
|
}
|
|
template <typename T>
|
|
static auto stripDecimalFieldValue(T && v)
|
|
{
|
|
if constexpr (std::is_same_v<std::decay_t<T>, DecimalField<DateTime64>>)
|
|
return v.getValue();
|
|
else
|
|
return v;
|
|
}
|
|
};
|
|
|
|
}
|
|
|
|
void registerFunctionDateDiff(FunctionFactory & factory)
|
|
{
|
|
factory.registerFunction<FunctionDateDiff>(FunctionFactory::CaseInsensitive);
|
|
}
|
|
|
|
}
|
|
|